8126 2006-04-01 17:35:25 -0800 Padding must not apply to column 2008-03-21 09:01:43 -0700 1 1 1 Unclassified WebKit Tables 416.x Mac OS X 10.4 VERIFIED FIXED http://www.gtalbot.org/BrowserBugsSection/MSIE6Bugs/TableColumnPaddingWidth.html P2 Normal --- 1 browserbugs2 webkit-unassigned ian joost oldest_to_newest 38237 0 browserbugs2 2006-04-01 17:35:25 -0800 Reference: "'padding-top', 'padding-right', 'padding-bottom', 'padding-left', 'padding' Applies to: all elements except elements with table display types other than table, inline-table, and table-cell" coming from CSS 2.1, Section 8.4 Padding http://www.w3.org/TR/CSS21/box.html#padding-properties Reference: "The five properties related to padding ('padding', 'padding-top', 'padding-right', 'padding-bottom', and 'padding-left') now say that they don't apply to table rows, row groups, header groups, footer groups, columns, and column groups." coming from CSS 2.1, Section C.3.10 http://www.w3.org/TR/CSS21/changes.html#q36 Steps to reproduce: Load the testcase at provided URL (I tried with Safari 2.02 (416.13)). Expected results: Each of the 3 tables must measure exactly 300px. I searched for duplicate bugfile and couldn't find one. 48700 1 browserbugs2 2006-07-07 06:21:07 -0700 The latest (April 11th 2006) release of CSS 2.1 is a bit more explicit and easier to read: "'padding-top', 'padding-right', 'padding-bottom', 'padding-left' Value: <padding-width> | inherit Initial: 0 Applies to: all elements except table-row-group, table-header-group, table-footer-group, table-row, table-column-group and table-column" CSS 2.1, Section 8.4 Padding http://www.w3.org/TR/2006/WD-CSS21-20060411/box.html#padding-properties "The five properties related to padding ('padding', 'padding-top', 'padding-right', 'padding-bottom', and 'padding-left') now say that they don't apply to table rows, row groups, header groups, footer groups, columns, and column groups." CSS 2.1, Section C.3.10 http://www.w3.org/TR/2006/WD-CSS21-20060411/changes.html#q36 48954 2 joost 2006-07-09 13:36:50 -0700 Confirmed the third result isn't correct, both Opera and Firefox render it correctly. Reporter, would it be possible to attach the testcase to the bug? Thx! 48984 3 9313 sam 2006-07-09 15:10:09 -0700 Created attachment 9313 reduced test case In case the reporter does not feel comfortable adding his test case, I am attaching a reduction of just the table with the issue. 50313 4 browserbugs2 2006-07-18 20:15:25 -0700 > Reporter, would it be possible to attach the testcase to the bug? > In case the reporter does not feel comfortable adding his test case, I am > attaching a reduction of just the table with the issue. Sorry, I did not get this bugmail due to various reasons, one being my webhosting company going through its own difficulties, overloads. The URL provided in this bugfile form is the original testcase: I feel confortable with whatever you do to fix this bug :) . There is a pseudo-rule right under the table so that measurements or verifications can be done easily and graphically. Thank you both (Joost and Sam) for confirming this bug and for your interest Gérard 55238 5 10498 hyatt 2006-09-11 00:28:17 -0700 Created attachment 10498 Patch. 55239 6 hyatt 2006-09-11 00:37:06 -0700 This change is probably worth explaining (I enhanced the comment a bit in my tree). When computing the minimum and maximum preferred widths for cells, we have a method called styleOrColWidth that attempts to snag the width from the cell, and if not set there, it uses the column. The problem arises when fixed widths are specified on the column. For percentage widths on cells vs. columns there is no difference, since a box-sizing rule of border-box is effectively what is assumed in all cases. For fixed widths though the behavior is different. A fixed width column is *still* applied to the border box of the cell. Therefore we need to subtract out the border and padding of the cell from the width returned. It will then get added back in later. (This does mean we'll fail degenerate cases where the border/padding exceed the column width, but the table code is full of that problem, and I'm not overly concerned about it.) 55279 7 hyatt 2006-09-11 20:40:10 -0700 Actually it occurred to me that even the degenerate case of too-small column widths will still behave correctly, so everything's all good here. 55280 8 10498 aroben 2006-09-11 21:27:44 -0700 Comment on attachment 10498 Patch. r=me 55306 9 ddkilzer 2006-09-12 08:06:11 -0700 Fixed by hyatt in r16315, test in r16316. 74636 10 browserbugs2 2008-03-21 09:01:43 -0700 Thank you for fixing this bug! :) Marking as VERIFIED 9313 2006-07-09 15:10:09 -0700 2006-07-09 15:10:09 -0700 reduced test case tablepad.html text/html 717 sam PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPHRpdGxlPnVudGl0bGVk PC90aXRsZT4KICAgICAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgogICAgICAgICAgICAudGVz dCB7IHBhZGRpbmc6IDBweCAyNHB4OyB9CiAgICAgICAgPC9zdHlsZT4KICAgICAgICAKICAgIDwv aGVhZD4KICAgIDxib2R5PgogICAgICAgIDx0YWJsZSBib3JkZXI9IjgiIGNlbGxwYWRkaW5nPSIw IiBjZWxsc3BhY2luZz0iMCI+CiAgICAgICAgICAgIDxjb2wgd2lkdGg9IjE5MiI+CiAgICAgICAg ICAgIDxjb2wgd2lkdGg9IjkyIj4KICAgICAgICAgICAgPHRyPgogICAgICAgICAgICAgICAgPHRk PmlzIDIwMDwvdGQ+CiAgICAgICAgICAgICAgICA8dGQ+aXMgMTAwPC90ZD4KICAgICAgICAgICAg PC90cj4KICAgICAgICA8L3RhYmxlPgoKICAgICAgICA8dGFibGUgYm9yZGVyPSI4IiBjZWxscGFk ZGluZz0iMCIgY2VsbHNwYWNpbmc9IjAiPgogICAgICAgICAgICA8Y29sIHdpZHRoPSIxOTIiPgog ICAgICAgICAgICA8Y29sIHdpZHRoPSI5MiI+CiAgICAgICAgICAgIDx0cj4KICAgICAgICAgICAg ICAgIDx0ZCBjbGFzcz0idGVzdCI+c2hvdWxkIGJlIDIwMDwvdGQ+CiAgICAgICAgICAgICAgICA8 dGQgY2xhc3M9InRlc3QiPnNob3VsZCBiZSAxMDA8L3RkPgogICAgICAgICAgICA8L3RyPgogICAg ICAgIDwvdGFibGU+CiAgICA8L2JvZHk+CjwvaHRtbD4K 10498 2006-09-11 00:28:17 -0700 2006-09-11 21:27:44 -0700 Patch. patch.txt text/plain 679 hyatt SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRl cmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCShyZXZpc2lvbiAxNjI5MykKKysrIHJlbmRlcmluZy9S ZW5kZXJUYWJsZUNlbGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MCw4ICs4MCwxMyBAQAogICAg IGlmIChjb2xTcGFuKCkgPiAxIHx8ICF3LmlzQXV0bygpKQogICAgICAgICByZXR1cm4gdzsKICAg ICBSZW5kZXJUYWJsZUNvbCogY29sID0gdGFibGUoKS0+Y29sRWxlbWVudChfY29sKTsKLSAgICBp ZiAoY29sKQorICAgIGlmIChjb2wpIHsKICAgICAgICAgdyA9IGNvbC0+c3R5bGUoKS0+d2lkdGgo KTsKKyAgICAgICAgCisgICAgICAgIC8vIENvbHVtbiB3aWR0aHMgc3BlY2lmaWVkIG9uIDxjb2w+ IGFwcGx5IHRvIHRoZSBib3JkZXIgYm94IG9mIHRoZSBjZWxsLgorICAgICAgICBpZiAody5pc0Zp eGVkKCkgJiYgdy52YWx1ZSgpID4gMCkKKyAgICAgICAgICAgIHcgPSBMZW5ndGgobWF4KDAsIHcu dmFsdWUoKSAtIGJvcmRlckxlZnQoKSAtIGJvcmRlclJpZ2h0KCkgLSBwYWRkaW5nTGVmdCgpIC0g cGFkZGluZ1JpZ2h0KCkpLCBGaXhlZCk7CisgICAgfQogICAgIHJldHVybiB3OwogfQogCg==