81251 2012-03-15 11:47:39 -0700 The commit-queue can hang when the test_expectations.txt style check fails during commit 2012-03-15 15:49:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric ojan oldest_to_newest 579595 0 abarth 2012-03-15 11:47:39 -0700 The commit-queue can hang when the test_expectations.txt style check fails during commit 579598 1 132094 abarth 2012-03-15 11:48:56 -0700 Created attachment 132094 Patch 579603 2 132094 eric 2012-03-15 11:51:36 -0700 Comment on attachment 132094 Patch OK. I *strongly* agree with your suggestion in the ChangeLog. 579832 3 132094 abarth 2012-03-15 15:49:00 -0700 Comment on attachment 132094 Patch Clearing flags on attachment: 132094 Committed r110900: <http://trac.webkit.org/changeset/110900> 579833 4 abarth 2012-03-15 15:49:04 -0700 All reviewed patches have been landed. Closing bug. 132094 2012-03-15 11:48:56 -0700 2012-03-15 15:49:00 -0700 Patch bug-81251-20120315114855.patch text/plain 4638 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMDg2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDEyLTAzLTE1ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgVGhlIGNvbW1pdC1xdWV1ZSBjYW4gaGFuZyB3aGVuIHRoZSB0ZXN0X2V4cGVjdGF0 aW9ucy50eHQgc3R5bGUgY2hlY2sgZmFpbHMgZHVyaW5nIGNvbW1pdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEyNTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBmb3Jnb3QgdG8gY2hlY2sgdGhlIC0t bm9uLWludGVyYWN0aXZlIGZsYWcsIHNvIHdlIGVuZCB1cCBwcm9tcHRpbmcKKyAgICAgICAgdGhl ICJ1c2VyIiB3aG8gZG9lc24ndCBleGlzdCBvbiB0aGUgYm90LiAgV2UgbWlnaHQgY29uc2lkZXIg dGVhY2hpbmcKKyAgICAgICAgdGhlIFVzZXIgY2xhc3MgYWJvdXQgbm9uLWludGVyYWN0aXZlIGlm IHdlIGhhdmUgdGhpcyBzb3J0IG9mIGJ1ZyBhZ2Fpbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zdGVwcy9jb21taXQucHk6CisgICAgICAgIChDb21taXQub3B0aW9ucyk6Cisg ICAgICAgIChDb21taXQuX2NoZWNrX3Rlc3RfZXhwZWN0YXRpb25zKToKKyAgICAgICAgKENvbW1p dC5ydW4pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb21taXRfdW5p dHRlc3QucHk6CisgICAgICAgIChDb21taXRUZXN0LnRlc3RfY2hlY2tfdGVzdF9leHBlY3RhdGlv bnMpOgorCiAyMDEyLTAzLTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1RLXSBBY3R1YWxseSB1c2UgLS1yZWxlYXNlIGFuZCAtLWRlYnVn IGNvbW1hbmQgbGluZSBvcHRpb25zIGluIHJ1bi1ndGstdGVzdApJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL3N0ZXBzL2NvbW1pdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29tbWl0LnB5CShyZXZpc2lvbiAxMTA4NjEpCisrKyBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29tbWl0LnB5CSh3b3JraW5nIGNvcHkp CkBAIC00NCw2ICs0NCw3IEBAIGNsYXNzIENvbW1pdChBYnN0cmFjdFN0ZXApOgogICAgIGRlZiBv cHRpb25zKGNscyk6CiAgICAgICAgIHJldHVybiBBYnN0cmFjdFN0ZXAub3B0aW9ucygpICsgWwog ICAgICAgICAgICAgT3B0aW9ucy5jaGVja19idWlsZGVycywKKyAgICAgICAgICAgIE9wdGlvbnMu bm9uX2ludGVyYWN0aXZlLAogICAgICAgICBdCiAKICAgICBkZWYgX2NvbW1pdF93YXJuaW5nKHNl bGYsIGVycm9yKToKQEAgLTY2LDYgKzY3LDggQEAgY2xhc3MgQ29tbWl0KEFic3RyYWN0U3RlcCk6 CiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHNlbGYuX3Rvb2wuZXhlY3V0aXZlLnJ1bl9hbmRf dGhyb3dfaWZfZmFpbChzZWxmLl90b29sLnBvcnQoKS5jaGVja193ZWJraXRfc3R5bGVfY29tbWFu ZCgpICsgYXJncywgY3dkPXNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKICAgICAgICAg ZXhjZXB0IFNjcmlwdEVycm9yLCBlOgorICAgICAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5ub25f aW50ZXJhY3RpdmU6CisgICAgICAgICAgICAgICAgcmFpc2UKICAgICAgICAgICAgIGlmIG5vdCBz ZWxmLl90b29sLnVzZXIuY29uZmlybSgiQXJlIHlvdSBzdXJlIHlvdSB3YW50IHRvIGNvbnRpbnVl PyIsIGRlZmF1bHQ9Im4iKToKICAgICAgICAgICAgICAgICBzZWxmLl9leGl0KDEpCiAKQEAgLTk0 LDEyICs5NywxNCBAQCBjbGFzcyBDb21taXQoQWJzdHJhY3RTdGVwKToKICAgICAgICAgICAgICAg ICBzZWxmLl9zdGF0ZVsiY29tbWl0X3RleHQiXSA9IGNvbW1pdF90ZXh0CiAgICAgICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgICAgICBleGNlcHQgQW1iaWd1b3VzQ29tbWl0RXJyb3IsIGU6Ci0g ICAgICAgICAgICAgICAgaWYgc2VsZi5fdG9vbC51c2VyLmNvbmZpcm0oc2VsZi5fY29tbWl0X3dh cm5pbmcoZSkpOgorICAgICAgICAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMubm9uX2ludGVyYWN0 aXZlIG9yIHNlbGYuX3Rvb2wudXNlci5jb25maXJtKHNlbGYuX2NvbW1pdF93YXJuaW5nKGUpKToK ICAgICAgICAgICAgICAgICAgICAgZm9yY2Vfc3F1YXNoID0gVHJ1ZQogICAgICAgICAgICAgICAg IGVsc2U6CiAgICAgICAgICAgICAgICAgICAgICMgVGhpcyB3aWxsIGNvcnJlY3RseSBpbnRlcnJ1 cHQgdGhlIHJlc3Qgb2YgdGhlIGNvbW1pdCBwcm9jZXNzLgogICAgICAgICAgICAgICAgICAgICBy YWlzZSBTY3JpcHRFcnJvcihtZXNzYWdlPSJEaWQgbm90IGNvbW1pdCIpCiAgICAgICAgICAgICBl eGNlcHQgQXV0aGVudGljYXRpb25FcnJvciwgZToKKyAgICAgICAgICAgICAgICBpZiBzZWxmLl9v cHRpb25zLm5vbl9pbnRlcmFjdGl2ZToKKyAgICAgICAgICAgICAgICAgICAgcmFpc2UgU2NyaXB0 RXJyb3IobWVzc2FnZT0iQXV0aGVudGljYXRpb24gcmVxdWlyZWQiKQogICAgICAgICAgICAgICAg IHVzZXJuYW1lID0gc2VsZi5fdG9vbC51c2VyLnByb21wdCgiJXMgbG9naW46ICIgJSBlLnNlcnZl cl9ob3N0LCByZXBlYXQ9NSkKICAgICAgICAgICAgICAgICBpZiBub3QgdXNlcm5hbWU6CiAgICAg ICAgICAgICAgICAgICAgIHJhaXNlIFNjcmlwdEVycm9yKCJZb3UgbmVlZCB0byBzcGVjaWZ5IHRo ZSB1c2VybmFtZSBvbiAlcyB0byBwZXJmb3JtIHRoZSBjb21taXQgYXMuIiAlIGUuc2VydmVyX2hv c3QpCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29tbWl0X3VuaXR0 ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9j b21taXRfdW5pdHRlc3QucHkJKHJldmlzaW9uIDExMDg2MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zdGVwcy9jb21taXRfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5 LDYgKzI5LDcgQEAKIGltcG9ydCB1bml0dGVzdAogCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0 ZW0ub3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0cHV0Q2FwdHVyZQorZnJvbSB3ZWJraXRweS5jb21t b24uc3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgU2NyaXB0RXJyb3IKIGZyb20gd2Via2l0cHkuY29t bW9uLnN5c3RlbS5leGVjdXRpdmVfbW9jayBpbXBvcnQgTW9ja0V4ZWN1dGl2ZQogZnJvbSB3ZWJr aXRweS50b29sLm1vY2t0b29sIGltcG9ydCBNb2NrT3B0aW9ucywgTW9ja1Rvb2wKIGZyb20gd2Vi a2l0cHkudG9vbC5zdGVwcy5jb21taXQgaW1wb3J0IENvbW1pdApAQCAtMzksOCArNDAsMTAgQEAg Y2xhc3MgQ29tbWl0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIGNhcHR1cmUgPSBP dXRwdXRDYXB0dXJlKCkKICAgICAgICAgb3B0aW9ucyA9IE1vY2tPcHRpb25zKCkKICAgICAgICAg b3B0aW9ucy5naXRfY29tbWl0ID0gIiIKKyAgICAgICAgb3B0aW9ucy5ub25faW50ZXJhY3RpdmUg PSBUcnVlCiAKICAgICAgICAgdG9vbCA9IE1vY2tUb29sKCkKKyAgICAgICAgdG9vbC51c2VyID0g Tm9uZSAgIyBXaWxsIGNhdXNlIGFueSBhY2Nlc3Mgb2YgdG9vbC51c2VyIHRvIHJhaXNlIGFuIGV4 Y2VwdGlvbi4KICAgICAgICAgc3RlcCA9IENvbW1pdCh0b29sLCBvcHRpb25zKQogICAgICAgICBz dGF0ZSA9IHsKICAgICAgICAgICAgICJjaGFuZ2VkX2ZpbGVzIjogWyJ0ZXN0X2V4cGVjdGF0aW9u cy50eHRYWFgiXSwKQEAgLTU1LDQgKzU4LDQgQEAgY2xhc3MgQ29tbWl0VGVzdCh1bml0dGVzdC5U ZXN0Q2FzZSk6CiAgICAgICAgIGNhcHR1cmUuYXNzZXJ0X291dHB1dHMoc2VsZiwgc3RlcC5ydW4s IFtzdGF0ZV0sIGV4cGVjdGVkX3N0ZGVycj0iTU9DSyBydW5fYW5kX3Rocm93X2lmX2ZhaWw6IFsn bW9jay1jaGVjay13ZWJraXQtc3R5bGUnLCAnLS1kaWZmLWZpbGVzJywgJ3BsYXRmb3JtL2Nocm9t aXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCddLCBjd2Q9L21vY2stY2hlY2tvdXRcbkNvbW1pdHRl ZCByNDk4MjQ6IDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC80OTgyND5cbiIpCiAK ICAgICAgICAgdG9vbC5leGVjdXRpdmUgPSBNb2NrRXhlY3V0aXZlKHNob3VsZF9sb2c9VHJ1ZSwg c2hvdWxkX3Rocm93X3doZW5fcnVuPXNldChbInBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dCJdKSkKLSAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoU3lzdGVtRXhpdCwgY2Fw dHVyZS5hc3NlcnRfb3V0cHV0cywgc2VsZiwgc3RlcC5ydW4sIFtzdGF0ZV0pCisgICAgICAgIHNl bGYuYXNzZXJ0UmFpc2VzKFNjcmlwdEVycm9yLCBjYXB0dXJlLmFzc2VydF9vdXRwdXRzLCBzZWxm LCBzdGVwLnJ1biwgW3N0YXRlXSkK