81250 2012-03-15 11:46:54 -0700 [chromium] Don't create a quad for video layers without a frame (avoid use of uninitialized m_format) 2012-03-16 01:20:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj cc-bugs jamesr sievers tdresser webkit.review.bot oldest_to_newest 579594 0 danakj 2012-03-15 11:46:54 -0700 [chromium] Don't create a quad for video layers without a frame (avoid use of uninitialized m_format) 579597 1 132093 danakj 2012-03-15 11:48:51 -0700 Created attachment 132093 Patch 579604 2 132093 jamesr 2012-03-15 11:51:44 -0700 Comment on attachment 132093 Patch R=me. Any way to get more direct test coverage of this? 579612 3 danakj 2012-03-15 12:01:47 -0700 I don't see a nice place to insert a unit test, but I guess this code path is exercised by layout tests already since valgrind noticed it? 580271 4 132093 webkit.review.bot 2012-03-16 01:20:21 -0700 Comment on attachment 132093 Patch Clearing flags on attachment: 132093 Committed r110964: <http://trac.webkit.org/changeset/110964> 580272 5 webkit.review.bot 2012-03-16 01:20:25 -0700 All reviewed patches have been landed. Closing bug. 132093 2012-03-15 11:48:51 -0700 2012-03-16 01:20:21 -0700 Patch bug-81250-20120315144846.patch text/plain 1566 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDUyN2NkOGZjNmFlOTY1 NzFjNGI3NzlhYTA0NjU2NDAxNjc4Yjk3MS4uMTViZWM3MTAxM2RkMTg1MmZjYjQ2YmMxZmZkZTg4 YTYwOGYzYjFjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTE1ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRG9u J3QgY3JlYXRlIGEgcXVhZCBmb3IgdmlkZW8gbGF5ZXJzIHdpdGhvdXQgYSBmcmFtZSAoYXZvaWQg dXNlIG9mIHVuaW5pdGlhbGl6ZWQgbV9mb3JtYXQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTI1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NW aWRlb0xheWVySW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ1ZpZGVvTGF5ZXJJbXBsOjph cHBlbmRRdWFkcyk6CisKIDIwMTItMDMtMTQgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogZXh0cmFjdCBDb21waWxlclNj cmlwdE1hcHBpbmcgZnJvbSBSYXdTb3VyY2VDb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ZpZGVvTGF5ZXJJ bXBsLmNwcAppbmRleCA0ODBjNzRlMWY5ZWUyYmIwZTNkZjhjMzQwMGJhMzgxYWE1ZjRjZDA0Li5i NWFhM2UxNzE1MGZlMDU0ZjczZTUxZWYwMDJhNmZkYWJmN2ZjNjQ3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1ZpZGVvTGF5ZXJJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9D Q1ZpZGVvTGF5ZXJJbXBsLmNwcApAQCAtMTU2LDYgKzE1Niw5IEBAIHZvaWQgQ0NWaWRlb0xheWVy SW1wbDo6d2lsbERyYXcoTGF5ZXJSZW5kZXJlckNocm9taXVtKiBsYXllclJlbmRlcmVyKQogCiB2 b2lkIENDVmlkZW9MYXllckltcGw6OmFwcGVuZFF1YWRzKENDUXVhZEN1bGxlciYgcXVhZExpc3Qs IGNvbnN0IENDU2hhcmVkUXVhZFN0YXRlKiBzaGFyZWRRdWFkU3RhdGUpCiB7CisgICAgaWYgKCFt X2ZyYW1lKQorICAgICAgICByZXR1cm47CisKICAgICBJbnRSZWN0IHF1YWRSZWN0KEludFBvaW50 KCksIGJvdW5kcygpKTsKICAgICBPd25QdHI8Q0NWaWRlb0RyYXdRdWFkPiB2aWRlb1F1YWQgPSBD Q1ZpZGVvRHJhd1F1YWQ6OmNyZWF0ZShzaGFyZWRRdWFkU3RhdGUsIHF1YWRSZWN0LCBtX3RleHR1 cmVzLCBtX2ZyYW1lLCBtX2Zvcm1hdCk7CiAK