81247 2012-03-15 11:34:58 -0700 Fix crbug 117957 - get settings scrolling with the wheel again. 2012-03-15 14:40:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scottbyer scottbyer jamesr rjkroege wjmaclean oldest_to_newest 579576 0 scottbyer 2012-03-15 11:34:58 -0700 Fix crbug 117957 - get settings scrolling with the wheel again. 579579 1 132087 scottbyer 2012-03-15 11:37:46 -0700 Created attachment 132087 Patch 579599 2 132087 jamesr 2012-03-15 11:48:59 -0700 Comment on attachment 132087 Patch Should this be iterating through ScrollableAreas or FrameViews? Do we have non-FrameView users of this? Something about this doesn't seem quite right. 579705 3 132115 scottbyer 2012-03-15 13:52:42 -0700 Created attachment 132115 Patch James, something more like this? This also fixes crbug.com/118125. However, I'm also thinking that it might be better to revert the original rAF patch and add this to that along with a couple of layout tests to cover the two bugs (something I don't think I could get done today, and this is blocking other work). Thoughts? 579711 4 132115 jamesr 2012-03-15 14:03:10 -0700 Comment on attachment 132115 Patch FrameView::serviceScriptedAnimations iterates through all child Frames, so I was hoping this could piggyback on a similar iteration. I think actually your earlier patch would be better than iterating through Widgets, sorry for the confusion. I'll R+ that patch. Reverting is also a find option - we should figure out if we can cover up the gap in test coverage to avoid doing this again. 579713 5 132087 jamesr 2012-03-15 14:05:07 -0700 Comment on attachment 132087 Patch I misread this at first and thought it would call service..() multiple times on subframes, but I see now it's directly calling serviceScrollAnimations() on the scrollable areas. I think this is OK. I think it might be better to iterate through the Frame tree to just hit FrameViews. In any case, I think it's really important to get better test coverage. I'm fine with landing this patch as-is, or reverting the other patch so we can shore it up a bit more. Your call. 579717 6 scottbyer 2012-03-15 14:06:08 -0700 Patch 1 doesn't fix the entire problem - it takes care of crbug.com/117957 but not crbug.com/118125. I'll follow this up with 579734 7 jamesr 2012-03-15 14:21:17 -0700 Ah, I didn't see the other one. Messy :/ Something lke your patch 2 is good but it should be using the Frame tree and then grabbing their views - see how serviceScriptedAnimations hits all frames. 579746 8 132122 scottbyer 2012-03-15 14:30:42 -0700 Created attachment 132122 Patch Ah, here we go. Much cleaner, still gets both bugs. 579751 9 132122 jamesr 2012-03-15 14:37:15 -0700 Comment on attachment 132122 Patch Cool! I feel a bit more comfortable about this one without additional testing since we have fairly good coverage for the other caller in this branch. 579752 10 132122 jamesr 2012-03-15 14:39:49 -0700 Comment on attachment 132122 Patch Clearing flags on attachment: 132122 Committed r110889: <http://trac.webkit.org/changeset/110889> 579753 11 jamesr 2012-03-15 14:40:14 -0700 All reviewed patches have been landed. Closing bug. 132087 2012-03-15 11:37:46 -0700 2012-03-15 14:30:32 -0700 Patch bug-81247-20120315113743.patch text/plain 1505 scottbyer U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA1OGFmNzgwOTQzOTAw MjlkZmI0Mzg2YWMzMjg5OWI4YThkMDkzYS4uOWY5N2Q3NjE5OTkzYTAyYTNmZjg5MDhlNGI0Yzc4 MGRkNTY4NzUxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTE1ICBTY290 dCBCeWVyICA8c2NvdHRieWVyQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggY3JidWcgMTE3 OTU3IC0gZ2V0IHNldHRpbmdzIHNjcm9sbGluZyB3aXRoIHRoZSB3aGVlbCBhZ2Fpbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMjQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgor CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVW aWV3OjpzZXJ2aWNlU2NyaXB0ZWRBbmltYXRpb25zKToKKwogMjAxMi0wMy0xNSAgTmlrb2xhcyBa aW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBTVkcgQW5pbWF0aW9u cyB1cGRhdGUgYmFzZVZhbCBpbnN0ZWFkIG9mIGFuaW1WYWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAppbmRleCAyZDM5MmRlOGMyYzQ5MDU4N2UyY2FjMGQzODJmNjdhOGJhZTQ5MGE2Li42NmEy ZTczOThjNDhiNzA4MmYxYzNhMmVmNTEwMGMzYzA0ZTZlNTU3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZVZpZXcuY3BwCkBAIC0yMDgzLDYgKzIwODMsMTAgQEAgdm9pZCBGcmFtZVZpZXc6OnVuc2NoZWR1 bGVSZWxheW91dCgpCiB2b2lkIEZyYW1lVmlldzo6c2VydmljZVNjcmlwdGVkQW5pbWF0aW9ucyhE T01UaW1lU3RhbXAgdGltZSkKIHsKICAgICBzZXJ2aWNlU2Nyb2xsQW5pbWF0aW9ucygpOworICAg IGZvciAoSGFzaFNldDxTY3JvbGxhYmxlQXJlYSo+OjppdGVyYXRvciBpdCA9IG1fc2Nyb2xsYWJs ZUFyZWFzLT5iZWdpbigpLCBlbmQgPSBtX3Njcm9sbGFibGVBcmVhcy0+ZW5kKCk7IGl0ICE9IGVu ZDsgKytpdCkgeworICAgICAgICBTY3JvbGxhYmxlQXJlYSogc2Nyb2xsYWJsZUFyZWEgPSAqaXQ7 CisgICAgICAgIHNjcm9sbGFibGVBcmVhLT5zZXJ2aWNlU2Nyb2xsQW5pbWF0aW9ucygpOworICAg IH0KIAogICAgIFZlY3RvcjxBbmltYXRpb25Db250cm9sbGVyKj4gYW5pbWF0aW9uczsKICAgICBm b3IgKEZyYW1lKiBmcmFtZSA9IG1fZnJhbWUuZ2V0KCk7IGZyYW1lOyBmcmFtZSA9IGZyYW1lLT50 cmVlKCktPnRyYXZlcnNlTmV4dCgpKQo= 132115 2012-03-15 13:52:42 -0700 2012-03-15 14:30:34 -0700 Patch bug-81247-20120315135241.patch text/plain 2285 scottbyer U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA1OGFmNzgwOTQzOTAw MjlkZmI0Mzg2YWMzMjg5OWI4YThkMDkzYS4uZTU5ODYzYTE0Zjg0YzMyMWNlNzBmZGM4ZjQ3ZDM0 ZWFlNDYwYmFhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTE1ICBTY290 dCBCeWVyICA8c2NvdHRieWVyQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggY3JidWcgMTE3 OTU3IC0gZ2V0IHNldHRpbmdzIHNjcm9sbGluZyB3aXRoIHRoZSB3aGVlbCBhZ2Fpbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMjQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBQ YXJ0aWFsbHkgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBhZ2UvRnJh bWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVW aWV3OjpzZXJ2aWNlU2Nyb2xsQW5pbWF0aW9ucyk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcu aDoKKyAgICAgICAgKEZyYW1lVmlldyk6CisKIDIwMTItMDMtMTUgIE5pa29sYXMgWmltbWVybWFu biAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgU1ZHIEFuaW1hdGlvbnMgdXBkYXRl IGJhc2VWYWwgaW5zdGVhZCBvZiBhbmltVmFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5k ZXggMmQzOTJkZThjMmM0OTA1ODdlMmNhYzBkMzgyZjY3YThiYWU0OTBhNi4uNDIzOWE3ZmI0ZDli YmM4MzUwYjc2Y2FhMTE2NjBlMmFlZDNjNWQ0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cApAQCAtMjA5NSw2ICsyMDk1LDIwIEBAIHZvaWQgRnJhbWVWaWV3OjpzZXJ2aWNlU2NyaXB0ZWRB bmltYXRpb25zKERPTVRpbWVTdGFtcCB0aW1lKQogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg ZG9jdW1lbnRzLnNpemUoKTsgKytpKQogICAgICAgICBkb2N1bWVudHNbaV0tPnNlcnZpY2VTY3Jp cHRlZEFuaW1hdGlvbnModGltZSk7CiB9CisKK3ZvaWQgRnJhbWVWaWV3OjpzZXJ2aWNlU2Nyb2xs QW5pbWF0aW9ucygpCit7CisgICAgU2Nyb2xsYWJsZUFyZWE6OnNlcnZpY2VTY3JvbGxBbmltYXRp b25zKCk7CisKKyAgICBjb25zdCBIYXNoU2V0PFJlZlB0cjxXaWRnZXQ+ID4qIHZpZXdDaGlsZHJl biA9IGNoaWxkcmVuKCk7CisgICAgSGFzaFNldDxSZWZQdHI8V2lkZ2V0PiA+OjppdGVyYXRvciBl bmQgPSB2aWV3Q2hpbGRyZW4tPmVuZCgpOworICAgIGZvciAoSGFzaFNldDxSZWZQdHI8V2lkZ2V0 PiA+OjppdGVyYXRvciBjdXJyZW50ID0gdmlld0NoaWxkcmVuLT5iZWdpbigpOyBjdXJyZW50ICE9 IGVuZDsgKytjdXJyZW50KSB7CisgICAgICAgIFdpZGdldCogd2lkZ2V0ID0gY3VycmVudC0+Z2V0 KCk7CisgICAgICAgIGlmICh3aWRnZXQtPmlzRnJhbWVWaWV3KCkpCisgICAgICAgICAgICBzdGF0 aWNfY2FzdDxGcmFtZVZpZXcqPih3aWRnZXQpLT5zZXJ2aWNlU2Nyb2xsQW5pbWF0aW9ucygpOwor ICAgIH0KK30KKwogI2VuZGlmCiAKIGJvb2wgRnJhbWVWaWV3Ojppc1RyYW5zcGFyZW50KCkgY29u c3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmggYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCmluZGV4IGYxNGEyMTMwZmEzOTk4ZjBhYzgwM2U2M2E0 ODQ3MzkxZDgyZTM0ODMuLjU4NWY3MmExMTJiNzM2Mjk3MDU1YTAzMzQ1Mjg1NzdkY2ZmMDhhZDEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaApAQCAtMTA5LDYgKzEwOSw3IEBAIHB1YmxpYzoKIAog I2lmIEVOQUJMRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRSkKICAgICB2b2lkIHNlcnZpY2VTY3Jp cHRlZEFuaW1hdGlvbnMoRE9NVGltZVN0YW1wKTsKKyAgICB2aXJ0dWFsIHZvaWQgc2VydmljZVNj cm9sbEFuaW1hdGlvbnMoKTsKICNlbmRpZgogCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lU SU5HKQo= 132122 2012-03-15 14:30:42 -0700 2012-03-15 14:39:49 -0700 Patch bug-81247-20120315143041.patch text/plain 1637 scottbyer U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA1OGFmNzgwOTQzOTAw MjlkZmI0Mzg2YWMzMjg5OWI4YThkMDkzYS4uYzcxN2QyMDE4NzBkZDQyNzQxMGM3NDYwMjM4ZThi NGJhY2FhNGJmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTE1ICBTY290 dCBCeWVyICA8c2NvdHRieWVyQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggY3JidWcgMTE3 OTU3IC0gZ2V0IHNldHRpbmdzIHNjcm9sbGluZyB3aXRoIHRoZSB3aGVlbCBhZ2Fpbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMjQ3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgdG8gZm9sbG93 LgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVWaWV3OjpzZXJ2aWNlU2NyaXB0ZWRBbmltYXRpb25zKToKKwogMjAxMi0wMy0xNSAgTmlrb2xh cyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAgICBTVkcgQW5pbWF0 aW9ucyB1cGRhdGUgYmFzZVZhbCBpbnN0ZWFkIG9mIGFuaW1WYWwKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmNwcAppbmRleCAyZDM5MmRlOGMyYzQ5MDU4N2UyY2FjMGQzODJmNjdhOGJhZTQ5MGE2Li5i NWYzZTczNmY4MTMxNDNmZDIzYzZiMDllNzFkYTE3NzJlOTUzZTY3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuY3BwCkBAIC0yMDgyLDExICsyMDgyLDEwIEBAIHZvaWQgRnJhbWVWaWV3Ojp1bnNj aGVkdWxlUmVsYXlvdXQoKQogI2lmIEVOQUJMRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRSkKIHZv aWQgRnJhbWVWaWV3OjpzZXJ2aWNlU2NyaXB0ZWRBbmltYXRpb25zKERPTVRpbWVTdGFtcCB0aW1l KQogewotICAgIHNlcnZpY2VTY3JvbGxBbmltYXRpb25zKCk7Ci0KLSAgICBWZWN0b3I8QW5pbWF0 aW9uQ29udHJvbGxlcio+IGFuaW1hdGlvbnM7Ci0gICAgZm9yIChGcmFtZSogZnJhbWUgPSBtX2Zy YW1lLmdldCgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHQoKSkK KyAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1fZnJhbWUuZ2V0KCk7IGZyYW1lOyBmcmFtZSA9IGZy YW1lLT50cmVlKCktPnRyYXZlcnNlTmV4dCgpKSB7CisgICAgICAgIGZyYW1lLT52aWV3KCktPnNl cnZpY2VTY3JvbGxBbmltYXRpb25zKCk7CiAgICAgICAgIGZyYW1lLT5hbmltYXRpb24oKS0+c2Vy dmljZUFuaW1hdGlvbnMoKTsKKyAgICB9CiAKICAgICBWZWN0b3I8UmVmUHRyPERvY3VtZW50PiA+ IGRvY3VtZW50czsKICAgICBmb3IgKEZyYW1lKiBmcmFtZSA9IG1fZnJhbWUuZ2V0KCk7IGZyYW1l OyBmcmFtZSA9IGZyYW1lLT50cmVlKCktPnRyYXZlcnNlTmV4dCgpKQo=