81245 2012-03-15 11:32:23 -0700 Web Inspector: crash in InspectorTimelineAgent when trying to add children to cancelable records 2012-03-15 12:30:52 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 579572 0 caseq 2012-03-15 11:32:23 -0700 Cancelable records are not expected to have children, since they may be cancelled. pushGCEventRecords() used to indirectly add children to cancelable records by invoking addRecordToTimeline(). We should always commit cancelable records before trying to add children. 579609 1 132096 caseq 2012-03-15 11:58:09 -0700 Created attachment 132096 Patch 579639 2 caseq 2012-03-15 12:30:52 -0700 Committed r110872: <http://trac.webkit.org/changeset/110872> 132096 2012-03-15 11:58:09 -0700 2012-03-15 12:27:30 -0700 Patch bug-81245-20120315225806.patch text/plain 3984 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk2NjZmZTVmNjE4MDVk NWI1ODI0YmYzZTYxODg3MmMwNjQxNWQzNS4uZWQ5ZDRjOTRlYWJjNDhhYTJjYjFkMGE4ODc1OGY4 NThkYjg3MzU5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTE1ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogY3Jhc2ggaW4gSW5zcGVjdG9yVGltZWxpbmVBZ2VudCB3aGVuIHRyeWluZyB0byBhZGQgY2hp bGRyZW4gdG8gY2FuY2VsYWJsZSByZWNvcmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04MTI0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6YWRkUmVjb3JkVG9U aW1lbGluZSk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rv clRpbWVsaW5lQWdlbnQ6OmlubmVyQWRkUmVjb3JkVG9UaW1lbGluZSk6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JUaW1lbGluZUFnZW50OjphcHBlbmRSZWNvcmQpOgorICAgICAgICAoV2Vi Q29yZTo6SW5zcGVjdG9yVGltZWxpbmVBZ2VudDo6Y29tbWl0Q2FuY2VsYWJsZVJlY29yZHMpOgor ICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50Lmg6CisgICAgICAgIChJ bnNwZWN0b3JUaW1lbGluZUFnZW50KToKKwogMjAxMi0wMy0xNCAgQ2hyaXMgRmxlaXphY2ggIDxj ZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYRGVzY3JpcHRpb24gZm9yIEhUTUw1IGZv b3RlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVs aW5lQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclRpbWVsaW5l QWdlbnQuY3BwCmluZGV4IDlhNTk0NDlkNTZiZjc4YTQyZjM5ZmY4YWZhNTdhN2QwYTg5ODA5N2Eu LjVhYmI5ZjA3ZGUyZjg5NzEwOGYxNzE1NjZhYWRmMjNlNDBlNTZiNjUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxpbmVBZ2VudC5jcHAKQEAgLTM3 OSw3ICszNzksMTMgQEAgdm9pZCBJbnNwZWN0b3JUaW1lbGluZUFnZW50OjpkaWRGaXJlQW5pbWF0 aW9uRnJhbWUoKQogICAgIGRpZENvbXBsZXRlQ3VycmVudFJlY29yZChUaW1lbGluZVJlY29yZFR5 cGU6OkZpcmVBbmltYXRpb25GcmFtZSk7CiB9CiAKLXZvaWQgSW5zcGVjdG9yVGltZWxpbmVBZ2Vu dDo6YWRkUmVjb3JkVG9UaW1lbGluZShQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gcHJwUmVj b3JkLCBjb25zdCBTdHJpbmcmIHR5cGUpCit2b2lkIEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OmFk ZFJlY29yZFRvVGltZWxpbmUoUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IHJlY29yZCwgY29u c3QgU3RyaW5nJiB0eXBlKQoreworICAgIGNvbW1pdENhbmNlbGFibGVSZWNvcmRzKCk7CisgICAg aW5uZXJBZGRSZWNvcmRUb1RpbWVsaW5lKHJlY29yZCwgdHlwZSk7Cit9CisKK3ZvaWQgSW5zcGVj dG9yVGltZWxpbmVBZ2VudDo6aW5uZXJBZGRSZWNvcmRUb1RpbWVsaW5lKFBhc3NSZWZQdHI8SW5z cGVjdG9yT2JqZWN0PiBwcnBSZWNvcmQsIGNvbnN0IFN0cmluZyYgdHlwZSkKIHsKICAgICBSZWZQ dHI8SW5zcGVjdG9yT2JqZWN0PiByZWNvcmQocHJwUmVjb3JkKTsKICAgICByZWNvcmQtPnNldFN0 cmluZygidHlwZSIsIHR5cGUpOwpAQCAtNDM4LDcgKzQ0NCw2IEBAIEluc3BlY3RvclRpbWVsaW5l QWdlbnQ6Okluc3BlY3RvclRpbWVsaW5lQWdlbnQoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5zdHJ1 bWVudGluCiB2b2lkIEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OmFwcGVuZFJlY29yZChQYXNzUmVm UHRyPEluc3BlY3Rvck9iamVjdD4gZGF0YSwgY29uc3QgU3RyaW5nJiB0eXBlLCBib29sIGNhcHR1 cmVDYWxsU3RhY2spCiB7CiAgICAgcHVzaEdDRXZlbnRSZWNvcmRzKCk7Ci0gICAgY29tbWl0Q2Fu Y2VsYWJsZVJlY29yZHMoKTsKICAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiByZWNvcmQgPSBU aW1lbGluZVJlY29yZEZhY3Rvcnk6OmNyZWF0ZUdlbmVyaWNSZWNvcmQodGltZXN0YW1wKCksIGNh cHR1cmVDYWxsU3RhY2sgPyBtX21heENhbGxTdGFja0RlcHRoIDogMCk7CiAgICAgcmVjb3JkLT5z ZXRPYmplY3QoImRhdGEiLCBkYXRhKTsKICAgICByZWNvcmQtPnNldFN0cmluZygidHlwZSIsIHR5 cGUpOwpAQCAtNDYxLDEzICs0NjYsMTkgQEAgdm9pZCBJbnNwZWN0b3JUaW1lbGluZUFnZW50Ojpw dXNoQ2FuY2VsYWJsZVJlY29yZChQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gZGEKIAogdm9p ZCBJbnNwZWN0b3JUaW1lbGluZUFnZW50Ojpjb21taXRDYW5jZWxhYmxlUmVjb3JkcygpCiB7Cisg ICAgVmVjdG9yPFRpbWVsaW5lUmVjb3JkRW50cnk+IGNhbmNlbGFibGVSZWNvcmRzOwogICAgIHdo aWxlICghbV9yZWNvcmRTdGFjay5pc0VtcHR5KCkpIHsKICAgICAgICAgVGltZWxpbmVSZWNvcmRF bnRyeSBlbnRyeSA9IG1fcmVjb3JkU3RhY2subGFzdCgpOwogICAgICAgICBpZiAoIW1fcmVjb3Jk U3RhY2subGFzdCgpLmNhbmNlbGFibGUpCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgbV9y ZWNvcmRTdGFjay5yZW1vdmVMYXN0KCk7CisgICAgICAgIGNhbmNlbGFibGVSZWNvcmRzLmFwcGVu ZChlbnRyeSk7CisgICAgfQorICAgIHdoaWxlICghY2FuY2VsYWJsZVJlY29yZHMuaXNFbXB0eSgp KSB7CisgICAgICAgIFRpbWVsaW5lUmVjb3JkRW50cnkgZW50cnkgPSBjYW5jZWxhYmxlUmVjb3Jk cy5sYXN0KCk7CisgICAgICAgIGNhbmNlbGFibGVSZWNvcmRzLnJlbW92ZUxhc3QoKTsKICAgICAg ICAgZW50cnkucmVjb3JkLT5zZXRPYmplY3QoImRhdGEiLCBlbnRyeS5kYXRhKTsKLSAgICAgICAg YWRkUmVjb3JkVG9UaW1lbGluZShlbnRyeS5yZWNvcmQsIGVudHJ5LnR5cGUpOworICAgICAgICBp bm5lckFkZFJlY29yZFRvVGltZWxpbmUoZW50cnkucmVjb3JkLnJlbGVhc2UoKSwgZW50cnkudHlw ZSk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yVGltZWxpbmVBZ2VudC5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv clRpbWVsaW5lQWdlbnQuaAppbmRleCBjNDVkMGMzYmI2MTU4NmRiOTRlZWY0OWY0MTkzMWE0Yjgz MmJlNjYxLi5lYWE4ZDJmNmEwYjA0NTQwZDQyODZmYzYzZDdmOWM2MzFjYTU2ZWNkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yVGltZWxpbmVBZ2VudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JUaW1lbGluZUFnZW50LmgKQEAg LTE1Niw2ICsxNTYsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgY29tbWl0Q2FuY2VsYWJsZVJlY29y ZHMoKTsKICAgICB2b2lkIGNhbmNlbFJlY29yZChjb25zdCBTdHJpbmcmIHR5cGUpOwogICAgIHZv aWQgYWRkUmVjb3JkVG9UaW1lbGluZShQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4sIGNvbnN0 IFN0cmluZyYgdHlwZSk7CisgICAgdm9pZCBpbm5lckFkZFJlY29yZFRvVGltZWxpbmUoUGFzc1Jl ZlB0cjxJbnNwZWN0b3JPYmplY3Q+LCBjb25zdCBTdHJpbmcmIHR5cGUpOwogCiAgICAgdm9pZCBw dXNoR0NFdmVudFJlY29yZHMoKTsKICAgICB2b2lkIGNsZWFyUmVjb3JkU3RhY2soKTsK