81231 2012-03-15 10:15:57 -0700 Web Inspector: normalize vertical overview bars by longest bar, not by longest frame 2012-03-15 12:34:33 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 579471 0 caseq 2012-03-15 10:15:57 -0700 Some frames take very long, especially when there's no animation -- so we should use total "cpu" time for frame rather then frame length for normalizing bars in the vertical overview mode. 579474 1 132069 caseq 2012-03-15 10:17:43 -0700 Created attachment 132069 Patch 579641 2 caseq 2012-03-15 12:34:33 -0700 Committed r110873: <http://trac.webkit.org/changeset/110873> 132069 2012-03-15 10:17:43 -0700 2012-03-15 11:16:06 -0700 Patch bug-81231-20120315211741.patch text/plain 7479 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk2NjZmZTVmNjE4MDVk NWI1ODI0YmYzZTYxODg3MmMwNjQxNWQzNS4uZDYwMjNmMmM1MmQ5OGQ2NGMxMWFmMzkyN2IzZDQ2 ZmE3ZDhlZWY1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTE1ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogbm9ybWFsaXplIHZlcnRpY2FsIG92ZXJ2aWV3IGJhcnMgYnkgbG9uZ2VzdCBiYXIsIG5vdCBi eSBsb25nZXN0IGZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04MTIzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGltZWxpbmVPdmVydmlld1BhbmUucHJvdG90eXBlLnJlc2V0KToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5wcm90b3R5cGUuYWNjZXB0KToKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5wcm90b3R5cGUud2luZG93 RW5kVGltZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVWZXJ0aWNhbE92ZXJ2aWV3 LnByb3RvdHlwZS5yZXNldCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVWZXJ0aWNh bE92ZXJ2aWV3LnByb3RvdHlwZS51cGRhdGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVs aW5lVmVydGljYWxPdmVydmlldy5wcm90b3R5cGUuX2FnZ3JlZ2F0ZUZyYW1lcyk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuVGltZWxpbmVWZXJ0aWNhbE92ZXJ2aWV3LnByb3RvdHlwZS5fYWdncmVn YXRlUmVjb3Jkcyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVWZXJ0aWNhbE92ZXJ2 aWV3LnByb3RvdHlwZS5nZXRXaW5kb3dUaW1lcyk6CisKIDIwMTItMDMtMTQgIENocmlzIEZsZWl6 YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWERlc2NyaXB0aW9uIGZvciBI VE1MNSBmb290ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGltZWxpbmVPdmVydmlld1BhbmUuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lT3ZlcnZpZXdQYW5lLmpzCmluZGV4IDgzOWVmMTVhZjIzMzI4OGFiOWU5 YTkwZTVkZWFjMzFmZTU1YjVlMWUuLmY1NGU3YzRiMjk3YmRhMTkxZTIzMDFjZTcxYWQ3MWQ4NWI0 ZWI0MmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGlt ZWxpbmVPdmVydmlld1BhbmUuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9UaW1lbGluZU92ZXJ2aWV3UGFuZS5qcwpAQCAtMzksNyArMzksNyBAQCBXZWJJbnNwZWN0 b3IuVGltZWxpbmVPdmVydmlld1BhbmUgPSBmdW5jdGlvbihwcmVzZW50YXRpb25Nb2RlbCkKICAg ICB0aGlzLmVsZW1lbnQuaWQgPSAidGltZWxpbmUtb3ZlcnZpZXctcGFuZWwiOwogCiAgICAgdGhp cy5fd2luZG93U3RhcnRUaW1lID0gMDsKLSAgICB0aGlzLl93aW5kb3dFbmRUaW1lID0gbnVsbDsK KyAgICB0aGlzLl93aW5kb3dFbmRUaW1lID0gSW5maW5pdHk7CiAKICAgICB0aGlzLl9wcmVzZW50 YXRpb25Nb2RlbCA9IHByZXNlbnRhdGlvbk1vZGVsOwogCkBAIC0yNzQsNyArMjc0LDcgQEAgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXdQYW5lLnByb3RvdHlwZSA9IHsKICAgICByZXNldDog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5fd2luZG93U3RhcnRUaW1lID0gMDsKLSAg ICAgICAgdGhpcy5fd2luZG93RW5kVGltZSA9IG51bGw7CisgICAgICAgIHRoaXMuX3dpbmRvd0Vu ZFRpbWUgPSBJbmZpbml0eTsKICAgICAgICAgdGhpcy5fb3ZlcnZpZXdXaW5kb3cucmVzZXQoKTsK ICAgICAgICAgdGhpcy5fb3ZlcnZpZXdDYWxjdWxhdG9yLnJlc2V0KCk7CiAgICAgICAgIHRoaXMu X292ZXJ2aWV3R3JpZC51cGRhdGVEaXZpZGVycyh0cnVlLCB0aGlzLl9vdmVydmlld0NhbGN1bGF0 b3IpOwpAQCAtMjkyLDcgKzI5Miw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFu ZS5wcm90b3R5cGUgPSB7CiAgICAgICovCiAgICAgYWNjZXB0OiBmdW5jdGlvbihyZWNvcmQpCiAg ICAgewotICAgICAgICByZXR1cm4gcmVjb3JkLmVuZFRpbWUgPj0gdGhpcy5fd2luZG93U3RhcnRU aW1lICYmICh0eXBlb2YgdGhpcy5fd2luZG93RW5kVGltZSAhPT0gIm51bWJlciIgfHwgcmVjb3Jk LnN0YXJ0VGltZSA8PSB0aGlzLl93aW5kb3dFbmRUaW1lKTsKKyAgICAgICAgcmV0dXJuIHJlY29y ZC5lbmRUaW1lID49IHRoaXMuX3dpbmRvd1N0YXJ0VGltZSAmJiByZWNvcmQuc3RhcnRUaW1lIDw9 IHRoaXMuX3dpbmRvd0VuZFRpbWU7CiAgICAgfSwKIAogICAgIHdpbmRvd1N0YXJ0VGltZTogZnVu Y3Rpb24oKQpAQCAtMzAyLDcgKzMwMiw3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3 UGFuZS5wcm90b3R5cGUgPSB7CiAKICAgICB3aW5kb3dFbmRUaW1lOiBmdW5jdGlvbigpCiAgICAg ewotICAgICAgICByZXR1cm4gdGhpcy5fd2luZG93RW5kVGltZSB8fCB0aGlzLl9wcmVzZW50YXRp b25Nb2RlbC5tYXhpbXVtUmVjb3JkVGltZSgpOworICAgICAgICByZXR1cm4gdGhpcy5fd2luZG93 RW5kVGltZSA8IEluZmluaXR5ID8gdGhpcy5fd2luZG93RW5kVGltZSA6IHRoaXMuX3ByZXNlbnRh dGlvbk1vZGVsLm1heGltdW1SZWNvcmRUaW1lKCk7CiAgICAgfSwKIAogICAgIHdpbmRvd0xlZnQ6 IGZ1bmN0aW9uKCkKQEAgLTgwMyw0MiArODAzLDM3IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVZl cnRpY2FsT3ZlcnZpZXcucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9yZWNvcmRzUGVyQmFy ID0gMTsKICAgICAgICAgdGhpcy5fZnJhbWVNb2RlID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2Jh clRpbWVzID0gW107CisgICAgICAgIHRoaXMuX2xvbmdlc3RCYXJUaW1lID0gMDsKICAgICB9LAog Ci0gICAgdXBkYXRlOiBmdW5jdGlvbihyZWNvcmRzKQorICAgIHVwZGF0ZTogZnVuY3Rpb24oYWxs UmVjb3JkcykKICAgICB7Ci0gICAgICAgIHJlY29yZHMgPSB0aGlzLl9maWx0ZXJSZWNvcmRzKHJl Y29yZHMpOwotCisgICAgICAgIHZhciByZWNvcmRzID0gW107CiAgICAgICAgIHZhciBmcmFtZUNv dW50ID0gMDsKLSAgICAgICAgdmFyIGJvdW5kYXJ5U3BhbiA9IDA7Ci0gICAgICAgIHZhciBsYXN0 RnJhbWVUaW1lID0gcmVjb3Jkcy5sZW5ndGggJiYgcmVjb3Jkc1swXS5zdGFydFRpbWU7Ci0gICAg ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcmVjb3Jkcy5sZW5ndGg7ICsraSkgewotICAgICAgICAg ICAgdmFyIHJlY29yZCA9IHJlY29yZHNbaV07Ci0gICAgICAgICAgICB2YXIgZHVyYXRpb24gPSBy ZWNvcmQuZW5kVGltZSAtIHJlY29yZC5zdGFydFRpbWU7Ci0gICAgICAgICAgICBpZiAoYm91bmRh cnlTcGFuIDwgZHVyYXRpb24pCi0gICAgICAgICAgICAgICAgYm91bmRhcnlTcGFuID0gZHVyYXRp b247Ci0gICAgICAgICAgICBpZiAocmVjb3JkLnR5cGUgPT09IFdlYkluc3BlY3Rvci5UaW1lbGlu ZU1vZGVsLlJlY29yZFR5cGUuQmVnaW5GcmFtZSB8fCAoZnJhbWVDb3VudCAmJiAoaSArIDEgPT09 IHJlY29yZHMubGVuZ3RoKSkpIHsKLSAgICAgICAgICAgICAgICAvLyBpZiB3ZSBoYXZlIGZyYW1l cywgdGFrZSBmcmFtZSBkdXJhdGlvbiBpbnRvIGFjY291bnQKLSAgICAgICAgICAgICAgICBpZiAo cmVjb3JkLnN0YXJ0VGltZSAtIGxhc3RGcmFtZVRpbWUgPiBib3VuZGFyeVNwYW4pCi0gICAgICAg ICAgICAgICAgICAgIGJvdW5kYXJ5U3BhbiA9IHJlY29yZC5zdGFydFRpbWUgLSBsYXN0RnJhbWVU aW1lOwotICAgICAgICAgICAgICAgIGxhc3RGcmFtZVRpbWUgPSByZWNvcmQuc3RhcnRUaW1lOwor ICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGFsbFJlY29yZHMubGVuZ3RoOyArK2kpIHsKKyAg ICAgICAgICAgIHZhciByZWNvcmQgPSBhbGxSZWNvcmRzW2ldOworICAgICAgICAgICAgaWYgKHJl Y29yZC5jYXRlZ29yeS5oaWRkZW4pCisgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAg ICAgICBpZiAocmVjb3JkLnR5cGUgPT09IFdlYkluc3BlY3Rvci5UaW1lbGluZU1vZGVsLlJlY29y ZFR5cGUuQmVnaW5GcmFtZSB8fCAoZnJhbWVDb3VudCAmJiAoaSArIDEgPT09IHJlY29yZHMubGVu Z3RoKSkpCiAgICAgICAgICAgICAgICAgKytmcmFtZUNvdW50OwotICAgICAgICAgICAgfQorICAg ICAgICAgICAgcmVjb3Jkcy5wdXNoKHJlY29yZCk7CiAgICAgICAgIH0KICAgICAgICAgLy8gSWYg d2UgaGF2ZSBmcmFtZXMsIGFnZ3JlZ2F0ZSBieSBmcmFtZXM7IG90aGVyd2lzZSwganVzdCBzaG93 IHRvcC1sZXZlbCByZWNvcmRzLgogICAgICAgICB2YXIgcmVjb3JkQ291bnQgPSBmcmFtZUNvdW50 IHx8IHJlY29yZHMubGVuZ3RoOwogCi0gICAgICAgIGNvbnN0IHBhZGRpbmdUb3AgPSA0OwogICAg ICAgICBjb25zdCBtaW5CYXJXaWR0aCA9IDQ7Ci0gICAgICAgIHZhciBzY2FsZSA9ICh0aGlzLmVs ZW1lbnQuY2xpZW50SGVpZ2h0IC0gcGFkZGluZ1RvcCkgLyBib3VuZGFyeVNwYW47CiAgICAgICAg IHRoaXMuX3JlY29yZHNQZXJCYXIgPSBNYXRoLm1heCgxLCByZWNvcmRDb3VudCAqIG1pbkJhcldp ZHRoIC8gdGhpcy5lbGVtZW50LmNsaWVudFdpZHRoKTsKICAgICAgICAgdmFyIG51bWJlck9mQmFy cyA9IE1hdGguY2VpbChyZWNvcmRDb3VudCAvIHRoaXMuX3JlY29yZHNQZXJCYXIpOwogCiAgICAg ICAgIHRoaXMuX2JhclRpbWVzID0gW107CisgICAgICAgIHRoaXMuX2xvbmdlc3RCYXJUaW1lID0g MDsKICAgICAgICAgdGhpcy5lbGVtZW50LnJlbW92ZUNoaWxkcmVuKCk7CiAgICAgICAgIHZhciBw YWRkaW5nID0gdGhpcy5lbGVtZW50LmNyZWF0ZUNoaWxkKCJkaXYiLCAicGFkZGluZyIpOwogCiAg ICAgICAgIHZhciBzdGF0aXN0aWNzID0gZnJhbWVDb3VudCA/IHRoaXMuX2FnZ3JlZ2F0ZUZyYW1l cyhyZWNvcmRzLCBudW1iZXJPZkJhcnMpIDogdGhpcy5fYWdncmVnYXRlUmVjb3JkcyhyZWNvcmRz LCBudW1iZXJPZkJhcnMpOworICAgICAgICBjb25zdCBwYWRkaW5nVG9wID0gNDsKKyAgICAgICAg dmFyIHNjYWxlID0gKHRoaXMuZWxlbWVudC5jbGllbnRIZWlnaHQgLSBwYWRkaW5nVG9wKSAvIHRo aXMuX2xvbmdlc3RCYXJUaW1lOworICAgICAgICAKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkg PCBzdGF0aXN0aWNzLmxlbmd0aDsgKytpKQogICAgICAgICAgICAgdGhpcy5lbGVtZW50Lmluc2Vy dEJlZm9yZSh0aGlzLl9idWlsZEJhcihzdGF0aXN0aWNzW2ldLCBzY2FsZSksIHBhZGRpbmcpOwog ICAgIH0sCkBAIC04NjYsNiArODYxLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lVmVydGljYWxP dmVydmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICB2YXIgYmFy RW5kVGltZSA9IHJlY29yZHNbY3VycmVudFJlY29yZCAtIDFdLmVuZFRpbWU7CiAgICAgICAgICAg ICBpZiAobG9uZ2VzdEZyYW1lU3RhdGlzdGljcykgeworICAgICAgICAgICAgICAgIHRoaXMuX2xv bmdlc3RCYXJUaW1lID0gTWF0aC5tYXgodGhpcy5fbG9uZ2VzdEJhclRpbWUsIGxvbmdlc3RGcmFt ZVRpbWUpOwogICAgICAgICAgICAgICAgIHN0YXRpc3RpY3MucHVzaChsb25nZXN0RnJhbWVTdGF0 aXN0aWNzKTsKICAgICAgICAgICAgICAgICB0aGlzLl9iYXJUaW1lcy5wdXNoKHsgc3RhcnRUaW1l OiBiYXJTdGFydFRpbWUsIGVuZFRpbWU6IGJhckVuZFRpbWUgfSk7CiAgICAgICAgICAgICB9CkBA IC05MDksMjAgKzkwNSwxMiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVWZXJ0aWNhbE92ZXJ2aWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHZhciBiYXJFbmRUaW1l ID0gcmVjb3Jkc1tjdXJyZW50UmVjb3JkIC0gMV0uZW5kVGltZTsKICAgICAgICAgICAgIHN0YXRp c3RpY3MucHVzaChsb25nZXN0UmVjb3JkLmFnZ3JlZ2F0ZWRTdGF0cyk7CisgICAgICAgICAgICB0 aGlzLl9sb25nZXN0QmFyVGltZSA9IE1hdGgubWF4KHRoaXMuX2xvbmdlc3RCYXJUaW1lLCBsb25n ZXN0UmVjb3JkLmVuZFRpbWUgLSBsb25nZXN0UmVjb3JkLnN0YXJ0VGltZSk7CiAgICAgICAgICAg ICB0aGlzLl9iYXJUaW1lcy5wdXNoKHsgc3RhcnRUaW1lOiBiYXJTdGFydFRpbWUsIGVuZFRpbWU6 IGJhckVuZFRpbWUgfSk7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIHN0YXRpc3RpY3M7CiAg ICAgfSwKIAotICAgIF9maWx0ZXJSZWNvcmRzOiBmdW5jdGlvbihyZWNvcmRzKQotICAgIHsKLSAg ICAgICAgZnVuY3Rpb24gZmlsdGVyKHJlY29yZCkKLSAgICAgICAgewotICAgICAgICAgICAgcmV0 dXJuICFyZWNvcmQuY2F0ZWdvcnkuaGlkZGVuOwotICAgICAgICB9Ci0gICAgICAgIHJldHVybiBy ZWNvcmRzLmZpbHRlcihmaWx0ZXIpOwotICAgIH0sCi0KICAgICBfYnVpbGRCYXI6IGZ1bmN0aW9u KHN0YXRpc3RpY3MsIHNjYWxlKQogICAgIHsKICAgICAgICAgdmFyIG91dGVyID0gZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgiZGl2Iik7CkBAIC05NTUsOCArOTQzLDggQEAgV2ViSW5zcGVjdG9yLlRp bWVsaW5lVmVydGljYWxPdmVydmlldy5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBsYXN0QmFy ID0gTWF0aC5taW4oTWF0aC5jZWlsKChyaWdodE9mZnNldCAtIG9mZnNldDAgLSAyKSAvIGJhcldp ZHRoKSwgdGhpcy5fYmFyVGltZXMubGVuZ3RoIC0gMSk7CiAgICAgICAgIGNvbnN0IHNuYXBUb1Jp Z2h0VG9sZXJhbmNlUGl4ZWxzID0gMzsKICAgICAgICAgcmV0dXJuIHsKLSAgICAgICAgICAgIHN0 YXJ0VGltZTogdGhpcy5fYmFyVGltZXNbZmlyc3RCYXJdLnN0YXJ0VGltZSwKLSAgICAgICAgICAg IGVuZFRpbWU6IHJpZ2h0T2Zmc2V0ICsgc25hcFRvUmlnaHRUb2xlcmFuY2VQaXhlbHMgPiB3aW5k b3dTcGFuID8gbnVsbCA6IHRoaXMuX2JhclRpbWVzW2xhc3RCYXJdLmVuZFRpbWUKKyAgICAgICAg ICAgIHN0YXJ0VGltZTogZmlyc3RCYXIgPj0gdGhpcy5fYmFyVGltZXMubGVuZ3RoID8gSW5maW5p dHkgOiB0aGlzLl9iYXJUaW1lc1tmaXJzdEJhcl0uc3RhcnRUaW1lLAorICAgICAgICAgICAgZW5k VGltZTogcmlnaHRPZmZzZXQgKyBzbmFwVG9SaWdodFRvbGVyYW5jZVBpeGVscyA+IHdpbmRvd1Nw YW4gPyBJbmZpbml0eSA6IHRoaXMuX2JhclRpbWVzW2xhc3RCYXJdLmVuZFRpbWUKICAgICAgICAg fQogICAgIH0KIH0K