81224 2012-03-15 09:05:46 -0700 Web Inspector: improve HeapSnapshot._buildReversIndex performance 2012-03-15 09:40:24 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 579424 0 yurys 2012-03-15 09:05:46 -0700 Caching node indexes and node count in local variables instead of calling getters each time reduces the method run time by factor of 1.5 579425 1 132059 yurys 2012-03-15 09:07:26 -0700 Created attachment 132059 Patch 579428 2 yurys 2012-03-15 09:10:54 -0700 For the WebKit/PerformanceTests/inspector/detailed-heapshots-smoke-test.html test with the patch applied: RESULT heap-snapshot: _buildDominatedNodes= 2857 ms without: RESULT heap-snapshot: _buildDominatedNodes= 4417 ms 579444 3 yurys 2012-03-15 09:40:24 -0700 Committed r110853: <http://trac.webkit.org/changeset/110853> 132059 2012-03-15 09:07:26 -0700 2012-03-15 09:09:08 -0700 Patch bug-81224-20120315200724.patch text/plain 2796 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzcyOWIxNjI5MWRiYjhk MTFjZDhlYmE1MjI5ZjM1NmNhOWRhNGE5OC4uMDkwMDNmNWY0YWE5MzE1M2RhZDc3NjZjOTQwNmYz MmYxYjgxZWZmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTAzLTE1ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGltcHJvdmUgSGVhcFNuYXBzaG90Ll9idWlsZFJldmVyc0luZGV4IHBlcmZvcm1hbmNlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTIyNAorCisg ICAgICAgIENhY2hpbmcgbm9kZSBpbmRleGVzIGFuZCBub2RlIGNvdW50IGluIGxvY2FsIHZhcmlh YmxlcyBpbnN0ZWFkIG9mCisgICAgICAgIGNhbGxpbmcgZ2V0dGVycyBlYWNoIHRpbWUgcmVkdWNl cyB0aGUgbWV0aG9kIHJ1biB0aW1lIGJ5CisgICAgICAgIGZhY3RvciBvZiAxLjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvSGVhcFNuYXBzaG90LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hv dC5wcm90b3R5cGUuX2J1aWxkUmV2ZXJzZUluZGV4KToKKwogMjAxMi0wMy0xNCAgWXVyeSBTZW1p a2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiB1 c2UgY2xhc3MgbmFtZSBpbmRleGVzIGluc3RlYWQgb2YgY2xhc3MgbmFtZXMgd2hlbiBldmFsdWF0 aW5nIGFnZ3JlZ2F0ZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvSGVhcFNuYXBzaG90LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9IZWFwU25hcHNob3QuanMKaW5kZXggOWNjZTk5YjhmZDdmZDAzZWU5MzA0N2E3OWUzYWUyNTg0 N2NjNDY2Zi4uMjdlZTU5NDlmOTExOWVhNThkM2YzMjVhYjBlYTYwMjQ1MWU0YzNiYSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMK QEAgLTkzMyw5ICs5MzMsMTEgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUg PSB7CiAgICAgICAgIC8vICAtICJpbmRleEFycmF5IiBpcyBhbiBhcnJheSBvZiBpbmRleGVzIGlu IHRoZSAiYmFja1JlZnNBcnJheSIKICAgICAgICAgLy8gICAgd2l0aCB0aGUgc2FtZSBwb3NpdGlv bnMgYXMgaW4gdGhlIF9ub2RlSW5kZXguCiAgICAgICAgIHZhciBpbmRleEFycmF5ID0gdGhpc1tp bmRleEFycmF5TmFtZV0gPSBuZXcgSW50MzJBcnJheSh0aGlzLl9ub2RlSW5kZXgubGVuZ3RoKTsK LSAgICAgICAgdmFyIG5vZGUgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdE5vZGUodGhp cywgdGhpcy5ub2RlSW5kZXhlc1swXSk7Ci0gICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhp cy5ub2RlQ291bnQ7ICsraSkgewotICAgICAgICAgICAgbm9kZS5ub2RlSW5kZXggPSB0aGlzLm5v ZGVJbmRleGVzW2ldOworICAgICAgICB2YXIgbm9kZUluZGV4ZXMgPSB0aGlzLm5vZGVJbmRleGVz OworICAgICAgICB2YXIgbm9kZUNvdW50ID0gdGhpcy5ub2RlQ291bnQ7CisgICAgICAgIHZhciBu b2RlID0gbmV3IFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3ROb2RlKHRoaXMsIG5vZGVJbmRleGVz WzBdKTsKKyAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBub2RlQ291bnQ7ICsraSkgeworICAg ICAgICAgICAgbm9kZS5ub2RlSW5kZXggPSBub2RlSW5kZXhlc1tpXTsKICAgICAgICAgICAgIGlu ZGV4Q2FsbGJhY2sobm9kZSwgZnVuY3Rpb24gKHBvc2l0aW9uKSB7ICsraW5kZXhBcnJheVtwb3Np dGlvbl07IH0pOwogICAgICAgICB9CiAgICAgICAgIHZhciBiYWNrUmVmc0NvdW50ID0gMDsKQEAg LTk1MCw5ICs5NTIsOCBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsK ICAgICAgICAgICAgIGluZGV4QXJyYXlbaV0gPSBiYWNrUmVmc1Bvc2l0aW9uOwogICAgICAgICAg ICAgYmFja1JlZnNQb3NpdGlvbiArPSBiYWNrUmVmc0NvdW50OwogICAgICAgICB9Ci0gICAgICAg IG5vZGUgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdE5vZGUodGhpcywgdGhpcy5ub2Rl SW5kZXhlc1swXSk7Ci0gICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5ub2RlQ291bnQ7 ICsraSkgewotICAgICAgICAgICAgbm9kZS5ub2RlSW5kZXggPSB0aGlzLm5vZGVJbmRleGVzW2ld OworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IG5vZGVDb3VudDsgKytpKSB7CisgICAgICAg ICAgICBub2RlLm5vZGVJbmRleCA9IG5vZGVJbmRleGVzW2ldOwogICAgICAgICAgICAgZGF0YUNh bGxiYWNrKG5vZGUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgZnVuY3Rpb24gKGJhY2tSZWZJ bmRleCkgeyByZXR1cm4gYmFja1JlZkluZGV4ICsgKC0tYmFja1JlZnNBcnJheVtiYWNrUmVmSW5k ZXhdKTsgfSwKICAgICAgICAgICAgICAgICAgICAgICAgICBmdW5jdGlvbiAoYmFja1JlZkluZGV4 LCBkZXN0SW5kZXgpIHsgYmFja1JlZnNBcnJheVtiYWNrUmVmSW5kZXhdID0gZGVzdEluZGV4OyB9 KTsK