81220 2012-03-15 07:49:04 -0700 [EFL] Implement LayoutTestController::setMinimumTimerInterval 2012-05-15 00:20:54 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 naginenis naginenis gyuyoung.kim lucas.de.marchi pnormand rakuco tonikitoo webkit.review.bot oldest_to_newest 579379 0 naginenis 2012-03-15 07:49:04 -0700 Implement LayoutTestController::setMinimumTimerInterval for EFL port so that we can unskip related tests from the skip list. 579395 1 132051 naginenis 2012-03-15 08:13:55 -0700 Created attachment 132051 Implement setMinimumTimerInterval and enable related tests. 579404 2 132051 rakuco 2012-03-15 08:23:53 -0700 Comment on attachment 132051 Implement setMinimumTimerInterval and enable related tests. Looks good, thanks. 580197 3 132051 gyuyoung.kim 2012-03-15 23:47:38 -0700 Comment on attachment 132051 Implement setMinimumTimerInterval and enable related tests. LGTM too. 591944 4 132051 pnormand 2012-03-30 01:24:14 -0700 Comment on attachment 132051 Implement setMinimumTimerInterval and enable related tests. View in context: https://bugs.webkit.org/attachment.cgi?id=132051&action=review > Tools/ChangeLog:12 > + (LayoutTestController::setMinimumTimerInterval): Implemented. "Implemented" here doesn't add much explanation to the changelog entry. Eithere remove it or provide a suitable explanation. 591955 5 naginenis 2012-03-30 01:48:13 -0700 (In reply to comment #4) > (From update of attachment 132051 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132051&action=review > > > Tools/ChangeLog:12 > > + (LayoutTestController::setMinimumTimerInterval): Implemented. > > "Implemented" here doesn't add much explanation to the changelog entry. Eithere remove it or provide a suitable explanation. Description is already there in the changelog, so I will remove it. Thanks for your review! 591957 6 134745 naginenis 2012-03-30 01:49:59 -0700 Created attachment 134745 Patch Fix changelog entry. 591989 7 134745 webkit.review.bot 2012-03-30 02:46:22 -0700 Comment on attachment 134745 Patch Clearing flags on attachment: 134745 Committed r112647: <http://trac.webkit.org/changeset/112647> 591990 8 webkit.review.bot 2012-03-30 02:46:28 -0700 All reviewed patches have been landed. Closing bug. 132051 2012-03-15 08:13:55 -0700 2012-03-30 01:49:59 -0700 Implement setMinimumTimerInterval and enable related tests. setMinimumTimerInterval.patch text/plain 2900 naginenis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjOGMxODYyLi4wM2QyMjMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDMt MTUgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5j b20+CisKKyAgICAgICAgW0VGTF0gSW1wbGVtZW50IExheW91dFRlc3RDb250cm9sbGVyOjpzZXRN aW5pbXVtVGltZXJJbnRlcnZhbCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTgxMjIwCisKKyAgICAgICAgVW5za2lwIHRlc3RzIGNvbm5lY3RlZCB3aXRo IHNldE1pbmltdW1UaW1lckludGVydmFsLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1NraXBwZWQ6CisKIDIwMTItMDMtMTUg IE5pa29sYXMgWmltbWVybWFubiAgPG56aW1tZXJtYW5uQHJpbS5jb20+CiAKICAgICAgICAgRW5h YmxlIGFuaW1WYWwgc3VwcG9ydCBmb3IgU1ZHTnVtYmVyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVk CmluZGV4IGNiMjQ0OWYuLjFjODBmZWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2VmbC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC04 MDYsMTMgKzgwNiw2IEBAIGZhc3QvcHJlbG9hZGVyL2RvY3VtZW50LXdyaXRlLmh0bWwKIGh0dHAv dGVzdHMvbG9jYWwvbGluay1zdHlsZXNoZWV0LWxvYWQtb3JkZXItcHJlbG9hZC5odG1sCiBodHRw L3Rlc3RzL2xvY2FsL2xpbmstc3R5bGVzaGVldC1sb2FkLW9yZGVyLmh0bWwKIAotIyBFRkwncyBM YXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgc2V0TWluaW11bVRpbWVySW50 ZXJ2YWwKLWZhc3QvZG9tL3RpbWVyLWluY3JlYXNlLW1pbi1pbnRlcnZhbC1hbmQtcmVzZXQtcGFy dC0xLmh0bWwKLWZhc3QvZG9tL3RpbWVyLWluY3JlYXNlLW1pbi1pbnRlcnZhbC1yZXBlYXRpbmcu aHRtbAotZmFzdC9kb20vdGltZXItaW5jcmVhc2UtbWluLWludGVydmFsLmh0bWwKLWZhc3QvZG9t L3RpbWVyLWluY3JlYXNlLXRoZW4tZGVjcmVhc2UtbWluLWludGVydmFsLXJlcGVhdGluZy5odG1s Ci1mYXN0L2RvbS90aW1lci1pbmNyZWFzZS10aGVuLWRlY3JlYXNlLW1pbi1pbnRlcnZhbC5odG1s Ci0KICMgRUZMJ3MgTGF5b3V0VGVzdENvbnRyb2xsZXIgZG9lcyBub3QgaW1wbGVtZW50IHNldFRl eHREaXJlY3Rpb24KIGZhc3QvaHRtbC9zZXQtdGV4dC1kaXJlY3Rpb24uaHRtbAogCmRpZmYgLS1n aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTFhMTYwOS4uYWIx YjgxZiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTE1ICBTdWRhcnNhbmEgTmFnaW5lbmkgIDxzdWRhcnNh bmEubmFnaW5lbmlAbGludXguaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIEltcGxlbWVudCBM YXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0TWluaW11bVRpbWVySW50ZXJ2YWwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMjIwCisKKyAgICAgICAgQWRk IG1pc3NpbmcgaW1wbGVtZW50YXRpb24gc2V0TWluaW11bVRpbWVySW50ZXJ2YWwgdG8gRUZMJ3MK KyAgICAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIgc28gdGhhdCB3ZSBjYW4gdW5za2lwIHJlbGF0 ZWQgdGVzdHMgZnJvbSB0aGUgc2tpcCBsaXN0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250 cm9sbGVyRWZsLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpzZXRNaW5pbXVt VGltZXJJbnRlcnZhbCk6IEltcGxlbWVudGVkLgorCiAyMDEyLTAzLTE1ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBXZWJLaXQyQVBJ VGVzdHMvVGVzdFByaW50aW5nIHRpbWVvdXQgaW4gdGhlIGJvdHMKZGlmZiAtLWdpdCBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHAgYi9Ub29scy9E dW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwCmluZGV4IDdjZGUx MjYuLjJlNzEyNWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRU ZXN0Q29udHJvbGxlckVmbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91 dFRlc3RDb250cm9sbGVyRWZsLmNwcApAQCAtNzUyLDkgKzc1Miw5IEBAIHZvaWQgTGF5b3V0VGVz dENvbnRyb2xsZXI6OnNldFNlcmlhbGl6ZUhUVFBMb2Fkcyhib29sKQogICAgIG5vdEltcGxlbWVu dGVkKCk7CiB9CiAKLXZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldE1pbmltdW1UaW1lcklu dGVydmFsKGRvdWJsZSkKK3ZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldE1pbmltdW1UaW1l ckludGVydmFsKGRvdWJsZSBtaW5pbXVtVGltZXJJbnRlcnZhbCkKIHsKLSAgICBub3RJbXBsZW1l bnRlZCgpOworICAgIGV3a192aWV3X3NldHRpbmdfbWluaW11bV90aW1lcl9pbnRlcnZhbF9zZXQo YnJvd3Nlci0+bWFpblZpZXcoKSwgbWluaW11bVRpbWVySW50ZXJ2YWwpOwogfQogCiB2b2lkIExh eW91dFRlc3RDb250cm9sbGVyOjpzZXRUZXh0RGlyZWN0aW9uKEpTU3RyaW5nUmVmKQo= 134745 2012-03-30 01:49:59 -0700 2012-03-30 02:46:22 -0700 Patch setMinimumTimerInterval.patch text/plain 2888 naginenis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MGVkNTZjLi4wMmEwNWY0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDMt MzAgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5j b20+CisKKyAgICAgICAgW0VGTF0gSW1wbGVtZW50IExheW91dFRlc3RDb250cm9sbGVyOjpzZXRN aW5pbXVtVGltZXJJbnRlcnZhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODEyMjAKKworICAgICAgICBVbnNraXAgdGVzdHMgY29ubmVjdGVkIHdpdGgg c2V0TWluaW11bVRpbWVySW50ZXJ2YWwuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvU2tpcHBlZDoKKwogMjAxMi0wMy0zMCAg UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgR1RLIHJlYmFzZWxpbmUgYWZ0ZXIgcjExMjU4MiBhbmQgcjExMjM5MS4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZWZsL1NraXBwZWQKaW5kZXggOTY2ZGIxMy4uMmQyOWJmZSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs L1NraXBwZWQKQEAgLTc0OSwxMyArNzQ5LDYgQEAgZmFzdC9wcmVsb2FkZXIvZG9jdW1lbnQtd3Jp dGUuaHRtbAogaHR0cC90ZXN0cy9sb2NhbC9saW5rLXN0eWxlc2hlZXQtbG9hZC1vcmRlci1wcmVs b2FkLmh0bWwKIGh0dHAvdGVzdHMvbG9jYWwvbGluay1zdHlsZXNoZWV0LWxvYWQtb3JkZXIuaHRt bAogCi0jIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMgbm90IGltcGxlbWVudCBzZXRN aW5pbXVtVGltZXJJbnRlcnZhbAotZmFzdC9kb20vdGltZXItaW5jcmVhc2UtbWluLWludGVydmFs LWFuZC1yZXNldC1wYXJ0LTEuaHRtbAotZmFzdC9kb20vdGltZXItaW5jcmVhc2UtbWluLWludGVy dmFsLXJlcGVhdGluZy5odG1sCi1mYXN0L2RvbS90aW1lci1pbmNyZWFzZS1taW4taW50ZXJ2YWwu aHRtbAotZmFzdC9kb20vdGltZXItaW5jcmVhc2UtdGhlbi1kZWNyZWFzZS1taW4taW50ZXJ2YWwt cmVwZWF0aW5nLmh0bWwKLWZhc3QvZG9tL3RpbWVyLWluY3JlYXNlLXRoZW4tZGVjcmVhc2UtbWlu LWludGVydmFsLmh0bWwKLQogIyBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBkb2VzIG5vdCBp bXBsZW1lbnQgc2V0VGV4dERpcmVjdGlvbgogZmFzdC9odG1sL3NldC10ZXh0LWRpcmVjdGlvbi5o dG1sCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCAxOGYwM2JmLi4zMjk3NjgyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDMtMzAgIFN1ZGFyc2FuYSBOYWdp bmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VG TF0gSW1wbGVtZW50IExheW91dFRlc3RDb250cm9sbGVyOjpzZXRNaW5pbXVtVGltZXJJbnRlcnZh bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEyMjAK KworICAgICAgICBBZGQgbWlzc2luZyBpbXBsZW1lbnRhdGlvbiBzZXRNaW5pbXVtVGltZXJJbnRl cnZhbCB0byBFRkwncworICAgICAgICBMYXlvdXRUZXN0Q29udHJvbGxlciBzbyB0aGF0IHdlIGNh biB1bnNraXAgcmVsYXRlZCB0ZXN0cyBmcm9tIHRoZSBza2lwIGxpc3QuCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwv TGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xs ZXI6OnNldE1pbmltdW1UaW1lckludGVydmFsKToKKwogMjAxMi0wMy0yOSAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZWQg4oCcSW50ZWzigJ0gZnJvbSB0 aGUgTGlvbiBidWlsZGVyc+KAmSBuYW1lcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVmbC5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwCmluZGV4IGQ5MjJjY2IuLjkzMGQwYjIg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxl ckVmbC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0xheW91dFRlc3RDb250cm9s bGVyRWZsLmNwcApAQCAtNzU3LDkgKzc1Nyw5IEBAIHZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6 OnNldFNlcmlhbGl6ZUhUVFBMb2Fkcyhib29sKQogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAK LXZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldE1pbmltdW1UaW1lckludGVydmFsKGRvdWJs ZSkKK3ZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldE1pbmltdW1UaW1lckludGVydmFsKGRv dWJsZSBtaW5pbXVtVGltZXJJbnRlcnZhbCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IGV3a192aWV3X3NldHRpbmdfbWluaW11bV90aW1lcl9pbnRlcnZhbF9zZXQoYnJvd3Nlci0+bWFp blZpZXcoKSwgbWluaW11bVRpbWVySW50ZXJ2YWwpOwogfQogCiB2b2lkIExheW91dFRlc3RDb250 cm9sbGVyOjpzZXRUZXh0RGlyZWN0aW9uKEpTU3RyaW5nUmVmKQo=