81205 2012-03-15 04:18:53 -0700 [EFL] Enable view mode media feature layout tests 2012-05-15 00:20:53 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 naginenis naginenis gyuyoung.kim lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 579266 0 naginenis 2012-03-15 04:18:53 -0700 Implement LayoutTestController::setViewModeMediaFeature for EFL port so that we can enable view mode media feature layout tests. 579276 1 132018 naginenis 2012-03-15 04:39:52 -0700 Created attachment 132018 Patch Implement setViewModeMediaFeature and unskip view mode media feature tests. 579298 2 132018 gyuyoung.kim 2012-03-15 05:37:44 -0700 Comment on attachment 132018 Patch Looks fine. 579329 3 132018 rakuco 2012-03-15 06:41:23 -0700 Comment on attachment 132018 Patch Looks OK, thanks for the patch. 585655 4 132018 webkit.review.bot 2012-03-22 13:43:33 -0700 Comment on attachment 132018 Patch Clearing flags on attachment: 132018 Committed r111753: <http://trac.webkit.org/changeset/111753> 585656 5 webkit.review.bot 2012-03-22 13:43:38 -0700 All reviewed patches have been landed. Closing bug. 132018 2012-03-15 04:39:52 -0700 2012-03-22 13:43:32 -0700 Patch viewmode.patch text/plain 3486 naginenis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZTg5MjA1Li4wODEzZWVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDMt MTUgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5j b20+CisKKyAgICAgICAgW0VGTF0gRW5hYmxlIHZpZXcgbW9kZSBtZWRpYSBmZWF0dXJlIGxheW91 dCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODEyMDUKKworICAgICAgICBVbnNraXAgdGVzdHMgY29ubmVjdGVkIHdpdGggc2V0Vmlld01vZGVN ZWRpYUZlYXR1cmUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9lZmwvU2tpcHBlZDoKKwogMjAxMi0wMy0xNSAgUGhpbGlwcGUgTm9y bWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgR1RLIGJh c2VsaW5lcyBmb3IgbmV3IGZhc3QvY3NzIHRlc3QuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCmlu ZGV4IGNiMjQ0OWYuLmI0NTRhYWIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Vm bC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkCkBAIC00Mjcs MTUgKzQyNyw2IEBAIHN2Zy9jdXN0b20vbWFudWFsbHktcGFyc2VkLWVtYmVkZGVkLXN2Zy1kaXNh bGxvd2VkLWluLWRhc2hib2FyZC5odG1sCiBzdmcvY3VzdG9tL21hbnVhbGx5LXBhcnNlZC1zdmct ZGlzYWxsb3dlZC1pbi1kYXNoYm9hcmQuaHRtbAogc3ZnL2N1c3RvbS9zdmctZGlzYWxsb3dlZC1p bi1kYXNoYm9hcmQtb2JqZWN0Lmh0bWwKIAotIyBFRkwncyBMYXlvdXRUZXN0Q29udHJvbGxlciBk b2VzIG5vdCBpbXBsZW1lbnQgc2V0Vmlld01vZGVNZWRpYUZlYXR1cmUKLWZhc3QvbWVkaWEvbWVk aWEtcXVlcnktbGlzdC0wMi5odG1sCi1mYXN0L21lZGlhL21lZGlhLXF1ZXJ5LWxpc3QtMDMuaHRt bAotZmFzdC9tZWRpYS9tZWRpYS1xdWVyeS1saXN0LTA0Lmh0bWwKLWZhc3QvbWVkaWEvbWVkaWEt cXVlcnktbGlzdC0wNS5odG1sCi1mYXN0L21lZGlhL21lZGlhLXF1ZXJ5LWxpc3QtMDYuaHRtbAot ZmFzdC9tZWRpYS9tZWRpYS1xdWVyeS1saXN0LTA3Lmh0bWwKLWZhc3QvbWVkaWEvdmlldy1tb2Rl LW1lZGlhLWZlYXR1cmUuaHRtbAotCiAjIEVGTCdzIExheW91dFRlc3RDb250cm9sbGVyIGRvZXMg bm90IGltcGxlbWVudCBlbmFibGVBdXRvUmVzaXplTW9kZQogZmFzdC9hdXRvcmVzaXplCiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlOTNhZTdh Li42MDJmOTcwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDMtMTUgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1 ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gRW5hYmxl IHZpZXcgbW9kZSBtZWRpYSBmZWF0dXJlIGxheW91dCB0ZXN0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEyMDUKKworICAgICAgICBBZGRpbmcgbWlz c2luZyBpbXBsZW1lbnRhdGlvbiBzZXRWaWV3TW9kZU1lZGlhRmVhdHVyZSB0byBFRkwncyAKKyAg ICAgICAgTGF5b3V0VGVzdENvbnRyb2xsZXIgc28gdGhhdCB3ZSBjYW4gdW5za2lwIHZpZXcgbW9k ZSAKKyAgICAgICAgbWVkaWEgZmVhdHVyZSBsYXlvdXQgdGVzdHMuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvTGF5 b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwOgorICAgICAgICAoTGF5b3V0VGVzdENvbnRyb2xsZXI6 OnNldFZpZXdNb2RlTWVkaWFGZWF0dXJlKTogSW1wbGVtZW50ZWQuCisKIDIwMTItMDMtMTQgIENo cmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQVJJQSB0 YWJsZXMgbmVlZCB0byBzdXBwb3J0IHNlbGVjdGVkIHJvd3MgYXR0cmlidXRlL3NlbGVjdCByb3dz IGNoYW5nZWQgbm90aWZpY2F0aW9uCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9l ZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZs L0xheW91dFRlc3RDb250cm9sbGVyRWZsLmNwcAppbmRleCA3Y2RlMTI2Li5lNTdiNjA2IDEwMDY0 NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvTGF5b3V0VGVzdENvbnRyb2xsZXJFZmwu Y3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9MYXlvdXRUZXN0Q29udHJvbGxlckVm bC5jcHAKQEAgLTI2Myw5ICsyNjMsMjIgQEAgdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0 VmFsdWVGb3JVc2VyKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIG5vZGUKICAgICBE dW1wUmVuZGVyVHJlZVN1cHBvcnRFZmw6OnNldFZhbHVlRm9yVXNlcihjb250ZXh0LCBub2RlT2Jq ZWN0LCB2YWx1ZSk7CiB9CiAKLXZvaWQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnNldFZpZXdNb2Rl TWVkaWFGZWF0dXJlKEpTU3RyaW5nUmVmKQordm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0 Vmlld01vZGVNZWRpYUZlYXR1cmUoSlNTdHJpbmdSZWYgbW9kZSkKIHsKLSAgICBub3RJbXBsZW1l bnRlZCgpOworICAgIEV2YXNfT2JqZWN0KiB2aWV3ID0gYnJvd3Nlci0+bWFpblZpZXcoKTsKKyAg ICBpZiAoIXZpZXcpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChlcXVhbHMobW9kZSwgIndp bmRvd2VkIikpCisgICAgICAgIGV3a192aWV3X21vZGVfc2V0KHZpZXcsIEVXS19WSUVXX01PREVf V0lORE9XRUQpOworICAgIGVsc2UgaWYgKGVxdWFscyhtb2RlLCAiZmxvYXRpbmciKSkKKyAgICAg ICAgZXdrX3ZpZXdfbW9kZV9zZXQodmlldywgRVdLX1ZJRVdfTU9ERV9GTE9BVElORyk7CisgICAg ZWxzZSBpZiAoZXF1YWxzKG1vZGUsICJmdWxsc2NyZWVuIikpCisgICAgICAgIGV3a192aWV3X21v ZGVfc2V0KHZpZXcsIEVXS19WSUVXX01PREVfRlVMTFNDUkVFTik7CisgICAgZWxzZSBpZiAoZXF1 YWxzKG1vZGUsICJtYXhpbWl6ZWQiKSkKKyAgICAgICAgZXdrX3ZpZXdfbW9kZV9zZXQodmlldywg RVdLX1ZJRVdfTU9ERV9NQVhJTUlaRUQpOworICAgIGVsc2UgaWYgKGVxdWFscyhtb2RlLCAibWlu aW1pemVkIikpCisgICAgICAgIGV3a192aWV3X21vZGVfc2V0KHZpZXcsIEVXS19WSUVXX01PREVf TUlOSU1JWkVEKTsKIH0KIAogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0V2luZG93SXNL ZXkoYm9vbCkK