81197 2012-03-15 00:47:25 -0700 [BlackBerry] Can not open certain links from bridge applications 2012-03-16 06:36:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 robin.webkit webkit-unassigned charles.wei manyoso rwlbuis tonikitoo webkit.review.bot oldest_to_newest 579186 0 robin.webkit 2012-03-15 00:47:25 -0700 Can not open certain links (e.g., target="_blank") from bridge applications. Patch coming up to fix this problem. 579248 1 132009 robin.webkit 2012-03-15 03:34:33 -0700 Created attachment 132009 patch 579274 2 132009 rwlbuis 2012-03-15 04:38:11 -0700 Comment on attachment 132009 patch View in context: https://bugs.webkit.org/attachment.cgi?id=132009&action=review > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1068 > + // how to handle patterns such as 'mailto:'. Where are we giving that chance iafter this patch? I thought the disabled block did that. > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1075 > + // } I think putting this in a #if 0 block would make this look less messy. 580211 3 robin.webkit 2012-03-16 00:11:02 -0700 (In reply to comment #2) > (From update of attachment 132009 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=132009&action=review > > > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1068 > > + // how to handle patterns such as 'mailto:'. > > Where are we giving that chance iafter this patch? I thought the disabled block did that. > The following is the updated comments, hope this explains things better. // FIXME: Enable these commented out when WebPageClient::handleStringPattern is implemented // and exposed to client. Before that, don't return PolicyIgnore so we can continue to // create new window and get to dispatchDecidePolicyForNavigationAction() where the client // is given a chance to decide how to handle patterns such as 'mailto:'. > > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1075 > > + // } > > I think putting this in a #if 0 block would make this look less messy. Will use "#if 0" in the updated patch. 580220 4 132216 robin.webkit 2012-03-16 00:19:35 -0700 Created attachment 132216 updated patch 580238 5 132216 buildbot 2012-03-16 00:44:11 -0700 Comment on attachment 132216 updated patch Attachment 132216 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11966017 580258 6 132216 charles.wei 2012-03-16 01:07:55 -0700 Comment on attachment 132216 updated patch LGTM. We need to implement "handleExternalLoad" and "handleStringPattern" sometime. 580260 7 132216 webkit.review.bot 2012-03-16 01:08:59 -0700 Comment on attachment 132216 updated patch Rejecting attachment 132216 from review queue. charles.wei@torchmobile.com.cn does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 580267 8 132216 charles.wei 2012-03-16 01:13:14 -0700 Comment on attachment 132216 updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=132216&action=review > Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1077 > +#endif Yes, we didn't implement handleStringPattern yet, so we should never reach here until that's been implemented. 580358 9 132216 rwlbuis 2012-03-16 04:16:28 -0700 Comment on attachment 132216 updated patch LGTM. 580456 10 132216 webkit.review.bot 2012-03-16 06:35:56 -0700 Comment on attachment 132216 updated patch Clearing flags on attachment: 132216 Committed r111000: <http://trac.webkit.org/changeset/111000> 580457 11 webkit.review.bot 2012-03-16 06:36:01 -0700 All reviewed patches have been landed. Closing bug. 132009 2012-03-15 03:34:33 -0700 2012-03-16 00:19:07 -0700 patch bug-81197-20120315183457.patch text/plain 5241 robin.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyODMxN2Q4YWE4NjIzMDc1ZGZhNmYwNTc2MTJlNWI0YWNhMDQ5YTAyLi4yZmNjMDZlYTk0 NGM3YTQxNmYzZmQwNWUzZjllNDZiMDkzYzg1N2JjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMi0wMy0xNSAgUm9iaW4gQ2FvICA8cm9iaW4uY2Fv QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQ2FuIG5vdCBvcGVu IGNlcnRhaW4gbGlua3MgZnJvbSBicmlkZ2UgYXBwbGljYXRpb25zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTE5NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhlIGVuZ2luZSBhc2tz IHRoZSBjbGllbnQgdG8gaGFuZGxlIHNvbWUgdHlwZSBvZiByZXF1ZXN0cyBleHRlcm5hbGx5Lgor ICAgICAgICBCdXQgV2ViUGFnZUNsaWVudDo6aGFuZGxlU3RyaW5nUGF0dGVybiBpcyBub3QgeWV0 IGltcGxlbWVudGVkIGFuZCBleHBvc2VkIHRvCisgICAgICAgIHRoZSBjbGllbnQuIEJlZm9yZSB0 aGF0LCB3ZSBzdGlsbCBuZWVkIHRvIGdpdmUgdGhlIGNsaWVudCBhIGNoYW5jZSB0byBkZWNpZGUK KyAgICAgICAgaG93IHRvIGhhbmRsZSByZXF1ZXN0cyBzdWNoIGFzICdtYWlsdG86Jy4KKworICAg ICAgICBUbyBhZGRyZXNzIHRoaXMgcHJvYmxlbSwgcjEwODc2MyBpbnRyb2R1Y2VkIGEgY2hhbmdl IHRoYXQgYXNrIHRoZSBjbGllbnQgdG8KKyAgICAgICAgZGVjaWRlIGhvdyB0byBoYW5kbGUgdGhl IG5hdmlnYXRpb24gaW4gZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dBY3Rpb24oKS4K KyAgICAgICAgVGhpcyBpcyBub3QgaW50dWl0aXZlIGFuZCB3aWxsIGJyaW5nIHRyb3VibGVzLCBi ZWNhdXNlIHRoaXMgbmF2aWdhdGlvbiB3aWxsCisgICAgICAgIGhhcHBlbiBpbiB0aGUgbmV3IHBh Z2UuIFNvIHRoZSBuZXcgcGFnZSBjbGllbnQgaXMgdG8gZGVjaWRlIGhvdyB0byBoYW5kbGUKKyAg ICAgICAgdGhlIG5hdmlnYXRpb24sIG5vdCB0aGUgb2xkIG9uZS4KKworICAgICAgICBUaGlzIHBh dGNoIHJldmVydHMgcjEwODc2MyBhbmQgc2tpcHMgY2FsbGluZyBXZWJQYWdlQ2xpZW50OjpoYW5k bGVTdHJpbmdQYXR0ZXJuCisgICAgICAgIHNpbmNlIGl0J3Mgbm90IGltcGxlbWVudGVkLgorCisg ICAgICAgIFRoaXMgd2F5IHRoZSBuZXcgd2luZG93IGFjdGlvbiB3aWxsIGNvbnRpbnVlLCBhbmQg dGhlIGxvZ2ljIGluCisgICAgICAgIGRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFj dGlvbigpIHdpbGwgaGFuZGxlIHRoZSBuYXZpZ2F0aW9uIGNvcnJlY3RseS4KKworICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRpc3BhdGNoRGVjaWRlUG9s aWN5Rm9yTmV3V2luZG93QWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xp ZW50QmxhY2tCZXJyeTo6ZGVjaWRlUG9saWN5Rm9yRXh0ZXJuYWxMb2FkKToKKwogMjAxMi0wMy0w OSAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIE5vdGlmaWNh dGlvblByZXNlbnRlciB0byBOb3RpZmljYXRpb25DbGllbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVy cnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggMGVlZjFmM2RhZjc4ZWMyZmJlOWJlYjdiZjg2 NTczNDU3ZDgyMTgzMS4uYTE0MWQ0NTdjZTMzZjc3MjdiN2IzMDlmMTVmZjZhYmNmYzY0YTM4MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTI3MCwy OSArMjcwLDEzIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Ojpkb1BlbmRpbmdG cmFnbWVudFNjcm9sbCgpCiAgICAgZGVsYXlQb2xpY3lDaGVja1VudGlsRnJhZ21lbnRFeGlzdHMo ZnJhZ21lbnQsIGZ1bmN0aW9uKTsKIH0KIAotdm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVy cnk6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uKEZyYW1lUG9saWN5RnVu Y3Rpb24gZnVuY3Rpb24sIGNvbnN0IE5hdmlnYXRpb25BY3Rpb24mIGFjdGlvbiwgY29uc3QgUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4sIGNvbnN0IFN0cmlu ZyYgZnJhbWVOYW1lKQordm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRpc3BhdGNo RGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uKEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rp b24sIGNvbnN0IE5hdmlnYXRpb25BY3Rpb24mLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVl c3QsIFBhc3NSZWZQdHI8Rm9ybVN0YXRlPiwgY29uc3QgU3RyaW5nJiBmcmFtZU5hbWUpCiB7CiAg ICAgaWYgKHJlcXVlc3QuaXNSZXF1ZXN0ZWRCeVBsdWdpbigpICYmIFNjcmlwdENvbnRyb2xsZXI6 OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpICYmICFtX3dlYlBhZ2VQcml2YXRlLT5tX3BsdWdpbk1h eU9wZW5OZXdUYWIpCiAgICAgICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+cG9saWN5Q2hlY2tlcigp LT4qZnVuY3Rpb24pKFBvbGljeUlnbm9yZSk7CiAKICAgICAvLyBBIG5ldyB3aW5kb3cgY2FuIG5l dmVyIGJlIGEgZnJhZ21lbnQgc2Nyb2xsLgogICAgIFBvbGljeUFjdGlvbiBkZWNpc2lvbiA9IGRl Y2lkZVBvbGljeUZvckV4dGVybmFsTG9hZChyZXF1ZXN0LCBmYWxzZSk7Ci0gICAgLy8gTGV0IHRo ZSBjbGllbnQgaGF2ZSBhIGNoYW5jZSB0byBzYXkgd2hldGhlciB0aGlzIG5hdmlnYXRpb24gc2hv dWxkCi0gICAgLy8gYmUgaWdub3JlZCBvciBub3QuCi0gICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06 Ok5ldHdvcmtSZXF1ZXN0IHBsYXRmb3JtUmVxdWVzdDsKLSAgICByZXF1ZXN0LmluaXRpYWxpemVQ bGF0Zm9ybVJlcXVlc3QocGxhdGZvcm1SZXF1ZXN0LCBmYWxzZSAvKmlzSW5pdGlhbCovKTsKLSAg ICBpZiAoaXNNYWluRnJhbWUoKSAmJiAhbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPmFjY2Vw dE5hdmlnYXRpb25SZXF1ZXN0KAotICAgICAgICBwbGF0Zm9ybVJlcXVlc3QsIEJsYWNrQmVycnk6 OlBsYXRmb3JtOjpOYXZpZ2F0aW9uVHlwZShhY3Rpb24udHlwZSgpKSkpIHsKLSAgICAgICAgaWYg KGFjdGlvbi50eXBlKCkgPT0gTmF2aWdhdGlvblR5cGVGb3JtU3VibWl0dGVkIHx8IGFjdGlvbi50 eXBlKCkgPT0gTmF2aWdhdGlvblR5cGVGb3JtUmVzdWJtaXR0ZWQpCi0gICAgICAgICAgICBtX2Zy YW1lLT5sb2FkZXIoKS0+cmVzZXRNdWx0aXBsZUZvcm1TdWJtaXNzaW9uUHJvdGVjdGlvbigpOwot Ci0gICAgICAgIGlmIChhY3Rpb24udHlwZSgpID09IE5hdmlnYXRpb25UeXBlTGlua0NsaWNrZWQg JiYgcmVxdWVzdC51cmwoKS5oYXNGcmFnbWVudElkZW50aWZpZXIoKSkgewotICAgICAgICAgICAg UmVzb3VyY2VSZXF1ZXN0IGVtcHR5UmVxdWVzdDsKLSAgICAgICAgICAgIG1fZnJhbWUtPmxvYWRl cigpLT5hY3RpdmVEb2N1bWVudExvYWRlcigpLT5zZXRMYXN0Q2hlY2tlZFJlcXVlc3QoZW1wdHlS ZXF1ZXN0KTsKLSAgICAgICAgfQotICAgICAgICBkZWNpc2lvbiA9IFBvbGljeUlnbm9yZTsKLSAg ICB9Ci0KICAgICAobV9mcmFtZS0+bG9hZGVyKCktPnBvbGljeUNoZWNrZXIoKS0+KmZ1bmN0aW9u KShkZWNpc2lvbik7CiB9CiAKQEAgLTEwNzksMTIgKzEwNjMsMTYgQEAgdm9pZCBGcmFtZUxvYWRl ckNsaWVudEJsYWNrQmVycnk6OnJlc3RvcmVWaWV3U3RhdGUoKQogCiBQb2xpY3lBY3Rpb24gRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkZWNpZGVQb2xpY3lGb3JFeHRlcm5hbExvYWQoY29u c3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBib29sIGlzRnJhZ21lbnRTY3JvbGwpCiB7Ci0g ICAgY29uc3QgS1VSTCYgdXJsID0gcmVxdWVzdC51cmwoKTsKLSAgICBTdHJpbmcgcGF0dGVybiA9 IG1fd2ViUGFnZVByaXZhdGUtPmZpbmRQYXR0ZXJuU3RyaW5nRm9yVXJsKHVybCk7Ci0gICAgaWYg KCFwYXR0ZXJuLmlzRW1wdHkoKSkgewotICAgICAgICBtX3dlYlBhZ2VQcml2YXRlLT5tX2NsaWVu dC0+aGFuZGxlU3RyaW5nUGF0dGVybihwYXR0ZXJuLmNoYXJhY3RlcnMoKSwgcGF0dGVybi5sZW5n dGgoKSk7Ci0gICAgICAgIHJldHVybiBQb2xpY3lJZ25vcmU7Ci0gICAgfQorICAgIC8vIEZJWE1F OiBFbmFibGUgdGhlc2UgY29tbWVudGVkIG91dCB3aGVuIFdlYlBhZ2VDbGllbnQ6OmhhbmRsZVN0 cmluZ1BhdHRlcm4gaXMgaW1wbGVtZW50ZWQKKyAgICAvLyBhbmQgZXhwb3NlZCB0byBjbGllbnQu IEJlZm9yZSB0aGF0LCB3ZSBzdGlsbCBuZWVkIHRvIGdpdmUgdGhlIGNsaWVudCBhIGNoYW5jZSB0 byBkZWNpZGUKKyAgICAvLyBob3cgdG8gaGFuZGxlIHBhdHRlcm5zIHN1Y2ggYXMgJ21haWx0bzon LgorCisgICAgLy8gY29uc3QgS1VSTCYgdXJsID0gcmVxdWVzdC51cmwoKTsKKyAgICAvLyBTdHJp bmcgcGF0dGVybiA9IG1fd2ViUGFnZVByaXZhdGUtPmZpbmRQYXR0ZXJuU3RyaW5nRm9yVXJsKHVy bCk7CisgICAgLy8gaWYgKCFwYXR0ZXJuLmlzRW1wdHkoKSkgeworICAgIC8vICAgIG1fd2ViUGFn ZVByaXZhdGUtPm1fY2xpZW50LT5oYW5kbGVTdHJpbmdQYXR0ZXJuKHBhdHRlcm4uY2hhcmFjdGVy cygpLCBwYXR0ZXJuLmxlbmd0aCgpKTsKKyAgICAvLyAgICByZXR1cm4gUG9saWN5SWdub3JlOwor ICAgIC8vIH0KIAogICAgIGlmIChtX3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNldHRpbmdzLT5hcmVM aW5rc0hhbmRsZWRFeHRlcm5hbGx5KCkKICAgICAgICAgICAgICYmIGlzTWFpbkZyYW1lKCkK 132216 2012-03-16 00:19:35 -0700 2012-03-16 06:35:56 -0700 updated patch bug-81197-20120316152001.patch text/plain 5084 robin.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyODMxN2Q4YWE4NjIzMDc1ZGZhNmYwNTc2MTJlNWI0YWNhMDQ5YTAyLi4yZmNjMDZlYTk0 NGM3YTQxNmYzZmQwNWUzZjllNDZiMDkzYzg1N2JjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzMSBAQAorMjAxMi0wMy0xNSAgUm9iaW4gQ2FvICA8cm9iaW4uY2Fv QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQ2FuIG5vdCBvcGVu IGNlcnRhaW4gbGlua3MgZnJvbSBicmlkZ2UgYXBwbGljYXRpb25zCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTE5NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhlIGVuZ2luZSBhc2tz IHRoZSBjbGllbnQgdG8gaGFuZGxlIHNvbWUgdHlwZSBvZiByZXF1ZXN0cyBleHRlcm5hbGx5Lgor ICAgICAgICBCdXQgV2ViUGFnZUNsaWVudDo6aGFuZGxlU3RyaW5nUGF0dGVybiBpcyBub3QgeWV0 IGltcGxlbWVudGVkIGFuZCBleHBvc2VkIHRvCisgICAgICAgIHRoZSBjbGllbnQuIEJlZm9yZSB0 aGF0LCB3ZSBzdGlsbCBuZWVkIHRvIGdpdmUgdGhlIGNsaWVudCBhIGNoYW5jZSB0byBkZWNpZGUK KyAgICAgICAgaG93IHRvIGhhbmRsZSByZXF1ZXN0cyBzdWNoIGFzICdtYWlsdG86Jy4KKworICAg ICAgICBUbyBhZGRyZXNzIHRoaXMgcHJvYmxlbSwgcjEwODc2MyBpbnRyb2R1Y2VkIGEgY2hhbmdl IHRoYXQgYXNrIHRoZSBjbGllbnQgdG8KKyAgICAgICAgZGVjaWRlIGhvdyB0byBoYW5kbGUgdGhl IG5hdmlnYXRpb24gaW4gZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dBY3Rpb24oKS4K KyAgICAgICAgVGhpcyBpcyBub3QgaW50dWl0aXZlIGFuZCB3aWxsIGJyaW5nIHRyb3VibGVzLCBi ZWNhdXNlIHRoaXMgbmF2aWdhdGlvbiB3aWxsCisgICAgICAgIGhhcHBlbiBpbiB0aGUgbmV3IHBh Z2UuIFNvIHRoZSBuZXcgcGFnZSBjbGllbnQgaXMgdG8gZGVjaWRlIGhvdyB0byBoYW5kbGUKKyAg ICAgICAgdGhlIG5hdmlnYXRpb24sIG5vdCB0aGUgb2xkIG9uZS4KKworICAgICAgICBUaGlzIHBh dGNoIHJldmVydHMgcjEwODc2MyBhbmQgc2tpcHMgY2FsbGluZyBXZWJQYWdlQ2xpZW50OjpoYW5k bGVTdHJpbmdQYXR0ZXJuCisgICAgICAgIHNpbmNlIGl0J3Mgbm90IGltcGxlbWVudGVkLgorCisg ICAgICAgIFRoaXMgd2F5IHRoZSBuZXcgd2luZG93IGFjdGlvbiB3aWxsIGNvbnRpbnVlLCBhbmQg dGhlIGxvZ2ljIGluCisgICAgICAgIGRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFj dGlvbigpIHdpbGwgaGFuZGxlIHRoZSBuYXZpZ2F0aW9uIGNvcnJlY3RseS4KKworICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRpc3BhdGNoRGVjaWRlUG9s aWN5Rm9yTmV3V2luZG93QWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xp ZW50QmxhY2tCZXJyeTo6ZGVjaWRlUG9saWN5Rm9yRXh0ZXJuYWxMb2FkKToKKwogMjAxMi0wMy0w OSAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIE5vdGlmaWNh dGlvblByZXNlbnRlciB0byBOb3RpZmljYXRpb25DbGllbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVy cnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggMGVlZjFmM2RhZjc4ZWMyZmJlOWJlYjdiZjg2 NTczNDU3ZDgyMTgzMS4uYWQ3ODc3ZDlhNDhhMmViMTgwOGY3ODIyZGYxYTQ1MWJmMDFjMGU4OCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTI3MCwy OSArMjcwLDEzIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5Ojpkb1BlbmRpbmdG cmFnbWVudFNjcm9sbCgpCiAgICAgZGVsYXlQb2xpY3lDaGVja1VudGlsRnJhZ21lbnRFeGlzdHMo ZnJhZ21lbnQsIGZ1bmN0aW9uKTsKIH0KIAotdm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVy cnk6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uKEZyYW1lUG9saWN5RnVu Y3Rpb24gZnVuY3Rpb24sIGNvbnN0IE5hdmlnYXRpb25BY3Rpb24mIGFjdGlvbiwgY29uc3QgUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4sIGNvbnN0IFN0cmlu ZyYgZnJhbWVOYW1lKQordm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRpc3BhdGNo RGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uKEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rp b24sIGNvbnN0IE5hdmlnYXRpb25BY3Rpb24mLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVl c3QsIFBhc3NSZWZQdHI8Rm9ybVN0YXRlPiwgY29uc3QgU3RyaW5nJiBmcmFtZU5hbWUpCiB7CiAg ICAgaWYgKHJlcXVlc3QuaXNSZXF1ZXN0ZWRCeVBsdWdpbigpICYmIFNjcmlwdENvbnRyb2xsZXI6 OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpICYmICFtX3dlYlBhZ2VQcml2YXRlLT5tX3BsdWdpbk1h eU9wZW5OZXdUYWIpCiAgICAgICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+cG9saWN5Q2hlY2tlcigp LT4qZnVuY3Rpb24pKFBvbGljeUlnbm9yZSk7CiAKICAgICAvLyBBIG5ldyB3aW5kb3cgY2FuIG5l dmVyIGJlIGEgZnJhZ21lbnQgc2Nyb2xsLgogICAgIFBvbGljeUFjdGlvbiBkZWNpc2lvbiA9IGRl Y2lkZVBvbGljeUZvckV4dGVybmFsTG9hZChyZXF1ZXN0LCBmYWxzZSk7Ci0gICAgLy8gTGV0IHRo ZSBjbGllbnQgaGF2ZSBhIGNoYW5jZSB0byBzYXkgd2hldGhlciB0aGlzIG5hdmlnYXRpb24gc2hv dWxkCi0gICAgLy8gYmUgaWdub3JlZCBvciBub3QuCi0gICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06 Ok5ldHdvcmtSZXF1ZXN0IHBsYXRmb3JtUmVxdWVzdDsKLSAgICByZXF1ZXN0LmluaXRpYWxpemVQ bGF0Zm9ybVJlcXVlc3QocGxhdGZvcm1SZXF1ZXN0LCBmYWxzZSAvKmlzSW5pdGlhbCovKTsKLSAg ICBpZiAoaXNNYWluRnJhbWUoKSAmJiAhbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPmFjY2Vw dE5hdmlnYXRpb25SZXF1ZXN0KAotICAgICAgICBwbGF0Zm9ybVJlcXVlc3QsIEJsYWNrQmVycnk6 OlBsYXRmb3JtOjpOYXZpZ2F0aW9uVHlwZShhY3Rpb24udHlwZSgpKSkpIHsKLSAgICAgICAgaWYg KGFjdGlvbi50eXBlKCkgPT0gTmF2aWdhdGlvblR5cGVGb3JtU3VibWl0dGVkIHx8IGFjdGlvbi50 eXBlKCkgPT0gTmF2aWdhdGlvblR5cGVGb3JtUmVzdWJtaXR0ZWQpCi0gICAgICAgICAgICBtX2Zy YW1lLT5sb2FkZXIoKS0+cmVzZXRNdWx0aXBsZUZvcm1TdWJtaXNzaW9uUHJvdGVjdGlvbigpOwot Ci0gICAgICAgIGlmIChhY3Rpb24udHlwZSgpID09IE5hdmlnYXRpb25UeXBlTGlua0NsaWNrZWQg JiYgcmVxdWVzdC51cmwoKS5oYXNGcmFnbWVudElkZW50aWZpZXIoKSkgewotICAgICAgICAgICAg UmVzb3VyY2VSZXF1ZXN0IGVtcHR5UmVxdWVzdDsKLSAgICAgICAgICAgIG1fZnJhbWUtPmxvYWRl cigpLT5hY3RpdmVEb2N1bWVudExvYWRlcigpLT5zZXRMYXN0Q2hlY2tlZFJlcXVlc3QoZW1wdHlS ZXF1ZXN0KTsKLSAgICAgICAgfQotICAgICAgICBkZWNpc2lvbiA9IFBvbGljeUlnbm9yZTsKLSAg ICB9Ci0KICAgICAobV9mcmFtZS0+bG9hZGVyKCktPnBvbGljeUNoZWNrZXIoKS0+KmZ1bmN0aW9u KShkZWNpc2lvbik7CiB9CiAKQEAgLTEwNzksMTIgKzEwNjMsMTggQEAgdm9pZCBGcmFtZUxvYWRl ckNsaWVudEJsYWNrQmVycnk6OnJlc3RvcmVWaWV3U3RhdGUoKQogCiBQb2xpY3lBY3Rpb24gRnJh bWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkZWNpZGVQb2xpY3lGb3JFeHRlcm5hbExvYWQoY29u c3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBib29sIGlzRnJhZ21lbnRTY3JvbGwpCiB7Cisj aWYgMAorICAgIC8vIEZJWE1FOiBFbmFibGUgdGhlc2UgY29tbWVudGVkIG91dCB3aGVuIFdlYlBh Z2VDbGllbnQ6OmhhbmRsZVN0cmluZ1BhdHRlcm4gaXMgaW1wbGVtZW50ZWQKKyAgICAvLyBhbmQg ZXhwb3NlZCB0byBjbGllbnQuIEJlZm9yZSB0aGF0LCBkb24ndCByZXR1cm4gUG9saWN5SWdub3Jl IHNvIHdlIGNhbiBjb250aW51ZSB0bworICAgIC8vIGNyZWF0ZSBuZXcgd2luZG93IGFuZCBnZXQg dG8gZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKCkgd2hlcmUgdGhlIGNs aWVudAorICAgIC8vIGlzIGdpdmVuIGEgY2hhbmNlIHRvIGRlY2lkZSBob3cgdG8gaGFuZGxlIHBh dHRlcm5zIHN1Y2ggYXMgJ21haWx0bzonLgogICAgIGNvbnN0IEtVUkwmIHVybCA9IHJlcXVlc3Qu dXJsKCk7CiAgICAgU3RyaW5nIHBhdHRlcm4gPSBtX3dlYlBhZ2VQcml2YXRlLT5maW5kUGF0dGVy blN0cmluZ0ZvclVybCh1cmwpOwogICAgIGlmICghcGF0dGVybi5pc0VtcHR5KCkpIHsKICAgICAg ICAgbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPmhhbmRsZVN0cmluZ1BhdHRlcm4ocGF0dGVy bi5jaGFyYWN0ZXJzKCksIHBhdHRlcm4ubGVuZ3RoKCkpOwogICAgICAgICByZXR1cm4gUG9saWN5 SWdub3JlOwogICAgIH0KKyNlbmRpZgogCiAgICAgaWYgKG1fd2ViUGFnZVByaXZhdGUtPm1fd2Vi U2V0dGluZ3MtPmFyZUxpbmtzSGFuZGxlZEV4dGVybmFsbHkoKQogICAgICAgICAgICAgJiYgaXNN YWluRnJhbWUoKQo=