81194 2012-03-14 23:26:28 -0700 Can't swipe to go back/forward when the current page is a PDF document 2012-03-15 14:16:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca ap mitz oldest_to_newest 579152 0 andersca 2012-03-14 23:26:28 -0700 Can't swipe to go back/forward when the current page is a PDF document 579155 1 131993 andersca 2012-03-14 23:29:47 -0700 Created attachment 131993 Patch 579162 2 ap 2012-03-14 23:50:02 -0700 Isn't this part of <rdar://problem/4347183>? 579163 3 ap 2012-03-14 23:51:53 -0700 OK, I see the relationship between that and <rdar://problem/6954125> now. Was confused because this bug didn't have InRadar keyword. 579164 4 131993 mitz 2012-03-14 23:52:32 -0700 Comment on attachment 131993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131993&action=review > Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:499 > + if ((deltaX > 0 && !page()->canGoBack()) || (deltaX < 0 && !page()->canGoForward())) Are there other places in WebKit2 where there is such a mapping between horizontal directions and back and forward? This seems like the wrong level to make this mapping. For example, a client configured for right-to-left reading may want the reverse mapping. 579199 5 131993 buildbot 2012-03-15 01:37:53 -0700 Comment on attachment 131993 Patch Attachment 131993 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11954541 579602 6 andersca 2012-03-15 11:51:01 -0700 (In reply to comment #4) > (From update of attachment 131993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131993&action=review > > > Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:499 > > + if ((deltaX > 0 && !page()->canGoBack()) || (deltaX < 0 && !page()->canGoForward())) > > Are there other places in WebKit2 where there is such a mapping between horizontal directions and back and forward? This seems like the wrong level to make this mapping. For example, a client configured for right-to-left reading may want the reverse mapping. We check the same thing in the web process in two places, I don't really see a good way to share the code between them. 579718 7 131993 sam 2012-03-15 14:07:06 -0700 Comment on attachment 131993 Patch Please fix the build before landing. 579730 8 andersca 2012-03-15 14:16:29 -0700 Committed r110885: <http://trac.webkit.org/changeset/110885> 131993 2012-03-14 23:29:47 -0700 2012-03-15 14:07:06 -0700 Patch bug-81194-20120314232945.patch text/plain 6652 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGYzNjg4OWEyYzdlMmM3 MWUzZTM4ZWM2ZjViZmI1NjgxNjgzOGI3NC4uN2ExNDQ4NWMyMWI4OGE5NjZlOWQ5ZjQxZDgxM2Y5 Y2RjMGZhZWM1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDEyLTAzLTE0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQ2FuJ3Qgc3dpcGUg dG8gZ28gYmFjay9mb3J3YXJkIHdoZW4gdGhlIGN1cnJlbnQgcGFnZSBpcyBhIFBERiBkb2N1bWVu dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODExOTQK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY5NTQxMjU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT3ZlcnJpZGUgLVtQREZWaWV3U2Nyb2xsVmlldyBz Y3JvbGxXaGVlbDpdIGFuZCBoYXZlIHRoZSBuZXcgaW1wbGVtZW50YXRpb24gY2FsbAorICAgICAg ICAtW1dLUERGVmlldyBmb3J3YXJkU2Nyb2xsV2hlZWxFdmVudDpdIHdoZW4gdGhlIFBERiBpcyBw aW5uZWQgdG8gZWl0aGVyIHRoZSBsZWZ0IG9yIHJpZ2h0IHNpZGUuCisgICAgICAgIFdLUERGVmll dyB3aWxsIHRoZW4gY2FsbCBQREZDb250cm9sbGVyOjpmb3J3YXJkU2Nyb2xsV2hlZWxFdmVudCB3 aGljaCBjaGVja3MgaWYgd2UgY2FuIGdvIGJhY2sgb3IgZm9yd2FyZCwKKyAgICAgICAgYW5kIHBh c3NlcyB0aGUgZXZlbnQgYWxvbmcgdG8gdGhlIFdLVmlldyB3aGljaCBlbmRzIHVwIHRyaWdnZXJp bmcgdGhlIHN3aXBpbmcgbWFjaGluZXJ5IGluIFNhZmFyaS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvbWFjL1BERlZpZXdDb250cm9sbGVyLmg6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9t YWMvUERGVmlld0NvbnRyb2xsZXIubW06CisgICAgICAgICgtW1dLUERGVmlldyBmb3J3YXJkU2Ny b2xsV2hlZWxFdmVudDpdKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6OlBE RlZpZXdDb250cm9sbGVyOjpmb3J3YXJkU2Nyb2xsV2hlZWxFdmVudCk6CisgICAgICAgIChXZWJL aXQ6OmZpbmRFbmNsb3NpbmdXS1BERlZpZXcpOgorICAgICAgICAoV2ViS2l0OjpQREZWaWV3U2Ny b2xsVmlld19zY3JvbGxXaGVlbCk6CisgICAgICAgIChXZWJLaXQ6OlBERlZpZXdDb250cm9sbGVy OjpwZGZLaXRCdW5kbGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmRpZENvbW1pdExvYWRGb3JGcmFtZSk6CisK KzIwMTItMDMtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAg ICAgICBqYXZhL2phdmEtYW5kLXBsdWdpbnMuaHRtbCB0ZXN0IGZhaWxpbmcKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMTg4CiAgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xMTA0ODY1Nz4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvbWFjL1BERlZpZXdDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9QREZWaWV3Q29udHJvbGxlci5oCmluZGV4IDNhNGYyZjYwMDNjZWFiYTM4ZGMzNDM0 Mzg0YWJkZDgxM2JjODBjMjcuLjQ2YWFmODQ1OGFlZDVjOTJiNzBhOTUzMTdhOGFmYzgwZjllYTM2 MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1BERlZpZXdD b250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUERGVmll d0NvbnRyb2xsZXIuaApAQCAtNjIsNiArNjIsOCBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgQ2xh c3MgcGRmUHJldmlld1ZpZXdDbGFzcygpOwogCisgICAgYm9vbCBmb3J3YXJkU2Nyb2xsV2hlZWxF dmVudChOU0V2ZW50ICopOworCiAgICAgTlNQcmludE9wZXJhdGlvbiAqbWFrZVByaW50T3BlcmF0 aW9uKE5TUHJpbnRJbmZvICopOwogICAgIHZvaWQgb3BlblBERkluRmluZGVyKCk7CiAgICAgdm9p ZCBzYXZlUERGVG9Eb3dubG9hZHNGb2xkZXIoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1BERlZpZXdDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvUERGVmlld0NvbnRyb2xsZXIubW0KaW5kZXggYzU0NDFhNDlmODQ1 ZWVlMTNjODQ0ZTEyNWZhY2JkZjQ2OTEyZDgzMS4uZmZjNDA2MTMwMWNhZmQ5MzcxMTA3M2VjMDUz NWI4ZjdmOGZiNTFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9t YWMvUERGVmlld0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9tYWMvUERGVmlld0NvbnRyb2xsZXIubW0KQEAgLTExNCw2ICsxMTQsNyBAQCBzdGF0aWMgQk9P TCBfUERGU2VsZWN0aW9uc0FyZUVxdWFsKFBERlNlbGVjdGlvbiAqc2VsZWN0aW9uQSwgUERGU2Vs ZWN0aW9uICpzZWxlYwogLSAoUERGVmlldyAqKXBkZlZpZXc7CiAtICh2b2lkKXNldERvY3VtZW50 OihQREZEb2N1bWVudCAqKXBkZkRvY3VtZW50OwogCistIChCT09MKWZvcndhcmRTY3JvbGxXaGVl bEV2ZW50OihOU0V2ZW50ICopd2hlZWxFdmVudDsKIC0gKHZvaWQpX2FwcGx5UERGUHJlZmVyZW5j ZXM7CiAtIChQREZTZWxlY3Rpb24gKilfbmV4dE1hdGNoRm9yOihOU1N0cmluZyAqKXN0cmluZyBk aXJlY3Rpb246KEJPT0wpZm9yd2FyZCBjYXNlU2Vuc2l0aXZlOihCT09MKWNhc2VGbGFnIHdyYXA6 KEJPT0wpd3JhcEZsYWcgZnJvbVNlbGVjdGlvbjooUERGU2VsZWN0aW9uICopaW5pdGlhbFNlbGVj dGlvbiBzdGFydEluU2VsZWN0aW9uOihCT09MKXN0YXJ0SW5TZWxlY3Rpb247CiBAZW5kCkBAIC0z ODMsNiArMzg0LDExIEBAIHN0YXRpYyB2b2lkIGluc2VydE9wZW5XaXRoRGVmYXVsdFBERk1lbnVJ dGVtKE5TTWVudSAqbWVudSwgTlNVSW50ZWdlciBpbmRleCkKICAgICBfcGRmVmlld0NvbnRyb2xs ZXItPnByaW50KCk7CiB9CiAKKy0gKEJPT0wpZm9yd2FyZFNjcm9sbFdoZWVsRXZlbnQ6KE5TRXZl bnQgKil3aGVlbEV2ZW50Cit7CisgICAgcmV0dXJuIF9wZGZWaWV3Q29udHJvbGxlci0+Zm9yd2Fy ZFNjcm9sbFdoZWVsRXZlbnQod2hlZWxFdmVudCk7Cit9CisKIEBlbmQKIAogbmFtZXNwYWNlIFdl YktpdCB7CkBAIC00ODYsNiArNDkyLDUxIEBAIENsYXNzIFBERlZpZXdDb250cm9sbGVyOjpwZGZQ cmV2aWV3Vmlld0NsYXNzKCkKICAgICAKICAgICByZXR1cm4gcGRmUHJldmlld1ZpZXdDbGFzczsK IH0KKworYm9vbCBQREZWaWV3Q29udHJvbGxlcjo6Zm9yd2FyZFNjcm9sbFdoZWVsRXZlbnQoTlNF dmVudCAqd2hlZWxFdmVudCkKK3sKKyAgICBDR0Zsb2F0IGRlbHRhWCA9IFt3aGVlbEV2ZW50IGRl bHRhWF07CisgICAgaWYgKChkZWx0YVggPiAwICYmICFwYWdlKCktPmNhbkdvQmFjaygpKSB8fCAo ZGVsdGFYIDwgMCAmJiAhcGFnZSgpLT5jYW5Hb0ZvcndhcmQoKSkpCisgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgIFttX3drVmlldyBzY3JvbGxXaGVlbDp3aGVlbEV2ZW50XTsKKyAgICByZXR1 cm4gdHJ1ZTsKK30KKworc3RhdGljIElNUCBvbGRQREZWaWV3U2Nyb2xsVmlld19zY3JvbGxXaGVl bDsKKworc3RhdGljIFdLUERGVmlldyAqZmluZEVuY2xvc2luZ1dLUERGVmlldyhOU1ZpZXcgKnZp ZXcpCit7CisgICAgZm9yIChOU1ZpZXcgKnN1cGVydmlldyA9IFt2aWV3IHN1cGVydmlld107IHN1 cGVydmlldzsgc3VwZXJ2aWV3ID0gW3N1cGVydmlldyBzdXBlcnZpZXddKSB7CisgICAgICAgIGlm IChbc3VwZXJ2aWV3IGlzS2luZE9mQ2xhc3M6W1dLUERGVmlldyBjbGFzc11dKQorICAgICAgICAg ICAgcmV0dXJuIHN0YXRpY19jYXN0PFdLUERGVmlldyAqPihzdXBlcnZpZXcpOworICAgIH0KKwor ICAgIHJldHVybiBuaWw7Cit9CisKK3N0YXRpYyB2b2lkIFBERlZpZXdTY3JvbGxWaWV3X3Njcm9s bFdoZWVsKE5TU2Nyb2xsVmlldyogc2VsZiwgU0VMIF9jbWQsIE5TRXZlbnQgKndoZWVsRXZlbnQp Cit7CisgICAgQ0dGbG9hdCBkZWx0YVggPSBbd2hlZWxFdmVudCBkZWx0YVhdOworICAgIENHRmxv YXQgZGVsdGFZID0gW3doZWVsRXZlbnQgZGVsdGFZXTsKKworICAgIE5TU2l6ZSBjb250ZW50c1Np emUgPSBbW3NlbGYgZG9jdW1lbnRWaWV3XSBib3VuZHNdLnNpemU7CisgICAgTlNSZWN0IHZpc2li bGVSZWN0ID0gW3NlbGYgZG9jdW1lbnRWaXNpYmxlUmVjdF07CisKKyAgICAvLyBXZSBvbmx5IHdh bnQgdG8gZm9yd2FyZCB0aGUgd2hlZWwgZXZlbnRzIGlmIHRoZSBob3Jpem9udGFsIGRlbHRhIGlz IG5vbi16ZXJvLAorICAgIC8vIGFuZCBvbmx5IGlmIHdlJ3JlIHBpbm5lZCB0byBlaXRoZXIgdGhl IGxlZnQgb3IgcmlnaHQgc2lkZS4KKyAgICAvLyBXZSBhbHNvIG5ldmVyIHdhbnQgdG8gZm9yd2Fy ZCBtb21lbnR1bSBzY3JvbGwgZXZlbnRzLgorICAgIGlmIChbd2hlZWxFdmVudCBtb21lbnR1bVBo YXNlXSA9PSBOU0V2ZW50UGhhc2VOb25lICYmIGRlbHRhWCAmJiBmYWJzZihkZWx0YVkpIDwgZmFi c2YoZGVsdGFYKQorICAgICAgICAmJiAoKGRlbHRhWCA+IDAgJiYgdmlzaWJsZVJlY3Qub3JpZ2lu LnggPD0gMCkgfHwgKGRlbHRhWCA8IDAgJiYgY29udGVudHNTaXplLndpZHRoIDw9IE5TTWF4WCh2 aXNpYmxlUmVjdCkpKSkgeworICAgIAorICAgICAgICBpZiAoV0tQREZWaWV3ICpwZGZWaWV3ID0g ZmluZEVuY2xvc2luZ1dLUERGVmlldyhzZWxmKSkgeworICAgICAgICAgICAgaWYgKFtwZGZWaWV3 IGZvcndhcmRTY3JvbGxXaGVlbEV2ZW50OndoZWVsRXZlbnRdKQorICAgICAgICAgICAgICAgIHJl dHVybjsKKyAgICAgICAgfQorICAgIH0KKworICAgIG9sZFBERlZpZXdTY3JvbGxWaWV3X3Njcm9s bFdoZWVsKHNlbGYsIF9jbWQsIHdoZWVsRXZlbnQpOworfQogICAgIAogTlNCdW5kbGUqIFBERlZp ZXdDb250cm9sbGVyOjpwZGZLaXRCdW5kbGUoKQogewpAQCAtNTAyLDYgKzU1MywxMiBAQCBOU0J1 bmRsZSogUERGVmlld0NvbnRyb2xsZXI6OnBkZktpdEJ1bmRsZSgpCiAgICAgcGRmS2l0QnVuZGxl ID0gW05TQnVuZGxlIGJ1bmRsZVdpdGhQYXRoOnBkZktpdFBhdGhdOwogICAgIGlmICghW3BkZktp dEJ1bmRsZSBsb2FkXSkKICAgICAgICAgTE9HX0VSUk9SKCJDb3VsZG4ndCBsb2FkIFBERktpdC5m cmFtZXdvcmsiKTsKKworICAgIGlmIChDbGFzcyBwZGZWaWV3U2Nyb2xsVmlld0NsYXNzID0gW3Bk ZktpdEJ1bmRsZSBjbGFzc05hbWVkOkAiUERGVmlld1Njcm9sbFZpZXciXSkgeworICAgICAgICBp ZiAoTWV0aG9kIHNjcm9sbFdoZWVsID0gY2xhc3NfZ2V0SW5zdGFuY2VNZXRob2QocGRmVmlld1Nj cm9sbFZpZXdDbGFzcywgQHNlbGVjdG9yKHNjcm9sbFdoZWVsOikpKQorICAgICAgICAgICAgb2xk UERGVmlld1Njcm9sbFZpZXdfc2Nyb2xsV2hlZWwgPSBtZXRob2Rfc2V0SW1wbGVtZW50YXRpb24o c2Nyb2xsV2hlZWwsIHJlaW50ZXJwcmV0X2Nhc3Q8SU1QPihQREZWaWV3U2Nyb2xsVmlld19zY3Jv bGxXaGVlbCkpOworICAgIH0KKwogICAgIHJldHVybiBwZGZLaXRCdW5kbGU7CiB9CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYzNhYjg2MzgwOTE1Zjhl YzYzYzhhYzk3OTA3YjFiZGNkMWZiMTBlMS4uMTFkYmQzZWNhMTQ1MDc3MjIyZjM2NzMyMGFiYzM1 Mjg1NzM5ZTAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAK QEAgLTE4MjUsNiArMTgyNSwxMyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkQ29tbWl0TG9hZEZv ckZyYW1lKHVpbnQ2NF90IGZyYW1lSUQsIGNvbnN0IFN0cmluZyYgbWltZVR5cAogCiAgICAgaWYg KGZyYW1lLT5pc01haW5GcmFtZSgpKSB7CiAgICAgICAgIG1fbWFpbkZyYW1lSGFzQ3VzdG9tUmVw cmVzZW50YXRpb24gPSBmcmFtZUhhc0N1c3RvbVJlcHJlc2VudGF0aW9uOworCisgICAgICAgIGlm IChtX21haW5GcmFtZUhhc0N1c3RvbVJlcHJlc2VudGF0aW9uKSB7CisgICAgICAgICAgICAvLyBB bHdheXMgYXNzdW1lIHRoYXQgdGhlIG1haW4gZnJhbWUgaXMgcGlubmVkIGhlcmUsIHNpbmNlIHRo ZSBjdXN0b20gcmVwcmVzZW50YXRpb24gdmlldyB3aWxsIGhhbmRsZQorICAgICAgICAgICAgLy8g YW55IHdoZWVsIGV2ZW50cyBhbmQgZGlzcGF0Y2ggdGhlbSB0byB0aGUgV0tWaWV3IHdoZW4gbmVj ZXNzYXJ5LgorICAgICAgICAgICAgbV9tYWluRnJhbWVJc1Bpbm5lZFRvTGVmdFNpZGUgPSB0cnVl OworICAgICAgICAgICAgbV9tYWluRnJhbWVJc1Bpbm5lZFRvUmlnaHRTaWRlID0gdHJ1ZTsKKyAg ICAgICAgfQogICAgICAgICBtX3BhZ2VDbGllbnQtPmRpZENvbW1pdExvYWRGb3JNYWluRnJhbWUo ZnJhbWVIYXNDdXN0b21SZXByZXNlbnRhdGlvbik7CiAgICAgfQogCg==