81187 2012-03-14 20:29:30 -0700 Platforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query the page's displayID 2012-03-14 22:07:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cmarrin simon.fraser oldest_to_newest 579071 0 jamesr 2012-03-14 20:29:30 -0700 Platforms without USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) don't need to query the page's displayID 579072 1 131980 jamesr 2012-03-14 20:30:03 -0700 Created attachment 131980 Patch 579081 2 jamesr 2012-03-14 20:37:36 -0700 In r97405 Chris Marrin added a PlatformDisplayID parameter to ScriptedAnimationController::create(). This is only used if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) is set, which is only set on mac and blackberry (?). Unfortunately this code tries to grab the display ID from Document::page() whenever a callback is set, bug that's not correct - the page() on a Document might be NULL. We have crash reports in chromium from this exact situation. Having the display ID on a Document-owned object seems inherently a bit broken - Documents aren't always associated with a Page and can move between Pages. I had a patch series underway in https://bugs.webkit.org/show_bug.cgi?id=74165 to move the controller up to the Page, which I think will make it clearer how to deal with issues like this. I haven't had time to get around to this, but this patch avoids doing the unnecessary call (and resulting crash) on most platforms. 579113 3 131980 simon.fraser 2012-03-14 21:37:49 -0700 Comment on attachment 131980 Patch Can you please file a separate bug on page() possibly being null? 579125 4 jamesr 2012-03-14 22:00:40 -0700 https://bugs.webkit.org/show_bug.cgi?id=81189 579126 5 jamesr 2012-03-14 22:07:39 -0700 Committed r110821: <http://trac.webkit.org/changeset/110821> 131980 2012-03-14 20:30:03 -0700 2012-03-14 21:37:49 -0700 Patch bug-81187-20120314203001.patch text/plain 1698 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjBjMTg4NTEwOTEzZGFj NjgzZWY3MjMyOTBlNjQ3MjQwN2E2Nzc1OS4uYmZhNWI3MTgzNmJmNTg4MmY1OTE4MTk0MWVkMjRj ZjdjNzQ3NGVlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTE0ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUGxhdGZvcm1zIHdp dGhvdXQgVVNFKFJFUVVFU1RfQU5JTUFUSU9OX0ZSQU1FX0RJU1BMQVlfTU9OSVRPUikgZG9uJ3Qg bmVlZCB0byBxdWVyeSB0aGUgcGFnZSdzIGRpc3BsYXlJRAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODExODcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpEb2N1bWVudDo6d2Via2l0UmVxdWVzdEFuaW1hdGlvbkZyYW1lKToKKwogMjAxMi0w My0xNCAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWFrZSBT aGFkb3dSb290LmFjdGl2ZUVsZW1lbnQgcmV0dXJuIG51bGwgaWYgaXQgZG9lcyBub3QgY29udGFp biBhIGZvY3VzZWQgZWxlbWVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDQ2NmFmNTQ1 Yjc1NjViNzVkZmY3ODEwYjk1ODZmYzAwMGNhZTYxYmQuLjE5MGM5ODAyN2YzNWJhNjM2YjhjNTEw YWUxOGZmOWEzMjlmNmU1ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNTI4OCw4ICs1 Mjg4LDEzIEBAIHZvaWQgRG9jdW1lbnQ6OmxvYWRFdmVudERlbGF5VGltZXJGaXJlZChUaW1lcjxE b2N1bWVudD4qKQogI2lmIEVOQUJMRShSRVFVRVNUX0FOSU1BVElPTl9GUkFNRSkKIGludCBEb2N1 bWVudDo6d2Via2l0UmVxdWVzdEFuaW1hdGlvbkZyYW1lKFBhc3NSZWZQdHI8UmVxdWVzdEFuaW1h dGlvbkZyYW1lQ2FsbGJhY2s+IGNhbGxiYWNrLCBFbGVtZW50KiBhbmltYXRpb25FbGVtZW50KQog ewotICAgIGlmICghbV9zY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIpCisgICAgaWYgKCFtX3Nj cmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcikgeworI2lmIFVTRShSRVFVRVNUX0FOSU1BVElPTl9G UkFNRV9ESVNQTEFZX01PTklUT1IpCiAgICAgICAgIG1fc2NyaXB0ZWRBbmltYXRpb25Db250cm9s bGVyID0gU2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyOjpjcmVhdGUodGhpcywgcGFnZSgpLT5k aXNwbGF5SUQoKSk7CisjZWxzZQorICAgICAgICBtX3NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxl ciA9IFNjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjo6Y3JlYXRlKHRoaXMsIDApOworI2VuZGlm CisgICAgfQogCiAgICAgcmV0dXJuIG1fc2NyaXB0ZWRBbmltYXRpb25Db250cm9sbGVyLT5yZWdp c3RlckNhbGxiYWNrKGNhbGxiYWNrLCBhbmltYXRpb25FbGVtZW50KTsKIH0K