81186 2012-03-14 20:02:03 -0700 REGRESSION (r103859): Cannot write a word with Korean double consonant 2012-04-06 17:14:33 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED InRadar, Regression P1 Critical --- 1 holy.adreamer webkit-unassigned ap enrica hbono mitz rniwa tony webkit.review.bot oldest_to_newest 579063 0 holy.adreamer 2012-03-14 20:02:03 -0700 When trying to type a word like '깍', which is 'ㄲ+ㅏ+ㄱ', in a text field, it results to 'ㅏㄱ'. And a word like '샀', which is 'ㅅ+ㅏ+ㅆ', results to 'ㅆ'. (For information, ㄲ is type by 'Shift+ㄱ') It seems like double consonant cannot be combined, and disappears when typed with other vowel. It happens in every text fields in a web page. Safari version doesn't have this kind of problem. Thank you. 579149 1 ap 2012-03-14 23:24:43 -0700 Confirmed with nightly r108302 as a regression form Safari 5.1.3 on OS X Lion. Steps to reproduce: 1. Enable Hangul 2-set input method. 2. Type Shift+R, K, R in any editable field. Expected results: 깍 Actual results: ㅏㄱ 579151 2 ap 2012-03-14 23:25:05 -0700 <rdar://problem/11053232> 583902 3 hbono 2012-03-21 01:51:35 -0700 Greetings, When I bisected nightly builds, this issue started from r103870 (*1) on my Lion Mac running on VMWare Fusion 4. Is it possible for someone to double-check this bisection result? (*1) <http://builds.nightly.webkit.org/files/trunk/mac/WebKit-SVN-r103870.dmg> (*2) <http://builds.nightly.webkit.org/files/trunk/mac/WebKit-SVN-r103857.dmg> Regards, Hironori Bono (In reply to comment #1) > Confirmed with nightly r108302 as a regression form Safari 5.1.3 on OS X Lion. > > Steps to reproduce: > > 1. Enable Hangul 2-set input method. > 2. Type Shift+R, K, R in any editable field. > > Expected results: 깍 > Actual results: ㅏㄱ 584963 4 133184 hbono 2012-03-21 21:39:01 -0700 Created attachment 133184 A quick fix (just for your information) Greetings, I have noticed this is a side-effect of r103859 today. To update status text, this change sends a fake mouse-move event when the keyboard status is changed, including when releasing a shift key while composing text. Unfortunately, this fake event confuses a Korean input method and it resets its marked text. Even though I have written a quick fix, it is just for your information and I'm not sure if it is a right fix. Neither do I have good ideas how to write layout tests for it. (It seems this fake event is invisible from JavaScript.) I wish it helps. Regards, Hironori Bono 588467 5 holy.adreamer 2012-03-26 19:02:39 -0700 Hello, I'm currently using r112169, but I'm afraid to say that this issue is still existing. Thank you. 588500 6 ap 2012-03-26 19:47:05 -0700 That's correct, the bug hasn't been fixed yet. 595742 7 133184 hbono 2012-04-04 11:24:47 -0700 Comment on attachment 133184 A quick fix (just for your information) Greetings, I would like to set r? to my change to get interest of WebKit reviewers. (I wonder if it is good to stall this issue.) Regards, Hironori Bono 595754 8 133184 mitz 2012-04-04 11:40:42 -0700 Comment on attachment 133184 A quick fix (just for your information) It looks like the problem is that the fake mouse event goes through mouseMovedInternal:, which does [[self inputContext] handleEvent:theEvent]. Since we don’t need the extra handling in -mouseMoved:, I think -postFakeMouseMovedEventForFlagsChangedEvent: should just change to do NativeWebMouseEvent webEvent(fakeEvent, self); _data->_page->handleMouseEvent(webEvent); 596969 9 135918 hbono 2012-04-05 15:40:00 -0700 Created attachment 135918 A quick fix v1 (applied a comment) Greetings, Many thanks for your review and investigation. I have tested your solution and verified it also fixes this issue. Even though I do not have any ideas how to write a layout test for this issue, would it be possible to review the updated one? Regards, Hironori Bono (In reply to comment #8) > (From update of attachment 133184 [details]) > It looks like the problem is that the fake mouse event goes through mouseMovedInternal:, which does [[self inputContext] handleEvent:theEvent]. Since we don’t need the extra handling in -mouseMoved:, I think -postFakeMouseMovedEventForFlagsChangedEvent: should just change to do > > NativeWebMouseEvent webEvent(fakeEvent, self); > _data->_page->handleMouseEvent(webEvent); 597000 10 135918 mitz 2012-04-05 16:23:09 -0700 Comment on attachment 135918 A quick fix v1 (applied a comment) Thanks for fixing this! 597835 11 135918 webkit.review.bot 2012-04-06 17:14:25 -0700 Comment on attachment 135918 A quick fix v1 (applied a comment) Clearing flags on attachment: 135918 Committed r113523: <http://trac.webkit.org/changeset/113523> 597836 12 webkit.review.bot 2012-04-06 17:14:33 -0700 All reviewed patches have been landed. Closing bug. 133184 2012-03-21 21:39:01 -0700 2012-04-05 15:40:00 -0700 A quick fix (just for your information) issue81186-patch0.txt text/plain 1784 hbono SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTY0OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTIxICBIaXJvbm9y aSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT046IENhbm5v dCB3cml0ZSBhIHdvcmQgd2l0aCBLb3JlYW4gZG91YmxlIGNvbnNvbmFudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODExODYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQgY2hhbmdlIHIxMDM4NTkg cG9zdHMgZmFrZSBtb3VzZS1tb3ZlIGV2ZW50cyB3aGVuIHRoZSBrZXlib2FyZCBzdGF0dXMgaXMK KyAgICAgICAgY2hhbmdlZC4gVW5mb3J0dW5hdGVseSwgdGhlc2UgZmFrZSBldmVudHMgY29uZnVz ZSBhIEtvcmVhbiBpbnB1dCBtZXRob2QgYW5kIGl0CisgICAgICAgIHJlc2V0cyBpdHMgbWFya2Vk IHRleHQuIFRoaXMgY2hhbmdlIHByZXZlbnRzIHNlbmRpbmcgdGhlc2UgZmFrZSBldmVudHMgd2hp bGUKKyAgICAgICAgY29tcG9zaW5nIHRleHQgd2l0aCBhbiBpbnB1dCBtZXRob2QuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgtW1dLVmlldyBfcG9z dEZha2VNb3VzZU1vdmVkRXZlbnRGb3JGbGFnc0NoYW5nZWRFdmVudDpdKToKKwogMjAxMi0wMy0y MSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtl IHVzZSBvZiBDRyByb3VuZGVkLXJlY3QgcHJpbWl0aXZlcwpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gMTExNjQ4KQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0y MTQ5LDYgKzIxNDksOCBAQCAtIChOU1ZpZXcgKiloaXRUZXN0OihOU1BvaW50KXBvaW50CiAKIC0g KHZvaWQpX3Bvc3RGYWtlTW91c2VNb3ZlZEV2ZW50Rm9yRmxhZ3NDaGFuZ2VkRXZlbnQ6KE5TRXZl bnQgKilmbGFnc0NoYW5nZWRFdmVudAogeworICAgIGlmIChfZGF0YS0+X3BhZ2UtPmVkaXRvclN0 YXRlKCkuaGFzQ29tcG9zaXRpb24pCisgICAgICAgIHJldHVybjsKICAgICBOU0V2ZW50ICpmYWtl RXZlbnQgPSBbTlNFdmVudCBtb3VzZUV2ZW50V2l0aFR5cGU6TlNNb3VzZU1vdmVkIGxvY2F0aW9u OltbZmxhZ3NDaGFuZ2VkRXZlbnQgd2luZG93XSBjb252ZXJ0U2NyZWVuVG9CYXNlOltOU0V2ZW50 IG1vdXNlTG9jYXRpb25dXQogICAgICAgICBtb2RpZmllckZsYWdzOltmbGFnc0NoYW5nZWRFdmVu dCBtb2RpZmllckZsYWdzXSB0aW1lc3RhbXA6W2ZsYWdzQ2hhbmdlZEV2ZW50IHRpbWVzdGFtcF0g d2luZG93TnVtYmVyOltmbGFnc0NoYW5nZWRFdmVudCB3aW5kb3dOdW1iZXJdCiAgICAgICAgIGNv bnRleHQ6W2ZsYWdzQ2hhbmdlZEV2ZW50IGNvbnRleHRdIGV2ZW50TnVtYmVyOjAgY2xpY2tDb3Vu dDowIHByZXNzdXJlOjBdOwo= 135918 2012-04-05 15:40:00 -0700 2012-04-06 17:14:25 -0700 A quick fix v1 (applied a comment) issue81186-patch1.txt text/plain 1870 hbono SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMzM4NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTA1ICBIaXJvbm9y aSBCb25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJFR1JFU1NJT046IENhbm5v dCB3cml0ZSBhIHdvcmQgd2l0aCBLb3JlYW4gZG91YmxlIGNvbnNvbmFudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODExODYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQgY2hhbmdlIHIxMDM4NTkg cG9zdHMgZmFrZSBtb3VzZS1tb3ZlIGV2ZW50cyB3aGVuIHRoZSBrZXlib2FyZCBzdGF0dXMgaXMK KyAgICAgICAgY2hhbmdlZC4gVW5mb3J0dW5hdGVseSwgdGhlc2UgbW91c2UgZXZlbnRzIGdvIHRv IGlucHV0IG1ldGhvZHMgYW5kIGNvbmZ1c2UgYQorICAgICAgICBLb3JlYW4gaW5wdXQgbWV0aG9k LiBUaGlzIGNoYW5nZSBkaXJlY3RseSBjYWxscyBoYW5kbGVNb3VzZUV2ZW50KCkgaW5zdGVhZCBv ZgorICAgICAgICAtbW91c2VNb3ZlZDogdG8gcHJldmVudCBzZW5kaW5nIHRoZXNlIGZha2UgZXZl bnRzIHRvIGlucHV0IG1ldGhvZHMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1Zp ZXcubW06CisgICAgICAgICgtW1dLVmlldyBfcG9zdEZha2VNb3VzZU1vdmVkRXZlbnRGb3JGbGFn c0NoYW5nZWRFdmVudDpdKToKKwogMjAxMi0wNC0wNSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBs ZS5jb20+CiAKICAgICAgICAgW21hY10gcmVxdWVzdEFuaW1hdGlvbkZyYW1lIHNvbWV0aW1lcyBz dHVjayB3aGVuIHBhZ2UgbG9hZHMgaW4gYSBiYWNrZ3JvdW5kIHRhYgpJbmRleDogU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbQkocmV2aXNpb24gMTEzMzU4KQorKysg U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCSh3b3JraW5nIGNvcHkp CkBAIC0yMTQ5LDcgKzIxNDksOCBAQCAtICh2b2lkKV9wb3N0RmFrZU1vdXNlTW92ZWRFdmVudEZv ckZsYWdzCiAgICAgTlNFdmVudCAqZmFrZUV2ZW50ID0gW05TRXZlbnQgbW91c2VFdmVudFdpdGhU eXBlOk5TTW91c2VNb3ZlZCBsb2NhdGlvbjpbW2ZsYWdzQ2hhbmdlZEV2ZW50IHdpbmRvd10gY29u dmVydFNjcmVlblRvQmFzZTpbTlNFdmVudCBtb3VzZUxvY2F0aW9uXV0KICAgICAgICAgbW9kaWZp ZXJGbGFnczpbZmxhZ3NDaGFuZ2VkRXZlbnQgbW9kaWZpZXJGbGFnc10gdGltZXN0YW1wOltmbGFn c0NoYW5nZWRFdmVudCB0aW1lc3RhbXBdIHdpbmRvd051bWJlcjpbZmxhZ3NDaGFuZ2VkRXZlbnQg d2luZG93TnVtYmVyXQogICAgICAgICBjb250ZXh0OltmbGFnc0NoYW5nZWRFdmVudCBjb250ZXh0 XSBldmVudE51bWJlcjowIGNsaWNrQ291bnQ6MCBwcmVzc3VyZTowXTsKLSAgICBbc2VsZiBtb3Vz ZU1vdmVkOmZha2VFdmVudF07CisgICAgTmF0aXZlV2ViTW91c2VFdmVudCB3ZWJFdmVudChmYWtl RXZlbnQsIHNlbGYpOworICAgIF9kYXRhLT5fcGFnZS0+aGFuZGxlTW91c2VFdmVudCh3ZWJFdmVu dCk7CiB9CiAKIC0gKE5TSW50ZWdlciljb252ZXJzYXRpb25JZGVudGlmaWVyCg==