81183 2012-03-14 19:04:52 -0700 NumericStrings should be inlined 2012-03-15 15:01:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 benjamin benjamin barraclough oldest_to_newest 579031 0 benjamin 2012-03-14 19:04:52 -0700 For some reason, NumericStrings is not always inlined. When it is not, we loose a couple of percent when converting numbers to strings. 579039 1 131975 benjamin 2012-03-14 19:09:04 -0700 Created attachment 131975 Patch 579147 2 131975 barraclough 2012-03-14 23:16:51 -0700 Comment on attachment 131975 Patch Nice catch! 579779 3 benjamin 2012-03-15 15:01:51 -0700 Committed r110891: <http://trac.webkit.org/changeset/110891> 131975 2012-03-14 19:09:04 -0700 2012-03-14 23:16:51 -0700 Patch bug-81183-20120314190903.patch text/plain 2574 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ODE3OGZjMmIxMTE1M2U1NWU3M2NjODE0ZTBlNjFkMjE0MjEyNGY2Li5kZDgwMGZlNWY2YmM3Yjdl M2Y5M2I5MjNjNGFkODA2YjI4Yjc2YTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMi0wMy0xNCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBOdW1lcmljU3RyaW5ncyBzaG91bGQgYmUgaW5saW5lZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODExODMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOdW1lcmljU3RyaW5ncyBp cyBub3QgYWx3YXlzIGlubGluZWQuIFdoZW4gaXQgaXMgbm90LCB0aGUgY2xhc3MgaXMgbm90IGZh c3RlcgorICAgICAgICB0aGFuIHVzaW5nIFVTdHJpbmc6Om51bWJlcigpIGRpcmVjdGx5LgorCisg ICAgICAgICogcnVudGltZS9OdW1lcmljU3RyaW5ncy5oOgorICAgICAgICAoSlNDOjpOdW1lcmlj U3RyaW5nczo6YWRkKToKKyAgICAgICAgKEpTQzo6TnVtZXJpY1N0cmluZ3M6Omxvb2t1cFNtYWxs U3RyaW5nKToKKwogMjAxMi0wMy0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgog CiAgICAgICAgIE1ha2UgQVJNdjcgd29yayBhZ2FpbgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvTnVtZXJpY1N0cmluZ3MuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL051bWVyaWNTdHJpbmdzLmgKaW5kZXggZDY1ZjE0MjY1Y2RmNjNmYjc0NDlmYTQ5 ZTZmNGVmOGNkZjAwYWYxZS4uN2ZhMjBjNDRkNTBlZGFhMmFmYzE4NGQ0M2MwNGQ1ZTc2YjllMGJi MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVtZXJpY1N0cmlu Z3MuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9OdW1lcmljU3RyaW5ncy5o CkBAIC0zNCw3ICszNCw3IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgY2xhc3MgTnVtZXJpY1N0 cmluZ3MgewogICAgIHB1YmxpYzoKLSAgICAgICAgVVN0cmluZyBhZGQoZG91YmxlIGQpCisgICAg ICAgIEFMV0FZU19JTkxJTkUgVVN0cmluZyBhZGQoZG91YmxlIGQpCiAgICAgICAgIHsKICAgICAg ICAgICAgIENhY2hlRW50cnk8ZG91YmxlPiYgZW50cnkgPSBsb29rdXAoZCk7CiAgICAgICAgICAg ICBpZiAoZCA9PSBlbnRyeS5rZXkgJiYgIWVudHJ5LnZhbHVlLmlzTnVsbCgpKQpAQCAtNDQsNyAr NDQsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIHJldHVybiBlbnRyeS52YWx1ZTsK ICAgICAgICAgfQogCi0gICAgICAgIFVTdHJpbmcgYWRkKGludCBpKQorICAgICAgICBBTFdBWVNf SU5MSU5FIFVTdHJpbmcgYWRkKGludCBpKQogICAgICAgICB7CiAgICAgICAgICAgICBpZiAoc3Rh dGljX2Nhc3Q8dW5zaWduZWQ+KGkpIDwgY2FjaGVTaXplKQogICAgICAgICAgICAgICAgIHJldHVy biBsb29rdXBTbWFsbFN0cmluZyhzdGF0aWNfY2FzdDx1bnNpZ25lZD4oaSkpOwpAQCAtNTYsNyAr NTYsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIHJldHVybiBlbnRyeS52YWx1ZTsK ICAgICAgICAgfQogCi0gICAgICAgIFVTdHJpbmcgYWRkKHVuc2lnbmVkIGkpCisgICAgICAgIEFM V0FZU19JTkxJTkUgVVN0cmluZyBhZGQodW5zaWduZWQgaSkKICAgICAgICAgewogICAgICAgICAg ICAgaWYgKGkgPCBjYWNoZVNpemUpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGxvb2t1cFNtYWxs U3RyaW5nKHN0YXRpY19jYXN0PHVuc2lnbmVkPihpKSk7CkBAIC03OSw3ICs3OSw3IEBAIG5hbWVz cGFjZSBKU0MgewogICAgICAgICBDYWNoZUVudHJ5PGRvdWJsZT4mIGxvb2t1cChkb3VibGUgZCkg eyByZXR1cm4gZG91YmxlQ2FjaGVbV1RGOjpGbG9hdEhhc2g8ZG91YmxlPjo6aGFzaChkKSAmIChj YWNoZVNpemUgLSAxKV07IH0KICAgICAgICAgQ2FjaGVFbnRyeTxpbnQ+JiBsb29rdXAoaW50IGkp IHsgcmV0dXJuIGludENhY2hlW1dURjo6SW50SGFzaDxpbnQ+OjpoYXNoKGkpICYgKGNhY2hlU2l6 ZSAtIDEpXTsgfQogICAgICAgICBDYWNoZUVudHJ5PHVuc2lnbmVkPiYgbG9va3VwKHVuc2lnbmVk IGkpIHsgcmV0dXJuIHVuc2lnbmVkQ2FjaGVbV1RGOjpJbnRIYXNoPHVuc2lnbmVkPjo6aGFzaChp KSAmIChjYWNoZVNpemUgLSAxKV07IH0KLSAgICAgICAgY29uc3QgVVN0cmluZyYgbG9va3VwU21h bGxTdHJpbmcodW5zaWduZWQgaSkKKyAgICAgICAgQUxXQVlTX0lOTElORSBjb25zdCBVU3RyaW5n JiBsb29rdXBTbWFsbFN0cmluZyh1bnNpZ25lZCBpKQogICAgICAgICB7CiAgICAgICAgICAgICBB U1NFUlQoaSA8IGNhY2hlU2l6ZSk7CiAgICAgICAgICAgICBpZiAoc21hbGxJbnRDYWNoZVtpXS5p c051bGwoKSkK