81172 2012-03-14 16:49:58 -0700 NRWT should respect --additional-platform-directory's Skipped list 2012-03-14 17:11:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton webkit-unassigned abarth ap dpranke jberlin ojan webkit.review.bot oldest_to_newest 578937 0 thorton 2012-03-14 16:49:58 -0700 Currently, if you specify --additional-platform-directory when running NRWT, it searches that directory for test results, but ignores its skipped list. I have a patch (+test). 578940 1 131958 thorton 2012-03-14 16:52:32 -0700 Created attachment 131958 patch 578964 2 thorton 2012-03-14 17:11:26 -0700 Landed in http://trac.webkit.org/changeset/110795, thanks Tim! 131958 2012-03-14 16:52:32 -0700 2012-03-14 17:06:50 -0700 patch nrwt-fix.diff text/plain 3180 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NjNh ODZlLi41NDEwOWUyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDMtMTQgIFRpbSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTlJXVCBzaG91bGQgcmVzcGVjdCAtLWFkZGl0 aW9uYWwtcGxhdGZvcm0tZGlyZWN0b3J5J3MgU2tpcHBlZCBsaXN0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTE3MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlc3BlY3QgdGhlIFNraXBwZWQgZmlsZSBp bnNpZGUgYWxsIHBhdGhzIGluY2x1ZGVkIHZpYSB0aGUgLS1hZGRpdGlvbmFsLXBsYXRmb3JtLWRp cmVjdG9yeSBvcHRpb24uIFRlc3QgcmVzdWx0cworICAgICAgICBmcm9tIHNhaWQgcGF0aCBhcmUg YWxyZWFkeSB1c2VkLCBidXQgdGhlIFNraXBwZWQgZmlsZSBpcyBpZ25vcmVkLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHk6CisgICAgICAg IChXZWJLaXRQb3J0Ll9za2lwcGVkX2ZpbGVfc2VhcmNoX3BhdGhzKToKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weToKKyAgICAg ICAgKHRlc3Rfc2tpcHBlZF9maWxlX3NlYXJjaF9wYXRocyk6CisKIDIwMTItMDMtMTQgIE9qYW4g VmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBBZGQgdGhlIGNocm9taXVtIGxp b24gYm90IHRvIGdhcmRlbi1vLW1hdGljIGFuZCByZW1vdmUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5IGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXQucHkKaW5kZXggZDMxNWYwNS4uNmU0 YTE2YiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC93ZWJraXQucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC93ZWJraXQucHkKQEAgLTMzMyw3ICszMzMsOCBAQCBjbGFzcyBXZWJLaXRQb3J0KFBvcnQpOgog ICAgICAgICByZXR1cm4gIiVzLXdrMiIgJSBzZWxmLnBvcnRfbmFtZQogCiAgICAgZGVmIF9za2lw cGVkX2ZpbGVfc2VhcmNoX3BhdGhzKHNlbGYpOgotICAgICAgICAjIFVubGlrZSBiYXNlbGluZV9z ZWFyY2hfcGF0aCwgd2Ugb25seSB3YW50IHRvIHNlYXJjaCBbV0syLVBPUlQsIFBPUlQtVkVSU0lP TiwgUE9SVF0gbm90IHRoZSBmdWxsIGNhc2FkZS4KKyAgICAgICAgIyBVbmxpa2UgYmFzZWxpbmVf c2VhcmNoX3BhdGgsIHdlIG9ubHkgd2FudCB0byBzZWFyY2ggW1dLMi1QT1JULCBQT1JULVZFUlNJ T04sIFBPUlRdIGFuZCBhbnkgZGlyZWN0b3JpZXMKKyAgICAgICAgIyBpbmNsdWRlZCB2aWEgLS1h ZGRpdGlvbmFsLXBsYXRmb3JtLWRpcmVjdG9yeSwgbm90IHRoZSBmdWxsIGNhc2FkZS4KICAgICAg ICAgIyBOb3RlIG9yZGVyIGRvZXNuJ3QgbWF0dGVyIHNpbmNlIHRoZSBTa2lwcGVkIGZpbGUgY29u dGVudHMgYXJlIGFsbCBjb21iaW5lZC4KICAgICAgICAgc2VhcmNoX3BhdGhzID0gc2V0KFtzZWxm LnBvcnRfbmFtZV0pCiAgICAgICAgIGlmICdmdXR1cmUnIG5vdCBpbiBzZWxmLm5hbWUoKToKQEAg LTM0Miw2ICszNDMsOCBAQCBjbGFzcyBXZWJLaXRQb3J0KFBvcnQpOgogICAgICAgICAgICAgIyBC ZWNhdXNlIG5lYXJseSBhbGwgb2YgdGhlIHNraXBwZWQgdGVzdHMgZm9yIFdlYktpdCAyIGFyZSBk dWUgdG8gY3Jvc3MtcGxhdGZvcm0KICAgICAgICAgICAgICMgaXNzdWVzLCBhbGwgd2syIHBvcnRz IHNoYXJlIGEgc2tpcHBlZCBsaXN0IHVuZGVyIHBsYXRmb3JtL3drMi4KICAgICAgICAgICAgIHNl YXJjaF9wYXRocy51cGRhdGUoW3NlbGYuX3drMl9wb3J0X25hbWUoKSwgIndrMiJdKQorICAgICAg ICBzZWFyY2hfcGF0aHMudXBkYXRlKHNlbGYuZ2V0X29wdGlvbigiYWRkaXRpb25hbF9wbGF0Zm9y bV9kaXJlY3RvcnkiLCBbXSkpCisKICAgICAgICAgcmV0dXJuIHNlYXJjaF9wYXRocwogCiAgICAg ZGVmIHRlc3RfZXhwZWN0YXRpb25zKHNlbGYpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC93ZWJraXRfdW5pdHRlc3QucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQppbmRleCA1 ZTIwYWJjLi42ZGM4NDU0IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdF91bml0dGVzdC5weQpAQCAtMTUxLDYgKzE1MSw4 IEBAIGNsYXNzIFdlYktpdFBvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToKICAg ICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0Ll9za2lwcGVkX2ZpbGVfc2VhcmNoX3BhdGhzKCks IHNldChbJ3Rlc3R3ZWJraXRwb3J0JywgJ3Rlc3R3ZWJraXRwb3J0LXZlcnNpb24nXSkpCiAgICAg ICAgIHBvcnQuX29wdGlvbnMgPSBNb2NrT3B0aW9ucyh3ZWJraXRfdGVzdF9ydW5uZXI9VHJ1ZSkK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0Ll9za2lwcGVkX2ZpbGVfc2VhcmNoX3BhdGhz KCksIHNldChbJ3Rlc3R3ZWJraXRwb3J0JywgJ3Rlc3R3ZWJraXRwb3J0LXZlcnNpb24nLCAndGVz dHdlYmtpdHBvcnQtd2syJywgJ3drMiddKSkKKyAgICAgICAgcG9ydC5fb3B0aW9ucyA9IE1vY2tP cHRpb25zKGFkZGl0aW9uYWxfcGxhdGZvcm1fZGlyZWN0b3J5PVsiaW50ZXJuYWwtdGVzdHdlYmtp dHBvcnQiXSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0Ll9za2lwcGVkX2ZpbGVfc2Vh cmNoX3BhdGhzKCksIHNldChbJ3Rlc3R3ZWJraXRwb3J0JywgJ3Rlc3R3ZWJraXRwb3J0LXZlcnNp b24nLCAnaW50ZXJuYWwtdGVzdHdlYmtpdHBvcnQnXSkpCiAKICAgICBkZWYgdGVzdF9yb290X29w dGlvbihzZWxmKToKICAgICAgICAgcG9ydCA9IFRlc3RXZWJLaXRQb3J0KCkK