81115 2012-03-14 08:46:59 -0700 [BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate 2012-03-19 07:45:48 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 81108 81121 0 anilsson webkit-unassigned benjamin rwlbuis tonikitoo webkit.review.bot oldest_to_newest 578436 0 anilsson 2012-03-14 08:46:59 -0700 The compositor tries to avoid rendering the same stuff twice, using a mechanism that was only applicable back when we had a separate OpenGL window. 581115 1 132420 anilsson 2012-03-16 17:12:16 -0700 Created attachment 132420 Patch 581274 2 132420 benjamin 2012-03-16 23:46:42 -0700 Comment on attachment 132420 Patch I trust you. 581751 3 132420 rwlbuis 2012-03-19 07:07:52 -0700 Comment on attachment 132420 Patch Let's try to get it in. 581788 4 132420 webkit.review.bot 2012-03-19 07:45:44 -0700 Comment on attachment 132420 Patch Clearing flags on attachment: 132420 Committed r111180: <http://trac.webkit.org/changeset/111180> 581789 5 webkit.review.bot 2012-03-19 07:45:48 -0700 All reviewed patches have been landed. Closing bug. 132420 2012-03-16 17:12:16 -0700 2012-03-19 07:45:44 -0700 Patch bug-81115-20120317011214.patch text/plain 4157 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMDkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3ODU2ODhlZTE5MTlmZmM5MzAzOTMxNGI0NjBjM2IzYjk0NjMxOGUzLi5kY2YzNTliZjZl ODZiZDc5N2RjN2RhY2RiMGEwY2M2YzUwZTQyZGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMi0wMy0xNCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSBvYnNvbGV0ZSBvcHRp bWl6YXRpb24gaW4gV2ViUGFnZUNvbXBvc2l0b3JQcml2YXRlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTExNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjb21wb3NpdG9yIHRyaWVkIHRvIGF2b2lk IHJlbmRlcmluZyB0aGUgc2FtZSBzdHVmZiB0d2ljZSwgdXNpbmcgYQorICAgICAgICBtZWNoYW5p c20gdGhhdCBkaWRuJ3Qgd29yayBwcm9wZXJseSBhbmQgaGFzIGJlZW4gcmVkdW5kYW50IHNpbmNl IHdlCisgICAgICAgIGludHJvZHVjZWQgZGVmZXJyZWQgYmxpdHMuIFJlbW92ZSB0aGlzIGNvZGUu CisKKyAgICAgICAgUmV2aWV3ZWQgaW50ZXJuYWxseSBieSBSb2JpbiBDYW8uCisKKyAgICAgICAg KiBBcGkvV2ViUGFnZUNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0 OjpXZWJQYWdlQ29tcG9zaXRvclByaXZhdGU6OldlYlBhZ2VDb21wb3NpdG9yUHJpdmF0ZSk6Cisg ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VDb21wb3NpdG9yUHJpdmF0ZTo6Y29t bWl0KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZUNvbXBvc2l0b3JQcml2 YXRlOjpkcmF3TGF5ZXJzKToKKyAgICAgICAgKiBBcGkvV2ViUGFnZUNvbXBvc2l0b3JfcC5oOgor CisyMDEyLTAzLTE0ICBBcnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KKwogICAgICAg ICBbQmxhY2tCZXJyeV0gUmVuYW1lIHRoZSBleGlzdGluZyBXZWJQYWdlQ29tcG9zaXRvciBjbGFz cyB0byBXZWJQYWdlQ29tcG9zaXRvclByaXZhdGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMTA4CiAgICAgICAgIFJJTSBQUjogMTM2Njg3CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VDb21wb3NpdG9yLmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNvbXBvc2l0b3IuY3BwCmlu ZGV4IGY2YmFlMGIwY2M0ZWMyNTE4Nzk5YWJlMzQ1NzlhNmU3ZTdiNzZjZDUuLjJmNzE3ZGY5MmZh ODU4Mzk3YTJiZmQyMWRhYWRmODk0YzMyY2M1ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZUNvbXBvc2l0b3IuY3BwCkBAIC00MCw4ICs0MCw2IEBAIFdl YlBhZ2VDb21wb3NpdG9yUHJpdmF0ZTo6V2ViUGFnZUNvbXBvc2l0b3JQcml2YXRlKFdlYlBhZ2VQ cml2YXRlKiBwYWdlKQogICAgIDogbV93ZWJQYWdlKHBhZ2UpCiAgICAgLCBtX2NvbnRleHQoR0xF UzJDb250ZXh0OjpjcmVhdGUocGFnZSkpCiAgICAgLCBtX2xheWVyUmVuZGVyZXIoTGF5ZXJSZW5k ZXJlcjo6Y3JlYXRlKG1fY29udGV4dC5nZXQoKSkpCi0gICAgLCBtX2dlbmVyYXRpb24oMCkKLSAg ICAsIG1fY29tcG9zaXRlZEdlbmVyYXRpb24oLTEpCiAgICAgLCBtX2JhY2tpbmdTdG9yZVVzZXNP cGVuR0woZmFsc2UpCiAgICAgLCBtX2FuaW1hdGlvblRpbWVyKHRoaXMsICZXZWJQYWdlQ29tcG9z aXRvclByaXZhdGU6OmFuaW1hdGlvblRpbWVyRmlyZWQpCiAgICAgLCBtX3RpbWVyQ2xpZW50KG5l dyBQbGF0Zm9ybTo6R2VuZXJpY1RpbWVyQ2xpZW50KFBsYXRmb3JtOjp1c2VySW50ZXJmYWNlVGhy ZWFkVGltZXJDbGllbnQoKSkpCkBAIC03OCwyNSArNzYsMTQgQEAgdm9pZCBXZWJQYWdlQ29tcG9z aXRvclByaXZhdGU6OmNvbW1pdChMYXllcldlYktpdFRocmVhZCogcm9vdExheWVyKQogICAgICAg ICByZXR1cm47CiAKICAgICByb290TGF5ZXItPmNvbW1pdE9uQ29tcG9zaXRpbmdUaHJlYWQoKTsK LSAgICArK21fZ2VuZXJhdGlvbjsKIH0KIAogYm9vbCBXZWJQYWdlQ29tcG9zaXRvclByaXZhdGU6 OmRyYXdMYXllcnMoY29uc3QgSW50UmVjdCYgZHN0UmVjdCwgY29uc3QgRmxvYXRSZWN0JiBjb250 ZW50cykKIHsKLSAgICAvLyBTYXZlIGEgZHJhdyBpZiB3ZSBhbHJlYWR5IGRyZXcgdGhpcyBnZW5l cmF0aW9uLCBmb3IgZXhhbXBsZSBkdWUgdG8gYSBjb25jdXJyZW50IHNjcm9sbCBvcGVyYXRpb24u Ci0gICAgaWYgKG1fY29tcG9zaXRlZEdlbmVyYXRpb24gPT0gbV9nZW5lcmF0aW9uICYmIGRzdFJl Y3QgPT0gbV9jb21wb3NpdGVkRHN0UmVjdAotICAgICAgICAmJiBjb250ZW50cyA9PSBtX2NvbXBv c2l0ZWRDb250ZW50c1JlY3QgJiYgIW1fYmFja2luZ1N0b3JlVXNlc09wZW5HTCkKLSAgICAgICAg cmV0dXJuIGZhbHNlOwotCiAgICAgbV9sYXllclJlbmRlcmVyLT5kcmF3TGF5ZXJzKGNvbnRlbnRz LCBtX2xheW91dFJlY3RGb3JDb21wb3NpdGluZywgbV9jb250ZW50c1NpemVGb3JDb21wb3NpdGlu ZywgZHN0UmVjdCk7CiAgICAgbV9sYXN0Q29tcG9zaXRpbmdSZXN1bHRzID0gbV9sYXllclJlbmRl cmVyLT5sYXN0UmVuZGVyaW5nUmVzdWx0cygpOwogCi0gICAgbV9jb21wb3NpdGVkRHN0UmVjdCA9 IGRzdFJlY3Q7Ci0gICAgbV9jb21wb3NpdGVkQ29udGVudHNSZWN0ID0gY29udGVudHM7Ci0gICAg bV9jb21wb3NpdGVkR2VuZXJhdGlvbiA9IG1fZ2VuZXJhdGlvbjsKLQogICAgIGlmIChtX2xhc3RD b21wb3NpdGluZ1Jlc3VsdHMubmVlZHNBbmltYXRpb25GcmFtZSkgewotICAgICAgICArK21fZ2Vu ZXJhdGlvbjsgLy8gVGhlIGFuaW1hdGlvbiB1cGRhdGUgbW92ZXMgdXMgYWxvbmcgb25lIGdlbmVy YXRpb24uCiAgICAgICAgIC8vIFVzaW5nIGEgdGltZW91dCBvZiAwIGFjdHVhbGx5IHdvbid0IHN0 YXJ0IGEgdGltZXIsIGl0IHdpbGwgc2VuZCBhIG1lc3NhZ2UuCiAgICAgICAgIG1fYW5pbWF0aW9u VGltZXIuc3RhcnQoMS4wIC8gNjAuMCk7CiAgICAgICAgIG1fd2ViUGFnZS0+dXBkYXRlRGVsZWdh dGVkT3ZlcmxheXMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkv V2ViUGFnZUNvbXBvc2l0b3JfcC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlQ29tcG9zaXRvcl9wLmgKaW5kZXggZGFmYzJkYjQwMzNkODlmNTExNTQ0YTE2ZmY1NTdiMjli MjJjYTUyZi4uMDAwMWM1MzkwZGJmMWNjZmVjZThlMDBhNDM4YWNiOGExOTY2ZTUzYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ29tcG9zaXRvcl9wLmgK KysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlQ29tcG9zaXRvcl9wLmgK QEAgLTc2LDEwICs3Niw2IEBAIHByaXZhdGU6CiAgICAgV2ViQ29yZTo6SW50UmVjdCBtX2xheW91 dFJlY3RGb3JDb21wb3NpdGluZzsKICAgICBXZWJDb3JlOjpJbnRTaXplIG1fY29udGVudHNTaXpl Rm9yQ29tcG9zaXRpbmc7CiAgICAgV2ViQ29yZTo6TGF5ZXJSZW5kZXJpbmdSZXN1bHRzIG1fbGFz dENvbXBvc2l0aW5nUmVzdWx0czsKLSAgICBpbnQgbV9nZW5lcmF0aW9uOwotICAgIGludCBtX2Nv bXBvc2l0ZWRHZW5lcmF0aW9uOwotICAgIFdlYkNvcmU6OkludFJlY3QgbV9jb21wb3NpdGVkRHN0 UmVjdDsKLSAgICBXZWJDb3JlOjpGbG9hdFJlY3QgbV9jb21wb3NpdGVkQ29udGVudHNSZWN0Owog ICAgIGJvb2wgbV9iYWNraW5nU3RvcmVVc2VzT3BlbkdMOwogICAgIEJsYWNrQmVycnk6OlBsYXRm b3JtOjpUaW1lcjxXZWJQYWdlQ29tcG9zaXRvclByaXZhdGU+IG1fYW5pbWF0aW9uVGltZXI7CiAg ICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlRpbWVyQ2xpZW50KiBtX3RpbWVyQ2xpZW50Owo=