81107 2012-03-14 07:52:48 -0700 [Qt] RenderThemeQt::fileListNameForWidth should override function in base class RenderTheme. (r110560) 2012-03-15 16:29:24 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno oldest_to_newest 578382 0 zeno 2012-03-14 07:52:48 -0700 RenderThemeQt::fileListNameForWidth() misses a parameter to properly override RenderTheme::fileListNameForWidth(). This becomes obvious after r110560 where the OVERRIDE keyword has been added to the function declaration. fileListNameForWidth() is only called in one place (WebCore/rendering/RenderFileUploadControl.cpp:244) and there it is called with the currently missing parameter "bool multipleFilesAllowed". Therefore we can assume that the implementation RenderThemeQt::fileListNameForWidth() never actually happens to be called currently. 578400 1 131850 zeno 2012-03-14 08:13:10 -0700 Created attachment 131850 patch for review. 579872 2 131850 zeno 2012-03-15 16:29:12 -0700 Comment on attachment 131850 patch for review. Clearing flags on attachment: 131850 Committed r110907: <http://trac.webkit.org/changeset/110907> 579873 3 zeno 2012-03-15 16:29:24 -0700 All reviewed patches have been landed. Closing bug. 131850 2012-03-14 08:13:10 -0700 2012-03-15 16:29:12 -0700 patch for review. 81107_20120314-161232.patch text/plain 2367 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NjI2Mjg5Li40MDE2MzA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDMtMTQgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XSBSZW5kZXJUaGVtZVF0OjpmaWxlTGlzdE5hbWVGb3JXaWR0aCBzaG91bGQgb3ZlcnJp ZGUgZnVuY3Rpb24gaW4gYmFzZSBjbGFzcyBSZW5kZXJUaGVtZS4gKHIxMTA1NjApCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTEwNworCisgICAgICAg IEFkZCAiYm9vbCBtdWx0aXBsZUZpbGVzQWxsb3dlZCIgdG8gdGhlIHBhcmFtZXRlciBsaXN0IG9m IFJlbmRlclRoZW1lUXQ6OmZpbGVMaXN0TmFtZUZvcldpZHRoLgorICAgICAgICBUaGlzIHdheSB0 aGUgYmFzZSBjbGFzcyBmdW5jdGlvbiBpcyBwcm9wZXJseSBvdmVycmlkZGVuLgorICAgICAgICBU aGUgbmVlZCBmb3IgdGhpcyBjaGFuZ2UgYmVjYW1lIG9idmlvdXMgYWZ0ZXIgcjExMDU2MCB3aGVy ZSB0aGUgT1ZFUlJJREUga2V5d29yZCBoYWQgYmVlbgorICAgICAgICBhZGRlZCB0byB0aGUgZnVu Y3Rpb24gc2lnbmF0dXJlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJUaGVtZVF0OjpmaWxlTGlzdE5hbWVGb3JXaWR0aCk6CisgICAgICAgICogcGxh dGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5oOgorICAgICAgICAoUmVuZGVyVGhlbWVRdCk6CisKIDIw MTItMDMtMTQgIEhhamltZSBNb3JyaXRhICA8bW9ycml0YUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9xdC9SZW5kZXJUaGVtZVF0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Jl bmRlclRoZW1lUXQuY3BwCmluZGV4IDg0N2ZlMzAuLmQzMjZiNjEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3F0L1JlbmRlclRoZW1lUXQuY3BwCkBAIC04NjksOCArODY5LDkgQEAgZG91 YmxlIFJlbmRlclRoZW1lUXQ6OmNhcmV0QmxpbmtJbnRlcnZhbCgpIGNvbnN0CiAgICAgcmV0dXJu IHN0YXRpY19jYXN0PFFHdWlBcHBsaWNhdGlvbio+KHFBcHApLT5zdHlsZUhpbnRzKCktPmN1cnNv ckZsYXNoVGltZSgpIC8gMTAwMC4wIC8gMi4wOwogfQogCi1TdHJpbmcgUmVuZGVyVGhlbWVRdDo6 ZmlsZUxpc3ROYW1lRm9yV2lkdGgoY29uc3QgRmlsZUxpc3QqIGZpbGVMaXN0LCBjb25zdCBGb250 JiBmb250LCBpbnQgd2lkdGgpIGNvbnN0CitTdHJpbmcgUmVuZGVyVGhlbWVRdDo6ZmlsZUxpc3RO YW1lRm9yV2lkdGgoY29uc3QgRmlsZUxpc3QqIGZpbGVMaXN0LCBjb25zdCBGb250JiBmb250LCBp bnQgd2lkdGgsIGJvb2wgbXVsdGlwbGVGaWxlc0FsbG93ZWQpIGNvbnN0CiB7CisgICAgVU5VU0VE X1BBUkFNKG11bHRpcGxlRmlsZXNBbGxvd2VkKTsKICAgICBpZiAod2lkdGggPD0gMCkKICAgICAg ICAgcmV0dXJuIFN0cmluZygpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9xdC9SZW5kZXJUaGVtZVF0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9SZW5kZXJU aGVtZVF0LmgKaW5kZXggZmYyZGI1OC4uMDNiNzE2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vcXQvUmVuZGVyVGhlbWVRdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3F0L1JlbmRlclRoZW1lUXQuaApAQCAtMTU1LDcgKzE1NSw3IEBAIHByb3RlY3RlZDoKICNl bmRpZgogICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlU2l6ZUJhc2VkT25TdHlsZShSZW5kZXJTdHls ZSopIGNvbnN0ID0gMDsKIAotICAgIHZpcnR1YWwgU3RyaW5nIGZpbGVMaXN0TmFtZUZvcldpZHRo KGNvbnN0IEZpbGVMaXN0KiwgY29uc3QgRm9udCYsIGludCB3aWR0aCkgY29uc3QgT1ZFUlJJREU7 CisgICAgdmlydHVhbCBTdHJpbmcgZmlsZUxpc3ROYW1lRm9yV2lkdGgoY29uc3QgRmlsZUxpc3Qq LCBjb25zdCBGb250JiwgaW50IHdpZHRoLCBib29sIG11bHRpcGxlRmlsZXNBbGxvd2VkKSBjb25z dCBPVkVSUklERTsKIAogICAgIHZpcnR1YWwgUVJlY3QgaW5mbGF0ZUJ1dHRvblJlY3QoY29uc3Qg UVJlY3QmIG9yaWdpbmFsUmVjdCkgY29uc3Q7CiAK