81087 2012-03-14 00:46:11 -0700 Don't install libWebCoreTestSupport on OS X production builds 2012-03-16 13:48:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 dev+webkit dev+webkit mrowe oldest_to_newest 578218 0 dev+webkit 2012-03-14 00:46:11 -0700 No reason to install this dylib on production builds. <rdar://problem/10501894> 578221 1 131801 dev+webkit 2012-03-14 00:53:08 -0700 Created attachment 131801 patch 578230 2 131801 mrowe 2012-03-14 01:14:42 -0700 Comment on attachment 131801 patch View in context: https://bugs.webkit.org/attachment.cgi?id=131801&action=review > Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:35 > +SKIP_INSTALL = $(SKIP_INSTALL_$(BUILD_TYPE)); > +SKIP_INSTALL_Production = YES; I don't know what BUILD_TYPE is. It wouldn't be what we want anyway. Since this library is only used by DumpRenderTree and friends we want this installed only when FORCE_TOOL_INSTALL = YES. See Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig for where we do this elsewhere. 579822 3 dev+webkit 2012-03-15 15:38:18 -0700 BUILD_TYPE was a typo. But the way ToolExecutable does it is even better. New patch forthcoming. 580894 4 132362 dev+webkit 2012-03-16 13:39:09 -0700 Created attachment 132362 patch2 580907 5 dev+webkit 2012-03-16 13:48:35 -0700 http://trac.webkit.org/changeset/111058 131801 2012-03-14 00:53:08 -0700 2012-03-16 13:39:09 -0700 patch patch.diff text/plain 1262 dev+webkit SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDY3MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAzLTE0ICBNYXR0IExp bGVrICA8bXJsQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBpbnN0YWxsIGxpYldlYkNvcmVU ZXN0U3VwcG9ydCBvbiBPUyBYIHByb2R1Y3Rpb24gYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTA4NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvV2ViQ29yZVRlc3RT dXBwb3J0LnhjY29uZmlnOgorCiAyMDEyLTAzLTE0ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3Zp bGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEJ1aWxkIGZpeCBmb3IgRUZM IGFmdGVyIHIxMTA2NjkuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9XZWJD b3JlVGVzdFN1cHBvcnQueGNjb25maWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ29u ZmlndXJhdGlvbnMvV2ViQ29yZVRlc3RTdXBwb3J0LnhjY29uZmlnCShyZXZpc2lvbiAxMTA2NzEp CisrKyBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9XZWJDb3JlVGVzdFN1cHBvcnQueGNj b25maWcJKHdvcmtpbmcgY29weSkKQEAgLTMxLDYgKzMxLDkgQEAKIElOU1RBTExfUEFUSCA9ICQo SU5TVEFMTF9QQVRIXyQoQ09ORklHVVJBVElPTikpOwogSU5TVEFMTF9QQVRIX1Byb2R1Y3Rpb24g PSAvdXNyL2xvY2FsL2xpYjsKIAorU0tJUF9JTlNUQUxMID0gJChTS0lQX0lOU1RBTExfJChCVUlM RF9UWVBFKSk7CitTS0lQX0lOU1RBTExfUHJvZHVjdGlvbiA9IFlFUzsKKwogTERfRFlMSUJfSU5T VEFMTF9OQU1FID0gJChMRF9EWUxJQl9JTlNUQUxMX05BTUVfJChDT05GSUdVUkFUSU9OKSk7CiBM RF9EWUxJQl9JTlNUQUxMX05BTUVfRGVidWcgPSBAcnBhdGgvJChFWEVDVVRBQkxFX1BBVEgpOwog TERfRFlMSUJfSU5TVEFMTF9OQU1FX1JlbGVhc2UgPSAkKExEX0RZTElCX0lOU1RBTExfTkFNRV9E ZWJ1Zyk7Cgo= 132362 2012-03-16 13:39:09 -0700 2012-03-16 13:40:17 -0700 patch2 take2.patch text/plain 1302 dev+webkit SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMTA1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAzLTE2ICBNYXR0IExp bGVrICA8bXJsQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBpbnN0YWxsIGxpYldlYkNvcmVU ZXN0U3VwcG9ydCBvbiBPUyBYIHByb2R1Y3Rpb24gYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTA4NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvV2ViQ29yZVRlc3RT dXBwb3J0LnhjY29uZmlnOgorCiAyMDEyLTAzLTE2ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgaW5jb3JyZWN0bHkgcmVtb3Zpbmcgc2Nyb2xsYmFyIGhlaWdodCBm b3IgYXV0byBoZWlnaHQgZmxleGJveCBjaGlsZHJlbgpJbmRleDogU291cmNlL1dlYkNvcmUvQ29u ZmlndXJhdGlvbnMvV2ViQ29yZVRlc3RTdXBwb3J0LnhjY29uZmlnCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1dlYkNvcmVUZXN0U3VwcG9ydC54Y2NvbmZpZwko cmV2aXNpb24gMTEwODg5KQorKysgU291cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvV2ViQ29y ZVRlc3RTdXBwb3J0LnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSwxMSBAQAog SU5TVEFMTF9QQVRIID0gJChJTlNUQUxMX1BBVEhfJChDT05GSUdVUkFUSU9OKSk7CiBJTlNUQUxM X1BBVEhfUHJvZHVjdGlvbiA9IC91c3IvbG9jYWwvbGliOwogCitTS0lQX0lOU1RBTEwgPSAkKFNL SVBfSU5TVEFMTF8kKEZPUkNFX1RPT0xfSU5TVEFMTCkpOworU0tJUF9JTlNUQUxMXyA9IFlFUzsK K1NLSVBfSU5TVEFMTF9OTyA9IFlFUzsKK1NLSVBfSU5TVEFMTF9ZRVMgPSBOTzsKKwogRFlMSUJf SU5TVEFMTF9OQU1FX0JBU0UgPSAkKERZTElCX0lOU1RBTExfTkFNRV9CQVNFXyQoQ09ORklHVVJB VElPTikpOwogRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0VfUHJvZHVjdGlvbiA9ICQoSU5TVEFMTF9Q QVRIKTsKIERZTElCX0lOU1RBTExfTkFNRV9CQVNFX0RlYnVnID0gQHJwYXRoOwog