81082 2012-03-13 23:35:43 -0700 [JSC] Web Inspector: CRASH running $0, $1, etc before they are set 2012-03-14 14:57:06 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 joepeck webkit-unassigned apavlov bweinstein joepeck keishi loislo oliver pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 578187 0 joepeck 2012-03-13 23:35:43 -0700 * STEPS TO REPRODUCE 1. Open Inspector to Console 2. js> $0 => CRASH Appears to be JSC only. 578191 1 131794 joepeck 2012-03-13 23:48:35 -0700 Created attachment 131794 [PATCH] Proposed Fix Another approach would be to implement and use ScriptValue::undefined instead of ScriptValue() from InjectedScriptHost. I'll try to get a patch of that up as well. 578195 2 joepeck 2012-03-13 23:56:23 -0700 Looks like JSC would probably need a ScriptState / ExecState for ScriptValue::undefined() to work, so I'm going to avoid that approach. 578807 3 131794 webkit.review.bot 2012-03-14 14:57:01 -0700 Comment on attachment 131794 [PATCH] Proposed Fix Clearing flags on attachment: 131794 Committed r110760: <http://trac.webkit.org/changeset/110760> 578808 4 webkit.review.bot 2012-03-14 14:57:06 -0700 All reviewed patches have been landed. Closing bug. 131794 2012-03-13 23:48:35 -0700 2012-03-14 14:57:01 -0700 [PATCH] Proposed Fix proposed-fix.patch text/plain 3230 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4YTBmZTQ5Li4yYTUwYjdlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDMt MTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBbSlND XSBXZWIgSW5zcGVjdG9yOiBDUkFTSCBydW5uaW5nICQwLCAkMSwgZXRjIGJlZm9yZSB0aGV5IGFy ZSBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgx MDgyCisKKyAgICAgICAgVGVzdCBmb3IgYW4gdW5kZWZpbmVkIGluc3BlY3RlZE9iamVjdC4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rv ci9jb25zb2xlL2NvbW1hbmQtbGluZS1hcGktZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGluc3Bl Y3Rvci9jb25zb2xlL2NvbW1hbmQtbGluZS1hcGkuaHRtbDoKKwogMjAxMi0wMy0xMCAgSnVsaWVu IENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW5kZXJPYmpl Y3Qgd2l0aCAncmVzaXplJyBkaWZmZXJlbnQgZnJvbSAnbm9uZScgc2hvdWxkIGhhdmUgYSBSZW5k ZXJMYXllcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29tbWFu ZC1saW5lLWFwaS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9j b21tYW5kLWxpbmUtYXBpLWV4cGVjdGVkLnR4dAppbmRleCA1ZGU2NDFjLi5hOGIyODYzIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb21tYW5kLWxpbmUtYXBpLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb21tYW5kLWxp bmUtYXBpLWV4cGVjdGVkLnR4dApAQCAtMSw2ICsxLDcgQEAKIFRlc3RzIHRoYXQgY29tbWFuZCBs aW5lIGFwaSB3b3Jrcy4KIAogJDAudG9TdHJpbmcoKSA9ICJbb2JqZWN0IEhUTUxQYXJhZ3JhcGhF bGVtZW50XSIKKyQzID0gdW5kZWZpbmVkCiBrZXlzKFszLDRdKS50b1N0cmluZygpID0gIjAsMSIK IHZhbHVlcyhbMyw0XSkudG9TdHJpbmcoKSA9ICIzLDQiCiAkKCdmb28nKS50b1N0cmluZygpID0g IltvYmplY3QgSFRNTFBhcmFncmFwaEVsZW1lbnRdIgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NvbnNvbGUvY29tbWFuZC1saW5lLWFwaS5odG1sIGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2NvbnNvbGUvY29tbWFuZC1saW5lLWFwaS5odG1sCmluZGV4IDkzMDRlYzAuLjEyMjE5 YTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbW1hbmQtbGlu ZS1hcGkuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb21tYW5kLWxp bmUtYXBpLmh0bWwKQEAgLTgsNiArOCw3IEBAIHZhciB0ZXN0ID0gZnVuY3Rpb24oKQogewogICAg IHZhciBleHByZXNzaW9ucyA9IFsKICAgICAgICAgIiQwLnRvU3RyaW5nKCkiLAorICAgICAgICAi JDMiLAogICAgICAgICAia2V5cyhbMyw0XSkudG9TdHJpbmcoKSIsCiAgICAgICAgICJ2YWx1ZXMo WzMsNF0pLnRvU3RyaW5nKCkiLAogICAgICAgICAiJCgnZm9vJykudG9TdHJpbmcoKSIsCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggNjUwM2IzZS4uZTEzNDc5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisy MDEyLTAzLTEzICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAg ICAgW0pTQ10gV2ViIEluc3BlY3RvcjogQ1JBU0ggcnVubmluZyAkMCwgJDEsIGV0YyBiZWZvcmUg dGhleSBhcmUgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MTA4MgorCisgICAgICAgIERvbid0IHJldHVybiBhbiBpbnZhbGlkIEpTVmFsdWUuIENo ZWNrIGlmIHRoZSBTY3JpcHRWYWx1ZQorICAgICAgICBoYXMgbm8gdmFsdWUgYW5kIHJldHVybiB1 bmRlZmluZWQgaW4gdGhhdCBjYXNlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVwZGF0ZWQgdGVzdDogaW5zcGVjdG9yL2NvbnNvbGUvY29tbWFuZC1s aW5lLWFwaS5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0luamVjdGVkU2NyaXB0SG9z dEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0luamVjdGVkU2NyaXB0SG9zdDo6aW5z cGVjdGVkT2JqZWN0KToKKwogMjAxMi0wMy0wOSAgSm9uIExlZSAgPGpvbmxlZUBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVuYW1lIE5vdGlmaWNhdGlvblByZXNlbnRlciB0byBOb3RpZmljYXRpb25D bGllbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSW5qZWN0ZWRT Y3JpcHRIb3N0Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSW5qZWN0 ZWRTY3JpcHRIb3N0Q3VzdG9tLmNwcAppbmRleCA3MDQwMmJjLi42MThkZTFkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0luamVjdGVkU2NyaXB0SG9zdEN1c3RvbS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNJbmplY3RlZFNjcmlwdEhvc3RD dXN0b20uY3BwCkBAIC04Niw3ICs4NiwxMSBAQCBKU1ZhbHVlIEpTSW5qZWN0ZWRTY3JpcHRIb3N0 OjppbnNwZWN0ZWRPYmplY3QoRXhlY1N0YXRlKiBleGVjKQogICAgICAgICByZXR1cm4ganNVbmRl ZmluZWQoKTsKIAogICAgIEpTTG9jayBsb2NrKFNpbGVuY2VBc3NlcnRpb25zT25seSk7Ci0gICAg cmV0dXJuIG9iamVjdC0+Z2V0KGV4ZWMpLmpzVmFsdWUoKTsKKyAgICBTY3JpcHRWYWx1ZSBzY3Jp cHRWYWx1ZSA9IG9iamVjdC0+Z2V0KGV4ZWMpOworICAgIGlmIChzY3JpcHRWYWx1ZS5oYXNOb1Zh bHVlKCkpCisgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOworCisgICAgcmV0dXJuIHNjcmlw dFZhbHVlLmpzVmFsdWUoKTsKIH0KIAogSlNWYWx1ZSBKU0luamVjdGVkU2NyaXB0SG9zdDo6aW50 ZXJuYWxDb25zdHJ1Y3Rvck5hbWUoRXhlY1N0YXRlKiBleGVjKQo=