81072 2012-03-13 20:26:56 -0700 [WebSocket]Browser should use 1000 as status code when WebSocket API close is called without status code parameter. 2012-05-08 00:17:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 0 li.yin webkit-unassigned abarth ap eric tkent toyoshim yutak oldest_to_newest 578128 0 li.yin 2012-03-13 20:26:56 -0700 When WebSocket API close was called like this "ws.cloes()", chromium didn't send the close frame to WebSocket server. And WebSocket server still sent frame to browser unexpectedly, it didn't produce some error, but maybe it's not friendly. Firefox used the status 1000 as the default value, when the close api had no the parameter. 578129 1 131776 li.yin 2012-03-13 20:33:25 -0700 Created attachment 131776 Patch 578138 2 131776 abarth 2012-03-13 21:14:05 -0700 Comment on attachment 131776 Patch Can you provide a link to the spec that requires this change? Also, changes in behavior require tests. 578156 3 li.yin 2012-03-13 21:54:13 -0700 http://dev.w3.org/html5/websockets/#dom-websocket-close If the WebSocket closing handshake has not yet been started, Start the WebSocket closing handshake and... Here, from RFC6455 http://tools.ietf.org/html/rfc6455#section-7.4, Start the WebSocket Closing Handshake, should send the close frame. 578163 4 abarth 2012-03-13 22:07:43 -0700 Thanks. That's good information to include in the ChangeLog. (The patch still needs a test, of course.) 578186 5 li.yin 2012-03-13 23:35:30 -0700 (In reply to comment #0) > When WebSocket API close was called like this "ws.cloes()", chromium didn't send the close frame to WebSocket server. > And WebSocket server still sent frame to browser unexpectedly, it didn't produce some error, but maybe it's not friendly. > I'm sorry for my previous misleading. From the newest code, chromium indeed sent close frame, when the close api was called without parameter. but it just had no body(status code and reason), which seemed to be allowed by RFC6455. > Firefox used the status 1000 as the default value, when the close api had no the parameter. The only difference is that Firefox used normal closure as the default value. 578513 6 toyoshim 2012-03-14 10:05:10 -0700 Hi joey, thank you for a patch. Originally, I implemented this WebSocket::close method for new hybi/rfc protocol. Before hybi-06, the WebSocket protocol didn't have the status code and the reason. At that time, the WebSocket API doesn't allow any argument for close method. From the viewpoint of protocol and API history, I decided to send close frame with empty body when user call close without any argument. 607333 7 li.yin 2012-04-22 01:14:07 -0700 (In reply to comment #6) > Hi joey, thank you for a patch. > Originally, I implemented this WebSocket::close method for new hybi/rfc protocol. > > Before hybi-06, the WebSocket protocol didn't have the status code and the reason. At that time, the WebSocket API doesn't allow any argument for close method. > From the viewpoint of protocol and API history, I decided to send close frame with empty body when user call close without any argument. From the bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=16703 It still have no obvious definition about the default status code in the spec, but it seems that 1000 should be. Do you think it is necessary to use 1000 instead of no status code? 607476 8 toyoshim 2012-04-22 22:39:13 -0700 Hi, Li. I post a similar comment on the w3c thread, too. [from RFC6455 7.1.5.] > a Close control frame may contain a status code indicating a reason for closure. > (snip) > If this Close control frame contains no status code, _The WebSocket > Connection Close Code_ is considered to be 1005. If _The WebSocket > Connection is Closed_ and no Close control frame was received by the > endpoint (such as could occur if the underlying transport connection > is lost), _The WebSocket Connection Close Code_ is considered to be > 1006. Actually, RFC said code and reason are optional. It uses 'MAY' in normative sections. I understand that this is because the API allow to omit them. As a result, pseudo code 1005 is needed for representing this case. 1005 doesn't represent any unexpected or error case. 618369 9 toyoshim 2012-05-07 23:59:49 -0700 API spec author said in the w3c thread in https://www.w3.org/Bugs/Public/show_bug.cgi?id=16703, > Ian 'Hixie' Hickson 2012-05-02 20:09:29 UTC > As far as I can tell, the spec is clear on this. If there's no argument, then > no close code is passed to the protocol. The protocol spec defines what to do > in that case. And Firefox is going to fix the behavior. https://bugzilla.mozilla.org/show_bug.cgi?id=748580 So, I'd like to close this issue. 618379 10 li.yin 2012-05-08 00:17:53 -0700 (In reply to comment #9) > API spec author said in the w3c thread in https://www.w3.org/Bugs/Public/show_bug.cgi?id=16703, > > > Ian 'Hixie' Hickson 2012-05-02 20:09:29 UTC > > As far as I can tell, the spec is clear on this. If there's no argument, then > > no close code is passed to the protocol. The protocol spec defines what to do > > in that case. > > And Firefox is going to fix the behavior. > https://bugzilla.mozilla.org/show_bug.cgi?id=748580 > > So, I'd like to close this issue. Okay, thanks. 131776 2012-03-13 20:33:25 -0700 2012-03-13 21:14:05 -0700 Patch bug-81072-20120315113515.patch text/plain 2473 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWI1MWVhOGMzMmMwM2Jl YmVlNWU1MzQwNGRhZDJlZGE3OTc4YjA5Ny4uZmU4NzJkNzgyMTMzZWVlZDFjMDYyZThhMjJjNjU1 NTM3Yjc3YmZlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTE0ICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIFtXZWJTb2NrZXRdQnJvd3NlciBzaG91 bGQgc2VuZCBjbG9zZSBmcmFtZSB3aGVuIFdlYlNvY2tldCBBUEkgY2xvc2UgaXMgY2FsbGVkIHdp dGhvdXQgc3RhdHVzIGNvZGUgcGFyYW1ldGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEwNzIKKyAgICAgICAgVXNpbmcgc3RhdHVzIGNvZGUgMTAw MCBhcyB0aGUgZGVmYXVsdCB2YWx1ZSBhbmQgc2VuZCBjbG9zZSBmcmFtZS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAg ICAgICAgKiBiaW5kaW5ncy9qcy9KU1dlYlNvY2tldEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpKU1dlYlNvY2tldDo6Y2xvc2UpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9W OFdlYlNvY2tldEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFdlYlNvY2tldDo6Y2xv c2VDYWxsYmFjayk6CisKIDIwMTItMDMtMTIgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFVzZSBJQ1UgQyBBUEkgaW5zdGVhZCBvZiBDKysgQVBJIGluIExvY2Fs aXplZE51bWJlcklDVQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNX ZWJTb2NrZXRDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJTb2Nr ZXRDdXN0b20uY3BwCmluZGV4IGM4ZTAwNjllZmNkN2YzNGRkNzk0MmEzYjRmNTEyMDVmMGIwZDQy MTcuLjYzZWExMDc5YTJhMWYxNGM3OWU0MDQ4NDI5YTYzYjBjZTBjYjQyYTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV2ViU29ja2V0Q3VzdG9tLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dlYlNvY2tldEN1c3RvbS5jcHAKQEAgLTEyMiw3 ICsxMjIsNyBAQCBKU1ZhbHVlIEpTV2ViU29ja2V0OjpjbG9zZShFeGVjU3RhdGUqIGV4ZWMpCiAg ICAgLy8gcmVtb3ZlIHRoaXMgY3VzdG9tIG1ldGhvZC4KICAgICBXZWJTb2NrZXQqIHdlYlNvY2tl dCA9IHN0YXRpY19jYXN0PFdlYlNvY2tldCo+KGltcGwoKSk7CiAgICAgc2l6ZV90IGFyZ3VtZW50 Q291bnQgPSBleGVjLT5hcmd1bWVudENvdW50KCk7Ci0gICAgaW50IGNvZGUgPSBXZWJTb2NrZXRD aGFubmVsOjpDbG9zZUV2ZW50Q29kZU5vdFNwZWNpZmllZDsKKyAgICBpbnQgY29kZSA9IFdlYlNv Y2tldENoYW5uZWw6OkNsb3NlRXZlbnRDb2RlTm9ybWFsQ2xvc3VyZTsKICAgICBTdHJpbmcgcmVh c29uID0gIiI7CiAgICAgaWYgKGFyZ3VtZW50Q291bnQgPj0gMSkgewogICAgICAgICBKU1ZhbHVl IHYgPSBleGVjLT5hcmd1bWVudCgwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOFdlYlNvY2tldEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhXZWJTb2NrZXRDdXN0b20uY3BwCmluZGV4IDliNWUxMGI2NmFkMjg5 NTVjZWRlZmU0ZGZkNmQwOWUzOTg5OThmYTYuLmZjYzdmZGNlNWI2MTMyYThlYTYyODM2MjliYjE5 YTc2ZTZiNDdjOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOFdlYlNvY2tldEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4V2ViU29ja2V0Q3VzdG9tLmNwcApAQCAtMTU1LDcgKzE1NSw3IEBAIHY4OjpIYW5k bGU8djg6OlZhbHVlPiBWOFdlYlNvY2tldDo6Y2xvc2VDYWxsYmFjayhjb25zdCB2ODo6QXJndW1l bnRzJiBhcmdzKQogICAgIC8vIHJlbW92ZSB0aGlzIGN1c3RvbSBtZXRob2QuCiAgICAgV2ViU29j a2V0KiB3ZWJTb2NrZXQgPSB0b05hdGl2ZShhcmdzLkhvbGRlcigpKTsKICAgICBpbnQgYXJndW1l bnRDb3VudCA9IGFyZ3MuTGVuZ3RoKCk7Ci0gICAgaW50IGNvZGUgPSBXZWJTb2NrZXRDaGFubmVs OjpDbG9zZUV2ZW50Q29kZU5vdFNwZWNpZmllZDsKKyAgICBpbnQgY29kZSA9IFdlYlNvY2tldENo YW5uZWw6OkNsb3NlRXZlbnRDb2RlTm9ybWFsQ2xvc3VyZTsKICAgICBTdHJpbmcgcmVhc29uID0g IiI7CiAgICAgaWYgKGFyZ3VtZW50Q291bnQgPj0gMSkgewogICAgICAgICBkb3VibGUgeCA9IGFy Z3NbMF0tPk51bWJlclZhbHVlKCk7Cg==