81068 2012-03-13 18:48:56 -0700 ValueToInt32 speculation will cause OSR exits even when it does not have to 2012-03-13 19:55:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo webkit-unassigned barraclough ggaren oliver oldest_to_newest 578092 0 fpizlo 2012-03-13 18:48:56 -0700 Patch forthcoming. 578093 1 fpizlo 2012-03-13 18:49:23 -0700 <rdar://problem/11043926> 578100 2 131770 fpizlo 2012-03-13 18:56:53 -0700 Created attachment 131770 the patch 578123 3 fpizlo 2012-03-13 19:55:47 -0700 Landed in http://trac.webkit.org/changeset/110661 131770 2012-03-13 18:56:53 -0700 2012-03-13 18:59:30 -0700 the patch v2iboolean_patch_1.diff text/plain 5493 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTEwNjU2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDEyLTAzLTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg VmFsdWVUb0ludDMyIHNwZWN1bGF0aW9uIHdpbGwgY2F1c2UgT1NSIGV4aXRzIGV2ZW4gd2hlbiBp dCBkb2VzIG5vdCBoYXZlIHRvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04MTA2OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTEwNDM5MjY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBUd28g cmVsYXRlZCBjaGFuZ2VzOgorICAgICAgICAxKSBWYWx1ZVRvSW50MzIgd2lsbCBub3cgYWx3YXlz IGp1c3QgZGVmZXIgdG8gdGhlIG5vbi1zcGVjdWxhdGl2ZSBwYXRoLCBpbnN0ZWFkCisgICAgICAg ICAgIG9mIGV4aXRpbmcsIGlmIGl0IGRvZXNuJ3Qga25vdyB3aGF0IHNwZWN1bGF0aW9ucyB0byBw ZXJmb3JtLgorICAgICAgICAyKSBWYWx1ZVRvSW50MzIgd2lsbCBzcGVjdWxhdGUgYm9vbGVhbiBp ZiBpdCBzZWVzIHRoaXMgdG8gYmUgcHJvZml0YWJsZS4KKworICAgICAgICAqIGRmZy9ERkdBYnN0 cmFjdFN0YXRlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0cmFjdFN0YXRlOjpleGVjdXRl KToKKyAgICAgICAgKiBkZmcvREZHTm9kZS5oOgorICAgICAgICAoSlNDOjpERkc6Ok5vZGU6OnNo b3VsZFNwZWN1bGF0ZUJvb2xlYW4pOgorICAgICAgICAoTm9kZSk6CisgICAgICAgICogZGZnL0RG R1NwZWN1bGF0aXZlSklULmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6 Y29tcGlsZVZhbHVlVG9JbnQzMik6CisKIDIwMTItMDMtMTMgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXggc2luY2UgaXNfcG9k PD4gaW5jbHVkZXMgc29tZSBoZWFkZXIgdGhhdCBJIGRpZG4ndCBrbm93IGFib3V0LgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFN0YXRlLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0U3RhdGUuY3BwCShyZXZp c2lvbiAxMTA2MzEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0U3Rh dGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTEsMTEgKzI5MSwxMiBAQCBib29sIEFic3RyYWN0 U3RhdGU6OmV4ZWN1dGUodW5zaWduZWQgaW5kCiAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAg CiAgICAgY2FzZSBWYWx1ZVRvSW50MzI6Ci0gICAgICAgIGlmIChtX2dyYXBoW25vZGUuY2hpbGQx KCldLnNob3VsZE5vdFNwZWN1bGF0ZUludGVnZXIoKSkgewotICAgICAgICAgICAgaWYgKG1fZ3Jh cGhbbm9kZS5jaGlsZDEoKV0uc2hvdWxkU3BlY3VsYXRlRG91YmxlKCkpCi0gICAgICAgICAgICAg ICAgZm9yTm9kZShub2RlLmNoaWxkMSgpKS5maWx0ZXIoUHJlZGljdE51bWJlcik7Ci0gICAgICAg IH0gZWxzZQorICAgICAgICBpZiAobV9ncmFwaFtub2RlLmNoaWxkMSgpXS5zaG91bGRTcGVjdWxh dGVJbnRlZ2VyKCkpCiAgICAgICAgICAgICBmb3JOb2RlKG5vZGUuY2hpbGQxKCkpLmZpbHRlcihQ cmVkaWN0SW50MzIpOworICAgICAgICBlbHNlIGlmIChtX2dyYXBoW25vZGUuY2hpbGQxKCldLnNo b3VsZFNwZWN1bGF0ZU51bWJlcigpKQorICAgICAgICAgICAgZm9yTm9kZShub2RlLmNoaWxkMSgp KS5maWx0ZXIoUHJlZGljdE51bWJlcik7CisgICAgICAgIGVsc2UgaWYgKG1fZ3JhcGhbbm9kZS5j aGlsZDEoKV0uc2hvdWxkU3BlY3VsYXRlQm9vbGVhbigpKQorICAgICAgICAgICAgZm9yTm9kZShu b2RlLmNoaWxkMSgpKS5maWx0ZXIoUHJlZGljdEJvb2xlYW4pOwogICAgICAgICAKICAgICAgICAg Zm9yTm9kZShub2RlSW5kZXgpLnNldChQcmVkaWN0SW50MzIpOwogICAgICAgICBicmVhazsKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCShyZXZpc2lvbiAxMTA2MzEpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUuaAkod29ya2luZyBjb3B5KQpAQCAtNzAw LDYgKzcwMCwxMSBAQCBzdHJ1Y3QgTm9kZSB7CiAgICAgICAgIHJldHVybiAhIShwcmVkaWN0aW9u KCkgJiBQcmVkaWN0RG91YmxlKTsKICAgICB9CiAgICAgCisgICAgYm9vbCBzaG91bGRTcGVjdWxh dGVCb29sZWFuKCkKKyAgICB7CisgICAgICAgIHJldHVybiBpc0Jvb2xlYW5QcmVkaWN0aW9uKHBy ZWRpY3Rpb24oKSk7CisgICAgfQorICAgIAogICAgIGJvb2wgc2hvdWxkU3BlY3VsYXRlRmluYWxP YmplY3QoKQogICAgIHsKICAgICAgICAgcmV0dXJuIGlzRmluYWxPYmplY3RQcmVkaWN0aW9uKHBy ZWRpY3Rpb24oKSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0 aXZlSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmNwcAkocmV2aXNpb24gMTEwNjMxKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0OTAsMzEg KzE0OTAsNDMgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUdldEJ5VmFsT25TdAogCiB2 b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlVmFsdWVUb0ludDMyKE5vZGUmIG5vZGUpCiB7Ci0g ICAgaWYgKGF0KG5vZGUuY2hpbGQxKCkpLnNob3VsZE5vdFNwZWN1bGF0ZUludGVnZXIoKSkgewot ICAgICAgICBpZiAoYXQobm9kZS5jaGlsZDEoKSkuc2hvdWxkU3BlY3VsYXRlRG91YmxlKCkpIHsK LSAgICAgICAgICAgIFNwZWN1bGF0ZURvdWJsZU9wZXJhbmQgb3AxKHRoaXMsIG5vZGUuY2hpbGQx KCkpOwotICAgICAgICAgICAgR1BSVGVtcG9yYXJ5IHJlc3VsdCh0aGlzKTsKLSAgICAgICAgICAg IEZQUlJlZyBmcHIgPSBvcDEuZnByKCk7Ci0gICAgICAgICAgICBHUFJSZWcgZ3ByID0gcmVzdWx0 LmdwcigpOwotICAgICAgICAgICAgSklUQ29tcGlsZXI6Okp1bXAgdHJ1bmNhdGVkVG9JbnRlZ2Vy ID0gbV9qaXQuYnJhbmNoVHJ1bmNhdGVEb3VibGVUb0ludDMyKGZwciwgZ3ByLCBKSVRDb21waWxl cjo6QnJhbmNoSWZUcnVuY2F0ZVN1Y2Nlc3NmdWwpOwotICAgICAgICAgICAgCi0gICAgICAgICAg ICBzaWxlbnRTcGlsbEFsbFJlZ2lzdGVycyhncHIpOwotICAgICAgICAgICAgY2FsbE9wZXJhdGlv bih0b0ludDMyLCBncHIsIGZwcik7Ci0gICAgICAgICAgICBzaWxlbnRGaWxsQWxsUmVnaXN0ZXJz KGdwcik7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIHRydW5jYXRlZFRvSW50ZWdlci5saW5r KCZtX2ppdCk7Ci0gICAgICAgICAgICBpbnRlZ2VyUmVzdWx0KGdwciwgbV9jb21waWxlSW5kZXgp OwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9Ci0gICAgICAgIC8vIERvIGl0IHRoZSBz YWZlIHdheS4KLSAgICAgICAgbm9uU3BlY3VsYXRpdmVWYWx1ZVRvSW50MzIobm9kZSk7CisgICAg aWYgKGF0KG5vZGUuY2hpbGQxKCkpLnNob3VsZFNwZWN1bGF0ZUludGVnZXIoKSkgeworICAgICAg ICBTcGVjdWxhdGVJbnRlZ2VyT3BlcmFuZCBvcDEodGhpcywgbm9kZS5jaGlsZDEoKSk7CisgICAg ICAgIEdQUlRlbXBvcmFyeSByZXN1bHQodGhpcywgb3AxKTsKKyAgICAgICAgbV9qaXQubW92ZShv cDEuZ3ByKCksIHJlc3VsdC5ncHIoKSk7CisgICAgICAgIGludGVnZXJSZXN1bHQocmVzdWx0Lmdw cigpLCBtX2NvbXBpbGVJbmRleCwgb3AxLmZvcm1hdCgpKTsKICAgICAgICAgcmV0dXJuOwogICAg IH0KICAgICAKLSAgICBTcGVjdWxhdGVJbnRlZ2VyT3BlcmFuZCBvcDEodGhpcywgbm9kZS5jaGls ZDEoKSk7Ci0gICAgR1BSVGVtcG9yYXJ5IHJlc3VsdCh0aGlzLCBvcDEpOwotICAgIG1faml0Lm1v dmUob3AxLmdwcigpLCByZXN1bHQuZ3ByKCkpOwotICAgIGludGVnZXJSZXN1bHQocmVzdWx0Lmdw cigpLCBtX2NvbXBpbGVJbmRleCwgb3AxLmZvcm1hdCgpKTsKKyAgICBpZiAoYXQobm9kZS5jaGls ZDEoKSkuc2hvdWxkU3BlY3VsYXRlTnVtYmVyKCkpIHsKKyAgICAgICAgU3BlY3VsYXRlRG91Ymxl T3BlcmFuZCBvcDEodGhpcywgbm9kZS5jaGlsZDEoKSk7CisgICAgICAgIEdQUlRlbXBvcmFyeSBy ZXN1bHQodGhpcyk7CisgICAgICAgIEZQUlJlZyBmcHIgPSBvcDEuZnByKCk7CisgICAgICAgIEdQ UlJlZyBncHIgPSByZXN1bHQuZ3ByKCk7CisgICAgICAgIEpJVENvbXBpbGVyOjpKdW1wIHRydW5j YXRlZFRvSW50ZWdlciA9IG1faml0LmJyYW5jaFRydW5jYXRlRG91YmxlVG9JbnQzMihmcHIsIGdw ciwgSklUQ29tcGlsZXI6OkJyYW5jaElmVHJ1bmNhdGVTdWNjZXNzZnVsKTsKKyAgICAgICAgCisg ICAgICAgIHNpbGVudFNwaWxsQWxsUmVnaXN0ZXJzKGdwcik7CisgICAgICAgIGNhbGxPcGVyYXRp b24odG9JbnQzMiwgZ3ByLCBmcHIpOworICAgICAgICBzaWxlbnRGaWxsQWxsUmVnaXN0ZXJzKGdw cik7CisgICAgICAgIAorICAgICAgICB0cnVuY2F0ZWRUb0ludGVnZXIubGluaygmbV9qaXQpOwor ICAgICAgICBpbnRlZ2VyUmVzdWx0KGdwciwgbV9jb21waWxlSW5kZXgpOworICAgICAgICByZXR1 cm47CisgICAgfQorICAgIAorICAgIGlmIChhdChub2RlLmNoaWxkMSgpKS5zaG91bGRTcGVjdWxh dGVCb29sZWFuKCkpIHsKKyAgICAgICAgU3BlY3VsYXRlQm9vbGVhbk9wZXJhbmQgb3AxKHRoaXMs IG5vZGUuY2hpbGQxKCkpOworICAgICAgICBHUFJUZW1wb3JhcnkgcmVzdWx0KHRoaXMsIG9wMSk7 CisgICAgICAgIAorICAgICAgICBtX2ppdC5hbmQzMihKSVRDb21waWxlcjo6VHJ1c3RlZEltbTMy KDEpLCBvcDEuZ3ByKCkpOworICAgICAgICAKKyAgICAgICAgaW50ZWdlclJlc3VsdChvcDEuZ3By KCksIG1fY29tcGlsZUluZGV4KTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICAKKyAgICAv LyBEbyBpdCB0aGUgc2FmZSB3YXkuCisgICAgbm9uU3BlY3VsYXRpdmVWYWx1ZVRvSW50MzIobm9k ZSk7CisgICAgcmV0dXJuOwogfQogCiB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlVUludDMy VG9OdW1iZXIoTm9kZSYgbm9kZSkK