81063 2012-03-13 17:28:08 -0700 GTK 32-bit Linux Release build failing after r110580 (from bug 80338) 2012-03-14 09:00:11 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mvujovic webkit-unassigned webkit.review.bot oldest_to_newest 578032 0 mvujovic 2012-03-13 17:28:08 -0700 GTK friends, The GTK 64-bit bots are building fine, but the GTK 32-bit bot is failing with a linking error: CCLD Programs/unittests/testcopyandpaste ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o):Internals.cpp:function WebCore::Internals::inspectorHighlightRects(WebCore::Document*, int&): error: undefined reference to 'WebCore::ClientRectList::ClientRectList(WTF::Vector<WebCore::FloatQuad, 0u> const&)' (From GTK 32-bit log: http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/22245/steps/compile-webkit/logs/stdio) In r110580 (bug 80338), I added a reference to ClientRectList(Vector<FloatQuad>) and I put its symbol in symbols.filter. This passed the GTK EWS bot, and the GTK 64-bit build bots after landing. However, I think GTK 32-bit wants another symbol for ClientRectList(Vector<FloatQuad>). I don't have a working environment set up to build GTK 32-bit on Linux and determine the required symbol. However, I have inferred a reasonable guess for what the symbol is, based on a very similar 32-bit build fix that Gustavo did: http://trac.webkit.org/changeset/105424/ Gustavo's fix also was related to method that took in a Vector. In that fix, there was already a symbol: _ZN7WebCore30overrideUserPreferredLanguagesERKN3WTF6VectorINS0_6StringELm0EEE; And Gustavo added: _ZN7WebCore30overrideUserPreferredLanguagesERKN3WTF6VectorINS0_6StringELj0EEE; (Notice the first symbol ends with "ELm0EEE". The second symbol ends with "ELj0EEE".) Currently, the symbol I have for the ClientRectList(Vector<FloatQuad>) constructor is: _ZN7WebCore14ClientRectListC1ERKN3WTF6VectorINS_9FloatQuadELm0EEE; Notice how this also ends with "ELm0EEE", like in Gustavo's fix. I'm guessing that the symbol I need to add is almost the same, except with a "ELj0EEE" at the end, like this: _ZN7WebCore14ClientRectListC1ERKN3WTF6VectorINS_9FloatQuadELj0EEE; 578046 1 131761 mvujovic 2012-03-13 17:35:18 -0700 Created attachment 131761 Prospective build fix patch after r110580 for GTK Linux 32-bit release. I've put a patch that adds the symbol that might fix the 32-bit build, based on the previous comment. If any GTK experts think I'm right, I would appreciate it if they reviewed and committed it. Thank you, Max 578203 2 131761 webkit.review.bot 2012-03-14 00:11:38 -0700 Comment on attachment 131761 Prospective build fix patch after r110580 for GTK Linux 32-bit release. Clearing flags on attachment: 131761 Committed r110668: <http://trac.webkit.org/changeset/110668> 578204 3 webkit.review.bot 2012-03-14 00:11:41 -0700 All reviewed patches have been landed. Closing bug. 578453 4 mvujovic 2012-03-14 09:00:11 -0700 Thank you for the review, Martin. Looks like it fixed the GTK 32-bit build :) http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/22282 131761 2012-03-13 17:35:18 -0700 2012-03-14 00:11:38 -0700 Prospective build fix patch after r110580 for GTK Linux 32-bit release. gtk32-build-fix.patch text/plain 1409 mvujovic ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkMjFmNDk2Li43YjU2ZDNi IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTItMDMtMTMgIE1heCBWdWpvdmljICA8bXZ1am92aWNAYWRvYmUuY29tPgorCisgICAgICAg IEdUSyAzMi1iaXQgTGludXggUmVsZWFzZSBidWlsZCBmYWlsaW5nIGFmdGVyIHIxMTA1ODAgKGZy b20gYnVnIDgwMzM4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODEwNjMKKworICAgICAgICBQcm9zcGVjdGl2ZSBidWlsZCBmaXggZm9yIEdUSyAzMi1i aXQgTGludXggUmVsZWFzZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXI6IEFkZGluZyBzeW1i b2wgZm9yIENsaWVudFJlY3RMaXN0KFZlY3RvcjxGbG9hdFF1YWQ+KSBmb3IKKyAgICAgICAgR1RL IDMyLWJpdC4KKwogMjAxMi0wMy0xMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPiAm JiBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFsd2F5 cyBlbmFibGUgRU5BQkxFKENMSUVOVF9CQVNFRF9HRU9MT0NBVElPTikKZGlmZiAtLWdpdCBhL1Nv dXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXIgYi9Tb3VyY2UvYXV0b3Rvb2xzL3N5bWJvbHMu ZmlsdGVyCmluZGV4IDljMTQ4YzUuLjA4Mzg0MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9hdXRvdG9v bHMvc3ltYm9scy5maWx0ZXIKKysrIGIvU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcgpA QCAtNTAsNiArNTAsNyBAQCBfWk43V2ViQ29yZTEyVGV4dEl0ZXJhdG9yMjZyYW5nZUZyb21Mb2Nh dGlvbkFuZExlbmd0aEVQTlNfN0VsZW1lbnRFaWliOwogX1pON1dlYkNvcmUxMlRleHRJdGVyYXRv cjI5Z2V0TG9jYXRpb25BbmRMZW5ndGhGcm9tUmFuZ2VFUE5TXzdFbGVtZW50RVBLTlNfNVJhbmdl RVJqUzZfOwogX1pON1dlYkNvcmUxMlRleHRJdGVyYXRvcjI5Z2V0TG9jYXRpb25BbmRMZW5ndGhG cm9tUmFuZ2VFUE5TXzdFbGVtZW50RVBLTlNfNVJhbmdlRVJtUzZfOwogX1pON1dlYkNvcmUxM2Ny ZWF0ZVdyYXBwZXJFUE4zSlNDOUV4ZWNTdGF0ZUVQTlNfMTdKU0RPTUdsb2JhbE9iamVjdEVQTlNf NE5vZGVFOworX1pON1dlYkNvcmUxNENsaWVudFJlY3RMaXN0QzFFUktOM1dURjZWZWN0b3JJTlNf OUZsb2F0UXVhZEVMajBFRUU7CiBfWk43V2ViQ29yZTE0Q2xpZW50UmVjdExpc3RDMUVSS04zV1RG NlZlY3RvcklOU185RmxvYXRRdWFkRUxtMEVFRTsKIF9aTjdXZWJDb3JlMTRDbGllbnRSZWN0TGlz dEMxRXY7CiBfWk43V2ViQ29yZTE0Q2xpZW50UmVjdExpc3REMUV2Owo=