81055 2012-03-13 16:27:06 -0700 Heap::destroy leaks CopiedSpace 2012-03-14 14:14:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg fpizlo ggaren levin+threading webkit.review.bot oldest_to_newest 577969 0 mhahnenberg 2012-03-13 16:27:06 -0700 Currently we do not do anything to clean up memory in the CopiedSpace in Heap::destroy. We should add a destroy() function to CopiedSpace to remedy this. 577970 1 mhahnenberg 2012-03-13 16:27:22 -0700 <rdar://problem/11041460> 578066 2 131766 mhahnenberg 2012-03-13 18:07:07 -0700 Created attachment 131766 Patch 578661 3 131766 ggaren 2012-03-14 12:39:58 -0700 Comment on attachment 131766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131766&action=review > Source/JavaScriptCore/heap/Heap.cpp:383 > + m_storageSpace.destroy(); This should move above the size() ASSERT. 578758 4 mhahnenberg 2012-03-14 14:14:28 -0700 Committed r110748: <http://trac.webkit.org/changeset/110748> 131766 2012-03-13 18:07:07 -0700 2012-03-14 12:39:58 -0700 Patch bug-81055-20120313180705.patch text/plain 3492 mhahnenberg U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MzA2NGMzMmYxZWQxMjlmYWFkZjAxYWEyOWJiMmRlOWU1ZTY1MWQ4Li42ODBiZmQyMmZmNDcwZTA5 Mjc3YjhhYTQ3ZGRjN2QyYTQ2MTJiYjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMi0wMy0xMyAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBw bGUuY29tPgorCisgICAgICAgIEhlYXA6OmRlc3Ryb3kgbGVha3MgQ29waWVkU3BhY2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMDU1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBkZXN0cm95 KCkgZnVuY3Rpb24gdG8gQ29waWVkU3BhY2UgdGhhdCBtb3ZlcyBhbGwgbm9ybWFsIHNpemUgCisg ICAgICAgIENvcGllZEJsb2NrcyBmcm9tIHRoZSBDb3BpZWRTcGFjZSB0byB0aGUgSGVhcCdzIGxp c3Qgb2YgZnJlZSBibG9ja3MgCisgICAgICAgIGFzIHdlbGwgYXMgZGVhbGxvY2F0ZXMgYWxsIG9m IHRoZSBvdmVyc2l6ZSBibG9ja3MgaW4gdGhlIENvcGllZFNwYWNlLiAKKyAgICAgICAgVGhpcyBm dW5jdGlvbiBpcyBub3cgY2FsbGVkIGluIEhlYXA6OmRlc3Ryb3koKS4KKworICAgICAgICAqIGhl YXAvQ29waWVkU3BhY2UuY3BwOgorICAgICAgICAoSlNDOjpDb3BpZWRTcGFjZTo6ZGVzdHJveSk6 CisgICAgICAgIChKU0MpOgorICAgICAgICAqIGhlYXAvQ29waWVkU3BhY2UuaDoKKyAgICAgICAg KENvcGllZFNwYWNlKToKKyAgICAgICAgKiBoZWFwL0hlYXAuY3BwOgorICAgICAgICAoSlNDOjpI ZWFwOjpkZXN0cm95KToKKwogMjAxMi0wMy0xMyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUu Y29tPgogCiAgICAgICAgIExvYWRzIGZyb20gVUludDMyQXJyYXlzIHNob3VsZCBub3QgcmVzdWx0 IGluIGEgZG91YmxlIHVwLWNvbnZlcnQgaWYgaXQgaXNuJ3QgbmVjZXNzYXJ5CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRTcGFjZS5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRTcGFjZS5jcHAKaW5kZXggYzg0NzAxMjBmNjUyM2JiODc0 ZTcwMjYzZjZiYWE2ODA5N2VlNzJiNi4uNWEyYWM0MGQ5NTcyMDAwNzQ2MGJkNDExOTk2NTZmMmQ4 M2M3ODI5YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3Bh Y2UuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZFNwYWNlLmNwcApA QCAtMjYxLDQgKzI2MSwyNiBAQCBDaGVja2VkQm9vbGVhbiBDb3BpZWRTcGFjZTo6Z2V0RnJlc2hC bG9jayhBbGxvY2F0aW9uRWZmb3J0IGFsbG9jYXRpb25FZmZvcnQsIENvcAogICAgIHJldHVybiB0 cnVlOwogfQogCit2b2lkIENvcGllZFNwYWNlOjpkZXN0cm95KCkKK3sKKyAgICB3aGlsZSAoIW1f dG9TcGFjZS0+aXNFbXB0eSgpKSB7CisgICAgICAgIENvcGllZEJsb2NrKiBibG9jayA9IHN0YXRp Y19jYXN0PENvcGllZEJsb2NrKj4obV90b1NwYWNlLT5yZW1vdmVIZWFkKCkpOworICAgICAgICBN dXRleExvY2tlciBsb2NrZXIobV9oZWFwLT5tX2ZyZWVCbG9ja0xvY2spOworICAgICAgICBtX2hl YXAtPm1fZnJlZUJsb2Nrcy5hcHBlbmQoYmxvY2spOworICAgICAgICBtX2hlYXAtPm1fbnVtYmVy T2ZGcmVlQmxvY2tzKys7CisgICAgfQorCisgICAgd2hpbGUgKCFtX2Zyb21TcGFjZS0+aXNFbXB0 eSgpKSB7CisgICAgICAgIENvcGllZEJsb2NrKiBibG9jayA9IHN0YXRpY19jYXN0PENvcGllZEJs b2NrKj4obV9mcm9tU3BhY2UtPnJlbW92ZUhlYWQoKSk7CisgICAgICAgIE11dGV4TG9ja2VyIGxv Y2tlcihtX2hlYXAtPm1fZnJlZUJsb2NrTG9jayk7CisgICAgICAgIG1faGVhcC0+bV9mcmVlQmxv Y2tzLmFwcGVuZChibG9jayk7CisgICAgICAgIG1faGVhcC0+bV9udW1iZXJPZkZyZWVCbG9ja3Mr KzsKKyAgICB9CisKKyAgICB3aGlsZSAoIW1fb3ZlcnNpemVCbG9ja3MuaXNFbXB0eSgpKSB7Cisg ICAgICAgIENvcGllZEJsb2NrKiBibG9jayA9IHN0YXRpY19jYXN0PENvcGllZEJsb2NrKj4obV9v dmVyc2l6ZUJsb2Nrcy5yZW1vdmVIZWFkKCkpOworICAgICAgICBibG9jay0+bV9hbGxvY2F0aW9u LmRlYWxsb2NhdGUoKTsKKyAgICB9Cit9CisKIH0gLy8gbmFtZXNwYWNlIEpTQwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2UuaCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL0NvcGllZFNwYWNlLmgKaW5kZXggZThmYTgwMDU1OTBjODM2MjM5MzNm NjQwOTA4YTJlYjE0M2QyY2Y3NS4uYTgwMzZjZjgzYjUzODRjYmEwY2EwODhkODcxOTU2MzdmOTYw NzY3MSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkU3BhY2Uu aAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRTcGFjZS5oCkBAIC02OCw2 ICs2OCw4IEBAIHB1YmxpYzoKICAgICBzaXplX3QgdG90YWxNZW1vcnlBbGxvY2F0ZWQoKSB7IHJl dHVybiBtX3RvdGFsTWVtb3J5QWxsb2NhdGVkOyB9CiAgICAgc2l6ZV90IHRvdGFsTWVtb3J5VXRp bGl6ZWQoKSB7IHJldHVybiBtX3RvdGFsTWVtb3J5VXRpbGl6ZWQ7IH0KIAorICAgIHZvaWQgZGVz dHJveSgpOworCiAgICAgc3RhdGljIENvcGllZEJsb2NrKiBibG9ja0Zvcih2b2lkKik7CiAKIHBy aXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCmluZGV4IGE1ZDRhMDYzZmIxYjFl ZWRmZTZjZmQ2NTg2MGYxMWFkZTczNmJmMDQuLmFjZTcwZGZiYjQ3YTM4MmRhMTlkZWU0NmU2MDZk NWExNmNmNjdkNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAu Y3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCkBAIC0zODAsNyAr MzgwLDggQEAgdm9pZCBIZWFwOjpkZXN0cm95KCkKICAgICBtX2dsb2JhbERhdGEtPnNtYWxsU3Ry aW5ncy5maW5hbGl6ZVNtYWxsU3RyaW5ncygpOwogICAgIHNocmluaygpOwogICAgIEFTU0VSVCgh c2l6ZSgpKTsKLSAgICAKKyAgICBtX3N0b3JhZ2VTcGFjZS5kZXN0cm95KCk7CisKICNpZiBFTkFC TEUoU0lNUExFX0hFQVBfUFJPRklMSU5HKQogICAgIG1fc2xvdFZpc2l0b3IubV92aXNpdGVkVHlw ZUNvdW50cy5kdW1wKFdURjo6ZGF0YUZpbGUoKSwgIlZpc2l0ZWQgVHlwZSBDb3VudHMiKTsKICAg ICBtX2Rlc3Ryb3llZFR5cGVDb3VudHMuZHVtcChXVEY6OmRhdGFGaWxlKCksICJEZXN0cm95ZWQg VHlwZSBDb3VudHMiKTsK