81046 2012-03-13 15:43:55 -0700 Improve filter-build-webkit, especially for iOS builds 2014-03-03 11:49:09 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino dino joepeck krit oldest_to_newest 577912 0 dino 2012-03-13 15:43:55 -0700 I'll collect the rules that are missing from fbwk here, and commit when we're happy. The first one: jsc: replacing existing signature 582305 1 dino 2012-03-19 15:15:32 -0700 This is producing some output: PhaseScriptExecution Copy WTF Headers For example: PhaseScriptExecution Copy WTF Headers building file list ... done ./ Stub.h config.h icu/ icu/unicode/ icu/unicode/parseerr.h icu/unicode/platform.h icu/unicode/putil.h icu/unicode/uchar.h icu/unicode/ucnv.h icu/unicode/ucnv_err.h icu/unicode/ucol.h icu/unicode/uconfig.h icu/unicode/uenum.h icu/unicode/uiter.h icu/unicode/uloc.h icu/unicode/umachine.h icu/unicode/unorm.h icu/unicode/urename.h icu/unicode/uscript.h icu/unicode/uset.h icu/unicode/ustring.h icu/unicode/utf.h icu/unicode/utf16.h icu/unicode/utf8.h icu/unicode/utf_old.h icu/unicode/utypes.h icu/unicode/uversion.h sent 614838 bytes received 588 bytes 1230852.00 bytes/sec total size is 613144 speedup is 1.00 582455 2 dino 2012-03-19 16:49:28 -0700 And when it runs again, you get something like this: PhaseScriptExecution Copy WTF Headers building file list ... done sent 4573 bytes received 20 bytes 9186.00 bytes/sec total size is 1208643 speedup is 263.15 589504 3 dino 2012-03-27 17:36:54 -0700 PhaseScriptExecution Generate Derived Sources /Developer/usr/bin/bison -d -p cssyy WebCore/css/CSSGrammar.y -o CSSGrammar.cpp /Developer/usr/bin/bison -d -p xpathyy WebCore/xml/XPathGrammar.y -o XPathGrammar.cpp 968462 4 dino 2014-01-15 14:09:21 -0800 I'm not sure how many of these are still relevant, but I have a big update coming and I don't see nearly as much crappy output. 968466 5 221306 dino 2014-01-15 14:12:58 -0800 Created attachment 221306 Patch 968468 6 221306 joepeck 2014-01-15 14:17:54 -0800 Comment on attachment 221306 Patch Looks good to me! 986119 7 krit 2014-03-02 10:07:22 -0800 Did that land? 986427 8 joepeck 2014-03-03 11:48:40 -0800 Looks like it did: r162090 <http://trac.webkit.org/changeset/162090> 986428 9 221306 joepeck 2014-03-03 11:49:09 -0800 Comment on attachment 221306 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221306&action=review > Tools/Scripts/filter-build-webkit:147 > + $path =~ s/("|\\|\.[oah]$)//g; Though I would like to have the .o's back. Not sure about .a/.h. 221306 2014-01-15 14:12:58 -0800 2014-03-03 11:49:09 -0800 Patch bug-81046-20140116091257.patch text/plain 5176 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTFhNmZiYjYyODExNDZhYTZjNDNmODU3ODE1ZDc5MTk1 NmI5YjVjZC4uYzFjZjQ2Y2Q1NTk0MTY1YzJhOGExMDBmOTRkM2QzZGMxYWJkZDFiYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAxLTE1ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAg ICBJbXByb3ZlIGZpbHRlci1idWlsZC13ZWJraXQsIGVzcGVjaWFsbHkgZm9yIGlPUyBidWlsZHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxMDQ2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTG90cyBvZiB1 cGRhdGVzIHRvIHRoZSBmaWx0ZXJpbmcgcnVsZXMsIG1vc3RseSBmcm9tIHRoZQorICAgICAgICBp T1MgYnVpbGQgb3V0cHV0LiBPdGhlciBoaWdobGlnaHRzIGluY2x1ZGU6CisgICAgICAgIC0gaWdu b3JpbmcgZXNjYXBlIHNlcXVlbmNlcyBmb3IgY29sb3Igb3VwdXQKKyAgICAgICAgLSBkZXRlY3Rp bmcgZXNjYXBlZCBzcGFjZXMgaW4gZmlsZSBuYW1lIHJlZ2V4cHMKKworICAgICAgICAqIFNjcmlw dHMvZmlsdGVyLWJ1aWxkLXdlYmtpdDoKKyAgICAgICAgKHNob3VsZElnbm9yZUxpbmUpOgorCiAy MDE0LTAxLTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBXZWIgcHJvY2VzcyBzb21ldGltZXMgY3Jhc2hlcyB3aGVuIHByaW50aW5n IGluIHN5bmNocm9ub3VzIG1vZGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1 aWxkLXdlYmtpdCBiL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdAppbmRleCBjMDQw MGIxNDZlODQxMmM1MzBmOWYwM2I3NzNjZTk3NjY0NjNjYjdiLi41N2MzMzAzNmFjMzQ3MDdhY2E2 M2JkOTgyY2RhOTQ0Y2NhZjJiYWUwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2ZpbHRlci1i dWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0CkBAIC0x MzgsMjIgKzEzOCwzMyBAQCBmb3IgKG15ICRwcmV2aW91c0xpbmUgPSAiIiwgbXkgJGxpbmUgPSA8 PjsgJGxpbmU7ICRwcmV2aW91c0xpbmUgPSAkbGluZSwgJGxpbmUgPQogICAgICAgICAkYnVpbGRG aW5pc2hlZCA9IDE7CiAgICAgfSBlbHNpZiAoJGxpbmUgPX4gL149PT0vKSB7CiAgICAgICAgIHBy aW50TGluZSgkbGluZSwgU1RZTEVfSEVBREVSKTsKLSAgICB9IGVsc2lmICgkbGluZSA9fiAvQ2hl Y2tpbmcgRGVwZW5kZW5jaWVzfENoZWNrIGRlcGVuZGVuY2llcy8pIHsKKyAgICB9IGVsc2lmICgk bGluZSA9fiAvQ2hlY2tpbmcgRGVwZW5kZW5jaWVzfENoZWNrIGRlcGVuZGVuY2llc3xDcmVhdGUg cHJvZHVjdCBzdHJ1Y3R1cmUvKSB7CiAgICAgICAgIHByaW50TGluZSgkbGluZSwgU1RZTEVfUExB SU4pOwogICAgIH0gZWxzaWYgKCRsaW5lID1+IC9cKlwqIEJVSUxEIFNVQ0NFRURFRCBcKlwqLykg ewogICAgICAgICBwcmludExpbmUoIkJ1aWxkIFN1Y2NlZWRlZCIsIFNUWUxFX1NVQ0NFU1MpOwot ICAgIH0gZWxzaWYgKCRsaW5lID1+IC9eKFBoYXNlU2NyaXB0RXhlY3V0aW9ufENsQ29tcGlsZXxD b21waWxlQ3xEaXN0cmlidXRlZC1Db21waWxlQ3xMZHxQQlhDcHxDcFJlc291cmNlfENvcHlQTkdG aWxlfENvcHlUaWZmRmlsZXxDcEhlYWRlcnxQcm9jZXNzaW5nfFByb2Nlc3NJbmZvUGxpc3RGaWxl fFByb2Nlc3NQQ0h8UHJvY2Vzc1BDSFwrXCt8VG91Y2h8TGlidG9vbHxDb3B5U3RyaW5nc0ZpbGV8 TWlnfENyZWF0ZVVuaXZlcnNhbEJpbmFyeXxBbmFseXplfFByb2Nlc3NQcm9kdWN0UGFja2FnaW5n fENvZGVTaWdufFN5bUxpbmt8VXBkYXRpbmd8Q29tcGlsZVhJQnxTdHJpcE5JQnxDb3B5UGxpc3RG aWxlfEdlbmVyYXRlRFNZTUZpbGUpICgiW14iXSsifFxTKyk/LykgewotICAgICAgICBteSAoJGNv bW1hbmQsICRwYXRoKSA9ICgkMSwgYmFzZW5hbWUoJDIpKTsKLSAgICAgICAgJHBhdGggPX4gcy8i Ly9nOworICAgIH0gZWxzaWYgKCRsaW5lID1+IC9eKFxlXFsxbSk/KFBoYXNlU2NyaXB0RXhlY3V0 aW9ufENsQ29tcGlsZXxDb21waWxlQ3xEaXN0cmlidXRlZC1Db21waWxlQ3xMZHxQQlhDcHxDcFJl c291cmNlfENvcHlQTkdGaWxlfENvcHlUaWZmRmlsZXxDcEhlYWRlcnxQcm9jZXNzaW5nfFByb2Nl c3NJbmZvUGxpc3RGaWxlfFByb2Nlc3NQQ0h8UHJvY2Vzc1BDSFwrXCt8VG91Y2h8TGlidG9vbHxD b3B5U3RyaW5nc0ZpbGV8TWlnfENyZWF0ZVVuaXZlcnNhbEJpbmFyeXxBbmFseXplfFByb2Nlc3NQ cm9kdWN0UGFja2FnaW5nfENvZGVTaWdufFN5bUxpbmt8VXBkYXRpbmd8Q29tcGlsZVhJQnxTdHJp cE5JQnxDb3B5UGxpc3RGaWxlfEdlbmVyYXRlRFNZTUZpbGUpKFxlXFswbSk/ICgiW14iXSsifChc XHwoPzw9XFwpXHN8XFMpKyk/LykgeworICAgICAgICBteSAoJGNvbW1hbmQsICRwYXRoKSA9ICgk MiwgYmFzZW5hbWUoJDQpKTsKKyAgICAgICAgJHBhdGggPX4gcy8oInxcXHxcLltvYWhdJCkvL2c7 CiAgICAgICAgIHByaW50TGluZSgiJGNvbW1hbmQgJHBhdGgiLCBTVFlMRV9QTEFJTik7CisgICAg fSBlbHNpZiAoJGxpbmUgPX4gL15cUytta2RpciAuKj8oXFMrKSQvKSB7CisgICAgICAgIG15ICRw YXRoID0gYmFzZW5hbWUoJDEpOworICAgICAgICBwcmludExpbmUoIm1rZGlyICRwYXRoIiwgU1RZ TEVfUExBSU4pOworICAgIH0gZWxzaWYgKCRsaW5lID1+IC9eY3AgKFxTKykvKSB7CisgICAgICAg IG15ICRwYXRoID0gYmFzZW5hbWUoJDEpOworICAgICAgICBwcmludExpbmUoImNwICRwYXRoIiwg U1RZTEVfUExBSU4pOworICAgIH0gZWxzaWYgKCRsaW5lID1+IC9weXRob24gKFxTK1wucHkpIChc UyspLykgeworICAgICAgICBteSAoJGNvbW1hbmQsICRwYXRoKSA9IChiYXNlbmFtZSgkMSksIGJh c2VuYW1lKCQyKSk7CisgICAgICAgIHByaW50TGluZSgicHl0aG9uICRjb21tYW5kICRwYXRoIiwg U1RZTEVfUExBSU4pOwogICAgIH0gZWxzaWYgKCRsaW5lID1+IC9eXC9cUys/KHN0cmlwfFdlYkNv cmVFeHBvcnRGaWxlR2VuZXJhdG9yKSAuKj8oXC98XD4gKShcUyspLykgewogICAgICAgICBteSAo JGNvbW1hbmQsICRwYXRoKSA9IChiYXNlbmFtZSgkMSksIGJhc2VuYW1lKCQzKSk7CiAgICAgICAg IHByaW50TGluZSgiJGNvbW1hbmQgJHBhdGgiLCBTVFlMRV9QTEFJTik7CiAgICAgfSBlbHNpZiAo JGxpbmUgPX4gL15vZmZsaW5lYXNtXDogLykgewogICAgICAgICBwcmludExpbmUoJGxpbmUsIFNU WUxFX1BMQUlOKTsKLSAgICB9IGVsc2lmICgkbGluZSA9fiAvXkdlbmVyYXRpbmcgbWVzc2FnZS4q KGhlYWRlcnxyZWNlaXZlcikgZm9yIChcUyspXC5cLlwuLykgewotICAgICAgICBteSAoJGNvbW1h bmQsICRwYXRoKSA9ICgkMSwgYmFzZW5hbWUoJDIpKTsKLSAgICAgICAgcHJpbnRMaW5lKCJHZW5l cmF0aW5nIG1lc3NhZ2UgJGNvbW1hbmQgJHBhdGgiLCBTVFlMRV9QTEFJTik7CisgICAgfSBlbHNp ZiAoJGxpbmUgPX4gL15HZW5lcmF0aW5nIChiaW5kaW5nc3xtZXNzYWdlcz8gKGhlYWRlcnxyZWNl aXZlcil8ZGVyaXZlZCBzb3VyY2UpIGZvciAoXFMrKVwuXC5cLi8pIHsKKyAgICAgICAgbXkgKCRj b21tYW5kLCAkcGF0aCkgPSAoJDEsIGJhc2VuYW1lKCQzKSk7CisgICAgICAgIHByaW50TGluZSgi R2VuZXJhdGluZyAkY29tbWFuZCAkcGF0aCIsIFNUWUxFX1BMQUlOKTsKKyAgICB9IGVsc2lmICgk bGluZSA9fiAvXlByZS1wcm9jZXNzaW5nIChcUyspIHNhbmRib3ggcHJvZmlsZS8pIHsKKyAgICAg ICAgcHJpbnRMaW5lKCRsaW5lLCBTVFlMRV9QTEFJTik7CiAgICAgfSBlbHNpZiAoJGxpbmUgPX4g L14oXFMrXC9jYykuKj8oXFMrKVwuKG91dHxleHApLykgewogICAgICAgICBteSAoJGNvbW1hbmQs ICRwYXRoKSA9IChiYXNlbmFtZSgkMSksIGJhc2VuYW1lKCQyKSk7CiAgICAgICAgIHByaW50TGlu ZSgiJGNvbW1hbmQgJHBhdGgiLCBTVFlMRV9QTEFJTik7CkBAIC0yMzAsNiArMjQxLDE4IEBAIHN1 YiBzaG91bGRJZ25vcmVMaW5lKCQkKQogICAgIHJldHVybiAxIGlmICRsaW5lID1+IC9saWJ0b29s LipoYXMgbm8gc3ltYm9scy87CiAgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL14jIExvd2VyIGNh c2UgYWxsIHRoZSB2YWx1ZXMsIGFzIENTUyB2YWx1ZXMgYXJlIGNhc2UtaW5zZW5zaXRpdmUkLzsK ICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXmlmIHNvcnQgLzsKKyAgICByZXR1cm4gMSBpZiAk bGluZSA9fiAvc2V0LXdlYmtpdC1jb25maWd1cmF0aW9uLzsKKyAgICByZXR1cm4gMSBpZiAkbGlu ZSA9fiAvXmJ1aWxkaW5nIGZpbGUgbGlzdC87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15c LlwvJC87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15cUytcLmgkLzsKKyAgICByZXR1cm4g MSBpZiAkbGluZSA9fiAvXlxTK1wvJC87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL15zZW50 IFxkKyBieXRlcy87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL150b3RhbCBzaXplIGlzLzsK KyAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXlwoICh4Y29kZWJ1aWxkfGlmKSAvOworICAgIHJl dHVybiAxIGlmICRsaW5lID1+IC9ed2FybmluZ1w6IGRldGVjdGVkIGludGVybmFsIGluc3RhbGws IHBhc3NpbmcgZW50aXRsZW1lbnRzIHRvIHNpbXVsYXRvciBhbnl3YXlcLi87CisgICAgcmV0dXJu IDEgaWYgJGxpbmUgPX4gL21heSBub3QgZnVuY3Rpb24gaW4gdGhlIFNpbXVsYXRvciBiZWNhdXNl IEFkIEhvYy87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL1wvdXNyXC9iaW5cL2NsYW5nIC4q PyBcPiBcUysuc2IvOworCiAgICAgaWYgKCRwbGF0Zm9ybSBlcSAid2luIikgewogICAgICAgICBy ZXR1cm4gMSBpZiAkbGluZSA9fiAvXlxzKih0b3VjaHxwZXJsfGNhdHxybSAtZnxiaXNvbnxkZWx8 ZmxleHxweXRob258XC91c3JcL2JpblwvZ1wrXCt8Z3BlcmZ8ZWNob3xzZWR8aWYgXFsgXC1mfFdl YkNvcmVcL2dlbmVyYXRlLWV4cG9ydC1maWxlKSAvOwogICAgICAgICByZXR1cm4gMSBpZiAkbGlu ZSA9fiAvXlxzKihpZiBub3QgZXhpc3QgXCJ8aWYgZXJyb3JsZXZlbCAxKS87Cg==