81034 2012-03-13 14:00:41 -0700 [Skia] Remove use of deprecated Skia constant and struct field names 2012-03-26 19:13:29 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P3 Trivial --- 1 bsalomon bsalomon bsalomon cc-bugs jamesr senorblanco webkit.review.bot oldest_to_newest 577791 0 bsalomon 2012-03-13 14:00:41 -0700 [Skia] Remove use of deprecated Skia constant and struct field names 577792 1 131710 bsalomon 2012-03-13 14:02:14 -0700 Created attachment 131710 Patch 577793 2 bsalomon 2012-03-13 14:03:33 -0700 This will allow us to remove some cruft in Skia. 588439 3 131710 jamesr 2012-03-26 18:33:42 -0700 Comment on attachment 131710 Patch OK 588475 4 131710 webkit.review.bot 2012-03-26 19:13:25 -0700 Comment on attachment 131710 Patch Clearing flags on attachment: 131710 Committed r112193: <http://trac.webkit.org/changeset/112193> 588476 5 webkit.review.bot 2012-03-26 19:13:29 -0700 All reviewed patches have been landed. Closing bug. 131710 2012-03-13 14:02:14 -0700 2012-03-26 19:13:25 -0700 Patch bug-81034-20120313170212.patch text/plain 3550 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDYwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTEzICBCcmlhbiBT YWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbU2tpYV0gUmVtb3ZlIHVz ZSBvZiBkZXByZWNhdGVkIFNraWEgY29uc3RhbnQgYW5kIHN0cnVjdCBmaWVsZCBuYW1lcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEwMzQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBiZWhhdmlvciBj aGFuZ2UsIHNvIG5vIHRlc3RzLiBUaGUgbW9kaWZpZWQgY29kZSBpcyBleGVjdXRlZCBieSBtYW55 IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v RnJhbWVCdWZmZXJTa1BpY3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OmNyZWF0ZUFjY2VsZXJhdGVkQ2FudmFzKToKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2VGaWx0ZXJzLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNDUmVuZGVyU3VyZmFjZUZpbHRlcnM6OmFwcGx5KToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpjcmVhdGVBY2NlbGVyYXRlZENhbnZhcyk6CisKIDIwMTItMDMtMTIgIFNpbW9uIEZyYXNl ciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVmYWN0b3Igc29tZSBjb2Rl IHRoYXQgaXMgdXNlZCB0byBjaGVjayB3aGV0aGVyIGEgbGF5ZXIgbmVlZHMgYmFja2luZyBzdG9y ZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRnJhbWVC dWZmZXJTa1BpY3R1cmVDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9GcmFtZUJ1ZmZlclNr UGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuY3BwCShyZXZpc2lvbiAxMTA2MDApCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9GcmFtZUJ1ZmZlclNr UGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 OSw3ICs0OSw3IEBAIHN0YXRpYyBQYXNzT3duUHRyPFNrQ2FudmFzPiBjcmVhdGVBY2NlbGUKICAg ICB0ZXh0dXJlRGVzYy5mRmxhZ3MgPSBrUmVuZGVyVGFyZ2V0X0dyUGxhdGZvcm1UZXh0dXJlRmxh ZzsKICAgICB0ZXh0dXJlRGVzYy5mV2lkdGggPSBjYW52YXNTaXplLndpZHRoKCk7CiAgICAgdGV4 dHVyZURlc2MuZkhlaWdodCA9IGNhbnZhc1NpemUuaGVpZ2h0KCk7Ci0gICAgdGV4dHVyZURlc2Mu ZkNvbmZpZyA9IGtSR0JBXzg4ODhfR3JQaXhlbENvbmZpZzsKKyAgICB0ZXh0dXJlRGVzYy5mQ29u ZmlnID0ga1NraWE4ODg4X1BNX0dyUGl4ZWxDb25maWc7CiAgICAgdGV4dHVyZURlc2MuZlRleHR1 cmVIYW5kbGUgPSB0ZXh0dXJlLT50ZXh0dXJlSWQoKTsKICAgICBTa0F1dG9UVW5yZWY8R3JUZXh0 dXJlPiB0YXJnZXQoZ3JDb250ZXh0LT5jcmVhdGVQbGF0Zm9ybVRleHR1cmUodGV4dHVyZURlc2Mp KTsKICAgICBTa0F1dG9UVW5yZWY8U2tEZXZpY2U+IGRldmljZShuZXcgU2tHcHVEZXZpY2UoZ3JD b250ZXh0LCB0YXJnZXQuZ2V0KCkpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnMuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVy U3VyZmFjZUZpbHRlcnMuY3BwCShyZXZpc2lvbiAxMTA2MDApCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2VGaWx0ZXJzLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjAyLDcgKzIwMiw3IEBAIFNrQml0bWFwIENDUmVuZGVyU3VyZmFj ZUZpbHRlcnM6OmFwcGx5KGMKICAgICAgICAgZGVzYy5mU2FtcGxlQ250ID0gMDsKICAgICAgICAg ZGVzYy5mV2lkdGggPSBzaXplLndpZHRoKCk7CiAgICAgICAgIGRlc2MuZkhlaWdodCA9IHNpemUu aGVpZ2h0KCk7Ci0gICAgICAgIGRlc2MuZkNvbmZpZyA9IGtSR0JBXzg4ODhfR3JQaXhlbENvbmZp ZzsKKyAgICAgICAgZGVzYy5mQ29uZmlnID0ga1NraWE4ODg4X1BNX0dyUGl4ZWxDb25maWc7CiAg ICAgICAgIC8vIEZJWE1FOiBjb3VsZCB3ZSB1c2UgYXBwcm94aW1hdGUgbWF0Y2gsIGFuZCBmaXgg dGV4Y29vcmRzIG9uIGRyYXcKICAgICAgICAgZGVzdCA9IGdyLT5sb2NrU2NyYXRjaFRleHR1cmUo ZGVzYywgR3JDb250ZXh0OjprRXhhY3RfU2NyYXRjaFRleE1hdGNoKTsKICAgICAgICAgaWYgKCFk ZXN0LnRleHR1cmUoKSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Nr aWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAJKHJldmlzaW9uIDExMDYwMCkK KysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lh LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTQsMTAgKzk0LDEwIEBAIHN0YXRpYyBTa0NhbnZhcyog Y3JlYXRlQWNjZWxlcmF0ZWRDYW52YXMKICAgICBnci0+cmVzZXRDb250ZXh0KCk7CiAgICAgR3JU ZXh0dXJlRGVzYyBkZXNjOwogICAgIGRlc2MuZkZsYWdzID0ga1JlbmRlclRhcmdldF9HclRleHR1 cmVGbGFnQml0OwotICAgIGRlc2MuZkFBTGV2ZWwgPSBrTm9uZV9HckFBTGV2ZWw7CisgICAgZGVz Yy5mU2FtcGxlQ250ID0gMDsKICAgICBkZXNjLmZXaWR0aCA9IHNpemUud2lkdGgoKTsKICAgICBk ZXNjLmZIZWlnaHQgPSBzaXplLmhlaWdodCgpOwotICAgIGRlc2MuZkNvbmZpZyA9IGtSR0JBXzg4 ODhfR3JQaXhlbENvbmZpZzsKKyAgICBkZXNjLmZDb25maWcgPSBrU2tpYTg4ODhfUE1fR3JQaXhl bENvbmZpZzsKICAgICBTa0F1dG9UVW5yZWY8R3JUZXh0dXJlPiB0ZXh0dXJlKGdyLT5jcmVhdGVV bmNhY2hlZFRleHR1cmUoZGVzYywgMCwgMCkpOwogICAgIGlmICghdGV4dHVyZS5nZXQoKSkKICAg ICAgICAgcmV0dXJuIDA7Cg==