81024 2012-03-13 12:41:43 -0700 fast/loader/form-submission-after-beforeunload-cancel.html is flaky 2012-03-13 16:11:45 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 fishd fishd aestes ap webkit.review.bot oldest_to_newest 577680 0 fishd 2012-03-13 12:41:43 -0700 fast/loader/form-submission-after-beforeunload-cancel.html is flaky On my system, it sometimes fails like this: CONFIRM NAVIGATION: Click 'Stay on Page' -CONFIRM NAVIGATION: Click 'Leave Page' -PASS +This tests that submitting a form a second time after canceling the first submission in a onbeforeunload handler is allowed. To test manually, follow the instructions in the JavaScript confirmation dialogs. + +FAIL + It looks like there is a race between the network stack (file:// loading) and the setTimeout(..., 0) that stamps the FAIL text. 577685 1 fishd 2012-03-13 12:45:29 -0700 Also, when the test fails, the next test run by DRT ends up with the following text prepended: CONFIRM NAVIGATION: Click 'Leave Page' PASS This suggests that the setTimeout code is running, trigging the notifyDone(), and then the form submission goes through. 577737 2 131702 fishd 2012-03-13 13:24:47 -0700 Created attachment 131702 v1 patch: increase timeout I'm not a big fan of patches like this. Obviously, disk reads could still in exceptional cases take longer than 1 second, but this makes the test far more stable. 577786 3 131702 aestes 2012-03-13 13:52:12 -0700 Comment on attachment 131702 v1 patch: increase timeout The one second timeout is indeed unfortunate, but since it only applies to the failure case and gets rid of the flakiness, this seems okay. 577950 4 131702 webkit.review.bot 2012-03-13 16:11:40 -0700 Comment on attachment 131702 v1 patch: increase timeout Clearing flags on attachment: 131702 Committed r110633: <http://trac.webkit.org/changeset/110633> 577952 5 webkit.review.bot 2012-03-13 16:11:45 -0700 All reviewed patches have been landed. Closing bug. 131702 2012-03-13 13:24:47 -0700 2012-03-13 16:11:40 -0700 v1 patch: increase timeout flake_1.txt text/plain 1304 fishd SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExMDU5MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTEzICBEYXJpbiBGaXNoZXIgIDxk YXJpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgZmFzdC9sb2FkZXIvZm9ybS1zdWJtaXNzaW9u LWFmdGVyLWJlZm9yZXVubG9hZC1jYW5jZWwuaHRtbCBpcyBmbGFreQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEwMjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbG9hZGVyL2Zvcm0tc3VibWlz c2lvbi1hZnRlci1iZWZvcmV1bmxvYWQtY2FuY2VsLmh0bWw6CisgICAgICAgIEdpdmUgdGhlIGZv cm0gcG9zdCBhIGJldHRlciBjaGFuY2Ugb2YgbG9hZGluZyBiZWZvcmUgdGhlIEZBSUwgdGltZXIu CisKIDIwMTItMDMtMTMgIFBoaWxpcCBSb2dlcnMgIDxwZHJAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBGaXggdGhlIHVzZSBvZiBzdGFsZSB0ZXh0IGZyYWdtZW50cwpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9sb2FkZXIvZm9ybS1zdWJtaXNzaW9uLWFmdGVyLWJlZm9yZXVubG9hZC1jYW5jZWwuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9mb3JtLXN1Ym1pc3Npb24t YWZ0ZXItYmVmb3JldW5sb2FkLWNhbmNlbC5odG1sCShyZXZpc2lvbiAxMTA0MDMpCisrKyBMYXlv dXRUZXN0cy9mYXN0L2xvYWRlci9mb3JtLXN1Ym1pc3Npb24tYWZ0ZXItYmVmb3JldW5sb2FkLWNh bmNlbC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yMCw3ICsyMCw3IEBAIHdpbmRvdy5hZGRFdmVu dExpc3RlbmVyKCJiZWZvcmV1bmxvYWQiLAogICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImNvbnNvbGUiKS5pbm5lckhUTUwgPSAiRkFJTCI7CiAgICAgICAgICAgICBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250 cm9sbGVyLm5vdGlmeURvbmUoKTsKLSAgICAgICAgfSwgMCk7CisgICAgICAgIH0sIDEwMDApOwog CiAgICAgICAgIGRvY3VtZW50LmZvcm1zWzBdLnN1Ym1pdCgpOwogICAgIH0sIDApOwo=