81017 2012-03-13 11:55:16 -0700 Revert RenderLayer::absoluteBoundingBox to an IntRect 2012-03-13 15:53:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw darin eae eric jchaffraix simon.fraser webkit.review.bot oldest_to_newest 577621 0 leviw 2012-03-13 11:55:16 -0700 RenderLayer::absoluteBoundingBox represents a layer's box in application coordinates and is used mostly by platform code. This change pixel snaps the rect and returns it as an IntRect to avoid exposing sub-pixel units to platform code, and because absolute coordinates make more senes to be in pixels (see also absoluteRects, which uses IntRect). 577649 1 131690 leviw 2012-03-13 12:16:22 -0700 Created attachment 131690 Patch 577651 2 131690 eric 2012-03-13 12:17:16 -0700 Comment on attachment 131690 Patch OK. 577653 3 131690 leviw 2012-03-13 12:17:47 -0700 Comment on attachment 131690 Patch Thanks Eric :) 577934 4 131690 webkit.review.bot 2012-03-13 15:53:50 -0700 Comment on attachment 131690 Patch Clearing flags on attachment: 131690 Committed r110629: <http://trac.webkit.org/changeset/110629> 577935 5 webkit.review.bot 2012-03-13 15:53:55 -0700 All reviewed patches have been landed. Closing bug. 131690 2012-03-13 12:16:22 -0700 2012-03-13 15:53:50 -0700 Patch bug-81017-20120313121621.patch text/plain 3524 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDU4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTAzLTEzICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZlcnQgUmVuZGVyTGF5 ZXI6OmFic29sdXRlQm91bmRpbmdCb3ggdG8gYW4gSW50UmVjdAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEwMTcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXZlcnRpbmcgUmVuZGVyTGF5ZXI6OmFic29s dXRlQm91bmRpbmdCb3ggdG8gYW4gKHBpeGVsIHNuYXBwZWQpIEludFJlY3QuIFdoZW5ldmVyCisg ICAgICAgIHBvc3NpYmxlLCB3ZSB1c2UgaW50ZWdlcnMgcmVwcmVzZW50aW5nIGZvciBhYnNvbHV0 ZSBjb29yZGluYXRlcy4gVGhpcyBpcyBlc3BlY2lhbGx5CisgICAgICAgIHJlbGV2YW50IGZvciBt ZXRob2RzLCBzdWNoIGFzIHRoaXMgb25lLCB0aGF0IGFyZSBleHBvcnRlZCBhbmQgdXNlZCBpbiBw bGF0Zm9ybSBjb2RlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2 aW9yLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckxheWVyOjphYnNvbHV0ZUJvdW5kaW5nQm94KToKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuaDoKKyAgICAgICAgKFJlbmRlckxheWVyKToKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21wb3NpdGluZ0ZvclBvc2l0aW9uKTogVGhp cyBpbnRlcnNlY3RzCisgICAgICAgIHRoZSBhYnNvbHV0ZSBib3VuZGluZyBib3ggd2l0aCB0aGUg RnJhbWVWaWV3LCB3aGljaCB1c2VzIGFsbCBpbnRlZ2VyIHZhbHVlcy4gSXQncworICAgICAgICB0 aGUgb25seSB1c2Ugb2YgYWJzb2x1dGVCb3VuZGluZ0JveCBpbiBXZWJDb3JlLgorCiAyMDEyLTAz LTEzICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIE1l ZGlhU3RyZWFtIEFQSTogUmVuYW1lIFBlZXJDb25uZWN0aW9uIHRvIERlcHJlY2F0ZWRQZWVyQ29u bmVjdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShy ZXZpc2lvbiAxMTA0NDgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTE5LDkgKzM5MTksOSBAQCBMYXlvdXRSZWN0IFJlbmRl ckxheWVyOjpib3VuZGluZ0JveChjb25zCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotTGF5b3V0 UmVjdCBSZW5kZXJMYXllcjo6YWJzb2x1dGVCb3VuZGluZ0JveCgpIGNvbnN0CitJbnRSZWN0IFJl bmRlckxheWVyOjphYnNvbHV0ZUJvdW5kaW5nQm94KCkgY29uc3QKIHsKLSAgICByZXR1cm4gYm91 bmRpbmdCb3gocm9vdCgpKTsKKyAgICByZXR1cm4gcGl4ZWxTbmFwcGVkSW50UmVjdChib3VuZGlu Z0JveChyb290KCkpKTsKIH0KIAogdm9pZCBSZW5kZXJMYXllcjo6Y2xlYXJDbGlwUmVjdHNJbmNs dWRpbmdEZXNjZW5kYW50cygpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuaAkocmV2aXNpb24gMTEwNDQ4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3NSw4ICs0NzUsOCBAQCBwdWJsaWM6CiAgICAg TGF5b3V0UmVjdCBib3VuZGluZ0JveChjb25zdCBSZW5kZXJMYXllciogcm9vdExheWVyKSBjb25z dDsKICAgICAvLyBCb3VuZGluZyBib3ggaW4gdGhlIGNvb3JkaW5hdGVzIG9mIHRoaXMgbGF5ZXIu CiAgICAgTGF5b3V0UmVjdCBsb2NhbEJvdW5kaW5nQm94KCkgY29uc3Q7Ci0gICAgLy8gQm91bmRp bmcgYm94IHJlbGF0aXZlIHRvIHRoZSByb290LgotICAgIExheW91dFJlY3QgYWJzb2x1dGVCb3Vu ZGluZ0JveCgpIGNvbnN0OworICAgIC8vIFBpeGVsIHNuYXBwZWQgYm91bmRpbmcgYm94IHJlbGF0 aXZlIHRvIHRoZSByb290LgorICAgIEludFJlY3QgYWJzb2x1dGVCb3VuZGluZ0JveCgpIGNvbnN0 OwogCiAgICAgdm9pZCB1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKGNvbnN0IEhpdFRlc3RSZXF1ZXN0 JiwgSGl0VGVzdFJlc3VsdCYpOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkocmV2aXNpb24gMTEwNDQ4KQorKysgU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTE2MDksNyArMTYwOSw3IEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpy ZXF1aXJlc0NvbXAKIAogICAgIC8vIEZpeGVkIHBvc2l0aW9uIGVsZW1lbnRzIHRoYXQgYXJlIGlu dmlzaWJsZSBpbiB0aGUgY3VycmVudCB2aWV3IGRvbid0IGdldCB0aGVpciBvd24gbGF5ZXIuCiAg ICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSBtX3JlbmRlclZpZXctPmZyYW1lVmlldygpOwotICAg IGlmIChmcmFtZVZpZXcgJiYgIWxheWVyLT5hYnNvbHV0ZUJvdW5kaW5nQm94KCkuaW50ZXJzZWN0 cyhMYXlvdXRSZWN0KGZyYW1lVmlldy0+c2Nyb2xsWEZvckZpeGVkUG9zaXRpb24oKSwgZnJhbWVW aWV3LT5zY3JvbGxZRm9yRml4ZWRQb3NpdGlvbigpLCBmcmFtZVZpZXctPmxheW91dFdpZHRoKCks IGZyYW1lVmlldy0+bGF5b3V0SGVpZ2h0KCkpKSkKKyAgICBpZiAoZnJhbWVWaWV3ICYmICFsYXll ci0+YWJzb2x1dGVCb3VuZGluZ0JveCgpLmludGVyc2VjdHMoSW50UmVjdChmcmFtZVZpZXctPnNj cm9sbFhGb3JGaXhlZFBvc2l0aW9uKCksIGZyYW1lVmlldy0+c2Nyb2xsWUZvckZpeGVkUG9zaXRp b24oKSwgZnJhbWVWaWV3LT5sYXlvdXRXaWR0aCgpLCBmcmFtZVZpZXctPmxheW91dEhlaWdodCgp KSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIHJldHVybiB0cnVlOwo=