81010 2012-03-13 10:34:53 -0700 REGRESSION(r110469): This patch still appears to crash (Requested by abarth on #webkit). 2012-03-14 02:44:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 78315 1 webkit.review.bot webkit.review.bot abarth morrita simon.fraser thorton zimmermann oldest_to_newest 577512 0 webkit.review.bot 2012-03-13 10:34:53 -0700 http://trac.webkit.org/changeset/110469 broke the build: This patch still appears to crash (Requested by abarth on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 577514 1 131660 webkit.review.bot 2012-03-13 10:35:25 -0700 Created attachment 131660 ROLLOUT of r110469 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 577516 2 abarth 2012-03-13 10:36:41 -0700 We're seeing a similar set of crashes as when this patch landed previously. I'm rolling it out to see if that fixes the crashes again. Here are some of the crash stacks: https://gist.github.com/2028708 577558 3 131660 webkit.review.bot 2012-03-13 11:06:01 -0700 Comment on attachment 131660 ROLLOUT of r110469 Clearing flags on attachment: 131660 Committed r110581: <http://trac.webkit.org/changeset/110581> 577559 4 webkit.review.bot 2012-03-13 11:06:06 -0700 All reviewed patches have been landed. Closing bug. 577616 5 simon.fraser 2012-03-13 11:51:37 -0700 s/crash/assertions I'd love to see some help on getting these resolved, rather than just reverting every time. 577650 6 zimmermann 2012-03-13 12:16:47 -0700 (In reply to comment #5) > s/crash/assertions > > I'd love to see some help on getting these resolved, rather than just reverting every time. Yop. I already fixed the v8 problem, and had a r+ patch on the original bug report, 12437, was about to land it :( 577703 7 thorton 2012-03-13 12:57:14 -0700 (In reply to comment #6) > (In reply to comment #5) > > s/crash/assertions > > > > I'd love to see some help on getting these resolved, rather than just reverting every time. > > Yop. I already fixed the v8 problem, and had a r+ patch on the original bug report, 12437, was about to land it :( Niko, is this rollout related to that? I thought this was separate (though still something I need help with). 577706 8 zimmermann 2012-03-13 12:58:48 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > s/crash/assertions > > > > > > I'd love to see some help on getting these resolved, rather than just reverting every time. > > > > Yop. I already fixed the v8 problem, and had a r+ patch on the original bug report, 12437, was about to land it :( > > Niko, is this rollout related to that? I thought this was separate (though still something I need help with). Sorry, I mixed up the patches. Adam reverted the SVGImage patch, not the animVal patch. The regressions due to the animVal patch should be fixed now, I landed the patch some minutes ago. 577759 9 abarth 2012-03-13 13:39:54 -0700 > I'd love to see some help on getting these resolved, rather than just reverting every time. I don't think I'll be much help in resolving this issue. I don't know much about SVG or painting. Maybe emailing webkit-dev would turn up someone who can help? 578275 10 morrita 2012-03-14 02:44:58 -0700 (In reply to comment #9) > > I'd love to see some help on getting these resolved, rather than just reverting every time. > > I don't think I'll be much help in resolving this issue. I don't know much about SVG or painting. Maybe emailing webkit-dev would turn up someone who can help? I'll take a look at this in next week since my local SL can have repro. 131660 2012-03-13 10:35:25 -0700 2012-03-13 11:06:01 -0700 ROLLOUT of r110469 bug-81010-20120313173753.patch text/plain 11289 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRiZTBiYTY2Y2QxZWUx ZjA3NjE5MjZjNGZmZTlhZTA2NzY5OTA2ZC4uNDAyM2Q1NmM2ZmZiOWM2Y2JiOTU1YmIzYWEyOGFj MWZmOTdmNWQzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEyLTAzLTEzICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTEwNDY5LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMTA0NjkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgxMDEwCisKKyAgICAgICAgVGhpcyBwYXRjaCBzdGlsbCBhcHBlYXJzIHRvIGNy YXNoIChSZXF1ZXN0ZWQgYnkgYWJhcnRoIG9uCisgICAgICAgICN3ZWJraXQpLgorCisgICAgICAg ICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpGcmFt ZVZpZXcpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpyZXNldCk6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZVZpZXc6OnJlcGFpbnRDb250ZW50UmVjdGFuZ2xlKToKKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjplbmREZWZlcnJlZFJlcGFpbnRz KToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6ZG9EZWZlcnJlZFJlcGFpbnRzKToKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6ZGVmZXJyZWRSZXBhaW50VGltZXJGaXJlZCk6Cisg ICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAgICAgKEZyYW1lVmlldyk6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmll dzo6c2hvdWxkUmVwYWludCk6CisgICAgICAgICogc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNWR0ltYWdlOjpkcmF3U1ZHVG9JbWFnZUJ1ZmZlcik6CisgICAg ICAgIChXZWJDb3JlOjpTVkdJbWFnZTo6ZHJhdyk6CisgICAgICAgICogc3ZnL2dyYXBoaWNzL1NW R0ltYWdlLmg6CisgICAgICAgICogc3ZnL2dyYXBoaWNzL1NWR0ltYWdlQ2FjaGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U1ZHSW1hZ2VDYWNoZTo6aW1hZ2VDb250ZW50Q2hhbmdlZCk6CisgICAg ICAgIChXZWJDb3JlOjpTVkdJbWFnZUNhY2hlOjpyZWRyYXdUaW1lckZpcmVkKToKKyAgICAgICAg KiBzdmcvZ3JhcGhpY3MvU1ZHSW1hZ2VDYWNoZS5oOgorICAgICAgICAoU1ZHSW1hZ2VDYWNoZSk6 CisKIDIwMTItMDMtMTMgIEtvbnJhZCBQaWFzY2lrICA8a3BpYXNjaWtAcmltLmNvbT4KIAogICAg ICAgICBbQmxhY2tCZXJyeV0gUmVtb3ZlIHN1YmxheWVycyBiZWZvcmUgY2xhbXBpbmcganVzdCBp biBjYXNlIHRoZSBsYXllciBhbHJlYWR5IGV4aXN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw CmluZGV4IGQ5OTg0MWFlZDcyMzVmMzI0YmIyYzAzMjI3ZmIzZGNiZjMyYTg5N2EuLjVlY2JjYTM2 MzYxYzVkOWI4YzhjNDdlZWExNGFmNjI1ZGYwMzYyYWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5jcHAKQEAgLTEzOCw3ICsxMzgsNiBAQCBGcmFtZVZpZXc6OkZyYW1lVmlldyhGcmFtZSogZnJh bWUpCiAgICAgLCBtX3dhc1Njcm9sbGVkQnlVc2VyKGZhbHNlKQogICAgICwgbV9pblByb2dyYW1t YXRpY1Njcm9sbChmYWxzZSkKICAgICAsIG1fZGVmZXJyZWRSZXBhaW50VGltZXIodGhpcywgJkZy YW1lVmlldzo6ZGVmZXJyZWRSZXBhaW50VGltZXJGaXJlZCkKLSAgICAsIG1fZGlzYWJsZVJlcGFp bnRzKDApCiAgICAgLCBtX2lzVHJhY2tpbmdSZXBhaW50cyhmYWxzZSkKICAgICAsIG1fc2hvdWxk VXBkYXRlV2hpbGVPZmZzY3JlZW4odHJ1ZSkKICAgICAsIG1fZGVmZXJTZXROZWVkc0xheW91dHMo MCkKQEAgLTI0NSw3ICsyNDQsNiBAQCB2b2lkIEZyYW1lVmlldzo6cmVzZXQoKQogICAgIG1faXNW aXN1YWxseU5vbkVtcHR5ID0gZmFsc2U7CiAgICAgbV9maXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlv dXRDYWxsYmFja1BlbmRpbmcgPSB0cnVlOwogICAgIG1fbWFpbnRhaW5TY3JvbGxQb3NpdGlvbkFu Y2hvciA9IDA7Ci0gICAgbV9kaXNhYmxlUmVwYWludHMgPSAwOwogfQogCiBib29sIEZyYW1lVmll dzo6aXNGcmFtZVZpZXcoKSBjb25zdCAKQEAgLTE3NTYsNyArMTc1NCw3IEBAIGNvbnN0IHVuc2ln bmVkIGNSZXBhaW50UmVjdFVuaW9uVGhyZXNob2xkID0gMjU7CiB2b2lkIEZyYW1lVmlldzo6cmVw YWludENvbnRlbnRSZWN0YW5nbGUoY29uc3QgSW50UmVjdCYgciwgYm9vbCBpbW1lZGlhdGUpCiB7 CiAgICAgQVNTRVJUKCFtX2ZyYW1lLT5vd25lckVsZW1lbnQoKSk7Ci0KKyAgICAKICAgICBpZiAo bV9pc1RyYWNraW5nUmVwYWludHMpIHsKICAgICAgICAgSW50UmVjdCByZXBhaW50UmVjdCA9IHI7 CiAgICAgICAgIHJlcGFpbnRSZWN0Lm1vdmUoLXNjcm9sbE9mZnNldCgpKTsKQEAgLTE3ODIsMTAg KzE3ODAsOSBAQCB2b2lkIEZyYW1lVmlldzo6cmVwYWludENvbnRlbnRSZWN0YW5nbGUoY29uc3Qg SW50UmVjdCYgciwgYm9vbCBpbW1lZGlhdGUpCiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIG1f cmVwYWludFJlY3RzWzBdLnVuaXRlKHBhaW50UmVjdCk7CiAgICAgICAgIG1fcmVwYWludENvdW50 Kys7Ci0KLSAgICAgICAgaWYgKCFtX2RlZmVycmluZ1JlcGFpbnRzKQotICAgICAgICAgICAgc3Rh cnREZWZlcnJlZFJlcGFpbnRUaW1lcihkZWxheSk7Ci0KKyAgICAKKyAgICAgICAgaWYgKCFtX2Rl ZmVycmluZ1JlcGFpbnRzICYmICFtX2RlZmVycmVkUmVwYWludFRpbWVyLmlzQWN0aXZlKCkpCisg ICAgICAgICAgICAgbV9kZWZlcnJlZFJlcGFpbnRUaW1lci5zdGFydE9uZVNob3QoZGVsYXkpOwog ICAgICAgICByZXR1cm47CiAgICAgfQogICAgIApAQCAtMTgzOCw2ICsxODM1LDcgQEAgdm9pZCBG cmFtZVZpZXc6OmJlZ2luRGVmZXJyZWRSZXBhaW50cygpCiAgICAgbV9kZWZlcnJpbmdSZXBhaW50 cysrOwogfQogCisKIHZvaWQgRnJhbWVWaWV3OjplbmREZWZlcnJlZFJlcGFpbnRzKCkKIHsKICAg ICBQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpOwpAQCAtMTg1MCwyNiArMTg0OCwxOCBAQCB2 b2lkIEZyYW1lVmlldzo6ZW5kRGVmZXJyZWRSZXBhaW50cygpCiAKICAgICBpZiAoLS1tX2RlZmVy cmluZ1JlcGFpbnRzKQogICAgICAgICByZXR1cm47CisgICAgCisgICAgaWYgKG1fZGVmZXJyZWRS ZXBhaW50VGltZXIuaXNBY3RpdmUoKSkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgaWYgKGRvdWJs ZSBkZWxheSA9IGFkanVzdGVkRGVmZXJyZWRSZXBhaW50RGVsYXkoKSkgewotICAgICAgICBzdGFy dERlZmVycmVkUmVwYWludFRpbWVyKGRlbGF5KTsKKyAgICAgICAgbV9kZWZlcnJlZFJlcGFpbnRU aW1lci5zdGFydE9uZVNob3QoZGVsYXkpOwogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIAog ICAgIGRvRGVmZXJyZWRSZXBhaW50cygpOwogfQogCi12b2lkIEZyYW1lVmlldzo6c3RhcnREZWZl cnJlZFJlcGFpbnRUaW1lcihkb3VibGUgZGVsYXkpCi17Ci0gICAgaWYgKG1fZGVmZXJyZWRSZXBh aW50VGltZXIuaXNBY3RpdmUoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgaWYgKG1fZGlzYWJs ZVJlcGFpbnRzKQotICAgICAgICByZXR1cm47Ci0KLSAgICBtX2RlZmVycmVkUmVwYWludFRpbWVy LnN0YXJ0T25lU2hvdChkZWxheSk7Ci19Ci0KIHZvaWQgRnJhbWVWaWV3OjpjaGVja1N0b3BEZWxh eWluZ0RlZmVycmVkUmVwYWludHMoKQogewogICAgIGlmICghbV9kZWZlcnJlZFJlcGFpbnRUaW1l ci5pc0FjdGl2ZSgpKQpAQCAtMTg4Niw5ICsxODc2LDYgQEAgdm9pZCBGcmFtZVZpZXc6OmNoZWNr U3RvcERlbGF5aW5nRGVmZXJyZWRSZXBhaW50cygpCiAgICAgCiB2b2lkIEZyYW1lVmlldzo6ZG9E ZWZlcnJlZFJlcGFpbnRzKCkKIHsKLSAgICBpZiAobV9kaXNhYmxlUmVwYWludHMpCi0gICAgICAg IHJldHVybjsKLQogICAgIEFTU0VSVCghbV9kZWZlcnJpbmdSZXBhaW50cyk7CiAgICAgaWYgKCFz aG91bGRVcGRhdGUoKSkgewogICAgICAgICBtX3JlcGFpbnRSZWN0cy5jbGVhcigpOwpAQCAtMTk0 NywxOCArMTkzNCw3IEBAIGRvdWJsZSBGcmFtZVZpZXc6OmFkanVzdGVkRGVmZXJyZWRSZXBhaW50 RGVsYXkoKSBjb25zdAogdm9pZCBGcmFtZVZpZXc6OmRlZmVycmVkUmVwYWludFRpbWVyRmlyZWQo VGltZXI8RnJhbWVWaWV3PiopCiB7CiAgICAgZG9EZWZlcnJlZFJlcGFpbnRzKCk7Ci19Ci0KLXZv aWQgRnJhbWVWaWV3OjpiZWdpbkRpc2FibGVSZXBhaW50cygpCi17Ci0gICAgbV9kaXNhYmxlUmVw YWludHMrKzsKLX0KLQotdm9pZCBGcmFtZVZpZXc6OmVuZERpc2FibGVSZXBhaW50cygpCi17Ci0g ICAgQVNTRVJUKG1fZGlzYWJsZVJlcGFpbnRzID4gMCk7Ci0gICAgbV9kaXNhYmxlUmVwYWludHMt LTsKLX0KK30gICAgCiAKIHZvaWQgRnJhbWVWaWV3OjpsYXlvdXRUaW1lckZpcmVkKFRpbWVyPEZy YW1lVmlldz4qKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu aCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKaW5kZXggZDNhZjU5OTUxOTljOWM0 NTQ3ZjA1ZjdlMDlmNjYzNzhiOGFkZGRkYS4uMWY5MGJjM2I4MGE2MDM4OTgxNWE4MDkxMzUzMWNj YmQwYjU3MDQ0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCkBAIC0yMDEsMTMgKzIwMSw4IEBA IHB1YmxpYzoKICAgICB2b2lkIGJlZ2luRGVmZXJyZWRSZXBhaW50cygpOwogICAgIHZvaWQgZW5k RGVmZXJyZWRSZXBhaW50cygpOwogICAgIHZvaWQgY2hlY2tTdG9wRGVsYXlpbmdEZWZlcnJlZFJl cGFpbnRzKCk7Ci0gICAgdm9pZCBzdGFydERlZmVycmVkUmVwYWludFRpbWVyKGRvdWJsZSBkZWxh eSk7CiAgICAgdm9pZCByZXNldERlZmVycmVkUmVwYWludERlbGF5KCk7CiAKLSAgICB2b2lkIGJl Z2luRGlzYWJsZVJlcGFpbnRzKCk7Ci0gICAgdm9pZCBlbmREaXNhYmxlUmVwYWludHMoKTsKLSAg ICBib29sIHJlcGFpbnRzRGlzYWJsZWQoKSB7IHJldHVybiBtX2Rpc2FibGVSZXBhaW50cyA+IDA7 IH0KLQogI2lmIEVOQUJMRShEQVNIQk9BUkRfU1VQUE9SVCkKICAgICB2b2lkIHVwZGF0ZURhc2hi b2FyZFJlZ2lvbnMoKTsKICNlbmRpZgpAQCAtNDcxLDkgKzQ2Niw3IEBAIHByaXZhdGU6CiAgICAg VGltZXI8RnJhbWVWaWV3PiBtX2RlZmVycmVkUmVwYWludFRpbWVyOwogICAgIGRvdWJsZSBtX2Rl ZmVycmVkUmVwYWludERlbGF5OwogICAgIGRvdWJsZSBtX2xhc3RQYWludFRpbWU7Ci0KLSAgICB1 bnNpZ25lZCBtX2Rpc2FibGVSZXBhaW50czsKLQorICAgIAogICAgIGJvb2wgbV9pc1RyYWNraW5n UmVwYWludHM7IC8vIFVzZWQgZm9yIHRlc3RpbmcuCiAgICAgVmVjdG9yPEludFJlY3Q+IG1fdHJh Y2tlZFJlcGFpbnRSZWN0czsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3Bw CmluZGV4IDBkZjlkMDJhNjIwZWZiOTUyNTk3NmY2YjZjYjVlNTgzODBiY2I0ZDIuLmNkMzg5M2E1 NTVkNjBmMWFiODlmMjYxNjNlNzBlNDI3YTI1OGRjYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVmlldy5jcHAKQEAgLTI5OCwxMCArMjk4LDcgQEAgYm9vbCBSZW5kZXJWaWV3Ojpz aG91bGRSZXBhaW50KGNvbnN0IEludFJlY3QmIHIpIGNvbnN0CiAKICAgICBpZiAoIW1fZnJhbWVW aWV3KQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICBpZiAobV9mcmFtZVZpZXctPnJlcGFp bnRzRGlzYWJsZWQoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCisgICAgCiAgICAgcmV0dXJu IHRydWU7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJ bWFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwCmluZGV4 IDVjYjgxMGE5N2U4MGQ5ZmZiNGJjMzE5NDE4ZGM0ZDEzNWMwZTYyN2MuLjU4NTc4MGZlYWFkODli NmNmOWMyMTM3ZThiMGY5YWQzZWY1MWVmZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2 Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNz L1NWR0ltYWdlLmNwcApAQCAtMTc3LDE1ICsxNzcsMTAgQEAgdm9pZCBTVkdJbWFnZTo6ZHJhd1NW R1RvSW1hZ2VCdWZmZXIoSW1hZ2VCdWZmZXIqIGJ1ZmZlciwgY29uc3QgSW50U2l6ZSYgc2l6ZSwg ZmwKICAgICBJbWFnZU9ic2VydmVyKiBvYnNlcnZlciA9IGltYWdlT2JzZXJ2ZXIoKTsKICAgICBB U1NFUlQob2JzZXJ2ZXIpOwogCi0gICAgLy8gVGVtcG9yYXJpbHkgcmVzZXQgaW1hZ2Ugb2JzZXJ2 ZXIsIHdlIGRvbid0IHdhbnQgdG8gcmVjZWl2ZSBhbnkgY2hhbmdlSW5SZWN0KCkgY2FsbHMgZHVl IHRvIHRoaXMgcmVsYXlvdXQuCisgICAgLy8gVGVtcG9yYXJpbHkgcmVzZXQgaW1hZ2Ugb2JzZXJ2 ZXIsIHdlIGRvbid0IHdhbnQgdG8gcmVjZWl2ZSBhbnkgY2hhbmdlSW5SZWN0KCkgY2FsbHMgZHVl IHRoaXMgcmVsYXlvdXQuCiAgICAgc2V0SW1hZ2VPYnNlcnZlcigwKTsKLQotICAgIC8vIERpc2Fi bGUgcmVwYWludGluZzsgd2UgZG9uJ3Qgd2FudCBkZWZlcnJlZCByZXBhaW50cyB0byBzY2hlZHVs ZSBhbnkgdGltZXJzIGR1ZSB0byB0aGlzIHJlbGF5b3V0LgotICAgIGZyYW1lLT52aWV3KCktPmJl Z2luRGlzYWJsZVJlcGFpbnRzKCk7Ci0KICAgICByZW5kZXJlci0+c2V0Q29udGFpbmVyU2l6ZShz aXplKTsKICAgICBmcmFtZS0+dmlldygpLT5yZXNpemUodGhpcy0+c2l6ZSgpKTsKLQogICAgIGlm ICh6b29tICE9IDEpCiAgICAgICAgIGZyYW1lLT5zZXRQYWdlWm9vbUZhY3Rvcih6b29tKTsKIApA QCAtMjA3LDkgKzIwMiw3IEBAIHZvaWQgU1ZHSW1hZ2U6OmRyYXdTVkdUb0ltYWdlQnVmZmVyKElt YWdlQnVmZmVyKiBidWZmZXIsIGNvbnN0IEludFNpemUmIHNpemUsIGZsCiAgICAgaWYgKGZyYW1l LT52aWV3KCktPm5lZWRzTGF5b3V0KCkpCiAgICAgICAgIGZyYW1lLT52aWV3KCktPmxheW91dCgp OwogCi0gICAgc2V0SW1hZ2VPYnNlcnZlcihvYnNlcnZlcik7Ci0KLSAgICBmcmFtZS0+dmlldygp LT5lbmREaXNhYmxlUmVwYWludHMoKTsKKyAgICBzZXRJbWFnZU9ic2VydmVyKG9ic2VydmVyKTsg CiB9CiAKIHZvaWQgU1ZHSW1hZ2U6OmRyYXcoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25z dCBGbG9hdFJlY3QmIGRzdFJlY3QsIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgQ29sb3JTcGFj ZSwgQ29tcG9zaXRlT3BlcmF0b3IgY29tcG9zaXRlT3ApCkBAIC0yMTcsNyArMjEwLDcgQEAgdm9p ZCBTVkdJbWFnZTo6ZHJhdyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVj dCYgZHN0UmVjdCwgY29uc3QgRmwKICAgICBpZiAoIW1fcGFnZSkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgRnJhbWVWaWV3KiB2aWV3ID0gZnJhbWVWaWV3KCk7CisgICAgRnJhbWVWaWV3KiB2aWV3 ID0gbV9wYWdlLT5tYWluRnJhbWUoKS0+dmlldygpOwogCiAgICAgR3JhcGhpY3NDb250ZXh0U3Rh dGVTYXZlciBzdGF0ZVNhdmVyKCpjb250ZXh0KTsKICAgICBjb250ZXh0LT5zZXRDb21wb3NpdGVP cGVyYXRpb24oY29tcG9zaXRlT3ApOwpAQCAtMjYyLDE0ICsyNTUsNiBAQCBSZW5kZXJCb3gqIFNW R0ltYWdlOjplbWJlZGRlZENvbnRlbnRCb3goKSBjb25zdAogICAgIHJldHVybiB0b1JlbmRlckJv eChyb290RWxlbWVudC0+cmVuZGVyZXIoKSk7CiB9CiAKLUZyYW1lVmlldyogU1ZHSW1hZ2U6OmZy YW1lVmlldygpIGNvbnN0Ci17Ci0gICAgaWYgKCFtX3BhZ2UpCi0gICAgICAgIHJldHVybiAwOwot Ci0gICAgcmV0dXJuIG1fcGFnZS0+bWFpbkZyYW1lKCktPnZpZXcoKTsKLX0KLQogYm9vbCBTVkdJ bWFnZTo6aGFzUmVsYXRpdmVXaWR0aCgpIGNvbnN0CiB7CiAgICAgaWYgKCFtX3BhZ2UpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuaCBiL1NvdXJjZS9X ZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5oCmluZGV4IDBmZTdiNjliN2MwOGVmY2VmMjA5 NjQ3MjJkMjc2NTUwOWY4OTVmNDEuLjdlMTYwNDkzMTQzYzI2ODgwNzczYmY0NzYxOGM3MjkwZDBm NGI1MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5oCkBAIC0zNCw3ICsz NCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgRnJhbWVWaWV3OwogY2xhc3Mg SW1hZ2VCdWZmZXI7CiBjbGFzcyBQYWdlOwogY2xhc3MgUmVuZGVyQm94OwpAQCAtNTQsNyArNTMs NiBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGRyYXdTVkdUb0ltYWdlQnVmZmVyKEltYWdlQnVmZmVy KiwgY29uc3QgSW50U2l6ZSYsIGZsb2F0IHpvb20sIFNob3VsZENsZWFyQnVmZmVyKTsKICAgICBS ZW5kZXJCb3gqIGVtYmVkZGVkQ29udGVudEJveCgpIGNvbnN0OwotICAgIEZyYW1lVmlldyogZnJh bWVWaWV3KCkgY29uc3Q7CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNTVkdJbWFnZSgpIGNvbnN0IHsg cmV0dXJuIHRydWU7IH0KICAgICB2aXJ0dWFsIEludFNpemUgc2l6ZSgpIGNvbnN0OwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlQ2FjaGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlQ2FjaGUuY3BwCmluZGV4IGZiMzhmZDU1 NGI2Mjc2ZTA2ZDZjYTQ4YWU2NTIxNzJiMGQ2ODhjNGQuLjBkOTdhMGZlY2VmZGMxZGUxYjIyNzAx OTJiZmNmNDFkMDQ5MmI4YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGlj cy9TVkdJbWFnZUNhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZH SW1hZ2VDYWNoZS5jcHAKQEAgLTIxLDcgKzIxLDYgQEAKICNpbmNsdWRlICJTVkdJbWFnZUNhY2hl LmgiCiAKICNpZiBFTkFCTEUoU1ZHKQotI2luY2x1ZGUgIkZyYW1lVmlldy5oIgogI2luY2x1ZGUg IkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIkltYWdlQnVmZmVyLmgiCiAjaW5jbHVkZSAi UmVuZGVyU1ZHUm9vdC5oIgpAQCAtODIsMTggKzgxLDEzIEBAIHZvaWQgU1ZHSW1hZ2VDYWNoZTo6 aW1hZ2VDb250ZW50Q2hhbmdlZCgpCiAgICAgZm9yIChJbWFnZURhdGFNYXA6Oml0ZXJhdG9yIGl0 ID0gbV9pbWFnZURhdGFNYXAuYmVnaW4oKTsgaXQgIT0gZW5kOyArK2l0KQogICAgICAgICBpdC0+ c2Vjb25kLmltYWdlTmVlZHNVcGRhdGUgPSB0cnVlOwogCi0gICAgLy8gSWYgd2UncmUgaW4gdGhl IG1pZGRsZSBvZiBsYXlvdXQsIHN0YXJ0IHJlZHJhd2luZyBkaXJ0eQotICAgIC8vIGltYWdlcyBv biBhIHRpbWVyOyBvdGhlcndpc2UgaXQncyBzYWZlIHRvIGRyYXcgaW1tZWRpYXRlbHkuCi0KLSAg ICBGcmFtZVZpZXcqIGZyYW1lVmlldyA9IG1fc3ZnSW1hZ2UtPmZyYW1lVmlldygpOwotICAgIGlm IChmcmFtZVZpZXcgJiYgZnJhbWVWaWV3LT5uZWVkc0xheW91dCgpKSB7Ci0gICAgICAgIGlmICgh bV9yZWRyYXdUaW1lci5pc0FjdGl2ZSgpKQotICAgICAgICAgICAgbV9yZWRyYXdUaW1lci5zdGFy dE9uZVNob3QoMCk7Ci0gICAgfSBlbHNlCi0gICAgICAgcmVkcmF3KCk7CisgICAgLy8gU3RhcnQg cmVkcmF3aW5nIGRpcnR5IGltYWdlcyB3aXRoIGEgdGltZXIsIGFzIGltYWdlQ29udGVudENoYW5n ZWQoKSBtYXkgYmUgY2FsbGVkCisgICAgLy8gYnkgdGhlIEZyYW1lVmlldyBvZiB0aGUgU1ZHSW1h Z2Ugd2hpY2ggaXMgY3VycmVudGx5IGluIEZyYW1lVmlldzo6bGF5b3V0KCkuCisgICAgaWYgKCFt X3JlZHJhd1RpbWVyLmlzQWN0aXZlKCkpCisgICAgICAgIG1fcmVkcmF3VGltZXIuc3RhcnRPbmVT aG90KDApOwogfQogCi12b2lkIFNWR0ltYWdlQ2FjaGU6OnJlZHJhdygpCit2b2lkIFNWR0ltYWdl Q2FjaGU6OnJlZHJhd1RpbWVyRmlyZWQoVGltZXI8U1ZHSW1hZ2VDYWNoZT4qKQogewogICAgIElt YWdlRGF0YU1hcDo6aXRlcmF0b3IgZW5kID0gbV9pbWFnZURhdGFNYXAuZW5kKCk7CiAgICAgZm9y IChJbWFnZURhdGFNYXA6Oml0ZXJhdG9yIGl0ID0gbV9pbWFnZURhdGFNYXAuYmVnaW4oKTsgaXQg IT0gZW5kOyArK2l0KSB7CkBAIC0xMTEsMTEgKzEwNSw2IEBAIHZvaWQgU1ZHSW1hZ2VDYWNoZTo6 cmVkcmF3KCkKICAgICBtX3N2Z0ltYWdlLT5pbWFnZU9ic2VydmVyKCktPmFuaW1hdGlvbkFkdmFu Y2VkKG1fc3ZnSW1hZ2UpOwogfQogCi12b2lkIFNWR0ltYWdlQ2FjaGU6OnJlZHJhd1RpbWVyRmly ZWQoVGltZXI8U1ZHSW1hZ2VDYWNoZT4qKQotewotICAgIHJlZHJhdygpOwotfQotCiBJbWFnZSog U1ZHSW1hZ2VDYWNoZTo6bG9va3VwT3JDcmVhdGVCaXRtYXBJbWFnZUZvclJlbmRlcmVyKGNvbnN0 IFJlbmRlck9iamVjdCogcmVuZGVyZXIpCiB7CiAgICAgQVNTRVJUKHJlbmRlcmVyKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZUNhY2hlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2VDYWNoZS5oCmluZGV4IDQ2YjcwOTM0MWRk MWIzMjNhOTI1ZDNmZDQyOGYxMWUxMmU0OTI3YjcuLjUzZDIxNjE5YTEyNDgyYWYwNzQwZWI5ZjM2 YTg4YjQ0YmM2OWJkYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9T VkdJbWFnZUNhY2hlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdl Q2FjaGUuaApAQCAtNzAsNyArNzAsNiBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgU1ZHSW1h Z2VDYWNoZShTVkdJbWFnZSopOwotICAgIHZvaWQgcmVkcmF3KCk7CiAgICAgdm9pZCByZWRyYXdU aW1lckZpcmVkKFRpbWVyPFNWR0ltYWdlQ2FjaGU+Kik7CiAKICAgICBzdHJ1Y3QgSW1hZ2VEYXRh IHsK