81009 2012-03-13 10:10:05 -0700 3D transformed surfaces with z>0 gets cropped 2012-03-14 04:57:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 larsgk larsgk kenneth noam webkit.review.bot oldest_to_newest 577488 0 131652 larsgk 2012-03-13 10:10:05 -0700 Created attachment 131652 Test page exposing what happens when clipping is done with no respect for 3D transforms. When rendering surfaces with a transform z>0 and in perspective, making the surface larger on screen than the corresponding surface with only 2D transforms, the surface gets cropped to a maximum size/shape of the same surface with no perspective applied. Test page exposing problem attached. 577521 1 131662 larsgk 2012-03-13 10:40:36 -0700 Created attachment 131662 Patch 577522 2 131662 noam 2012-03-13 10:41:58 -0700 Comment on attachment 131662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131662&action=review LGTM - see nitpicks > Source/WebCore/ChangeLog:11 > + The scissor clipping in TextureMapperGL didn't > + take 3D transforms into account when calculating > + the clipping region. Now, it will bail out early > + if the transform is not affine. Weird line wrapping :) > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:607 > + if (!modelViewMatrix.isAffine()) Add a comment 577535 3 131665 larsgk 2012-03-13 10:52:53 -0700 Created attachment 131665 Patch 578313 4 131665 webkit.review.bot 2012-03-14 04:57:01 -0700 Comment on attachment 131665 Patch Clearing flags on attachment: 131665 Committed r110691: <http://trac.webkit.org/changeset/110691> 578314 5 webkit.review.bot 2012-03-14 04:57:06 -0700 All reviewed patches have been landed. Closing bug. 131652 2012-03-13 10:10:05 -0700 2012-03-13 10:10:05 -0700 Test page exposing what happens when clipping is done with no respect for 3D transforms. index.html text/html 2552 larsgk PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIKImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPgo8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+CiAgICA8 IS0tIERvbmUgYnkgTGFycyBLbnVkc2VuIGluIE1hcmNoLCAyMDEyIC0tPgogICAgPGhlYWQ+CiAg ICAgICAgPHRpdGxlPkNsaXBQcm9ibGVtPC90aXRsZT4KICAgICAgICA8bWV0YSBuYW1lPSJ2aWV3 cG9ydCIgY29udGVudCA9ICJ3aWR0aD05ODAsIHVzZXItc2NhbGFibGUgPSBubyIgLz4KICAgICAg ICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hh cnNldD1VVEYtOCIgLz4KPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KCmJvZHkgewogIGJhY2tncm91 bmQtY29sb3I6IHdoaXRlOwp9Cgojc3BhY2Vjb250YWluZXIgewogIG1hcmdpbjogMDsKICB3aWR0 aDogOTYwcHg7CiAgaGVpZ2h0OiA3ODBweDsKICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgdG9wOiAx MHB4OwogIGxlZnQ6IDEwcHg7CiAgYmFja2dyb3VuZC1jb2xvcjogYmxhY2s7CiAgLXdlYmtpdC1w ZXJzcGVjdGl2ZTogMzAwMDsKfQoKI3NwYWNlb2Zmc2V0IHsKICAtd2Via2l0LXRyYW5zZm9ybS1z dHlsZTogcHJlc2VydmUtM2Q7CiAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZVgoNDgwcHgp IHRyYW5zbGF0ZVkoMzkwcHgpOwp9Cgojc3BhY2VpdGVtIHsKICAtd2Via2l0LXRyYW5zZm9ybS1z dHlsZTogcHJlc2VydmUtM2Q7CiAgLXdlYmtpdC1hbmltYXRpb24tbmFtZTogcHVsc2U7CiAgLXdl YmtpdC1hbmltYXRpb24tZHVyYXRpb246IDRzOwogIC13ZWJraXQtYW5pbWF0aW9uLWl0ZXJhdGlv bi1jb3VudDogaW5maW5pdGU7CiAgLXdlYmtpdC1hbmltYXRpb24tdGltaW5nLWZ1bmN0aW9uOiBs aW5lYXI7CiAgLy8td2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWCgtNDAwcHgpIHRyYW5zbGF0 ZVkoLTIwMHB4KSB0cmFuc2xhdGVaKDQwMHB4KTsKICAvLy13ZWJraXQtdHJhbnNmb3JtOiB0cmFu c2xhdGVYKC00MDBweCkgdHJhbnNsYXRlWSgtMjAwcHgpIHNjYWxlKDEuMSk7CiAgcG9zaXRpb246 IGZpeGVkOwogIHdpZHRoOiA4MDBweDsKICBoZWlnaHQ6IDQwMHB4OwogIGJhY2tncm91bmQtY29s b3I6IHdoaXRlOwp9CgkKI3NwYWNlcmVmZXJlbmNlewogIC13ZWJraXQtdHJhbnNmb3JtLXN0eWxl OiBwcmVzZXJ2ZS0zZDsKICAtd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWCgtNDAwcHgpIHRy YW5zbGF0ZVkoLTMwMHB4KTsKICBwb3NpdGlvbjogZml4ZWQ7CiAgd2lkdGg6IDgwMHB4OwogIGhl aWdodDogMjBweDsKICBiYWNrZ3JvdW5kLWNvbG9yOiB3aGl0ZTsKfQoJCkAtd2Via2l0LWtleWZy YW1lcyBwdWxzZSB7CiAgMCUgICAgeyAtd2Via2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWCgtNDAw cHgpIHRyYW5zbGF0ZVkoLTIwMHB4KSB0cmFuc2xhdGVaKC00MDBweCl9CiAgNTAlICAgeyAtd2Vi a2l0LXRyYW5zZm9ybTogdHJhbnNsYXRlWCgtNDAwcHgpIHRyYW5zbGF0ZVkoLTIwMHB4KSB0cmFu c2xhdGVaKDQwMHB4KX0KICAxMDAlICB7IC13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGVYKC00 MDBweCkgdHJhbnNsYXRlWSgtMjAwcHgpIHRyYW5zbGF0ZVooLTQwMHB4KX0KfQoJCjwvc3R5bGU+ CiAgICA8L2hlYWQ+CiAgICA8Ym9keT4KICAgICAgPGRpdiBpZD0ic3BhY2Vjb250YWluZXIiPgog ICAgICAgIDxkaXYgaWQ9InNwYWNlb2Zmc2V0Ij4KICAgICAgICAgIDxkaXYgaWQ9InNwYWNlaXRl bSI+CiAgICAgICAgICAgIDxkaXYgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6cmVkOyB3aWR0aDox MDAlOyBoZWlnaHQ6MjBweDsiPlRoaXMgaXMgbGluZSAxIC0gMjBweCB0YWxsPC9kaXY+CiAgICAg ICAgICAgIDxkaXYgc3R5bGU9ImJhY2tncm91bmQtY29sb3I6Ymx1ZTsgd2lkdGg6MTAwJTsgaGVp Z2h0OjIwcHg7Ij5UaGlzIGlzIGxpbmUgMiAtIDIwcHggdGFsbDwvZGl2PgogICAgICAgICAgICA8 ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kLWNvbG9yOnJlZDsgd2lkdGg6MTAwJTsgaGVpZ2h0OjIwcHg7 Ij5UaGlzIGlzIGxpbmUgMyAtIDIwcHggdGFsbDwvZGl2PgogICAgICAgICAgICA8ZGl2IHN0eWxl PSJiYWNrZ3JvdW5kLWNvbG9yOmJsdWU7IHdpZHRoOjEwMCU7IGhlaWdodDoyMHB4OyI+VGhpcyBp cyBsaW5lIDQgLSAyMHB4IHRhbGw8L2Rpdj4KICAgICAgICAgICAgPGRpdiBzdHlsZT0id2lkdGg6 MTAwJTsgaGVpZ2h0OjUwcHg7Ij5XaGVuIHogPiAwLCB0aGUgY2xpcHBpbmcgc2VlbXMgdG8gY3V0 IHRvbyBtdWNoLjwvZGl2PgogICAgICAgICAgPC9kaXY+CiAgICAgICAgICA8ZGl2IGlkPSJzcGFj ZXJlZmVyZW5jZSI+CiAgICAgICAgICAgICAgVGhpcyBiYXIgaGFzIHRoZSBzYW1lIHdpZHRoIGFz IHRoZSBib3ggYmVsb3cgLSBidXQgc3RheXMgYXQgeiA9IDAKICAgICAgICAgIDwvZGl2PgogICAg ICAgIDwvZGl2PgogICAgICA8L2Rpdj4KICAgIDwvYm9keT4KPC9odG1sPgo= 131662 2012-03-13 10:40:36 -0700 2012-03-13 10:52:46 -0700 Patch bug-81009-20120313184338.patch text/plain 1714 larsgk U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQ3ODkxZGU4NWFjOGYz MjI5YTQwN2IwZjU2OThmODY5NWFmYTQ0NS4uZDNjZDcxNGVhNDNmNDU2MzkxY2M2ODhhYmI5NDU3 ZmJiMWExNjBkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAzLTEzICBMYXJz IEtudWRzZW4gIDxsYXJzLmtudWRzZW5Abm9raWEuY29tPgorCisgICAgICAgIDNEIHRyYW5zZm9y bWVkIHN1cmZhY2VzIHdpdGggej4wIGdldHMgY3JvcHBlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEwMDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2Npc3NvciBjbGlwcGluZyBpbiBUZXh0dXJl TWFwcGVyR0wgZGlkbid0CisgICAgICAgIHRha2UgM0QgdHJhbnNmb3JtcyBpbnRvIGFjY291bnQg d2hlbiBjYWxjdWxhdGluZworICAgICAgICB0aGUgY2xpcHBpbmcgcmVnaW9uLiAgTm93LCBpdCB3 aWxsIGJhaWwgb3V0IGVhcmx5CisgICAgICAgIGlmIHRoZSB0cmFuc2Zvcm0gaXMgbm90IGFmZmlu ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRlc3RlZCBieSBjdXJyZW50IGNvbXBvc2l0aW5n IGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0 dXJlTWFwcGVyR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckdMOjpiZWdp blNjaXNzb3JDbGlwKToKKwogMjAxMi0wMy0xMyAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgc25pcHBldHMgbW9kZWwu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckdMLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9UZXh0dXJlTWFwcGVyR0wuY3BwCmluZGV4IGM4YjhjZDliMDQ2OTQzZjhkMGQwZmIyYjBmOGU0 ODBjNTlkZDAwMjUuLjYzYjI3NGExY2IyOWY0NmNmOWNlOTU4YTZmNWJjYzM5OGU5ZDAzMWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9UZXh0dXJlTWFwcGVyR0wuY3BwCkBAIC02MDQsNiArNjA0LDkgQEAgdm9pZCBUZXh0dXJlTWFw cGVyR0w6OmJpbmRTdXJmYWNlKEJpdG1hcFRleHR1cmUgKnN1cmZhY2VQb2ludGVyKQogCiBib29s IFRleHR1cmVNYXBwZXJHTDo6YmVnaW5TY2lzc29yQ2xpcChjb25zdCBUcmFuc2Zvcm1hdGlvbk1h dHJpeCYgbW9kZWxWaWV3TWF0cml4LCBjb25zdCBGbG9hdFJlY3QmIHRhcmdldFJlY3QpCiB7Cisg ICAgaWYgKCFtb2RlbFZpZXdNYXRyaXguaXNBZmZpbmUoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCiAgICAgRmxvYXRRdWFkIHF1YWQgPSBtb2RlbFZpZXdNYXRyaXgucHJvamVjdFF1YWQodGFy Z2V0UmVjdCk7CiAgICAgSW50UmVjdCByZWN0ID0gcXVhZC5lbmNsb3NpbmdCb3VuZGluZ0JveCgp OwogCg== 131665 2012-03-13 10:52:53 -0700 2012-03-14 04:57:01 -0700 Patch bug-81009-20120313185555.patch text/plain 1824 larsgk U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQ3ODkxZGU4NWFjOGYz MjI5YTQwN2IwZjU2OThmODY5NWFmYTQ0NS4uODIyYmFmZDMwNDc4MTk5NWNkNTg2MjViMjlkNjQx NTlkYWVlMmYxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTEzICBMYXJz IEtudWRzZW4gIDxsYXJzLmtudWRzZW5Abm9raWEuY29tPgorCisgICAgICAgIDNEIHRyYW5zZm9y bWVkIHN1cmZhY2VzIHdpdGggej4wIGdldHMgY3JvcHBlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEwMDkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgc2Npc3NvciBjbGlwcGluZyBpbiBUZXh0dXJl TWFwcGVyR0wgZGlkbid0IHRha2UgM0QgdHJhbnNmb3JtcyAKKyAgICAgICAgaW50byBhY2NvdW50 IHdoZW4gY2FsY3VsYXRpbmcgdGhlIGNsaXBwaW5nIHJlZ2lvbi4KKyAgICAgICAgTm93LCBpdCB3 aWxsIGJhaWwgb3V0IGVhcmx5IGlmIHRoZSB0cmFuc2Zvcm0gaXMgbm90IGFmZmluZS4KKworICAg ICAgICBObyBuZXcgdGVzdHMuIFRlc3RlZCBieSBjdXJyZW50IGNvbXBvc2l0aW5nIGxheW91dCB0 ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVy R0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlckdMOjpiZWdpblNjaXNzb3JD bGlwKToKKwogMjAxMi0wMy0xMyAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgc25pcHBldHMgbW9kZWwuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckdMLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyR0wuY3BwCmluZGV4IGM4YjhjZDliMDQ2OTQzZjhkMGQwZmIyYjBmOGU0ODBjNTlkZDAw MjUuLjE2MTllMWRmNGY2MjQwNjZmYjc3NTU1NjczOTg5M2RlOWRiNmFhMWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyR0wuY3BwCkBAIC02MDQsNiArNjA0LDExIEBAIHZvaWQgVGV4dHVyZU1hcHBlckdMOjpi aW5kU3VyZmFjZShCaXRtYXBUZXh0dXJlICpzdXJmYWNlUG9pbnRlcikKIAogYm9vbCBUZXh0dXJl TWFwcGVyR0w6OmJlZ2luU2Npc3NvckNsaXAoY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIG1v ZGVsVmlld01hdHJpeCwgY29uc3QgRmxvYXRSZWN0JiB0YXJnZXRSZWN0KQogeworICAgIC8vIDNE IHRyYW5zZm9ybXMgYXJlIGN1cnJlbnRseSBub3Qgc3VwcG9ydGVkIGluIHNjaXNzb3IgY2xpcHBp bmcKKyAgICAvLyByZXN1bHRpbmcgaW4gY3JvcHBlZCBzdXJmYWNlcyB3aGVuIHo+MC4KKyAgICBp ZiAoIW1vZGVsVmlld01hdHJpeC5pc0FmZmluZSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK ICAgICBGbG9hdFF1YWQgcXVhZCA9IG1vZGVsVmlld01hdHJpeC5wcm9qZWN0UXVhZCh0YXJnZXRS ZWN0KTsKICAgICBJbnRSZWN0IHJlY3QgPSBxdWFkLmVuY2xvc2luZ0JvdW5kaW5nQm94KCk7CiAK