81007 2012-03-13 09:57:56 -0700 check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt 2012-03-16 05:14:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kbolisetty webkit-unassigned abarth gyuyoung.kim jchaffraix mrahaman ojan webkit.review.bot oldest_to_newest 577466 0 kbolisetty 2012-03-13 09:57:56 -0700 ./Tools/Scripts/check-webkit-style LayoutTests/platform/efl/test_expectations.txt fails even after removing duplicate entries in Skipped & test_expectations.txt ./Tools/Scripts/check-webkit-style LayoutTests/platform/efl/test_expectations.txt Traceback (most recent call last): File "./Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/main.py", line 149, in main file_reader.process_paths(paths) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 145, in process_paths self.process_file(path) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 838, in process checker.check(lines) File "/home/administrator/kishore/osc/code/8march/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 103, in check overrides = self._port_obj.test_expectations_overrides() AttributeError: 'NoneType' object has no attribute 'test_expectations_overrides' 577476 1 kbolisetty 2012-03-13 10:05:02 -0700 I also have done little debugging in python scripts and could find the workaround for this issue, but not sure if it is a right fix. Adding "efl" in Tools/Scripts/webkitpy/layout_tests/port/builders.py as shown below would solve the issue. _ports_without_builders = [ "google-chrome-linux32", "google-chrome-linux64", "qt-mac", "qt-win", "qt-wk2", "efl", ] 580151 2 132200 kbolisetty 2012-03-15 22:46:06 -0700 Created attachment 132200 patch 580399 3 132200 webkit.review.bot 2012-03-16 05:14:50 -0700 Comment on attachment 132200 patch Clearing flags on attachment: 132200 Committed r110990: <http://trac.webkit.org/changeset/110990> 580400 4 webkit.review.bot 2012-03-16 05:14:57 -0700 All reviewed patches have been landed. Closing bug. 132200 2012-03-15 22:46:06 -0700 2012-03-16 05:14:49 -0700 patch patch-81007 text/plain 1602 kbolisetty SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExMDk0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTAzLTE1ICBLaXNob3JlIEJvbGlzZXR0eSAgPGtib2xpc2V0dHlAaW5u b21pbmRzLmNvbT4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgZmFpbHMgb24gTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODEwMDcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIGRlZGlkY2F0ZWQgYnVpbGQgc2xhdmUg aXMgYXZhaWxhYmxlIGZvciBlZmwgb24gYnVpbGQud2Via2l0Lm9yZy4gCisgICAgICAgIFRoaXMg Y2hhbmdlIGFkZCdzIGFuIGVudHJ5IGZvciB0aGUgZWxmIHBvcnQgaW4gbGlzdCBvZiBhdmFpbGFi bGUgcG9ydCBidWlsZGVycy4KKyAgICAgICAgVGhpcyBpcyByZXF1aXJlZCBiZWNhdXNlIHRlc3Rf ZXhwZWN0YXRpb25zLnB5IHdoZW4gdHJpZ2dlcmVkLCBsb29rcyBmb3IgYSB2YWxpZCBwb3J0IG9i amVjdCBmb3IgdGhlIHNwZWNpZmllZCBwb3J0LiAKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYnVpbGRlcnMucHk6CisKIDIwMTItMDMtMTUgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBUaGUgY29tbWl0LXF1ZXVlIHNob3Vs ZCBmYXN0LXRyYWNrIHBhdGNoZXMgdGhhdCBoYXZlIGFscmVhZHkgcGFzc2VkIHRoZSB0ZXN0aW5n IEVXUyBib3RzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2J1aWxkZXJzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvYnVpbGRlcnMucHkJKHJldmlzaW9uIDExMDkzNSkKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYnVpbGRlcnMucHkJKHdvcmtpbmcgY29weSkK QEAgLTYwLDYgKzYwLDcgQEAgX2V4YWN0X21hdGNoZXMgPSB7CiAgICAgIlF0IExpbnV4IFJlbGVh c2UiOiB7InBvcnRfbmFtZSI6ICJxdC1saW51eCIsICJzcGVjaWZpZXJzIjogc2V0KFsid2luIiwg ImxpbnV4IiwgIm1hYyJdKX0sCiAgICAgIldpbmRvd3MgWFAgRGVidWcgKFRlc3RzKSI6IHsicG9y dF9uYW1lIjogIndpbi14cCIsICJzcGVjaWZpZXJzIjogc2V0KFsid2luIl0pfSwKICAgICAiV2lu ZG93cyA3IFJlbGVhc2UgKFdlYktpdDIgVGVzdHMpIjogeyJwb3J0X25hbWUiOiAid2luLWZ1dHVy ZS13azIiLCAic3BlY2lmaWVycyI6IHNldChbIndrMiJdKX0sCisgICAgIkVGTCBMaW51eCBSZWxl YXNlIjogeyJwb3J0X25hbWUiOiAiZWZsIiwgInNwZWNpZmllcnMiOiBzZXQoWyJlZmwiXSl9LAog fQogCiAK