8100 2006-03-31 02:33:40 -0800 REGRESSION (NativeTextField): Right-aligned and RTL text jitters in new text fields 2006-04-19 02:22:24 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 VERIFIED FIXED Regression P1 Normal --- 1 mitz darin darin oldest_to_newest 38064 0 mitz 2006-03-31 02:33:40 -0800 Summary: glyphs' horizontal positions slightly change as more text is entered into a right-aligned or RTL text field. To reproduce: 1) Open the attached test case. 2) In the first text field, type lower-case "x"s. Watch the glyphs' positions as you add more "x"s. 3) In the second text field, type (or paste) Alephs. Watch the position of the last-typed Aleph as you type the next one. 4) From the Debug menu, choose Use ATSU For All Text, reload and repeat (in step 3, watch all Alephs). I think these are artifacts of the "rounding hack". They can be observed in Mail too (and in other editable or dynamic HTML). The right-aligned case is somewhat artificial, but the RTL case is a real problem. 38065 1 7415 mitz 2006-03-31 02:34:41 -0800 Created attachment 7415 Test case 38066 2 7416 mitz 2006-03-31 02:36:22 -0800 Created attachment 7416 Test case Oops 38183 3 7443 mitz 2006-04-01 09:47:52 -0800 Created attachment 7443 Apply rounding on the left in RTL runs This patch addresses the RTL part of this bug. The right-aligned-LTR case (and the symmetric left-aligned-LTR case) are arguably non-issues. I think that in order to solve them, WebTextRenderer will need to know if the run is going anchored on the right or on the left, and use that instead of the rtl flag. This patch affects the pixel results of all tests that include RTL test in Lucida Grande (and maybe other fractional-width fonts). Updated results will need to be generated and landed. 38186 4 7443 darin 2006-04-01 11:00:56 -0800 Comment on attachment 7443 Apply rounding on the left in RTL runs OK, r=me 38315 5 darin 2006-04-02 19:02:24 -0700 (In reply to comment #3) > This patch addresses the RTL part of this bug. The right-aligned-LTR case (and > the symmetric left-aligned-LTR case) are arguably non-issues. I think that in > order to solve them, WebTextRenderer will need to know if the run is going > anchored on the right or on the left, and use that instead of the rtl flag. Seems like the jittering *is* an issue in the right-aligned-LTR and left-aligned-RTL cases, although a much smaller one. Maybe we should have a second bug report about those. 38352 6 mjs 2006-04-02 23:25:41 -0700 These are all text field regressions so they should all be P1. 7415 2006-03-31 02:34:41 -0800 2006-03-31 02:36:22 -0800 Test case text field jitter.html text/html 348 mitz PHA+CiAgICBUeXBlICZsZHF1bzt4eHh4eHh4eHh4eHgmcmRxdW87Li4uIGluIHRoZSB0ZXh0IGZp ZWxkIGJlbG93Lgo8L3A+CjxpbnB1dCBzdHlsZT0iZm9udC1mYW1pbHk6ICdMdWNpZGEgR3JhbmRl JzsgZm9udC1zaXplOiAxNHB4OyI+CjxwPgogICAgVHlwZSAmbGRxdW87JiN4MDVkMDsmI3gwNWQw OyYjeDA1ZDA7JiN4MDVkMDsmI3gwNWQwOyYjeDA1ZDA7JiN4MDVkMDsmI3gwNWQwOyYjeDA1ZDA7 JnJkcXVvOy4uLiBpbiB0aGUgdGV4dCBmaWVsZCBiZWxvdy4KPC9wPgo8aW5wdXQgc3R5bGU9ImRp cmVjdGlvbjogcnRsOyBmb250LWZhbWlseTogJ0x1Y2lkYSBHcmFuZGUnOyBmb250LXNpemU6IDE0 cHg7Ij4K 7416 2006-03-31 02:36:22 -0800 2006-03-31 02:36:22 -0800 Test case text field jitter.html text/html 367 mitz PHA+CiAgICBUeXBlICZsZHF1bzt4eHh4eHh4eHh4eHgmcmRxdW87Li4uIGluIHRoZSB0ZXh0IGZp ZWxkIGJlbG93Lgo8L3A+CjxpbnB1dCBzdHlsZT0idGV4dC1hbGlnbjogcmlnaHQ7IGZvbnQtZmFt aWx5OiAnTHVjaWRhIEdyYW5kZSc7IGZvbnQtc2l6ZTogMTRweDsiPgo8cD4KICAgIFR5cGUgJmxk cXVvOyYjeDA1ZDA7JiN4MDVkMDsmI3gwNWQwOyYjeDA1ZDA7JiN4MDVkMDsmI3gwNWQwOyYjeDA1 ZDA7JiN4MDVkMDsmI3gwNWQwOyZyZHF1bzsuLi4gaW4gdGhlIHRleHQgZmllbGQgYmVsb3cuCjwv cD4KPGlucHV0IHN0eWxlPSJkaXJlY3Rpb246IHJ0bDsgZm9udC1mYW1pbHk6ICdMdWNpZGEgR3Jh bmRlJzsgZm9udC1zaXplOiAxNHB4OyI+Cg== 7443 2006-04-01 09:47:52 -0800 2006-04-01 11:00:56 -0800 Apply rounding on the left in RTL runs 8100_r1.patch text/plain 6316 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTM2MjYpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMjAgQEAKKzIwMDYtIyMtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0 enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9p ZD04MTAwCisgICAgICAgICAgUkVHUkVTU0lPTiAoTmF0aXZlVGV4dEZpZWxkKTogUmlnaHQtYWxp Z25lZCBhbmQgUlRMIHRleHQgaml0dGVycyBpbiBuZXcgdGV4dCBmaWVsZHMKKworICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L1dlYlRleHRSZW5kZXJlci5tOgorICAgICAgICAob3ZlcnJpZGVMYXlv dXRPcGVyYXRpb24pOiBGb3IgUlRMIHJ1bnMsIGFwcGx5IHRoZSB3b3JkLXJvdW5kaW5nIG9uIHRo ZSBsZWZ0LgorICAgICAgICAoQ0dfZmxvYXRXaWR0aEZvclJ1bik6IEZvciBSVEwgcnVucywgYXBw bHkgdGhlIGxhc3QgY2hhcmFjdGVyJ3Mgcm91bmRpbmcKKyAgICAgICAgb24gdGhlIGxlZnQgYnkg YWRqdXN0aW5nIHRoZSBzdGFydCBwb3NpdGlvbi4KKyAgICAgICAgKGluaXRpYWxpemVXaWR0aEl0 ZXJhdG9yKTogQWRkZWQgZmluYWxSb3VuZGluZ1dpZHRoIGZpZWxkIHRvIFdpZHRoSXRlcmF0b3Iu CisgICAgICAgIChhZHZhbmNlV2lkdGhJdGVyYXRvcik6IEZvciBSVEwgcnVucywgYXBwbHkgcm91 bmRpbmcgb24gdGhlIGxlZnQgb2YgdGhlIGNoYXJhY3RlciwKKyAgICAgICAgYnkgaW5jcmVhc2lu ZyB0aGUgd2lkdGggb2YgdGhlIG5leHQgY2hhcmFjdGVyICh3aGljaCBpcyB0aGUgY2hhcmFjdGVy IHRvIHRoZSBsZWZ0KS4gRm9yCisgICAgICAgIHRoZSBsYXN0IGNoYXJhY3Rlciwga2VlcCB0aGUg cm91bmRpbmcgd2lkdGggaW4gdGhlIGl0ZXJhdG9yJ3MgZmluYWxSb3VuZGluZ1dpZHRoLCB0byBi ZSB1c2VkIGJ5CisgICAgICAgIENHX2Zsb2F0V2lkdGhGb3JSdW4oKS4KKwogMjAwNi0wNC0wMSAg RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFj aWVqLgpJbmRleDogV2ViS2l0L1dlYkNvcmVTdXBwb3J0L1dlYlRleHRSZW5kZXJlci5tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9XZWJDb3JlU3VwcG9ydC9XZWJUZXh0UmVuZGVyZXIubQkocmV2aXNp b24gMTM2MjUpCisrKyBXZWJLaXQvV2ViQ29yZVN1cHBvcnQvV2ViVGV4dFJlbmRlcmVyLm0JKHdv cmtpbmcgY29weSkKQEAgLTEwNyw2ICsxMDcsNyBAQCB0eXBlZGVmIHN0cnVjdCBXaWR0aEl0ZXJh dG9yIHsKICAgICBmbG9hdCB3aWR0aFRvU3RhcnQ7CiAgICAgZmxvYXQgcGFkZGluZzsKICAgICBm bG9hdCBwYWRQZXJTcGFjZTsKKyAgICBmbG9hdCBmaW5hbFJvdW5kaW5nV2lkdGg7CiB9IFdpZHRo SXRlcmF0b3I7CiAKIHR5cGVkZWYgc3RydWN0IEFUU1VMYXlvdXRQYXJhbWV0ZXJzCkBAIC0yNTYs NiArMjU3LDcgQEAgc3RhdGljIE9TU3RhdHVzIG92ZXJyaWRlTGF5b3V0T3BlcmF0aW9uKAogICAg ICAgICBmbG9hdCBwYWRkaW5nID0gc3R5bGUtPnBhZGRpbmc7CiAgICAgICAgIC8vIEluIHRoZSBD b3JlR3JhcGhpY3MgY29kZSBwYXRoLCB0aGUgcm91bmRpbmcgaGFjayBpcyBhcHBsaWVkIGluIGxv Z2ljYWwgb3JkZXIuCiAgICAgICAgIC8vIEhlcmUgaXQgaXMgYXBwbGllZCBpbiB2aXN1YWwgbGVm dC10by1yaWdodCBvcmRlciwgd2hpY2ggbWF5IGJlIGJldHRlci4KKyAgICAgICAgSXRlbUNvdW50 IGxhc3RSb3VuZGluZ0NoYXIgPSAwOwogICAgICAgICBJdGVtQ291bnQgaTsKICAgICAgICAgZm9y IChpID0gMTsgaSA8IGNvdW50OyBpKyspIHsKICAgICAgICAgICAgIGJvb2wgaXNMYXN0Q2hhciA9 IGkgPT0gY291bnQgLSAxOwpAQCAtMzA2LDExICszMDgsMjIgQEAgc3RhdGljIE9TU3RhdHVzIG92 ZXJyaWRlTGF5b3V0T3BlcmF0aW9uKAogICAgICAgICAgICAgaWYgKGlzUm91bmRpbmdIYWNrQ2hh cmFjdGVyKGNoKSkKICAgICAgICAgICAgICAgICB3aWR0aCA9IGNlaWxmKHdpZHRoKTsKICAgICAg ICAgICAgIGxhc3RBZGp1c3RlZFBvcyA9IGxhc3RBZGp1c3RlZFBvcyArIHdpZHRoOwotICAgICAg ICAgICAgaWYgKGlzUm91bmRpbmdIYWNrQ2hhcmFjdGVyKG5leHRDaCkpCi0gICAgICAgICAgICAg ICAgaWYgKCFpc0xhc3RDaGFyCi0gICAgICAgICAgICAgICAgICAgICAgICB8fCBzdHlsZS0+YXBw bHlSdW5Sb3VuZGluZwotICAgICAgICAgICAgICAgICAgICAgICAgfHwgKHJ1bi0+dG8gPCAoaW50 KXJ1bi0+bGVuZ3RoICYmIGlzUm91bmRpbmdIYWNrQ2hhcmFjdGVyKGNoYXJhY3RlcnNbcnVuLT50 byAtIHJ1bi0+ZnJvbV0pKSkKKyAgICAgICAgICAgIGlmIChpc1JvdW5kaW5nSGFja0NoYXJhY3Rl cihuZXh0Q2gpCisgICAgICAgICAgICAgICAgJiYgKCFpc0xhc3RDaGFyCisgICAgICAgICAgICAg ICAgICAgIHx8IHN0eWxlLT5hcHBseVJ1blJvdW5kaW5nCisgICAgICAgICAgICAgICAgICAgIHx8 IChydW4tPnRvIDwgKGludClydW4tPmxlbmd0aCAmJiBpc1JvdW5kaW5nSGFja0NoYXJhY3Rlcihj aGFyYWN0ZXJzW3J1bi0+dG8gLSBydW4tPmZyb21dKSkpKSB7CisgICAgICAgICAgICAgICAgaWYg KCFzdHlsZS0+cnRsKQogICAgICAgICAgICAgICAgICAgICBsYXN0QWRqdXN0ZWRQb3MgPSBjZWls ZihsYXN0QWRqdXN0ZWRQb3MpOworICAgICAgICAgICAgICAgIGVsc2UgeworICAgICAgICAgICAg ICAgICAgICBmbG9hdCByb3VuZGluZ1dpZHRoID0gY2VpbGYobGFzdEFkanVzdGVkUG9zKSAtIGxh c3RBZGp1c3RlZFBvczsKKyAgICAgICAgICAgICAgICAgICAgRml4ZWQgcncgPSBGbG9hdFRvRml4 ZWQocm91bmRpbmdXaWR0aCk7CisgICAgICAgICAgICAgICAgICAgIEl0ZW1Db3VudCBqOworICAg ICAgICAgICAgICAgICAgICBmb3IgKGogPSBsYXN0Um91bmRpbmdDaGFyOyBqIDwgaTsgaisrKQor ICAgICAgICAgICAgICAgICAgICAgICAgbGF5b3V0UmVjb3Jkc1tqXS5yZWFsUG9zICs9IHJ3Owor ICAgICAgICAgICAgICAgICAgICBsYXN0Um91bmRpbmdDaGFyID0gaTsKKyAgICAgICAgICAgICAg ICAgICAgbGFzdEFkanVzdGVkUG9zICs9IHJvdW5kaW5nV2lkdGg7CisgICAgICAgICAgICAgICAg fQorICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKHN5bnRoZXRpY0JvbGRQYXNzKSB7CiAg ICAgICAgICAgICAgICAgaWYgKHN5bnRoZXRpY0JvbGRPZmZzZXQpCiAgICAgICAgICAgICAgICAg ICAgIGxheW91dFJlY29yZHNbaS0xXS5yZWFsUG9zICs9IHN5bnRoZXRpY0JvbGRPZmZzZXQ7CkBA IC0xMDQ3LDggKzEwNjAsOSBAQCBzdGF0aWMgZmxvYXQgQ0dfZmxvYXRXaWR0aEZvclJ1bihXZWJU ZXh0CiAgICAgICAgIGlmICghc3R5bGUtPnJ0bCkKICAgICAgICAgICAgICpzdGFydFBvc2l0aW9u ID0gaXQud2lkdGhUb1N0YXJ0OwogICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgIGZsb2F0IGZp bmFsUm91bmRpbmdXaWR0aCA9IGl0LmZpbmFsUm91bmRpbmdXaWR0aDsKICAgICAgICAgICAgIGFk dmFuY2VXaWR0aEl0ZXJhdG9yKCZpdCwgcnVuLT5sZW5ndGgsIDAsIDAsIDApOwotICAgICAgICAg ICAgKnN0YXJ0UG9zaXRpb24gPSBpdC5ydW5XaWR0aFNvRmFyIC0gcnVuV2lkdGg7CisgICAgICAg ICAgICAqc3RhcnRQb3NpdGlvbiA9IGl0LnJ1bldpZHRoU29GYXIgLSBydW5XaWR0aCArIGZpbmFs Um91bmRpbmdXaWR0aDsKICAgICAgICAgfQogICAgIH0KICAgICBpZiAobnVtR2x5cGhzUmVzdWx0 KQpAQCAtMTc1Miw2ICsxNzY2LDcgQEAgc3RhdGljIHZvaWQgaW5pdGlhbGl6ZVdpZHRoSXRlcmF0 b3IoV2lkdAogICAgIGl0ZXJhdG9yLT5zdHlsZSA9IHN0eWxlOwogICAgIGl0ZXJhdG9yLT5jdXJy ZW50Q2hhcmFjdGVyID0gcnVuLT5mcm9tOwogICAgIGl0ZXJhdG9yLT5ydW5XaWR0aFNvRmFyID0g MDsKKyAgICBpdGVyYXRvci0+ZmluYWxSb3VuZGluZ1dpZHRoID0gMDsKIAogICAgIC8vIElmIHRo ZSBwYWRkaW5nIGlzIG5vbi16ZXJvLCBjb3VudCB0aGUgbnVtYmVyIG9mIHNwYWNlcyBpbiB0aGUg cnVuCiAgICAgLy8gYW5kIGRpdmlkZSB0aGF0IGJ5IHRoZSBwYWRkaW5nIGZvciBwZXIgc3BhY2Ug YWRkaXRpb24uCkBAIC0xODE1LDEwICsxODMwLDEyIEBAIHN0YXRpYyB1bnNpZ25lZCBhZHZhbmNl V2lkdGhJdGVyYXRvcihXaWQKICAgICBjb25zdCBVbmlDaGFyICpjcCA9ICZydW4tPmNoYXJhY3Rl cnNbY3VycmVudENoYXJhY3Rlcl07CiAKICAgICBjb25zdCBXZWJDb3JlVGV4dFN0eWxlICpzdHls ZSA9IGl0ZXJhdG9yLT5zdHlsZTsKLSAgICBib29sIG5lZWRDaGFyVHJhbnNmb3JtID0gc3R5bGUt PnJ0bCB8IHN0eWxlLT5zbWFsbENhcHM7CisgICAgYm9vbCBydGwgPSBzdHlsZS0+cnRsOworICAg IGJvb2wgbmVlZENoYXJUcmFuc2Zvcm0gPSBydGwgfCBzdHlsZS0+c21hbGxDYXBzOwogICAgIGJv b2wgaGFzRXh0cmFTcGFjaW5nID0gc3R5bGUtPmxldHRlclNwYWNpbmcgfCBzdHlsZS0+d29yZFNw YWNpbmcgfCBzdHlsZS0+cGFkZGluZzsKIAogICAgIGZsb2F0IHJ1bldpZHRoU29GYXIgPSBpdGVy YXRvci0+cnVuV2lkdGhTb0ZhcjsKKyAgICBmbG9hdCBsYXN0Um91bmRpbmdXaWR0aCA9IGl0ZXJh dG9yLT5maW5hbFJvdW5kaW5nV2lkdGg7CiAKICAgICB3aGlsZSAoY3VycmVudENoYXJhY3RlciA8 IG9mZnNldCkgewogICAgICAgICBVQ2hhcjMyIGMgPSAqY3A7CkBAIC0xODU0LDcgKzE4NzEsNyBA QCBzdGF0aWMgdW5zaWduZWQgYWR2YW5jZVdpZHRoSXRlcmF0b3IoV2lkCiAgICAgICAgIFdlYlRl eHRSZW5kZXJlciAqcmVuZGVyZXIgPSBpdGVyYXRvci0+cmVuZGVyZXI7CiAKICAgICAgICAgaWYg KG5lZWRDaGFyVHJhbnNmb3JtKSB7Ci0gICAgICAgICAgICBpZiAoc3R5bGUtPnJ0bCkKKyAgICAg ICAgICAgIGlmIChydGwpCiAgICAgICAgICAgICAgICAgYyA9IHVfY2hhck1pcnJvcihjKTsKIAog ICAgICAgICAgICAgLy8gSWYgc21hbGwtY2FwcywgY29udmVydCBsb3dlcmNhc2UgdG8gdXBwZXIu CkBAIC0xOTQ0LDYgKzE5NjEsOCBAQCBzdGF0aWMgdW5zaWduZWQgYWR2YW5jZVdpZHRoSXRlcmF0 b3IoV2lkCiAgICAgICAgIC8vIFdlIGFkanVzdCB0aGUgd2lkdGggb2YgdGhlIGxhc3QgY2hhcmFj dGVyIG9mIGEgIndvcmQiIHRvIGVuc3VyZSBhbiBpbnRlZ2VyIHdpZHRoLgogICAgICAgICAvLyBJ ZiB3ZSBtb3ZlIEtIVE1MIHRvIGZsb2F0cyB3ZSBjYW4gcmVtb3ZlIHRoaXMgKGFuZCByZWxhdGVk KSBoYWNrcy4KIAorICAgICAgICBmbG9hdCBvbGRXaWR0aCA9IHdpZHRoOworCiAgICAgICAgIC8v IEZvcmNlIGNoYXJhY3RlcnMgdGhhdCBhcmUgdXNlZCB0byBkZXRlcm1pbmUgd29yZCBib3VuZGFy aWVzIGZvciB0aGUgcm91bmRpbmcgaGFjawogICAgICAgICAvLyB0byBiZSBpbnRlZ2VyIHdpZHRo LCBzbyBmb2xsb3dpbmcgd29yZHMgd2lsbCBzdGFydCBvbiBhbiBpbnRlZ2VyIGJvdW5kYXJ5Lgog ICAgICAgICBpZiAoc3R5bGUtPmFwcGx5V29yZFJvdW5kaW5nICYmIGlzUm91bmRpbmdIYWNrQ2hh cmFjdGVyKGMpKQpAQCAtMTk2NSwxNiArMTk4NCwxOCBAQCBzdGF0aWMgdW5zaWduZWQgYWR2YW5j ZVdpZHRoSXRlcmF0b3IoV2lkCiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBBU1NFUlQo cmVuZGVyZXJzVXNlZCk7CiAgICAgICAgICAgICBBU1NFUlQoZ2x5cGhzVXNlZCk7Ci0gICAgICAg ICAgICAqd2lkdGhzKysgPSB3aWR0aDsKKyAgICAgICAgICAgICp3aWR0aHMrKyA9IChydGwgPyBv bGRXaWR0aCArIGxhc3RSb3VuZGluZ1dpZHRoIDogd2lkdGgpOwogICAgICAgICAgICAgKnJlbmRl cmVyc1VzZWQrKyA9IHJlbmRlcmVyOwogICAgICAgICAgICAgKmdseXBoc1VzZWQrKyA9IGdseXBo OwogICAgICAgICB9CiAKKyAgICAgICAgbGFzdFJvdW5kaW5nV2lkdGggPSB3aWR0aCAtIG9sZFdp ZHRoOwogICAgICAgICArK251bUdseXBoczsKICAgICB9CiAKICAgICBpdGVyYXRvci0+Y3VycmVu dENoYXJhY3RlciA9IGN1cnJlbnRDaGFyYWN0ZXI7CiAgICAgaXRlcmF0b3ItPnJ1bldpZHRoU29G YXIgPSBydW5XaWR0aFNvRmFyOworICAgIGl0ZXJhdG9yLT5maW5hbFJvdW5kaW5nV2lkdGggPSBs YXN0Um91bmRpbmdXaWR0aDsKIAogICAgIHJldHVybiBudW1HbHlwaHM7CiB9Cg==