80990 2012-03-13 08:31:05 -0700 ENABLE_INSPECTOR flag is unavailable in .idl files 2014-12-17 16:37:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mvujovic webkit-unassigned burg oldest_to_newest 577344 0 mvujovic 2012-03-13 08:31:05 -0700 In Internals.idl (under WebCore), when I add a block like this: #if defined(ENABLE_INSPECTOR) && ENABLE_INSPECTOR ... #endif The block is never entered, even with a build that includes the inspector (e.g. running "Tools/Scripts/build-webkit"). The block should be entered. Interestingly, in a .cpp or .h file, a block like the following works properly: #if ENABLE(INSPECTOR) ... #endif So far, it seems the workaround has been to use "#if ENABLE(INSPECTOR)" blocks within the bodies of inspector-related functions, such as: void InternalSettings::setInspectorResourcesDataSizeLimits(int maximumResourcesContentSize, int maximumSingleResourceContentSize, ExceptionCode& ec) { #if ENABLE(INSPECTOR) if (!page() || !page()->inspectorController()) { ec = INVALID_ACCESS_ERR; return; } page()->inspectorController()->setResourcesDataSizeLimitsFromInternals(maximumResourcesContentSize, maximumSingleResourceContentSize); #else UNUSED_PARAM(maximumResourcesContentSize); UNUSED_PARAM(maximumSingleResourceContentSize); UNUSED_PARAM(ec); #endif } This works, but ideally, we'd like the "setInspectorResourcesDataSizeLimits" method to be undefined when the inspector isn't present by wrapping it with an #if/#endif block in the .idl file. 1056592 1 burg 2014-12-17 16:37:54 -0800 Use Conditional=INSPECTOR.