80983 2012-03-13 05:13:13 -0700 Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace 2012-03-19 23:48:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen ap darin gavinp hausmann kbalazs webkit.review.bot oldest_to_newest 577240 0 jochen 2012-03-13 05:13:13 -0700 Split WTFReportBacktrace into WTFReportBacktrace and WTFPrintBacktrace 577241 1 131593 jochen 2012-03-13 05:15:35 -0700 Created attachment 131593 Patch 577244 2 jochen 2012-03-13 05:20:48 -0700 Alexey, can you review this change? During my debugging, I often use WTFGetBacktrace to store backtraces in various objects, and want to print the symbolized stack trace at some later point. 578250 3 jochen 2012-03-14 01:53:09 -0700 Adding Gavin and Balazs who both wrote that code, and Simon and Darin, who reviewed their changes 578310 4 131593 gavinp 2012-03-14 04:54:16 -0700 Comment on attachment 131593 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131593&action=review I'm not a reviewer, but I like this change. > Source/JavaScriptCore/wtf/Assertions.cpp:-307 > - for (int i = framesToSkip; i < frames; ++i) { Nice to see framesToSkip leave the printing logic. 578362 5 kbalazs 2012-03-14 07:11:54 -0700 Seems reasonable to me (although I'm not a reviewer). 582801 6 131593 webkit.review.bot 2012-03-19 23:48:34 -0700 Comment on attachment 131593 Patch Clearing flags on attachment: 131593 Committed r111366: <http://trac.webkit.org/changeset/111366> 582802 7 webkit.review.bot 2012-03-19 23:48:39 -0700 All reviewed patches have been landed. Closing bug. 131593 2012-03-13 05:15:35 -0700 2012-03-19 23:48:34 -0700 Patch bug-80983-20120313131533.patch text/plain 3969 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NThlZDliOWYzMDA4OTg3YzJhNzdjMGRiN2QxZGEyMDNmYzMyYTU2Li5hNjMxMjZlMTg3MTY4M2Ex MmFjMjY2MDg2ZDQ5YTQ3ZWMxMTdkMzEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0wMy0xMyAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVt Lm9yZz4KKworICAgICAgICBTcGxpdCBXVEZSZXBvcnRCYWNrdHJhY2UgaW50byBXVEZSZXBvcnRC YWNrdHJhY2UgYW5kIFdURlByaW50QmFja3RyYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDk4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWxsb3dzIHByaW50aW5nIGEgYmFja3RyYWNlIGFj cXVpcmVkIGJ5IGFuIGVhcmxpZXIgV1RGR2V0QmFja3RyYWNlCisgICAgICAgIGNhbGwgd2hpY2gg aXMgdXNlZnVsIGZvciBsb2NhbCBkZWJ1Z2dpbmcuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9u cy5jcHA6CisgICAgICAgICogd3RmL0Fzc2VydGlvbnMuaDoKKwogMjAxMi0wMy0xMiAgSG9qb25n IEhhbiAgPGhvam9uZy5oYW5Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgRml4IHRlc3QgY2FzZXMg Zm9yIFJlZ0V4cCBtdWx0aWxpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvQXNzZXJ0aW9ucy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMu Y3BwCmluZGV4IDllNzQ0ZDM4NzIxYzI5MzNiYmRkMzY0ZjVmOTU1Njk1YTA4ZjEzNGYuLjg5YWRl MzU5OTExZmU0YTQwMzM4YjBmZjY0NWRjYTE4N2M4MWQ0MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3d0Zi9Bc3NlcnRpb25zLmNwcApAQCAtMjc5LDYgKzI3OSwxNyBAQCB2b2lkIFdURkdldEJh Y2t0cmFjZSh2b2lkKiogc3RhY2ssIGludCogc2l6ZSkKICNlbmRpZgogfQogCit2b2lkIFdURlJl cG9ydEJhY2t0cmFjZSgpCit7CisgICAgc3RhdGljIGNvbnN0IGludCBmcmFtZXNUb1Nob3cgPSAz MTsKKyAgICBzdGF0aWMgY29uc3QgaW50IGZyYW1lc1RvU2tpcCA9IDI7CisgICAgdm9pZCogc2Ft cGxlc1tmcmFtZXNUb1Nob3cgKyBmcmFtZXNUb1NraXBdOworICAgIGludCBmcmFtZXMgPSBmcmFt ZXNUb1Nob3cgKyBmcmFtZXNUb1NraXA7CisKKyAgICBXVEZHZXRCYWNrdHJhY2Uoc2FtcGxlcywg JmZyYW1lcyk7CisgICAgV1RGUHJpbnRCYWNrdHJhY2Uoc2FtcGxlcyArIGZyYW1lc1RvU2tpcCwg ZnJhbWVzIC0gZnJhbWVzVG9Ta2lwKTsKK30KKwogI2lmIE9TKERBUldJTikgfHwgT1MoTElOVVgp CiAjICBpZiBQTEFURk9STShRVCkgfHwgUExBVEZPUk0oR1RLKQogIyAgICBpZiBkZWZpbmVkKF9f R0xJQkNfXykgJiYgIWRlZmluZWQoX19VQ0xJQkNfXykKQEAgLTI4OSwzOCArMzAwLDMxIEBAIHZv aWQgV1RGR2V0QmFja3RyYWNlKHZvaWQqKiBzdGFjaywgaW50KiBzaXplKQogIyAgZW5kaWYKICNl bmRpZgogCi12b2lkIFdURlJlcG9ydEJhY2t0cmFjZSgpCit2b2lkIFdURlByaW50QmFja3RyYWNl KHZvaWQqKiBzdGFjaywgaW50IHNpemUpCiB7Ci0gICAgc3RhdGljIGNvbnN0IGludCBmcmFtZXNU b1Nob3cgPSAzMTsKLSAgICBzdGF0aWMgY29uc3QgaW50IGZyYW1lc1RvU2tpcCA9IDI7Ci0gICAg dm9pZCogc2FtcGxlc1tmcmFtZXNUb1Nob3cgKyBmcmFtZXNUb1NraXBdOwotICAgIGludCBmcmFt ZXMgPSBmcmFtZXNUb1Nob3cgKyBmcmFtZXNUb1NraXA7Ci0KLSAgICBXVEZHZXRCYWNrdHJhY2Uo c2FtcGxlcywgJmZyYW1lcyk7Ci0KICNpZiBVU0UoQkFDS1RSQUNFX1NZTUJPTFMpCi0gICAgY2hh cioqIHN5bWJvbHMgPSBiYWNrdHJhY2Vfc3ltYm9scyhzYW1wbGVzLCBmcmFtZXMpOworICAgIGNo YXIqKiBzeW1ib2xzID0gYmFja3RyYWNlX3N5bWJvbHMoc3RhY2ssIHNpemUpOwogICAgIGlmICgh c3ltYm9scykKICAgICAgICAgcmV0dXJuOwogI2VuZGlmCiAKLSAgICBmb3IgKGludCBpID0gZnJh bWVzVG9Ta2lwOyBpIDwgZnJhbWVzOyArK2kpIHsKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IHNp emU7ICsraSkgewogICAgICAgICBjb25zdCBjaGFyKiBtYW5nbGVkTmFtZSA9IDA7CiAgICAgICAg IGNoYXIqIGN4YURlbWFuZ2xlZCA9IDA7CiAjaWYgVVNFKEJBQ0tUUkFDRV9TWU1CT0xTKQogICAg ICAgICBtYW5nbGVkTmFtZSA9IHN5bWJvbHNbaV07CiAjZWxpZiBVU0UoRExBRERSKQogICAgICAg ICBEbF9pbmZvIGluZm87Ci0gICAgICAgIGlmIChkbGFkZHIoc2FtcGxlc1tpXSwgJmluZm8pICYm IGluZm8uZGxpX3NuYW1lKQorICAgICAgICBpZiAoZGxhZGRyKHN0YWNrW2ldLCAmaW5mbykgJiYg aW5mby5kbGlfc25hbWUpCiAgICAgICAgICAgICBtYW5nbGVkTmFtZSA9IGluZm8uZGxpX3NuYW1l OwogICAgICAgICBpZiAobWFuZ2xlZE5hbWUpCiAgICAgICAgICAgICBjeGFEZW1hbmdsZWQgPSBh Ymk6Ol9fY3hhX2RlbWFuZ2xlKG1hbmdsZWROYW1lLCAwLCAwLCAwKTsKICNlbmRpZgotICAgICAg ICBjb25zdCBpbnQgZnJhbWVOdW1iZXIgPSBpIC0gZnJhbWVzVG9Ta2lwICsgMTsKKyAgICAgICAg Y29uc3QgaW50IGZyYW1lTnVtYmVyID0gaSArIDE7CiAgICAgICAgIGlmIChtYW5nbGVkTmFtZSB8 fCBjeGFEZW1hbmdsZWQpCi0gICAgICAgICAgICBwcmludGZfc3RkZXJyX2NvbW1vbigiJS0zZCAl cCAlc1xuIiwgZnJhbWVOdW1iZXIsIHNhbXBsZXNbaV0sIGN4YURlbWFuZ2xlZCA/IGN4YURlbWFu Z2xlZCA6IG1hbmdsZWROYW1lKTsKKyAgICAgICAgICAgIHByaW50Zl9zdGRlcnJfY29tbW9uKCIl LTNkICVwICVzXG4iLCBmcmFtZU51bWJlciwgc3RhY2tbaV0sIGN4YURlbWFuZ2xlZCA/IGN4YURl bWFuZ2xlZCA6IG1hbmdsZWROYW1lKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgcHJpbnRm X3N0ZGVycl9jb21tb24oIiUtM2QgJXBcbiIsIGZyYW1lTnVtYmVyLCBzYW1wbGVzW2ldKTsKKyAg ICAgICAgICAgIHByaW50Zl9zdGRlcnJfY29tbW9uKCIlLTNkICVwXG4iLCBmcmFtZU51bWJlciwg c3RhY2tbaV0pOwogICAgICAgICBmcmVlKGN4YURlbWFuZ2xlZCk7CiAgICAgfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuaCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5oCmluZGV4IDE0YjkwOTFmZDNhYWUyY2IwOTk5YWNi M2RkMGRmMjg4ZjZjNTQ0YjAuLjdjMzhmNTY0ZGU2NWRmYjJjMmZkZTQzZDRkYmQwNWUwM2EzMGFi NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQXNzZXJ0aW9ucy5oCkBAIC0xNDYsNiArMTQ2 LDcgQEAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RGTG9nVmVyYm9zZShjb25zdCBjaGFyKiBm aWxlLCBpbnQgbGluZSwgY29uc3QgY2hhciogZnUKIAogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQg V1RGR2V0QmFja3RyYWNlKHZvaWQqKiBzdGFjaywgaW50KiBzaXplKTsKIFdURl9FWFBPUlRfUFJJ VkFURSB2b2lkIFdURlJlcG9ydEJhY2t0cmFjZSgpOworV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQg V1RGUHJpbnRCYWNrdHJhY2Uodm9pZCoqIHN0YWNrLCBpbnQgc2l6ZSk7CiAKIHR5cGVkZWYgdm9p ZCAoKldURkNyYXNoSG9va0Z1bmN0aW9uKSgpOwogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgV1RG U2V0Q3Jhc2hIb29rKFdURkNyYXNoSG9va0Z1bmN0aW9uKTsK