80971 2012-03-13 00:32:30 -0700 Remove obsolete constructors of CSSPrimitiveValue class. 2012-03-14 19:09:46 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 81077 0 gram webkit-unassigned abarth apavlov kling koivisto macpherson menard ossy webkit.review.bot yuqiang.xian oldest_to_newest 577127 0 gram 2012-03-13 00:32:30 -0700 In CSSPrimitiveValueMappings.h file, there are many specialized template functions for CSSPrimitiveValue class. but the following constructors can't be reached. * template<> inline CSSPrimitiveValue::CSSPrimitiveValue(int i) * template<> inline CSSPrimitiveValue::CSSPrimitiveValue(unsigned i) For the each constructors, there exists overloaded constructor that has the same parameter types as corresponding constructor. Therefore, the overloaded constructor is always called instead of template specialized one. Moreover, they cause compile errors on the Intel compiler(icpc version 12.1.0) because icpc doesn't allow template function specialization with same parameter types as overloaded function. 577137 1 131566 gram 2012-03-13 00:39:16 -0700 Created attachment 131566 Patch 577139 2 131567 gram 2012-03-13 00:47:31 -0700 Created attachment 131567 Patch 578162 3 gram 2012-03-13 22:06:45 -0700 I create a new bug for Intel compiler support on Linux QT port. https://bugs.webkit.org/show_bug.cgi?id=81077 You can build using Intel compiler referring to the bug. 578999 4 gram 2012-03-14 18:06:45 -0700 Would you give me some review about this patch? 579040 5 131567 webkit.review.bot 2012-03-14 19:09:41 -0700 Comment on attachment 131567 Patch Clearing flags on attachment: 131567 Committed r110807: <http://trac.webkit.org/changeset/110807> 579041 6 webkit.review.bot 2012-03-14 19:09:46 -0700 All reviewed patches have been landed. Closing bug. 131566 2012-03-13 00:39:16 -0700 2012-03-13 00:47:24 -0700 Patch bug-80971-20120313163910.patch text/plain 1137 gram U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1By aW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAppbmRleCBkYTkyZTNkMTUwODgwY2IzNjI0MjkzZTUzMWRl MDk4OGY3MGY5MDhiLi44MGM1OTI4Y2I1MDQ1MmY5OWU4Y2VhZDViNWMyMmZmNGExYzZlYzI2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgKQEAg LTg2LDEzICs4Niw2IEBAIHRlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpvcGVy YXRvciB1bnNpZ25lZCBzaG9ydCgpIGNvbnN0CiAgICAgcmV0dXJuIDA7CiB9CiAKLXRlbXBsYXRl PD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1ZShpbnQgaSkKLSAg ICA6IENTU1ZhbHVlKFByaW1pdGl2ZUNsYXNzKQotewotICAgIG1fcHJpbWl0aXZlVW5pdFR5cGUg PSBDU1NfTlVNQkVSOwotICAgIG1fdmFsdWUubnVtID0gc3RhdGljX2Nhc3Q8ZG91YmxlPihpKTsK LX0KLQogdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJhdG9yIGludCgp IGNvbnN0CiB7CiAgICAgaWYgKG1fcHJpbWl0aXZlVW5pdFR5cGUgPT0gQ1NTX05VTUJFUikKQEAg LTEwMiwxMyArOTUsNiBAQCB0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6b3Bl cmF0b3IgaW50KCkgY29uc3QKICAgICByZXR1cm4gMDsKIH0KIAotdGVtcGxhdGU8PiBpbmxpbmUg Q1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKHVuc2lnbmVkIGkpCi0gICAgOiBD U1NWYWx1ZShQcmltaXRpdmVDbGFzcykKLXsKLSAgICBtX3ByaW1pdGl2ZVVuaXRUeXBlID0gQ1NT X05VTUJFUjsKLSAgICBtX3ZhbHVlLm51bSA9IHN0YXRpY19jYXN0PGRvdWJsZT4oaSk7Ci19Ci0K IHRlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpvcGVyYXRvciB1bnNpZ25lZCgp IGNvbnN0CiB7CiAgICAgaWYgKG1fcHJpbWl0aXZlVW5pdFR5cGUgPT0gQ1NTX05VTUJFUikK 131567 2012-03-13 00:47:31 -0700 2012-03-14 19:09:41 -0700 Patch bug-80971-20120313164725.patch text/plain 1832 gram U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2VmYWQ5ODczZDZjYmE5 ZjhjMzgxZWNhZmIzNDg3OWI0NjI4MGJlNC4uMDMxMjFiYWI2NjFkYmQ3YzE5ZDZjZTFmZmMzZWY5 ODcxNWU5MmY1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTEzICBLd29u amluIEplb25nICA8Z3JhbUBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZW1vdmUgb2Jzb2xl dGUgY29uc3RydWN0b3JzIG9mIENTU1ByaW1pdGl2ZVZhbHVlIGNsYXNzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5NzEKKworICAgICAgICBSZW1v dmUgY29uc3RydWN0b3JzIG9mIENTU1ByaW1pdGl2ZVZhbHVlIHRoYXQgY2FuJ3QgYmUKKyAgICAg ICAgcmVhY2hlZC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGNzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmg6CisKIDIwMTItMDMtMTIgIEtl bnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gUmVmYWN0 b3Igc29tZSBoZWFkZXIgaW5jbHVkZXMgaW4gVjggYmluZGluZ3MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmggYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCmluZGV4IGRhOTJlM2QxNTA4ODBjYjM2 MjQyOTNlNTMxZGUwOTg4ZjcwZjkwOGIuLjgwYzU5MjhjYjUwNDUyZjk5ZThjZWFkNWI1YzIyZmY0 YTFjNmVjMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1 ZU1hcHBpbmdzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFw cGluZ3MuaApAQCAtODYsMTMgKzg2LDYgQEAgdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZl VmFsdWU6Om9wZXJhdG9yIHVuc2lnbmVkIHNob3J0KCkgY29uc3QKICAgICByZXR1cm4gMDsKIH0K IAotdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVl KGludCBpKQotICAgIDogQ1NTVmFsdWUoUHJpbWl0aXZlQ2xhc3MpCi17Ci0gICAgbV9wcmltaXRp dmVVbml0VHlwZSA9IENTU19OVU1CRVI7Ci0gICAgbV92YWx1ZS5udW0gPSBzdGF0aWNfY2FzdDxk b3VibGU+KGkpOwotfQotCiB0ZW1wbGF0ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6b3Bl cmF0b3IgaW50KCkgY29uc3QKIHsKICAgICBpZiAobV9wcmltaXRpdmVVbml0VHlwZSA9PSBDU1Nf TlVNQkVSKQpAQCAtMTAyLDEzICs5NSw2IEBAIHRlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2 ZVZhbHVlOjpvcGVyYXRvciBpbnQoKSBjb25zdAogICAgIHJldHVybiAwOwogfQogCi10ZW1wbGF0 ZTw+IGlubGluZSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUodW5zaWduZWQg aSkKLSAgICA6IENTU1ZhbHVlKFByaW1pdGl2ZUNsYXNzKQotewotICAgIG1fcHJpbWl0aXZlVW5p dFR5cGUgPSBDU1NfTlVNQkVSOwotICAgIG1fdmFsdWUubnVtID0gc3RhdGljX2Nhc3Q8ZG91Ymxl PihpKTsKLX0KLQogdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJhdG9y IHVuc2lnbmVkKCkgY29uc3QKIHsKICAgICBpZiAobV9wcmltaXRpdmVVbml0VHlwZSA9PSBDU1Nf TlVNQkVSKQo=