80924 2012-03-12 18:46:43 -0700 [V8][Refactoring] Remove getCachedWrapperSlow() from V8Bindings.cpp 2012-03-12 21:22:26 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth arv japhet webkit.review.bot oldest_to_newest 576883 0 haraken 2012-03-12 18:46:43 -0700 getCachedWrapperSlow() is called by getCachedWrapper() only, and getCachedWrapperSlow() just calls getCachedWrapperInline(). Thus, we can expand getCachedWrapperInline() into getCachedWrapper(), which removes getCachedWrapperSlow(). 576887 1 131487 haraken 2012-03-12 18:49:05 -0700 Created attachment 131487 Patch 576893 2 131487 abarth 2012-03-12 19:09:44 -0700 Comment on attachment 131487 Patch This doesn't slow things down by inlining too much code? 576904 3 haraken 2012-03-12 19:14:48 -0700 (In reply to comment #2) > (From update of attachment 131487 [details]) > This doesn't slow things down by inlining too much code? I confirmed no perf regression in DOM core tests of DROMAEO. I do not think this change increases the inlined code. This change just moves getCachedWrapperInline(), which had been already inlined. 576906 4 131487 abarth 2012-03-12 19:17:12 -0700 Comment on attachment 131487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131487&action=review > Source/WebCore/bindings/v8/V8DOMWrapper.h:-135 > - return getCachedWrapperSlow(node); This function used to be out-of-line, but I think that's fine. 576909 5 haraken 2012-03-12 19:18:10 -0700 (In reply to comment #4) > > Source/WebCore/bindings/v8/V8DOMWrapper.h:-135 > > - return getCachedWrapperSlow(node); > > This function used to be out-of-line, but I think that's fine. Ah, I got it. Thanks for the clarification. Let me land it. 576992 6 131487 webkit.review.bot 2012-03-12 21:22:22 -0700 Comment on attachment 131487 Patch Clearing flags on attachment: 131487 Committed r110536: <http://trac.webkit.org/changeset/110536> 576993 7 webkit.review.bot 2012-03-12 21:22:26 -0700 All reviewed patches have been landed. Closing bug. 131487 2012-03-12 18:49:05 -0700 2012-03-12 21:22:22 -0700 Patch bug-80924-20120313104903.patch text/plain 4749 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNTI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA5MzU4MWRmZDhkNWM3 NWQyMGFhZGE0YWE3OWM0NTdlNmVhZGRlZS4uNTNmNDAxZDMxZGFkNTVhNDA0ZTQ1YTEwMTUzNTNi NmY1YjM0YTlhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTAzLTEyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdW1JlZmFjdG9y aW5nXSBSZW1vdmUgZ2V0Q2FjaGVkV3JhcHBlclNsb3coKSBmcm9tIFY4QmluZGluZ3MuY3BwCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDkyNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGdldENhY2hlZFdy YXBwZXJTbG93KCkgaXMgY2FsbGVkIGJ5IGdldENhY2hlZFdyYXBwZXIoKSBvbmx5LAorICAgICAg ICBhbmQgZ2V0Q2FjaGVkV3JhcHBlclNsb3coKSBqdXN0IGNhbGxzIGdldENhY2hlZFdyYXBwZXJJ bmxpbmUoKS4KKyAgICAgICAgVGh1cywgdGhpcyBwYXRjaCBleHBhbmRzIGdldENhY2hlZFdyYXBw ZXJJbmxpbmUoKSBpbnRvIGdldENhY2hlZFdyYXBwZXIoKSwKKyAgICAgICAgYW5kIHJlbW92ZXMg Z2V0Q2FjaGVkV3JhcHBlclNsb3coKS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGlu IGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKyAg ICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlY4 RE9NV3JhcHBlcjo6Z2V0Q2FjaGVkV3JhcHBlcik6CisKKzIwMTItMDMtMTIgIEtlbnRhcm8gSGFy YSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtWOF1bUmVmYWN0b3JpbmddIFJl bW92ZSBnZXRXcmFwcGVyKCkgYW5kIGdldFdyYXBwZXJTbG93KCkKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwOTIwCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IDlkMGZiN2M1ZDY4NThlYzlhYmE4YjNi NDBjYjVmMzBmNmZhMDVmNjguLmM5OTUyNzRjYjRiZjFkZTI3NzM1MjQyZmJkZGMyMTAyZGY3YTU5 ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcApAQCAt MzIsNyArMzIsNiBAQAogI2luY2x1ZGUgIlY4RE9NV3JhcHBlci5oIgogCiAjaW5jbHVkZSAiQXJy YXlCdWZmZXJWaWV3LmgiCi0jaW5jbHVkZSAiRE9NRGF0YVN0b3JlLmgiCiAjaW5jbHVkZSAiRG9j dW1lbnRMb2FkZXIuaCIKICNpbmNsdWRlICJFdmVudFRhcmdldEhlYWRlcnMuaCIKICNpbmNsdWRl ICJFdmVudFRhcmdldEludGVyZmFjZXMuaCIKQEAgLTQxLDEzICs0MCwxMSBAQAogI2luY2x1ZGUg IlY4QWJzdHJhY3RFdmVudExpc3RlbmVyLmgiCiAjaW5jbHVkZSAiVjhCaW5kaW5nLmgiCiAjaW5j bHVkZSAiVjhDb2xsZWN0aW9uLmgiCi0jaW5jbHVkZSAiVjhET01NYXAuaCIKICNpbmNsdWRlICJW OEV2ZW50TGlzdGVuZXIuaCIKICNpbmNsdWRlICJWOEV2ZW50TGlzdGVuZXJMaXN0LmgiCiAjaW5j bHVkZSAiVjhIVE1MQ29sbGVjdGlvbi5oIgogI2luY2x1ZGUgIlY4SFRNTERvY3VtZW50LmgiCiAj aW5jbHVkZSAiVjhIaWRkZW5Qcm9wZXJ0eU5hbWUuaCIKLSNpbmNsdWRlICJWOElzb2xhdGVkQ29u dGV4dC5oIgogI2luY2x1ZGUgIlY4TG9jYXRpb24uaCIKICNpbmNsdWRlICJWOE5hbWVkTm9kZU1h cC5oIgogI2luY2x1ZGUgIlY4Tm9kZUZpbHRlckNvbmRpdGlvbi5oIgpAQCAtNjksMjAgKzY2LDYg QEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdGF0aWMgQUxXQVlTX0lOTElORSB2ODo6SGFu ZGxlPHY4OjpPYmplY3Q+IGdldENhY2hlZFdyYXBwZXJJbmxpbmUoTm9kZSogbm9kZSkKLXsKLSAg ICBWOElzb2xhdGVkQ29udGV4dCogY29udGV4dCA9IFY4SXNvbGF0ZWRDb250ZXh0OjpnZXRFbnRl cmVkKCk7Ci0gICAgaWYgKExJS0VMWSghY29udGV4dCkpIHsKLSAgICAgICAgdjg6OlBlcnNpc3Rl bnQ8djg6Ok9iamVjdD4qIHdyYXBwZXIgPSBub2RlLT53cmFwcGVyKCk7Ci0gICAgICAgIGlmICgh d3JhcHBlcikKLSAgICAgICAgICAgIHJldHVybiB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+KCk7Ci0g ICAgICAgIHJldHVybiAqd3JhcHBlcjsKLSAgICB9Ci0gICAgRE9NRGF0YVN0b3JlKiBzdG9yZSA9 IGNvbnRleHQtPndvcmxkKCktPmRvbURhdGFTdG9yZSgpOwotICAgIERPTU5vZGVNYXBwaW5nJiBk b21Ob2RlTWFwID0gbm9kZS0+aXNBY3RpdmVOb2RlKCkgPyBzdG9yZS0+YWN0aXZlRG9tTm9kZU1h cCgpIDogc3RvcmUtPmRvbU5vZGVNYXAoKTsKLSAgICByZXR1cm4gZG9tTm9kZU1hcC5nZXQobm9k ZSk7Ci19Ci0KIC8vIFRoZSBjYWxsZXIgbXVzdCBoYXZlIGluY3JlYXNlZCBvYmoncyByZWYgY291 bnQuCiB2b2lkIFY4RE9NV3JhcHBlcjo6c2V0SlNXcmFwcGVyRm9yRE9NT2JqZWN0KHZvaWQqIG9i amVjdCwgdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD4gd3JhcHBlcikKIHsKQEAgLTMwMywxMSAr Mjg2LDYgQEAgYm9vbCBWOERPTVdyYXBwZXI6OmlzV3JhcHBlck9mVHlwZSh2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gdmFsdWUsIFdyYXBwZXJUeXBlSW5mbyoKICAgICByZXR1cm4gdHlwZUluZm8gPT0g dHlwZTsKIH0KIAotdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBWOERPTVdyYXBwZXI6OmdldENhY2hl ZFdyYXBwZXJTbG93KE5vZGUqIG5vZGUpCi17Ci0gICAgcmV0dXJuIGdldENhY2hlZFdyYXBwZXJJ bmxpbmUobm9kZSk7Ci19Ci0KICNkZWZpbmUgVFJZX1RPX1dSQVBfV0lUSF9JTlRFUkZBQ0UoaW50 ZXJmYWNlTmFtZSkgXAogICAgIGlmIChldmVudE5hbWVzKCkuaW50ZXJmYWNlRm9yIyNpbnRlcmZh Y2VOYW1lID09IGRlc2lyZWRJbnRlcmZhY2UpIFwKICAgICAgICAgcmV0dXJuIHRvVjgoc3RhdGlj X2Nhc3Q8aW50ZXJmYWNlTmFtZSo+KHRhcmdldCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTVdyYXBwZXIuaAppbmRleCA0ZWQzODUxYTI0MGNhMDNmZDdiODE2MDA5ODVjY2JjY2U2 MTkyMzMxLi4wZTgwYjIyOTY5NWY5ZDljOGZjOWUzMmQyZmVlYThkMmIzNDVhZjMyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaApAQCAtMzEsNiArMzEsNyBAQAog I2lmbmRlZiBWOERPTVdyYXBwZXJfaAogI2RlZmluZSBWOERPTVdyYXBwZXJfaAogCisjaW5jbHVk ZSAiRE9NRGF0YVN0b3JlLmgiCiAjaW5jbHVkZSAiRXZlbnQuaCIKICNpbmNsdWRlICJJc29sYXRl ZFdvcmxkLmgiCiAjaW5jbHVkZSAiTm9kZS5oIgpAQCAtMzgsNiArMzksNyBAQAogI2luY2x1ZGUg IlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSAiVjhDdXN0b21YUGF0aE5TUmVzb2x2ZXIuaCIK ICNpbmNsdWRlICJWOEV2ZW50LmgiCisjaW5jbHVkZSAiVjhJc29sYXRlZENvbnRleHQuaCIKICNp bmNsdWRlICJWOFV0aWxpdGllcy5oIgogI2luY2x1ZGUgIlY4WFBhdGhOU1Jlc29sdmVyLmgiCiAj aW5jbHVkZSAiV3JhcHBlclR5cGVJbmZvLmgiCkBAIC0xMzIsMTEgKzEzNCwxOCBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgICAgICAgICAgICAgaWYgKExJS0VMWSghIXdyYXBwZXIpKQogICAg ICAgICAgICAgICAgICAgICByZXR1cm4gKndyYXBwZXI7CiAgICAgICAgICAgICB9Ci0gICAgICAg ICAgICByZXR1cm4gZ2V0Q2FjaGVkV3JhcHBlclNsb3cobm9kZSk7Ci0gICAgICAgIH0KIAotICAg IHByaXZhdGU6Ci0gICAgICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdldENhY2hl ZFdyYXBwZXJTbG93KE5vZGUqKTsKKyAgICAgICAgICAgIFY4SXNvbGF0ZWRDb250ZXh0KiBjb250 ZXh0ID0gVjhJc29sYXRlZENvbnRleHQ6OmdldEVudGVyZWQoKTsKKyAgICAgICAgICAgIGlmIChM SUtFTFkoIWNvbnRleHQpKSB7CisgICAgICAgICAgICAgICAgdjg6OlBlcnNpc3RlbnQ8djg6Ok9i amVjdD4qIHdyYXBwZXIgPSBub2RlLT53cmFwcGVyKCk7CisgICAgICAgICAgICAgICAgaWYgKCF3 cmFwcGVyKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6T2JqZWN0 PigpOworICAgICAgICAgICAgICAgIHJldHVybiAqd3JhcHBlcjsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIERPTURhdGFTdG9yZSogc3RvcmUgPSBjb250ZXh0LT53b3JsZCgpLT5kb21EYXRh U3RvcmUoKTsKKyAgICAgICAgICAgIERPTU5vZGVNYXBwaW5nJiBkb21Ob2RlTWFwID0gbm9kZS0+ aXNBY3RpdmVOb2RlKCkgPyBzdG9yZS0+YWN0aXZlRG9tTm9kZU1hcCgpIDogc3RvcmUtPmRvbU5v ZGVNYXAoKTsKKyAgICAgICAgICAgIHJldHVybiBkb21Ob2RlTWFwLmdldChub2RlKTsKKyAgICAg ICAgfQogICAgIH07CiAKIH0K