80919 2012-03-12 18:12:26 -0700 [chromium] Use tileRect instead of pointer derefs 2012-03-12 20:33:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj backer cc-bugs enne jamesr webkit.review.bot oldest_to_newest 576840 0 danakj 2012-03-12 18:12:26 -0700 [chromium] Use tileRect instead of pointer derefs 576841 1 131479 danakj 2012-03-12 18:13:03 -0700 Created attachment 131479 Patch 576843 2 danakj 2012-03-12 18:14:44 -0700 tileRect is an alias for quad->quadVisibleRect() used throughout the LRC::drawTileQuad() method, except on these 4 lines. 576939 3 131479 enne 2012-03-12 19:47:02 -0700 Comment on attachment 131479 Patch Sure. Seems more consistent. 576972 4 131479 webkit.review.bot 2012-03-12 20:33:45 -0700 Comment on attachment 131479 Patch Clearing flags on attachment: 131479 Committed r110534: <http://trac.webkit.org/changeset/110534> 576973 5 webkit.review.bot 2012-03-12 20:33:49 -0700 All reviewed patches have been landed. Closing bug. 131479 2012-03-12 18:13:03 -0700 2012-03-12 20:33:45 -0700 Patch bug-80919-20120312211301.patch text/plain 2291 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDc3ZDhlMTkxZGY0ODEx NGZjZDdiY2I1NTZjZTA1ZTY2YjQ2YzNkMC4uNmM1NTlhMzVjZjY3OGE1MDMyNWE5M2ZkNTIxODhj NGYyYTRlOTc3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTEyICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gVXNl IHRpbGVSZWN0IGluc3RlYWQgb2YgcG9pbnRlciBkZXJlZnMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwOTE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1 bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdUaWxl UXVhZCk6CisKIDIwMTItMDMtMTIgIFNjb3R0IEJ5ZXIgIDxzY290dGJ5ZXJAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIENsZWFudXAgb2Jzb2xldGUgZmlsZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0u Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5k ZXJlckNocm9taXVtLmNwcAppbmRleCA0ZWQ4OWZkOWU2N2E3MmRmN2IxYjEyNGZkZWNhYmEyODJm ZjVhYTRiLi45ZWNlODlkY2E4YWFmNDc2NDIyNmJjNzhjMzM2MDBlZGZlNzdjNGQ4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRl cmVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKQEAgLTY1NiwxMyArNjU2LDEzIEBAIHZv aWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3VGlsZVF1YWQoY29uc3QgQ0NUaWxlRHJhd1F1 YWQqIHF1YWQpCiAgICAgICAgIENDTGF5ZXJRdWFkOjpFZGdlIHJpZ2h0RWRnZSh0b3BSaWdodCwg Ym90dG9tUmlnaHQpOwogCiAgICAgICAgIC8vIE9ubHkgYXBwbHkgYW50aS1hbGlhc2luZyB0byBl ZGdlcyBub3QgY2xpcHBlZCBkdXJpbmcgY3VsbGluZy4KLSAgICAgICAgaWYgKHF1YWQtPnRvcEVk Z2VBQSgpICYmIHF1YWQtPnF1YWRWaXNpYmxlUmVjdCgpLnkoKSA9PSBxdWFkLT5xdWFkUmVjdCgp LnkoKSkKKyAgICAgICAgaWYgKHF1YWQtPnRvcEVkZ2VBQSgpICYmIHRpbGVSZWN0LnkoKSA9PSBx dWFkLT5xdWFkUmVjdCgpLnkoKSkKICAgICAgICAgICAgIHRvcEVkZ2UgPSBkZXZpY2VMYXllckVk Z2VzLnRvcCgpOwotICAgICAgICBpZiAocXVhZC0+bGVmdEVkZ2VBQSgpICYmIHF1YWQtPnF1YWRW aXNpYmxlUmVjdCgpLngoKSA9PSBxdWFkLT5xdWFkUmVjdCgpLngoKSkKKyAgICAgICAgaWYgKHF1 YWQtPmxlZnRFZGdlQUEoKSAmJiB0aWxlUmVjdC54KCkgPT0gcXVhZC0+cXVhZFJlY3QoKS54KCkp CiAgICAgICAgICAgICBsZWZ0RWRnZSA9IGRldmljZUxheWVyRWRnZXMubGVmdCgpOwotICAgICAg ICBpZiAocXVhZC0+cmlnaHRFZGdlQUEoKSAmJiBxdWFkLT5xdWFkVmlzaWJsZVJlY3QoKS5tYXhY KCkgPT0gcXVhZC0+cXVhZFJlY3QoKS5tYXhYKCkpCisgICAgICAgIGlmIChxdWFkLT5yaWdodEVk Z2VBQSgpICYmIHRpbGVSZWN0Lm1heFgoKSA9PSBxdWFkLT5xdWFkUmVjdCgpLm1heFgoKSkKICAg ICAgICAgICAgIHJpZ2h0RWRnZSA9IGRldmljZUxheWVyRWRnZXMucmlnaHQoKTsKLSAgICAgICAg aWYgKHF1YWQtPmJvdHRvbUVkZ2VBQSgpICYmIHF1YWQtPnF1YWRWaXNpYmxlUmVjdCgpLm1heFko KSA9PSBxdWFkLT5xdWFkUmVjdCgpLm1heFkoKSkKKyAgICAgICAgaWYgKHF1YWQtPmJvdHRvbUVk Z2VBQSgpICYmIHRpbGVSZWN0Lm1heFkoKSA9PSBxdWFkLT5xdWFkUmVjdCgpLm1heFkoKSkKICAg ICAgICAgICAgIGJvdHRvbUVkZ2UgPSBkZXZpY2VMYXllckVkZ2VzLmJvdHRvbSgpOwogCiAgICAg ICAgIGZsb2F0IHNpZ24gPSBGbG9hdFF1YWQodGlsZVJlY3QpLmlzQ291bnRlcmNsb2Nrd2lzZSgp ID8gLTEgOiAxOwo=