80917 2012-03-12 18:04:30 -0700 Refactor some code that is used to check whether a layer needs backing store 2012-03-30 15:32:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser dino enne jamesr simon.fraser oldest_to_newest 576831 0 simon.fraser 2012-03-12 18:04:30 -0700 Refactor some code that is used to check whether a layer needs backing store 576834 1 131478 simon.fraser 2012-03-12 18:05:55 -0700 Created attachment 131478 Patch 577525 2 131478 dino 2012-03-13 10:42:44 -0700 Comment on attachment 131478 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131478&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:-836 > - > - // If we have got this far and the renderer has no children, then we're ok. > - if (!renderObject->firstChild()) > - return true; It seems like this is no longer tested for an early return? 577548 3 simon.fraser 2012-03-13 10:58:34 -0700 (In reply to comment #2) > (From update of attachment 131478 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=131478&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:-836 > > - > > - // If we have got this far and the renderer has no children, then we're ok. > > - if (!renderObject->firstChild()) > > - return true; The checks for child renderers and child layers effectively do the same test. > It seems like this is no longer tested for an early return? 592560 4 simon.fraser 2012-03-30 15:32:35 -0700 http://trac.webkit.org/changeset/110601 131478 2012-03-12 18:05:55 -0700 2012-03-13 10:42:44 -0700 Patch bug-80917-20120312180554.patch text/plain 4941 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE5ZjlmZDRmOTg3ZGYw NTlhYjE3OTI5N2Y4ODNhNmUxOTEzNTExOS4uZDQwZjBmMmJjMWQ0ZGFiNTRjZTExY2Y0ODFjNzEy N2RjMjU0YzJlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTAzLTEyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlZmFjdG9yIHNv bWUgY29kZSB0aGF0IGlzIHVzZWQgdG8gY2hlY2sgd2hldGhlciBhIGxheWVyIG5lZWRzIGJhY2tp bmcgc3RvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTgwOTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TW92ZSBzb21lIGNvZGUgb3V0IG9mIGlzU2ltcGxlQ29udGFpbmVyQ29tcG9zaXRpbmdMYXllcigp IGluIHR3byBuZXcKKyAgICAgICAgbWV0aG9kcyB0byBtYWtlIHRoZSBjb2RlIG1vcmUgc2VsZi1k ZXNjcmlwdGl2ZS4KKyAgICAgICAgCisgICAgICAgIE5vIGJlaGF2aW9yIGNoYW5nZSwgc28gbm8g dGVzdHMuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6cGFpbnRzQm94RGVjb3JhdGlvbnMp OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tp bmc6OnBhaW50c0NoaWxkcmVuKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2lu Zzo6aXNTaW1wbGVDb250YWluZXJDb21wb3NpdGluZ0xheWVyKToKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyTGF5ZXJCYWNraW5nLmg6CisgICAgICAgIChSZW5kZXJMYXllckJhY2tpbmcpOgor CiAyMDEyLTAzLTA4ICBSb2JpbiBDYW8gIDxyb2Jpbi5jYW9AdG9yY2htb2JpbGUuY29tLmNuPgog CiAgICAgICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVhbSBXZWJHTCByZWxhdGVkIGZpbGVzIGZyb20g cGxhdGZvcm0vZ3JhcGhpY3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQmFja2luZy5jcHAKaW5kZXggNDVhZGMyNDVjMjEyYWIyNGYwMWE1OWU4MWRiZTg3MjE4ODc3 N2IxMC4uMDkxYTIyNDAzZTY1YTFkNmYzZDVlYmE2ZDU1M2MzMjdlNGVkYjkzYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAgLTgwOSw2 ICs4MDksMzEgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUJhY2tncm91bmRDb2xv cigpCiAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRDb250ZW50c1RvQmFja2dyb3VuZENvbG9yKHJl bmRlcmVyQmFja2dyb3VuZENvbG9yKCkpOwogfQogCitib29sIFJlbmRlckxheWVyQmFja2luZzo6 cGFpbnRzQm94RGVjb3JhdGlvbnMoKSBjb25zdAoreworICAgIGlmICghbV9vd25pbmdMYXllci0+ aGFzVmlzaWJsZUNvbnRlbnQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKGhh c0JveERlY29yYXRpb25zT3JCYWNrZ3JvdW5kKHJlbmRlcmVyKCkpKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKworICAgIGlmIChtX293bmluZ0xheWVyLT5oYXNPdmVyZmxvd0NvbnRyb2xzKCkpCisg ICAgICAgIHJldHVybiB0cnVlOworCisgICAgcmV0dXJuIGZhbHNlOworfQorCitib29sIFJlbmRl ckxheWVyQmFja2luZzo6cGFpbnRzQ2hpbGRyZW4oKSBjb25zdAoreworICAgIGlmIChtX293bmlu Z0xheWVyLT5oYXNWaXNpYmxlQ29udGVudCgpICYmIGNvbnRhaW5zTm9uRW1wdHlSZW5kZXJlcnMo KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgICAgIAorICAgIGlmIChoYXNWaXNpYmxlTm9u Q29tcG9zaXRpbmdEZXNjZW5kYW50TGF5ZXJzKCkpCisgICAgICAgIHJldHVybiB0cnVlOworCisg ICAgcmV0dXJuIGZhbHNlOworfQorCiAvLyBBICJzaW1wbGUgY29udGFpbmVyIGxheWVyIiBpcyBh IFJlbmRlckxheWVyIHdoaWNoIGhhcyBubyB2aXNpYmxlIGNvbnRlbnQgdG8gcmVuZGVyLgogLy8g SXQgbWF5IGhhdmUgbm8gY2hpbGRyZW4sIG9yIGFsbCBpdHMgY2hpbGRyZW4gbWF5IGJlIHRoZW1z ZWx2ZXMgY29tcG9zaXRlZC4KIC8vIFRoaXMgaXMgYSB1c2VmdWwgb3B0aW1pemF0aW9uLCBiZWNh dXNlIGl0IGFsbG93cyB1cyB0byBhdm9pZCBhbGxvY2F0aW5nIGJhY2tpbmcgc3RvcmUuCkBAIC04 MTksMjEgKzg0NCw4IEBAIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjppc1NpbXBsZUNvbnRhaW5l ckNvbXBvc2l0aW5nTGF5ZXIoKSBjb25zdAogICAgICAgICByZW5kZXJPYmplY3QtPmhhc01hc2so KSkgICAgICAgICAgICAvLyBtYXNrcyByZXF1aXJlIHNwZWNpYWwgdHJlYXRtZW50CiAgICAgICAg IHJldHVybiBmYWxzZTsKIAotICAgIFJlbmRlclN0eWxlKiBzdHlsZSA9IHJlbmRlck9iamVjdC0+ c3R5bGUoKTsKLSAgICBib29sIGlzVmlzaWJsZSA9IG1fb3duaW5nTGF5ZXItPmhhc1Zpc2libGVD b250ZW50KCk7Ci0KLSAgICAvLyBSZWplY3QgYW55dGhpbmcgdGhhdCBoYXMgYSBib3JkZXIsIGEg Ym9yZGVyLXJhZGl1cyBvciBvdXRsaW5lLAotICAgIC8vIG9yIGFueSBiYWNrZ3JvdW5kIChjb2xv ciBvciBpbWFnZSkuCi0gICAgLy8gRklYTUU6IHdlIGNvdWxkIG9wdGltaXplIGxheWVycyBmb3Ig c2ltcGxlIGJhY2tncm91bmRzLgotICAgIGlmIChpc1Zpc2libGUgJiYgaGFzQm94RGVjb3JhdGlv bnNPckJhY2tncm91bmQocmVuZGVyT2JqZWN0KSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0g ICAgaWYgKGlzVmlzaWJsZSAmJiBtX293bmluZ0xheWVyLT5oYXNPdmVyZmxvd0NvbnRyb2xzKCkp CisgICAgaWYgKHBhaW50c0JveERlY29yYXRpb25zKCkgfHwgcGFpbnRzQ2hpbGRyZW4oKSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgLy8gSWYgd2UgaGF2ZSBnb3QgdGhpcyBmYXIgYW5k IHRoZSByZW5kZXJlciBoYXMgbm8gY2hpbGRyZW4sIHRoZW4gd2UncmUgb2suCi0gICAgaWYgKCFy ZW5kZXJPYmplY3QtPmZpcnN0Q2hpbGQoKSkKLSAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgCiAg ICAgaWYgKHJlbmRlck9iamVjdC0+bm9kZSgpICYmIHJlbmRlck9iamVjdC0+bm9kZSgpLT5pc0Rv Y3VtZW50Tm9kZSgpKSB7CiAgICAgICAgIC8vIExvb2sgdG8gc2VlIGlmIHRoZSByb290IG9iamVj dCBoYXMgYSBub24tc2ltcGxlIGJhY2tncm91bmQKQEAgLTg0MSw3ICs4NTMsNyBAQCBib29sIFJl bmRlckxheWVyQmFja2luZzo6aXNTaW1wbGVDb250YWluZXJDb21wb3NpdGluZ0xheWVyKCkgY29u c3QKICAgICAgICAgaWYgKCFyb290T2JqZWN0KQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgICAgICAKLSAgICAgICAgc3R5bGUgPSByb290T2JqZWN0LT5zdHlsZSgpOworICAgICAgICBS ZW5kZXJTdHlsZSogc3R5bGUgPSByb290T2JqZWN0LT5zdHlsZSgpOwogICAgICAgICAKICAgICAg ICAgLy8gUmVqZWN0IGFueXRoaW5nIHRoYXQgaGFzIGEgYm9yZGVyLCBhIGJvcmRlci1yYWRpdXMg b3Igb3V0bGluZSwKICAgICAgICAgLy8gb3IgaXMgbm90IGEgc2ltcGxlIGJhY2tncm91bmQgKG5v IGJhY2tncm91bmQsIG9yIHNvbGlkIGNvbG9yKS4KQEAgLTg2MCwxMyArODcyLDYgQEAgYm9vbCBS ZW5kZXJMYXllckJhY2tpbmc6OmlzU2ltcGxlQ29udGFpbmVyQ29tcG9zaXRpbmdMYXllcigpIGNv bnN0CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCi0gICAgLy8gQ2hlY2sgdG8g c2VlIGlmIGFsbCB0aGUgcmVuZGVyZXIncyBjaGlsZHJlbiBhcmUgY29tcG9zaXRpbmcgbGF5ZXJz LgotICAgIGlmIChpc1Zpc2libGUgJiYgY29udGFpbnNOb25FbXB0eVJlbmRlcmVycygpKQotICAg ICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIAotICAgIGlmIChoYXNWaXNpYmxlTm9uQ29tcG9z aXRpbmdEZXNjZW5kYW50TGF5ZXJzKCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAKICAg ICByZXR1cm4gdHJ1ZTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQmFja2luZy5oCmluZGV4IGE3NWUzMThiOTJjOGE4MjRiNzIwOGY0ZTY1NGNhODNjNjViMGNk YWMuLjQ3MjhjMWNjNzYzMjE5ZGUyNGFjMGViNTE5ZTRjZTc1MDRkMTU1MDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmgKQEAgLTE4Niw2ICsxODYs OSBAQCBwcml2YXRlOgogICAgIAogICAgIGJvb2wgaXNNYWluRnJhbWVSZW5kZXJWaWV3TGF5ZXIo KSBjb25zdDsKICAgICAKKyAgICBib29sIHBhaW50c0JveERlY29yYXRpb25zKCkgY29uc3Q7Cisg ICAgYm9vbCBwYWludHNDaGlsZHJlbigpIGNvbnN0OworCiAgICAgLy8gUmV0dXJucyB0cnVlIGlm IHRoaXMgY29tcG9zaXRpbmcgbGF5ZXIgaGFzIG5vIHZpc2libGUgY29udGVudC4KICAgICBib29s IGlzU2ltcGxlQ29udGFpbmVyQ29tcG9zaXRpbmdMYXllcigpIGNvbnN0OwogICAgIC8vIFJldHVy bnMgdHJ1ZSBpZiB0aGlzIGxheWVyIGhhcyBjb250ZW50IHRoYXQgbmVlZHMgdG8gYmUgcmVuZGVy ZWQgYnkgcGFpbnRpbmcgaW50byB0aGUgYmFja2luZyBzdG9yZS4K