80910 2012-03-12 17:23:11 -0700 [chromium] vsync ticks are needed in invisible tabs when we are still updating resources 2012-03-13 15:50:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca nduca cc-bugs husky jamesr webkit.review.bot oldest_to_newest 576773 0 nduca 2012-03-12 17:23:11 -0700 [chromium] vsync ticks are needed in invisible tabs when we are still updating resources 576774 1 131464 nduca 2012-03-12 17:23:35 -0700 Created attachment 131464 Patch 576777 2 nduca 2012-03-12 17:26:55 -0700 When we go in the background to another tab just before we begin a frame and commit, and there are more updates than can fit in a frame, then we forget to tick the scheduler. This leaves us the main thread blocked in the commit. 577475 3 nduca 2012-03-13 10:03:52 -0700 *** Bug 80995 has been marked as a duplicate of this bug. *** 577503 4 husky 2012-03-13 10:28:39 -0700 Confirmed that this patch fixes the bug for me. 577831 5 131464 jamesr 2012-03-13 14:45:50 -0700 Comment on attachment 131464 Patch R=me I think it would be useful to have a way to abort pending updates as well when going !visible or when dropping resources, so we don't upload until tiles that we wanna drop or have already dropped. 577858 6 nduca 2012-03-13 15:06:08 -0700 (In reply to comment #5) > I think it would be useful to have a way to abort pending updates as well when going !visible or when dropping resources, so we don't upload until tiles that we wanna drop or have already dropped. Or, maybe we can make the updates just skip --- e.g. we do the update step but early out the individual updates if they're discovered to be pointless. That'd allow us to speed through the update step if we were trying to drop command buffer resources, but still always drop the command buffer resources in a consistent place [COMMIT_IDLE]. 577930 7 131464 webkit.review.bot 2012-03-13 15:50:35 -0700 Comment on attachment 131464 Patch Clearing flags on attachment: 131464 Committed r110627: <http://trac.webkit.org/changeset/110627> 577931 8 webkit.review.bot 2012-03-13 15:50:39 -0700 All reviewed patches have been landed. Closing bug. 131464 2012-03-12 17:23:35 -0700 2012-03-13 15:50:35 -0700 Patch bug-80910-20120312172334.patch text/plain 5266 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTY2ZmIxNmJlYTMzMTIy ODUyOTkyODRjZTg4YmNjYmZmYWNiNTc2MS4uNTQxNTM1YWM2NzJjZmRiNzVlOWJlMDMxYTE1YmI4 ODcxNWEyNGM2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTEyICBOYXQg RHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIHZzeW5jIHRp Y2tzIGFyZSBuZWVkZWQgaW4gaW52aXNpYmxlIHRhYnMgd2hlbiB3ZSBhcmUgc3RpbGwgdXBkYXRp bmcgcmVzb3VyY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04MDkxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTY2hlZHVsZXJTdGF0ZU1hY2hp bmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NTY2hlZHVsZXJTdGF0ZU1hY2hpbmU6OnZzeW5j Q2FsbGJhY2tOZWVkZWQpOgorCiAyMDEyLTAzLTEyICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NA d2Via2l0Lm9yZz4KIAogICAgICAgICBJdCBkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8gcmV0dXJuIGNv bnN0IHVuc2lnbmVkLCBhbmQgR0NDIHdhcm5zIGFib3V0IGl0LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwppbmRleCAyMDRmYzExOWZjOWRmYjlkZGZiZjEyOGE2MGQ2NDE0NmRhZjU3OWE1Li4wZmRi MmNiM2M1ZWI4NDJlYWNmMGRlNjVkMzY1MGU0MmRmMWE5NjZjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEyLTAzLTEyICBOYXQgRHVjYSAgPG5kdWNhQGNo cm9taXVtLm9yZz4KIAorICAgICAgICBbY2hyb21pdW1dIHZzeW5jIHRpY2tzIGFyZSBuZWVkZWQg aW4gaW52aXNpYmxlIHRhYnMgd2hlbiB3ZSBhcmUgc3RpbGwgdXBkYXRpbmcgcmVzb3VyY2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDkxMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVzdHMvQ0NT Y2hlZHVsZXJTdGF0ZU1hY2hpbmVUZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRFU1QpOgor ICAgICAgICAoV2ViQ29yZSk6CisKKzIwMTItMDMtMTIgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21p dW0ub3JnPgorCiAgICAgICAgIFtDaHJvbWl1bV0gRm9yY2UgY29tcG9zaXRlQW5kUmVhZGJhY2sg dGhyb3VnaCByZWd1bGFyIHNjaGVkdWxpbmcgZmxvdwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzcwNDkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTY2hlZHVsZXJTdGF0ZU1hY2hpbmUu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTY2hl ZHVsZXJTdGF0ZU1hY2hpbmUuY3BwCmluZGV4IDg1ZDk0OWNjZjI4ZGRmMjE1Y2E3MzBjMzljOGFj NzlhODg2OWI0MWMuLmYzN2YwYjQxN2IzZWVkNTdmMjBjY2NlMzE1ZDY5MDNlZDlhN2E4ZDYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND U2NoZWR1bGVyU3RhdGVNYWNoaW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy9DQ1NjaGVkdWxlclN0YXRlTWFjaGluZS5jcHAKQEAgLTE2NCwx MyArMTY0LDEzIEBAIHZvaWQgQ0NTY2hlZHVsZXJTdGF0ZU1hY2hpbmU6OnVwZGF0ZVN0YXRlKEFj dGlvbiBhY3Rpb24pCiBib29sIENDU2NoZWR1bGVyU3RhdGVNYWNoaW5lOjp2c3luY0NhbGxiYWNr TmVlZGVkKCkgY29uc3QKIHsKICAgICBpZiAoIW1fdmlzaWJsZSB8fCBtX2NvbnRleHRTdGF0ZSAh PSBDT05URVhUX0FDVElWRSkgewotICAgICAgICBpZiAobV9uZWVkc0ZvcmNlZFJlZHJhdykKKyAg ICAgICAgaWYgKG1fbmVlZHNGb3JjZWRSZWRyYXcgfHwgbV9jb21taXRTdGF0ZSA9PSBDT01NSVRf U1RBVEVfVVBEQVRJTkdfUkVTT1VSQ0VTKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAotICAgIHJldHVybiBtX25lZWRzUmVkcmF3IHx8 IG1fbmVlZHNGb3JjZWRSZWRyYXcgfHwgbV91cGRhdGVNb3JlUmVzb3VyY2VzUGVuZGluZzsKKyAg ICByZXR1cm4gbV9uZWVkc1JlZHJhdyB8fCBtX25lZWRzRm9yY2VkUmVkcmF3IHx8IG1fY29tbWl0 U3RhdGUgPT0gQ09NTUlUX1NUQVRFX1VQREFUSU5HX1JFU09VUkNFUzsKIH0KIAogdm9pZCBDQ1Nj aGVkdWxlclN0YXRlTWFjaGluZTo6ZGlkRW50ZXJWU3luYygpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDU2NoZWR1bGVyU3RhdGVNYWNoaW5lVGVzdC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDU2NoZWR1bGVyU3RhdGVNYWNoaW5lVGVzdC5j cHAKaW5kZXggOGI5ODBkNTllODNlYTJjZjM5NWI3OTUxMmVjNzViYzdlZjE0ZDU3MS4uZWE2Yjky N2U1Mzk0NTBmMWQwYmFjYmE0MTcxOTIzZTc3Y2FkYmZjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9DQ1NjaGVkdWxlclN0YXRlTWFjaGluZVRlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NTY2hlZHVsZXJTdGF0ZU1hY2hpbmVUZXN0 LmNwcApAQCAtMTU5LDMwICsxNTksMTIgQEAgVEVTVChDQ1NjaGVkdWxlclN0YXRlTWFjaGluZVRl c3QsIFRlc3ROZXh0QWN0aW9uRHJhd3NPblZTeW5jKQogICAgICAgICAgICAgfSBlbHNlCiAgICAg ICAgICAgICAgICAgc3RhdGUuc2V0VmlzaWJsZSh0cnVlKTsKIAotICAgICAgICAgICAgLy8gQ2Fz ZSAxOiBuZWVkc0NvbW1pdD1mYWxzZSB1cGRhdGVNb3JlUmVzb3VyY2VzUGVuZGluZz1mYWxzZS4K KyAgICAgICAgICAgIC8vIENhc2UgMTogbmVlZHNDb21taXQ9ZmFsc2UKICAgICAgICAgICAgIHN0 YXRlLnNldE5lZWRzQ29tbWl0KGZhbHNlKTsKLSAgICAgICAgICAgIHN0YXRlLnNldFVwZGF0ZU1v cmVSZXNvdXJjZXNQZW5kaW5nKGZhbHNlKTsKLSAgICAgICAgICAgIEVYUEVDVF9GQUxTRShzdGF0 ZS52c3luY0NhbGxiYWNrTmVlZGVkKCkpOwotICAgICAgICAgICAgRVhQRUNUX05FKENDU2NoZWR1 bGVyU3RhdGVNYWNoaW5lOjpBQ1RJT05fRFJBVywgc3RhdGUubmV4dEFjdGlvbigpKTsKLQotICAg ICAgICAgICAgLy8gQ2FzZSAyOiBuZWVkc0NvbW1pdD1mYWxzZSB1cGRhdGVNb3JlUmVzb3VyY2Vz UGVuZGluZz10cnVlLgotICAgICAgICAgICAgc3RhdGUuc2V0TmVlZHNDb21taXQoZmFsc2UpOwot ICAgICAgICAgICAgc3RhdGUuc2V0VXBkYXRlTW9yZVJlc291cmNlc1BlbmRpbmcodHJ1ZSk7Ci0g ICAgICAgICAgICBpZiAodmlzaWJsZSkKLSAgICAgICAgICAgICAgICBFWFBFQ1RfVFJVRShzdGF0 ZS52c3luY0NhbGxiYWNrTmVlZGVkKCkpOwogICAgICAgICAgICAgRVhQRUNUX05FKENDU2NoZWR1 bGVyU3RhdGVNYWNoaW5lOjpBQ1RJT05fRFJBVywgc3RhdGUubmV4dEFjdGlvbigpKTsKIAotICAg ICAgICAgICAgLy8gQ2FzZSAzOiBuZWVkc0NvbW1pdD10cnVlIHVwZGF0ZU1vcmVSZXNvdXJjZXNQ ZW5kaW5nPWZhbHNlLgotICAgICAgICAgICAgc3RhdGUuc2V0TmVlZHNDb21taXQodHJ1ZSk7Ci0g ICAgICAgICAgICBzdGF0ZS5zZXRVcGRhdGVNb3JlUmVzb3VyY2VzUGVuZGluZyhmYWxzZSk7Ci0g ICAgICAgICAgICBFWFBFQ1RfRkFMU0Uoc3RhdGUudnN5bmNDYWxsYmFja05lZWRlZCgpKTsKLSAg ICAgICAgICAgIEVYUEVDVF9ORShDQ1NjaGVkdWxlclN0YXRlTWFjaGluZTo6QUNUSU9OX0RSQVcs IHN0YXRlLm5leHRBY3Rpb24oKSk7Ci0KLSAgICAgICAgICAgIC8vIENhc2UgNDogbmVlZHNDb21t aXQ9dHJ1ZSB1cGRhdGVNb3JlUmVzb3VyY2VzUGVuZGluZz10cnVlLgorICAgICAgICAgICAgLy8g Q2FzZSAyOiBuZWVkc0NvbW1pdD10cnVlCiAgICAgICAgICAgICBzdGF0ZS5zZXROZWVkc0NvbW1p dCh0cnVlKTsKLSAgICAgICAgICAgIHN0YXRlLnNldFVwZGF0ZU1vcmVSZXNvdXJjZXNQZW5kaW5n KHRydWUpOwotICAgICAgICAgICAgaWYgKHZpc2libGUpCi0gICAgICAgICAgICAgICAgRVhQRUNU X1RSVUUoc3RhdGUudnN5bmNDYWxsYmFja05lZWRlZCgpKTsKICAgICAgICAgICAgIEVYUEVDVF9O RShDQ1NjaGVkdWxlclN0YXRlTWFjaGluZTo6QUNUSU9OX0RSQVcsIHN0YXRlLm5leHRBY3Rpb24o KSk7CiAgICAgICAgIH0KICAgICB9CkBAIC0zNzEsNiArMzUzLDIwIEBAIFRFU1QoQ0NTY2hlZHVs ZXJTdGF0ZU1hY2hpbmVUZXN0LCBUZXN0VXBkYXRlc19Ob1JlZHJhd19Ud29Sb3VuZHNPZlVwZGF0 ZXMpCiAgICAgRVhQRUNUX0VRKENDU2NoZWR1bGVyU3RhdGVNYWNoaW5lOjpBQ1RJT05fQ09NTUlU LCBzdGF0ZS5uZXh0QWN0aW9uKCkpOwogfQogCisKK1RFU1QoQ0NTY2hlZHVsZXJTdGF0ZU1hY2hp bmVUZXN0LCBUZXN0VlN5bmNOZWVkZWRXaGVuVXBkYXRlc1BlbmRpbmdCdXRJbnZpc2libGUpCit7 CisgICAgU3RhdGVNYWNoaW5lIHN0YXRlOworICAgIHN0YXRlLnNldENvbW1pdFN0YXRlKENDU2No ZWR1bGVyU3RhdGVNYWNoaW5lOjpDT01NSVRfU1RBVEVfVVBEQVRJTkdfUkVTT1VSQ0VTKTsKKyAg ICBzdGF0ZS5zZXROZWVkc1JlZHJhdyhmYWxzZSk7CisgICAgc3RhdGUuc2V0VmlzaWJsZShmYWxz ZSk7CisgICAgc3RhdGUuc2V0VXBkYXRlTW9yZVJlc291cmNlc1BlbmRpbmcodHJ1ZSk7CisgICAg RVhQRUNUX1RSVUUoc3RhdGUudnN5bmNDYWxsYmFja05lZWRlZCgpKTsKKworICAgIHN0YXRlLnNl dFVwZGF0ZU1vcmVSZXNvdXJjZXNQZW5kaW5nKGZhbHNlKTsKKyAgICBFWFBFQ1RfVFJVRShzdGF0 ZS52c3luY0NhbGxiYWNrTmVlZGVkKCkpOworfQorCiBURVNUKENDU2NoZWR1bGVyU3RhdGVNYWNo aW5lVGVzdCwgVGVzdFVwZGF0ZXNfV2l0aFJlZHJhd19PbmVSb3VuZE9mVXBkYXRlcykKIHsKICAg ICBTdGF0ZU1hY2hpbmUgc3RhdGU7Cg==