80905 2012-03-12 16:12:00 -0700 Implement ApplicationCacheHost::canCacheInPageCache() for chromium. 2012-03-13 13:48:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gavinp gavinp dglazkov eric japhet webkit.review.bot oldest_to_newest 576673 0 gavinp 2012-03-12 16:12:00 -0700 Implement ApplicationCacheHost::canCacheInPageCache() for chromium. 576677 1 131438 gavinp 2012-03-12 16:15:34 -0700 Created attachment 131438 Patch 576683 2 131440 gavinp 2012-03-12 16:18:20 -0700 Created attachment 131440 Patch 576685 3 gavinp 2012-03-12 16:21:11 -0700 Wait a second while I learn webkit-patch upload. 576691 4 131442 gavinp 2012-03-12 16:24:48 -0700 Created attachment 131442 Patch 576700 5 131446 gavinp 2012-03-12 16:32:44 -0700 Created attachment 131446 Patch 576703 6 gavinp 2012-03-12 16:34:31 -0700 It took me a while, but I managed to get webkit-patch to upload a real patch. I am not turning on the PageCache with this; Settings stops it as I note in my comment. However, this will make the statistics I'm gathering in PageCache.cpp to reevaluate that decision much better. Note this patch is made relative to Bug 80904, so can't land until after that patch. 576759 7 131446 webkit.review.bot 2012-03-12 17:09:57 -0700 Comment on attachment 131446 Patch Attachment 131446 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11943230 576979 8 131446 gavinp 2012-03-12 20:46:44 -0700 Comment on attachment 131446 Patch The chromium buildbot failure is expected; given that 80904 hasn't landed yet. I'll upload another patch to double-check EWS after any review. 577338 9 131619 gavinp 2012-03-13 08:26:04 -0700 Created attachment 131619 Patch 577339 10 gavinp 2012-03-13 08:26:38 -0700 Bug 80904 has landed, so this upload is the same as the last one: except I expect it to pass EWS because the tree has changed. 577626 11 131619 eric 2012-03-13 11:58:03 -0700 Comment on attachment 131619 Patch I assume you've audited the callers? 577633 12 gavinp 2012-03-13 12:06:14 -0700 There are two callers: both are in PageCache.cpp. The first is in the debug printing/histogram gathering code in the PageCache. This change will make that family of histograms better reflect what PageCache performance would be if we used the PageCache. The second is in PageCache::canCachePageContainingThisFrame(). That's moot because frameLoader->client()->canCachePage() will always fail, so it will always return the same result. As well, page->settings()->usesPageCache() is usually false in chrome (modulo a command line argument that combined with the above does nothing). If I ever want to make frameLoader->client()->canCachePage() report better stats, I'll have to either disable the command line flag to "turn on pagecache" or make page-cache work well enough not to ruin the lives of those brave canaries who have set this (currently nonfunctional) command line argument. 577774 13 131619 webkit.review.bot 2012-03-13 13:48:15 -0700 Comment on attachment 131619 Patch Clearing flags on attachment: 131619 Committed r110600: <http://trac.webkit.org/changeset/110600> 577775 14 webkit.review.bot 2012-03-13 13:48:28 -0700 All reviewed patches have been landed. Closing bug. 131438 2012-03-12 16:15:34 -0700 2012-03-12 16:18:15 -0700 Patch bug-80905-20120312191533.patch text/plain 1091 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKaW5kZXggZWIwYTlmZmUxOGExOTZhMWIx M2YwNWNjZWJmMDRjNWZmMDQyOGYzZi4uYmJmNzQwZGZkMzMxNGIxYjJiNmNjYzk5YWJkMTVjNmEz MWM4NDQ5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRp b25DYWNoZUhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0FwcGxpY2F0 aW9uQ2FjaGVIb3N0LmNwcApAQCAtMTk1LDggKzE5NSwxMCBAQCB2b2lkIEFwcGxpY2F0aW9uQ2Fj aGVIb3N0OjptYXliZUxvYWRGYWxsYmFja1N5bmNocm9ub3VzbHkoY29uc3QgUmVzb3VyY2VSZXF1 ZXN0JgogCiBib29sIEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNoZUluUGFnZUNhY2hlKCkK IHsKLSAgICAvLyBOL0EgdG8gdGhlIGNocm9taXVtIHBvcnQgd2hpY2ggZG9lc24ndCB1c2UgdGhl IHBhZ2UgY2FjaGUuCi0gICAgcmV0dXJuIGZhbHNlOworICAgIC8vIENocm9taXVtIGRvZXNuJ3Qg dXNlIHRoZSBwYWdlIGNhY2hlLCBob3dldmVyLCB0aGF0J3MgY29udHJvbGxlZCBieSBXZWJDb3Jl OjpTZXR0aW5ncywgd2hpY2ggaGFzIHVzZXNQYWdlQ2FjaGUoKSByZXR1cm4KKyAgICAvLyBmYWxz ZS4gU28gd2UgcmV0dXJuIGFuIGh5cHRvdGhldGljYWwgaGVyZTogQ2hyb21pdW0gd29uJ3QgZW5k IHVwIHVzaW5nIHRoZSBQYWdlQ2FjaGUsIGJ1dCB0aGUgc3RhdGlzdGljcyBpbiBQYWdlQ2FjaGUu Y3BwCisgICAgLy8gd2lsbCBiZSByZXBvcnRlZCBjb3JyZWN0bHkgZm9yIHJlLWV2YWx1YXRpbmcg dGhhdCBkZWNpc2lvbi4KKyAgICByZXR1cm4gIWlzQXBwbGljYXRpb25DYWNoZUVuYWJsZWQoKSB8 fCBzdGF0dXMoKSA9PSBVTkNBQ0hFRDsKIH0KIAogdm9pZCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6 c2V0RE9NQXBwbGljYXRpb25DYWNoZShET01BcHBsaWNhdGlvbkNhY2hlKiBkb21BcHBsaWNhdGlv bkNhY2hlKQo= 131440 2012-03-12 16:18:20 -0700 2012-03-12 16:24:44 -0700 Patch bug-80905-20120312191818.patch text/plain 2355 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGFiMzY1ZTBiMTU2NmQ5NGM2ZDVmNjUzMGU0Mzc2NDkwZGY5YjE1YjcuLjMwY2RmZTAyZGRhZTE4 MjBjYzE2ZTMyMmQzZjc5NDgzY2Y5Mzk4ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMjggQEAKIDIwMTItMDMtMTIgIEdhdmluIFBldGVycyAgPGdhdmlucEBjaHJvbWl1 bS5vcmc+CiAKKyAgICAgICAgSW1wbGVtZW50IEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNo ZUluUGFnZUNhY2hlKCkgZm9yIGNocm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHNyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlSG9zdDo6Y2FuQ2FjaGVJblBhZ2VDYWNoZSk6 CisKKzIwMTItMDMtMTIgIEdhdmluIFBldGVycyAgPGdhdmlucEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgSW1wbGVtZW50IEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNoZUluUGFnZUNhY2hl KCkgZm9yIGNocm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODA5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIHdvbid0IGNhdXNlIGNocm9tZSB0byB1c2UgdGhlIFBhZ2VDYWNoZSwgYnV0 IGl0IHdpbGwgY2F1c2Ugb3VyIGhpc3RvZ3JhbSBzdGF0aXN0aWNzCisgICAgICAgIGRlc2NyaWJp bmcgUGFnZUNhY2hlIHVzZSB0byBiZSBtb3JlIGFjY3VyYXRlLgorCisgICAgICAgICogc3JjL0Fw cGxpY2F0aW9uQ2FjaGVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFwcGxpY2F0aW9uQ2Fj aGVIb3N0OjpjYW5DYWNoZUluUGFnZUNhY2hlKToKKworMjAxMi0wMy0xMiAgR2F2aW4gUGV0ZXJz ICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KKwogICAgICAgICBNYWtlIEFwcGxpY2F0aW9uQ2FjaGVI b3N0OjpjYW5DYWNoZUluUGFnZUNhY2hlKCkgbm9uLWNvbnN0LgogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5MDQKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCmluZGV4IGViMGE5ZmZl MThhMTk2YTFiMTNmMDVjY2ViZjA0YzVmZjA0MjhmM2YuLmJiZjc0MGRmZDMzMTRiMWIyYjZjY2M5 OWFiZDE1YzZhMzFjODQ0OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKQEAgLTE5NSw4ICsxOTUsMTAgQEAgdm9pZCBBcHBs aWNhdGlvbkNhY2hlSG9zdDo6bWF5YmVMb2FkRmFsbGJhY2tTeW5jaHJvbm91c2x5KGNvbnN0IFJl c291cmNlUmVxdWVzdCYKIAogYm9vbCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6Y2FuQ2FjaGVJblBh Z2VDYWNoZSgpCiB7Ci0gICAgLy8gTi9BIHRvIHRoZSBjaHJvbWl1bSBwb3J0IHdoaWNoIGRvZXNu J3QgdXNlIHRoZSBwYWdlIGNhY2hlLgotICAgIHJldHVybiBmYWxzZTsKKyAgICAvLyBDaHJvbWl1 bSBkb2Vzbid0IHVzZSB0aGUgcGFnZSBjYWNoZSwgaG93ZXZlciwgdGhhdCdzIGNvbnRyb2xsZWQg YnkgV2ViQ29yZTo6U2V0dGluZ3MsIHdoaWNoIGhhcyB1c2VzUGFnZUNhY2hlKCkgcmV0dXJuCisg ICAgLy8gZmFsc2UuIFNvIHdlIHJldHVybiBhbiBoeXB0b3RoZXRpY2FsIGhlcmU6IENocm9taXVt IHdvbid0IGVuZCB1cCB1c2luZyB0aGUgUGFnZUNhY2hlLCBidXQgdGhlIHN0YXRpc3RpY3MgaW4g UGFnZUNhY2hlLmNwcAorICAgIC8vIHdpbGwgYmUgcmVwb3J0ZWQgY29ycmVjdGx5IGZvciByZS1l dmFsdWF0aW5nIHRoYXQgZGVjaXNpb24uCisgICAgcmV0dXJuICFpc0FwcGxpY2F0aW9uQ2FjaGVF bmFibGVkKCkgfHwgc3RhdHVzKCkgPT0gVU5DQUNIRUQ7CiB9CiAKIHZvaWQgQXBwbGljYXRpb25D YWNoZUhvc3Q6OnNldERPTUFwcGxpY2F0aW9uQ2FjaGUoRE9NQXBwbGljYXRpb25DYWNoZSogZG9t QXBwbGljYXRpb25DYWNoZSkK 131442 2012-03-12 16:24:48 -0700 2012-03-12 16:32:39 -0700 Patch bug-80905-20120312192446.patch text/plain 1091 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKaW5kZXggZWIwYTlmZmUxOGExOTZhMWIx M2YwNWNjZWJmMDRjNWZmMDQyOGYzZi4uYmJmNzQwZGZkMzMxNGIxYjJiNmNjYzk5YWJkMTVjNmEz MWM4NDQ5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRp b25DYWNoZUhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0FwcGxpY2F0 aW9uQ2FjaGVIb3N0LmNwcApAQCAtMTk1LDggKzE5NSwxMCBAQCB2b2lkIEFwcGxpY2F0aW9uQ2Fj aGVIb3N0OjptYXliZUxvYWRGYWxsYmFja1N5bmNocm9ub3VzbHkoY29uc3QgUmVzb3VyY2VSZXF1 ZXN0JgogCiBib29sIEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNoZUluUGFnZUNhY2hlKCkK IHsKLSAgICAvLyBOL0EgdG8gdGhlIGNocm9taXVtIHBvcnQgd2hpY2ggZG9lc24ndCB1c2UgdGhl IHBhZ2UgY2FjaGUuCi0gICAgcmV0dXJuIGZhbHNlOworICAgIC8vIENocm9taXVtIGRvZXNuJ3Qg dXNlIHRoZSBwYWdlIGNhY2hlLCBob3dldmVyLCB0aGF0J3MgY29udHJvbGxlZCBieSBXZWJDb3Jl OjpTZXR0aW5ncywgd2hpY2ggaGFzIHVzZXNQYWdlQ2FjaGUoKSByZXR1cm4KKyAgICAvLyBmYWxz ZS4gU28gd2UgcmV0dXJuIGFuIGh5cHRvdGhldGljYWwgaGVyZTogQ2hyb21pdW0gd29uJ3QgZW5k IHVwIHVzaW5nIHRoZSBQYWdlQ2FjaGUsIGJ1dCB0aGUgc3RhdGlzdGljcyBpbiBQYWdlQ2FjaGUu Y3BwCisgICAgLy8gd2lsbCBiZSByZXBvcnRlZCBjb3JyZWN0bHkgZm9yIHJlLWV2YWx1YXRpbmcg dGhhdCBkZWNpc2lvbi4KKyAgICByZXR1cm4gIWlzQXBwbGljYXRpb25DYWNoZUVuYWJsZWQoKSB8 fCBzdGF0dXMoKSA9PSBVTkNBQ0hFRDsKIH0KIAogdm9pZCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6 c2V0RE9NQXBwbGljYXRpb25DYWNoZShET01BcHBsaWNhdGlvbkNhY2hlKiBkb21BcHBsaWNhdGlv bkNhY2hlKQo= 131446 2012-03-12 16:32:44 -0700 2012-03-13 08:25:59 -0700 Patch bug-80905-20120312193243.patch text/plain 2025 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGFiMzY1ZTBiMTU2NmQ5NGM2ZDVmNjUzMGU0Mzc2NDkwZGY5YjE1YjcuLmMxOWUxNmNlOTBkNjNl YTI2MmVjNjA0NDhiZmFjZWM2NDYyMDU4OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTggQEAKIDIwMTItMDMtMTIgIEdhdmluIFBldGVycyAgPGdhdmlucEBjaHJvbWl1 bS5vcmc+CiAKKyAgICAgICAgSW1wbGVtZW50IEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNo ZUluUGFnZUNhY2hlKCkgZm9yIGNocm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHdvbid0IGNhdXNlIGNocm9tZSB0byB1c2UgdGhlIFBh Z2VDYWNoZSwgYnV0IGl0IHdpbGwgY2F1c2Ugb3VyIGhpc3RvZ3JhbSBzdGF0aXN0aWNzCisgICAg ICAgIGRlc2NyaWJpbmcgUGFnZUNhY2hlIHVzZSB0byBiZSBtb3JlIGFjY3VyYXRlLgorCisgICAg ICAgICogc3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFw cGxpY2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNoZUluUGFnZUNhY2hlKToKKworMjAxMi0wMy0xMiAg R2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KKwogICAgICAgICBNYWtlIEFwcGxp Y2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNoZUluUGFnZUNhY2hlKCkgbm9uLWNvbnN0LgogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5MDQKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCmlu ZGV4IGViMGE5ZmZlMThhMTk2YTFiMTNmMDVjY2ViZjA0YzVmZjA0MjhmM2YuLmJiZjc0MGRmZDMz MTRiMWIyYjZjY2M5OWFiZDE1YzZhMzFjODQ0OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKQEAgLTE5NSw4ICsxOTUsMTAg QEAgdm9pZCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6bWF5YmVMb2FkRmFsbGJhY2tTeW5jaHJvbm91 c2x5KGNvbnN0IFJlc291cmNlUmVxdWVzdCYKIAogYm9vbCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6 Y2FuQ2FjaGVJblBhZ2VDYWNoZSgpCiB7Ci0gICAgLy8gTi9BIHRvIHRoZSBjaHJvbWl1bSBwb3J0 IHdoaWNoIGRvZXNuJ3QgdXNlIHRoZSBwYWdlIGNhY2hlLgotICAgIHJldHVybiBmYWxzZTsKKyAg ICAvLyBDaHJvbWl1bSBkb2Vzbid0IHVzZSB0aGUgcGFnZSBjYWNoZSwgaG93ZXZlciwgdGhhdCdz IGNvbnRyb2xsZWQgYnkgV2ViQ29yZTo6U2V0dGluZ3MsIHdoaWNoIGhhcyB1c2VzUGFnZUNhY2hl KCkgcmV0dXJuCisgICAgLy8gZmFsc2UuIFNvIHdlIHJldHVybiBhbiBoeXB0b3RoZXRpY2FsIGhl cmU6IENocm9taXVtIHdvbid0IGVuZCB1cCB1c2luZyB0aGUgUGFnZUNhY2hlLCBidXQgdGhlIHN0 YXRpc3RpY3MgaW4gUGFnZUNhY2hlLmNwcAorICAgIC8vIHdpbGwgYmUgcmVwb3J0ZWQgY29ycmVj dGx5IGZvciByZS1ldmFsdWF0aW5nIHRoYXQgZGVjaXNpb24uCisgICAgcmV0dXJuICFpc0FwcGxp Y2F0aW9uQ2FjaGVFbmFibGVkKCkgfHwgc3RhdHVzKCkgPT0gVU5DQUNIRUQ7CiB9CiAKIHZvaWQg QXBwbGljYXRpb25DYWNoZUhvc3Q6OnNldERPTUFwcGxpY2F0aW9uQ2FjaGUoRE9NQXBwbGljYXRp b25DYWNoZSogZG9tQXBwbGljYXRpb25DYWNoZSkK 131619 2012-03-13 08:26:04 -0700 2012-03-13 13:48:15 -0700 Patch bug-80905-20120313112603.patch text/plain 2025 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGFiMzY1ZTBiMTU2NmQ5NGM2ZDVmNjUzMGU0Mzc2NDkwZGY5YjE1YjcuLmMxOWUxNmNlOTBkNjNl YTI2MmVjNjA0NDhiZmFjZWM2NDYyMDU4OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTggQEAKIDIwMTItMDMtMTIgIEdhdmluIFBldGVycyAgPGdhdmlucEBjaHJvbWl1 bS5vcmc+CiAKKyAgICAgICAgSW1wbGVtZW50IEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNo ZUluUGFnZUNhY2hlKCkgZm9yIGNocm9taXVtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGlzIHdvbid0IGNhdXNlIGNocm9tZSB0byB1c2UgdGhlIFBh Z2VDYWNoZSwgYnV0IGl0IHdpbGwgY2F1c2Ugb3VyIGhpc3RvZ3JhbSBzdGF0aXN0aWNzCisgICAg ICAgIGRlc2NyaWJpbmcgUGFnZUNhY2hlIHVzZSB0byBiZSBtb3JlIGFjY3VyYXRlLgorCisgICAg ICAgICogc3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFw cGxpY2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNoZUluUGFnZUNhY2hlKToKKworMjAxMi0wMy0xMiAg R2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KKwogICAgICAgICBNYWtlIEFwcGxp Y2F0aW9uQ2FjaGVIb3N0OjpjYW5DYWNoZUluUGFnZUNhY2hlKCkgbm9uLWNvbnN0LgogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA5MDQKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCmlu ZGV4IGViMGE5ZmZlMThhMTk2YTFiMTNmMDVjY2ViZjA0YzVmZjA0MjhmM2YuLmJiZjc0MGRmZDMz MTRiMWIyYjZjY2M5OWFiZDE1YzZhMzFjODQ0OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKQEAgLTE5NSw4ICsxOTUsMTAg QEAgdm9pZCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6bWF5YmVMb2FkRmFsbGJhY2tTeW5jaHJvbm91 c2x5KGNvbnN0IFJlc291cmNlUmVxdWVzdCYKIAogYm9vbCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6 Y2FuQ2FjaGVJblBhZ2VDYWNoZSgpCiB7Ci0gICAgLy8gTi9BIHRvIHRoZSBjaHJvbWl1bSBwb3J0 IHdoaWNoIGRvZXNuJ3QgdXNlIHRoZSBwYWdlIGNhY2hlLgotICAgIHJldHVybiBmYWxzZTsKKyAg ICAvLyBDaHJvbWl1bSBkb2Vzbid0IHVzZSB0aGUgcGFnZSBjYWNoZSwgaG93ZXZlciwgdGhhdCdz IGNvbnRyb2xsZWQgYnkgV2ViQ29yZTo6U2V0dGluZ3MsIHdoaWNoIGhhcyB1c2VzUGFnZUNhY2hl KCkgcmV0dXJuCisgICAgLy8gZmFsc2UuIFNvIHdlIHJldHVybiBhbiBoeXB0b3RoZXRpY2FsIGhl cmU6IENocm9taXVtIHdvbid0IGVuZCB1cCB1c2luZyB0aGUgUGFnZUNhY2hlLCBidXQgdGhlIHN0 YXRpc3RpY3MgaW4gUGFnZUNhY2hlLmNwcAorICAgIC8vIHdpbGwgYmUgcmVwb3J0ZWQgY29ycmVj dGx5IGZvciByZS1ldmFsdWF0aW5nIHRoYXQgZGVjaXNpb24uCisgICAgcmV0dXJuICFpc0FwcGxp Y2F0aW9uQ2FjaGVFbmFibGVkKCkgfHwgc3RhdHVzKCkgPT0gVU5DQUNIRUQ7CiB9CiAKIHZvaWQg QXBwbGljYXRpb25DYWNoZUhvc3Q6OnNldERPTUFwcGxpY2F0aW9uQ2FjaGUoRE9NQXBwbGljYXRp b25DYWNoZSogZG9tQXBwbGljYXRpb25DYWNoZSkK