80903 2012-03-12 15:56:20 -0700 Web Inspector: InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly 2012-03-12 16:34:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 34679 1 beidson beidson apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 576646 0 beidson 2012-03-12 15:56:20 -0700 Web Inspector: InspectorDOMStorageAgent creates a Storage object which is a DOMWindowProperty - Should use the StorageArea directly DOMWindowProperties are a mechanism for registering with the DOMWindow which has one specific lifetime. WebInspector resources have a completely distinct lifetime, and should not be instantiating DOMWindowProperties. It seems that there is no reason the Inspector resource couldn't use the StorageArea directly. This was discovered while fixing https://bugs.webkit.org/show_bug.cgi?id=34679 and is currently blocking it. 576674 1 131437 beidson 2012-03-12 16:12:56 -0700 Created attachment 131437 Make it use the StorageArea directly 576676 2 webkit.review.bot 2012-03-12 16:14:58 -0700 Attachment 131437 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InspectorDOMStorageResource.h:43: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 576678 3 131437 timothy 2012-03-12 16:15:45 -0700 Comment on attachment 131437 Make it use the StorageArea directly View in context: https://bugs.webkit.org/attachment.cgi?id=131437&action=review > Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:115 > + Frame* frame = storageResource->frame(); > if (storageResource) { These lines need flipped so the Frame is inside the null check. Fix before landing. 576704 4 beidson 2012-03-12 16:34:58 -0700 http://trac.webkit.org/changeset/110500 131437 2012-03-12 16:12:56 -0700 2012-03-12 16:15:45 -0700 Make it use the StorageArea directly textmate stdin GrkJ7B.txt text/plain 6866 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMzFhYzlkLi5mOGNmNDliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTItMDMtMTIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDkwMworICAgICAg ICBJbnNwZWN0b3JET01TdG9yYWdlQWdlbnQgY3JlYXRlcyBhIFN0b3JhZ2Ugb2JqZWN0IHdoaWNo IGlzIGEgRE9NV2luZG93UHJvcGVydHkgLSBTaG91bGQgdXNlIHRoZSBTdG9yYWdlQXJlYSBkaXJl Y3RseQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4gKE5vIGJlaGF2aW9yIGNoYW5nZSkKKworICAgICAgICBDaGFuZ2VkIHRvIGhv bGQgdGhlIFN0b3JhZ2VBcmVhIGRpcmVjdGx5IGFuZCBhZGRlZCBhIEZyYW1lKiBhY2Nlc3NvcjoK KyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlLmg6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2U6OmNyZWF0ZSk6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2U6OnN0b3JhZ2VBcmVhKToK KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZTo6ZnJhbWUpOgor ICAgICAgICAoSW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlKToKKworICAgICAgICAqIGluc3Bl Y3Rvci9JbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlOjpJbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2Up OgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTVN0b3JhZ2VBZ2VudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01TdG9yYWdlQWdlbnQ6OmdldERPTVN0b3JhZ2VF bnRyaWVzKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTVN0b3JhZ2VBZ2VudDo6c2V0 RE9NU3RvcmFnZUl0ZW0pOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NU3RvcmFnZUFn ZW50OjpyZW1vdmVET01TdG9yYWdlSXRlbSk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JE T01TdG9yYWdlQWdlbnQ6OmRpZFVzZURPTVN0b3JhZ2UpOgorCiAyMDEyLTAzLTEyICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIGds b2JhbCBzdGF0aWMgdmFyaWFibGUgZm9yIEJsYWNrQmVycnkuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NU3RvcmFnZUFnZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01TdG9yYWdlQWdlbnQuY3BwCmluZGV4IDYzZGFm MzkuLjkyNTE4OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JET01TdG9yYWdlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JET01TdG9yYWdlQWdlbnQuY3BwCkBAIC0xMTEsMTIgKzExMSwxMyBAQCB2b2lkIEluc3Bl Y3RvckRPTVN0b3JhZ2VBZ2VudDo6ZGlzYWJsZShFcnJvclN0cmluZyopCiB2b2lkIEluc3BlY3Rv ckRPTVN0b3JhZ2VBZ2VudDo6Z2V0RE9NU3RvcmFnZUVudHJpZXMoRXJyb3JTdHJpbmcqLCBpbnQg c3RvcmFnZUlkLCBSZWZQdHI8SW5zcGVjdG9yQXJyYXk+JiBlbnRyaWVzKQogewogICAgIEluc3Bl Y3RvckRPTVN0b3JhZ2VSZXNvdXJjZSogc3RvcmFnZVJlc291cmNlID0gZ2V0RE9NU3RvcmFnZVJl c291cmNlRm9ySWQoc3RvcmFnZUlkKTsKKyAgICBGcmFtZSogZnJhbWUgPSBzdG9yYWdlUmVzb3Vy Y2UtPmZyYW1lKCk7CiAgICAgaWYgKHN0b3JhZ2VSZXNvdXJjZSkgewogICAgICAgICBzdG9yYWdl UmVzb3VyY2UtPnN0YXJ0UmVwb3J0aW5nQ2hhbmdlc1RvRnJvbnRlbmQoKTsKLSAgICAgICAgU3Rv cmFnZSogZG9tU3RvcmFnZSA9IHN0b3JhZ2VSZXNvdXJjZS0+ZG9tU3RvcmFnZSgpOwotICAgICAg ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgZG9tU3RvcmFnZS0+bGVuZ3RoKCk7ICsraSkgewot ICAgICAgICAgICAgU3RyaW5nIG5hbWUoZG9tU3RvcmFnZS0+a2V5KGkpKTsKLSAgICAgICAgICAg IFN0cmluZyB2YWx1ZShkb21TdG9yYWdlLT5nZXRJdGVtKG5hbWUpKTsKKyAgICAgICAgU3RvcmFn ZUFyZWEqIHN0b3JhZ2VBcmVhID0gc3RvcmFnZVJlc291cmNlLT5zdG9yYWdlQXJlYSgpOworICAg ICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc3RvcmFnZUFyZWEtPmxlbmd0aChmcmFtZSk7 ICsraSkgeworICAgICAgICAgICAgU3RyaW5nIG5hbWUoc3RvcmFnZUFyZWEtPmtleShpLCBmcmFt ZSkpOworICAgICAgICAgICAgU3RyaW5nIHZhbHVlKHN0b3JhZ2VBcmVhLT5nZXRJdGVtKG5hbWUs IGZyYW1lKSk7CiAgICAgICAgICAgICBSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IGVudHJ5ID0gSW5z cGVjdG9yQXJyYXk6OmNyZWF0ZSgpOwogICAgICAgICAgICAgZW50cnktPnB1c2hTdHJpbmcobmFt ZSk7CiAgICAgICAgICAgICBlbnRyeS0+cHVzaFN0cmluZyh2YWx1ZSk7CkBAIC0xMzAsNyArMTMx LDcgQEAgdm9pZCBJbnNwZWN0b3JET01TdG9yYWdlQWdlbnQ6OnNldERPTVN0b3JhZ2VJdGVtKEVy cm9yU3RyaW5nKiwgaW50IHN0b3JhZ2VJZCwgY28KICAgICBJbnNwZWN0b3JET01TdG9yYWdlUmVz b3VyY2UqIHN0b3JhZ2VSZXNvdXJjZSA9IGdldERPTVN0b3JhZ2VSZXNvdXJjZUZvcklkKHN0b3Jh Z2VJZCk7CiAgICAgaWYgKHN0b3JhZ2VSZXNvdXJjZSkgewogICAgICAgICBFeGNlcHRpb25Db2Rl IGV4Y2VwdGlvbiA9IDA7Ci0gICAgICAgIHN0b3JhZ2VSZXNvdXJjZS0+ZG9tU3RvcmFnZSgpLT5z ZXRJdGVtKGtleSwgdmFsdWUsIGV4Y2VwdGlvbik7CisgICAgICAgIHN0b3JhZ2VSZXNvdXJjZS0+ c3RvcmFnZUFyZWEoKS0+c2V0SXRlbShrZXksIHZhbHVlLCBleGNlcHRpb24sIHN0b3JhZ2VSZXNv dXJjZS0+ZnJhbWUoKSk7CiAgICAgICAgICpzdWNjZXNzID0gIWV4Y2VwdGlvbjsKICAgICB9CiB9 CkBAIC0xMzksNyArMTQwLDcgQEAgdm9pZCBJbnNwZWN0b3JET01TdG9yYWdlQWdlbnQ6OnJlbW92 ZURPTVN0b3JhZ2VJdGVtKEVycm9yU3RyaW5nKiwgaW50IHN0b3JhZ2VJZCwKIHsKICAgICBJbnNw ZWN0b3JET01TdG9yYWdlUmVzb3VyY2UqIHN0b3JhZ2VSZXNvdXJjZSA9IGdldERPTVN0b3JhZ2VS ZXNvdXJjZUZvcklkKHN0b3JhZ2VJZCk7CiAgICAgaWYgKHN0b3JhZ2VSZXNvdXJjZSkgewotICAg ICAgICBzdG9yYWdlUmVzb3VyY2UtPmRvbVN0b3JhZ2UoKS0+cmVtb3ZlSXRlbShrZXkpOworICAg ICAgICBzdG9yYWdlUmVzb3VyY2UtPnN0b3JhZ2VBcmVhKCktPnJlbW92ZUl0ZW0oa2V5LCBzdG9y YWdlUmVzb3VyY2UtPmZyYW1lKCkpOwogICAgICAgICAqc3VjY2VzcyA9IHRydWU7CiAgICAgfQog fQpAQCAtMTc0LDggKzE3NSw3IEBAIHZvaWQgSW5zcGVjdG9yRE9NU3RvcmFnZUFnZW50OjpkaWRV c2VET01TdG9yYWdlKFN0b3JhZ2VBcmVhKiBzdG9yYWdlQXJlYSwgYm9vbCBpCiAgICAgICAgICAg ICByZXR1cm47CiAgICAgfQogCi0gICAgUmVmUHRyPFN0b3JhZ2U+IGRvbVN0b3JhZ2UgPSBTdG9y YWdlOjpjcmVhdGUoZnJhbWUsIHN0b3JhZ2VBcmVhKTsKLSAgICBSZWZQdHI8SW5zcGVjdG9yRE9N U3RvcmFnZVJlc291cmNlPiByZXNvdXJjZSA9IEluc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZTo6 Y3JlYXRlKGRvbVN0b3JhZ2UuZ2V0KCksIGlzTG9jYWxTdG9yYWdlLCBmcmFtZSk7CisgICAgUmVm UHRyPEluc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZT4gcmVzb3VyY2UgPSBJbnNwZWN0b3JET01T dG9yYWdlUmVzb3VyY2U6OmNyZWF0ZShzdG9yYWdlQXJlYSwgaXNMb2NhbFN0b3JhZ2UsIGZyYW1l KTsKIAogICAgIG1fcmVzb3VyY2VzLnNldChyZXNvdXJjZS0+aWQoKSwgcmVzb3VyY2UpOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NU3RvcmFnZVJl c291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01TdG9yYWdl UmVzb3VyY2UuY3BwCmluZGV4IDMyN2Q3YmYuLjVjOTgyMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2UuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2UuY3BwCkBA IC00Miw2ICs0Miw3IEBACiAjaW5jbHVkZSAiSW5zcGVjdG9yVmFsdWVzLmgiCiAjaW5jbHVkZSAi U2VjdXJpdHlPcmlnaW4uaCIKICNpbmNsdWRlICJTdG9yYWdlLmgiCisjaW5jbHVkZSAiU3RvcmFn ZUFyZWEuaCIKICNpbmNsdWRlICJTdG9yYWdlRXZlbnQuaCIKIAogdXNpbmcgbmFtZXNwYWNlIEpT QzsKQEAgLTUwLDkgKzUxLDkgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBpbnQgSW5zcGVjdG9y RE9NU3RvcmFnZVJlc291cmNlOjpzX25leHRVbnVzZWRJZCA9IDE7CiAKLUluc3BlY3RvckRPTVN0 b3JhZ2VSZXNvdXJjZTo6SW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlKFN0b3JhZ2UqIGRvbVN0 b3JhZ2UsIGJvb2wgaXNMb2NhbFN0b3JhZ2UsIEZyYW1lKiBmcmFtZSkKK0luc3BlY3RvckRPTVN0 b3JhZ2VSZXNvdXJjZTo6SW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlKFN0b3JhZ2VBcmVhKiBz dG9yYWdlQXJlYSwgYm9vbCBpc0xvY2FsU3RvcmFnZSwgRnJhbWUqIGZyYW1lKQogICAgIDogIEV2 ZW50TGlzdGVuZXIoSW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlVHlwZSkKLSAgICAsIG1fZG9t U3RvcmFnZShkb21TdG9yYWdlKQorICAgICwgbV9zdG9yYWdlQXJlYShzdG9yYWdlQXJlYSkKICAg ICAsIG1faXNMb2NhbFN0b3JhZ2UoaXNMb2NhbFN0b3JhZ2UpCiAgICAgLCBtX2ZyYW1lKGZyYW1l KQogICAgICwgbV9mcm9udGVuZCgwKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckRPTVN0b3JhZ2VSZXNvdXJjZS5oCmluZGV4IDY0MTUzZjMuLjVjYmJlMGUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01TdG9yYWdl UmVzb3VyY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NU3Rv cmFnZVJlc291cmNlLmgKQEAgLTQwLDE1ICs0MCwxNSBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKLSAgICBjbGFzcyBTdG9yYWdlOworICAgIGNsYXNzIFN0b3JhZ2VBcmVhOwogICAgIGNsYXNz IEZyYW1lOwogICAgIGNsYXNzIEluc3BlY3RvckZyb250ZW5kOwogCiAgICAgY2xhc3MgSW5zcGVj dG9yRE9NU3RvcmFnZVJlc291cmNlIDogcHVibGljIEV2ZW50TGlzdGVuZXIgewogICAgIHB1Ymxp YzoKLSAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8SW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNl PiBjcmVhdGUoU3RvcmFnZSogZG9tU3RvcmFnZSwgYm9vbCBpc0xvY2FsU3RvcmFnZSwgRnJhbWUq IGZyYW1lKQorICAgICAgICBzdGF0aWMgUGFzc1JlZlB0cjxJbnNwZWN0b3JET01TdG9yYWdlUmVz b3VyY2U+IGNyZWF0ZShTdG9yYWdlQXJlYSogc3RvcmFnZUFyZWEsIGJvb2wgaXNMb2NhbFN0b3Jh Z2UsIEZyYW1lKiBmcmFtZSkKICAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIGFkb3B0UmVm KG5ldyBJbnNwZWN0b3JET01TdG9yYWdlUmVzb3VyY2UoZG9tU3RvcmFnZSwgaXNMb2NhbFN0b3Jh Z2UsIGZyYW1lKSk7CisgICAgICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IEluc3BlY3RvckRP TVN0b3JhZ2VSZXNvdXJjZShzdG9yYWdlQXJlYSwgaXNMb2NhbFN0b3JhZ2UsIGZyYW1lKSk7CiAg ICAgICAgIH0KIAogICAgICAgICBzdGF0aWMgY29uc3QgSW5zcGVjdG9yRE9NU3RvcmFnZVJlc291 cmNlKiBjYXN0KGNvbnN0IEV2ZW50TGlzdGVuZXIqIGxpc3RlbmVyKQpAQCAtNjUsMTMgKzY1LDE0 IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICBib29sIGlzU2FtZUhvc3RBbmRUeXBl KEZyYW1lKiwgYm9vbCBpc0xvY2FsU3RvcmFnZSkgY29uc3Q7CiAgICAgICAgIGludCBpZCgpIGNv bnN0IHsgcmV0dXJuIG1faWQ7IH0KLSAgICAgICAgU3RvcmFnZSogZG9tU3RvcmFnZSgpIGNvbnN0 IHsgcmV0dXJuIG1fZG9tU3RvcmFnZS5nZXQoKTsgfQorICAgICAgICBTdG9yYWdlQXJlYSogc3Rv cmFnZUFyZWEoKSBjb25zdCB7IHJldHVybiBtX3N0b3JhZ2VBcmVhLmdldCgpOyB9CisgICAgICAg IEZyYW1lKiBmcmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fZnJhbWUuZ2V0KCk7IH0KIAogICAgIHBy aXZhdGU6CiAKLSAgICAgICAgSW5zcGVjdG9yRE9NU3RvcmFnZVJlc291cmNlKFN0b3JhZ2UqLCBi b29sIGlzTG9jYWxTdG9yYWdlLCBGcmFtZSopOworICAgICAgICBJbnNwZWN0b3JET01TdG9yYWdl UmVzb3VyY2UoU3RvcmFnZUFyZWEqLCBib29sIGlzTG9jYWxTdG9yYWdlLCBGcmFtZSopOwogCi0g ICAgICAgIFJlZlB0cjxTdG9yYWdlPiBtX2RvbVN0b3JhZ2U7CisgICAgICAgIFJlZlB0cjxTdG9y YWdlQXJlYT4gbV9zdG9yYWdlQXJlYTsKICAgICAgICAgYm9vbCBtX2lzTG9jYWxTdG9yYWdlOwog ICAgICAgICBSZWZQdHI8RnJhbWU+IG1fZnJhbWU7CiAgICAgICAgIEluc3BlY3RvckZyb250ZW5k OjpET01TdG9yYWdlKiBtX2Zyb250ZW5kOwo=