80898 2012-03-12 15:16:40 -0700 Make ApplicationCacheHost::isApplicationCacheEnabled() const. 2012-03-12 15:49:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 gavinp gavinp ap beidson japhet webkit.review.bot oldest_to_newest 576599 0 gavinp 2012-03-12 15:16:40 -0700 Make ApplicationCacheHost::isApplicationCacheEnabled() const. 576606 1 131424 gavinp 2012-03-12 15:19:56 -0700 Created attachment 131424 Patch 576612 2 gavinp 2012-03-12 15:25:44 -0700 This patch make this ApplicationCacheHost method const; I'm shortly going to add code to chromium that follows a const pointer, and the function was logically already const. 576618 3 131424 ap 2012-03-12 15:30:35 -0700 Comment on attachment 131424 Patch We generally try to not have const pointers to large objects like this one, because it simply doesn't make sense. So, it would be slightly better to fix chromium side to not keep a const pointer. But there is no harm in this patch either. Note that the existing line below is worse: > DocumentLoader* documentLoader() const { return m_documentLoader; } This is basically a sneaky way to remove constness (DocumentLoader owns ApplicationCacheHost and a lot more). 576639 4 gavinp 2012-03-12 15:48:40 -0700 You're right. Let's get it right. 131424 2012-03-12 15:19:56 -0700 2012-03-12 15:49:12 -0700 Patch bug-80898-20120312181954.patch text/plain 3858 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVmNGM1ZTZmYTM2ZGE1 ZGQ0NGQwZTEyNjAwNzk1N2Y4YWJiNzgzMC4uMjI0OTJhMzNhZDExYWY0YTk3MzUwZGMyZDQ4OGU4 MzQwZjUyNGVlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTAzLTEyICBHYXZp biBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1ha2UgQXBwbGljYXRp b25DYWNoZUhvc3Q6OmlzQXBwbGljYXRpb25DYWNoZUVuYWJsZWQoKSBjb25zdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwODk4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBtYWtlIHRo aXMgQXBwbGljYXRpb25DYWNoZUhvc3QgbWV0aG9kIGNvbnN0OyBJJ20gc2hvcnRseSBnb2luZyB0 byBhZGQKKyAgICAgICAgY29kZSB0byBjaHJvbWl1bSB0aGF0IGZvbGxvd3MgYSBjb25zdCBwb2lu dGVyLCBhbmQgdGhlIGZ1bmN0aW9uIHdhcyBsb2dpY2FsbHkgYWxyZWFkeQorICAgICAgICBjb25z dC4KKworICAgICAgICAqIGxvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlSG9zdDo6aXNBcHBsaWNhdGlvbkNh Y2hlRW5hYmxlZCk6CisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVI b3N0Lmg6CisgICAgICAgIChBcHBsaWNhdGlvbkNhY2hlSG9zdCk6CisKIDIwMTItMDMtMTAgIFN0 ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjExMDM1OC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MGEwMjNiZmRmNDZkNzY5MmVmNTcwNTFkOWRkNGE0ZGExM2Y1Yjc3Yi4uYTRhYmRiNGNlNDI1M2Q0 YzJmOGJhOTVjZGU3NTc1ODY5YjJkOGZkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAxMi0wMy0xMiAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVt Lm9yZz4KKworICAgICAgICBNYWtlIEFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojppc0FwcGxpY2F0aW9u Q2FjaGVFbmFibGVkKCkgY29uc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD04MDg5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggbWFrZSB0aGlzIEFwcGxpY2F0aW9uQ2FjaGVIb3N0IG1l dGhvZCBjb25zdDsgSSdtIHNob3J0bHkgZ29pbmcgdG8gYWRkCisgICAgICAgIGNvZGUgdG8gY2hy b21pdW0gdGhhdCBmb2xsb3dzIGEgY29uc3QgcG9pbnRlciwgYW5kIHRoZSBmdW5jdGlvbiB3YXMg bG9naWNhbGx5IGFscmVhZHkKKyAgICAgICAgY29uc3QuCisgICAgICAgIAorICAgICAgICAqIHNy Yy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNhdGlv bkNhY2hlSG9zdDo6aXNBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCk6CisKIDIwMTItMDMtMTAgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTAzNjMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAppbmRleCAyOTQyMWNlN2Mz MzI4OTZmMDY2MDM0NDg3NTlhNWMzOTI2NDkyMTNmLi4yNzNkNjM0NDM2YTZiYjJlNTYyMGRiMmQx N2MzOTIyMzg1NmRhYjlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2Fj aGUvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9h cHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKQEAgLTQ3MSw3ICs0NzEsNyBAQCB2b2lk IEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjphYm9ydCgpCiAgICAgfQogfQogCi1ib29sIEFwcGxpY2F0 aW9uQ2FjaGVIb3N0Ojppc0FwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKCkKK2Jvb2wgQXBwbGljYXRp b25DYWNoZUhvc3Q6OmlzQXBwbGljYXRpb25DYWNoZUVuYWJsZWQoKSBjb25zdAogewogICAgIHJl dHVybiBtX2RvY3VtZW50TG9hZGVyLT5mcmFtZSgpLT5zZXR0aW5ncygpCiAgICAgICAgICAgICYm IG1fZG9jdW1lbnRMb2FkZXItPmZyYW1lKCktPnNldHRpbmdzKCktPm9mZmxpbmVXZWJBcHBsaWNh dGlvbkNhY2hlRW5hYmxlZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2Fw cGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmggYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBw Y2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuaAppbmRleCAwNDU1NmJlOTZjZTgyMmM3OTE0ZWY0 Nzc3NDE0OGUyYWM0Mzg5N2YwLi4xMjI0ZWNjZjdjY2FjNTA5MTBjN2VjN2MwMjhjM2I3YjU4MGM1 MWQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRp b25DYWNoZUhvc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGlj YXRpb25DYWNoZUhvc3QuaApAQCAtMTYxLDcgKzE2MSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICNlbmRpZgogCiAgICAgcHJpdmF0ZToKLSAgICAgICAgYm9vbCBpc0FwcGxpY2F0aW9uQ2FjaGVF bmFibGVkKCk7CisgICAgICAgIGJvb2wgaXNBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCgpIGNvbnN0 OwogICAgICAgICBEb2N1bWVudExvYWRlciogZG9jdW1lbnRMb2FkZXIoKSBjb25zdCB7IHJldHVy biBtX2RvY3VtZW50TG9hZGVyOyB9CiAKICAgICAgICAgc3RydWN0IERlZmVycmVkRXZlbnQgewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhv c3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3Qu Y3BwCmluZGV4IDczZjI1OGIwYzdmYjdjZTg5MzNmMDM5OWEwZWU3ZGFmMmFhZGYzNDYuLjcwMDNm MTk1M2E4OGVlNjQyMDExY2JlYzBjOTc5NmE2Y2IyMTI3NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAKQEAgLTMwMCw3ICsz MDAsNyBAQCB2b2lkIEFwcGxpY2F0aW9uQ2FjaGVIb3N0OjphYm9ydCgpCiAgICAgLy8gRklYTUU6 IFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzYyNzAKIH0KIAot Ym9vbCBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6aXNBcHBsaWNhdGlvbkNhY2hlRW5hYmxlZCgpCiti b29sIEFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojppc0FwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKCkgY29u c3QKIHsKICAgICBBU1NFUlQobV9kb2N1bWVudExvYWRlci0+ZnJhbWUoKSk7CiAgICAgcmV0dXJu IG1fZG9jdW1lbnRMb2FkZXItPmZyYW1lKCktPnNldHRpbmdzKCkK