80892 2012-03-12 14:39:11 -0700 [Skia] Release CGImage used to apply color space conversion to SkBitmap 2012-03-12 16:24:04 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon abarth senorblanco webkit.review.bot oldest_to_newest 576546 0 bsalomon 2012-03-12 14:39:11 -0700 Release CGImage used to apply color space conversion to SkBitmap 576549 1 131415 bsalomon 2012-03-12 14:43:00 -0700 Created attachment 131415 Patch 576552 2 bsalomon 2012-03-12 14:44:50 -0700 This fixes a pretty bad memory leak on the mac. Any decoded image that has a color space conversion applied is leaked. Cary Clark (who wrote the relevant function) confirmed that there is a leak and the fix is to release the CGImageRef. 576564 3 bsalomon 2012-03-12 14:50:23 -0700 Associated CR bug: http://crbug.com/117011 576688 4 131415 abarth 2012-03-12 16:24:00 -0700 Comment on attachment 131415 Patch Clearing flags on attachment: 131415 Committed r110499: <http://trac.webkit.org/changeset/110499> 576689 5 abarth 2012-03-12 16:24:04 -0700 All reviewed patches have been landed. Closing bug. 131415 2012-03-12 14:43:00 -0700 2012-03-12 16:24:00 -0700 Patch bug-80892-20120312174258.patch text/plain 2049 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDQ4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTAzLTEyICBCcmlhbiBT YWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbU2tpYV0gUmVsZWFzZSBD R0ltYWdlIHVzZWQgdG8gYXBwbHkgY29sb3Igc3BhY2UgY29udmVyc2lvbiB0byBTa0JpdG1hcAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4OTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWdyZXNzaW9u cyBzaG91bGQgYmUgY292ZXJlZCBieSBhbnkgdGVzdCB0aGF0IGRvZXMgaW1hZ2UgZGVjb2RlIG9u IHRoZSBtYWMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9za2lhL0ltYWdl RGVjb2RlclNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVzb2x2ZUNvbG9yU3BhY2UpOgor CiAyMDEyLTAzLTEyICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KIAogICAg ICAgICBJdCBkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8gcmV0dXJuIGNvbnN0IHVuc2lnbmVkLCBhbmQg R0NDIHdhcm5zIGFib3V0IGl0LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2Ut ZGVjb2RlcnMvc2tpYS9JbWFnZURlY29kZXJTa2lhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9za2lhL0ltYWdlRGVjb2RlclNraWEuY3Bw CShyZXZpc2lvbiAxMTA0NzYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNv ZGVycy9za2lhL0ltYWdlRGVjb2RlclNraWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTksNyAr MTE5LDcgQEAgc3RhdGljIHZvaWQgcmVzb2x2ZUNvbG9yU3BhY2UoY29uc3QgU2tCaQogewogICAg IGludCB3aWR0aCA9IGJpdG1hcC53aWR0aCgpOwogICAgIGludCBoZWlnaHQgPSBiaXRtYXAuaGVp Z2h0KCk7Ci0gICAgQ0dJbWFnZVJlZiBzcmNJbWFnZSA9IFNrQ3JlYXRlQ0dJbWFnZVJlZldpdGhD b2xvcnNwYWNlKGJpdG1hcCwgY29sb3JTcGFjZSk7CisgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+ IHNyY0ltYWdlKEFkb3B0Q0YsIFNrQ3JlYXRlQ0dJbWFnZVJlZldpdGhDb2xvcnNwYWNlKGJpdG1h cCwgY29sb3JTcGFjZSkpOwogICAgIFNrQXV0b0xvY2tQaXhlbHMgbG9jayhiaXRtYXApOwogICAg IHZvaWQqIHBpeGVscyA9IGJpdG1hcC5nZXRQaXhlbHMoKTsKICAgICBSZXRhaW5QdHI8Q0dDb250 ZXh0UmVmPiBjZ0JpdG1hcChBZG9wdENGLCBDR0JpdG1hcENvbnRleHRDcmVhdGUocGl4ZWxzLCB3 aWR0aCwgaGVpZ2h0LCA4LCB3aWR0aCAqIDQsIGRldmljZVJHQkNvbG9yU3BhY2VSZWYoKSwga0NH Qml0bWFwQnl0ZU9yZGVyMzJIb3N0IHwga0NHSW1hZ2VBbHBoYVByZW11bHRpcGxpZWRGaXJzdCkp OwpAQCAtMTI3LDcgKzEyNyw3IEBAIHN0YXRpYyB2b2lkIHJlc29sdmVDb2xvclNwYWNlKGNvbnN0 IFNrQmkKICAgICAgICAgcmV0dXJuOwogICAgIENHQ29udGV4dFNldEJsZW5kTW9kZShjZ0JpdG1h cC5nZXQoKSwga0NHQmxlbmRNb2RlQ29weSk7CiAgICAgQ0dSZWN0IGJvdW5kcyA9IHsgezAsIDB9 LCB7d2lkdGgsIGhlaWdodH0gfTsKLSAgICBDR0NvbnRleHREcmF3SW1hZ2UoY2dCaXRtYXAuZ2V0 KCksIGJvdW5kcywgc3JjSW1hZ2UpOworICAgIENHQ29udGV4dERyYXdJbWFnZShjZ0JpdG1hcC5n ZXQoKSwgYm91bmRzLCBzcmNJbWFnZS5nZXQoKSk7CiB9CiAKIHN0YXRpYyBDR0NvbG9yU3BhY2VS ZWYgY3JlYXRlQ29sb3JTcGFjZShjb25zdCBDb2xvclByb2ZpbGUmIGNvbG9yUHJvZmlsZSkK