8089 2006-03-30 12:52:39 -0800 REGRESSION: Caret position is off in native text field with text-align:right 2006-04-04 01:52:26 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 VERIFIED FIXED data:text/html,<input%20style="text-align:%20right;"> Regression P1 Normal --- 1 mitz darin oldest_to_newest 38009 0 mitz 2006-03-30 12:52:39 -0800 In a new text field with text-align: right, the caret is positioned 1 pixel to the right of where it is supposed to be when the field is empty, and 1 pixel to the left when the field contains text (which is 2px to the left from the initial position). 38207 1 darin 2006-04-01 13:39:38 -0800 Looking at the behavior it seems that it's correct when there is text. I looked at it side by side with an LTR field and it seems to be fine. So I'll try to fix the bug about where it is without the text. 38208 2 darin 2006-04-01 13:46:07 -0800 I assume the relevant function is RenderBox::caretRect. 38212 3 darin 2006-04-01 14:36:43 -0800 No, turns out it's RenderFlow::caretRect. 38213 4 darin 2006-04-01 14:42:14 -0800 The code wasn't taking into account the width of the caret itself. But once I added code to do that, we end up with what Mitz called the right result, which unfortunately is one pixel to the right of what we get once we start typing. Working on it. 38215 5 darin 2006-04-01 14:59:09 -0800 1px was the width of the caret, 1px was the padding. 38217 6 7449 darin 2006-04-01 15:16:20 -0800 Created attachment 7449 patch with detailed change log 38224 7 7449 mjs 2006-04-01 15:58:26 -0800 Comment on attachment 7449 patch with detailed change log r=me 38484 8 mitz 2006-04-04 01:52:26 -0700 Verified in r13675 nightly. 7449 2006-04-01 15:16:20 -0800 2006-04-01 15:58:26 -0800 patch with detailed change log CaretPositionPatch.txt text/plain 7505 darin SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJGbG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSByZW5kZXJpbmcv UmVuZGVyRmxvdy5jcHAJKHJldmlzaW9uIDEzNjI4KQorKysgcmVuZGVyaW5nL1JlbmRlckZsb3cu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NzksNTQgKzU3OSw1MiBAQAogCiBJbnRSZWN0IFJlbmRl ckZsb3c6OmNhcmV0UmVjdChpbnQgb2Zmc2V0LCBFQWZmaW5pdHkgYWZmaW5pdHksIGludCAqZXh0 cmFXaWR0aFRvRW5kT2ZMaW5lKQogewotICAgIGlmIChmaXJzdENoaWxkKCkgfHwgc3R5bGUoKS0+ ZGlzcGxheSgpID09IElOTElORSkgewotICAgICAgICAvLyBEbyB0aGUgbm9ybWFsIGNhbGN1bGF0 aW9uCisgICAgLy8gRG8gdGhlIG5vcm1hbCBjYWxjdWxhdGlvbiBpbiBtb3N0IGNhc2VzLgorICAg IGlmIChmaXJzdENoaWxkKCkgfHwgc3R5bGUoKS0+ZGlzcGxheSgpID09IElOTElORSkKICAgICAg ICAgcmV0dXJuIFJlbmRlckNvbnRhaW5lcjo6Y2FyZXRSZWN0KG9mZnNldCwgYWZmaW5pdHksIGV4 dHJhV2lkdGhUb0VuZE9mTGluZSk7Ci0gICAgfQogCiAgICAgLy8gVGhpcyBpcyBhIHNwZWNpYWwg Y2FzZToKICAgICAvLyBUaGUgZWxlbWVudCBpcyBub3QgYW4gaW5saW5lIGVsZW1lbnQsIGFuZCBp dCdzIGVtcHR5LiBTbyB3ZSBoYXZlIHRvCiAgICAgLy8gY2FsY3VsYXRlIGEgZmFrZSBwb3NpdGlv biB0byBpbmRpY2F0ZSB3aGVyZSBvYmplY3RzIGFyZSB0byBiZSBpbnNlcnRlZC4KICAgICAKLSAg ICBpbnQgX3gsIF95LCB3aWR0aCwgaGVpZ2h0OwotICAgIAotICAgIC8vIEVESVQgRklYTUU6IHRo aXMgZG9lcyBuZWl0aGVyIHRha2UgaW50byByZWdhcmQgOmZpcnN0LWxpbmUgbm9yIDpmaXJzdC1s ZXR0ZXIKKyAgICAvLyBGSVhNRTogVGhpcyBkb2VzIG5vdCB0YWtlIGludG8gYWNjb3VudCBlaXRo ZXIgOmZpcnN0LWxpbmUgb3IgOmZpcnN0LWxldHRlcgogICAgIC8vIEhvd2V2ZXIsIGFzIHNvb24g YXMgc29tZSBjb250ZW50IGlzIGVudGVyZWQsIHRoZSBsaW5lIGJveGVzIHdpbGwgYmUKLSAgICAv LyBjb25zdHJ1Y3RlZCBwcm9wZXJseSBhbmQgdGhpcyBrbHVkZ2UgaXMgbm90IGNhbGxlZCBhbnkg bW9yZS4gU28gb25seQotICAgIC8vIHRoZSBjYXJldCBzaXplIG9mIGFuIGVtcHR5IDpmaXJzdC1s aW5lJ2QgYmxvY2sgaXMgd3JvbmcsIGJ1dCBJIHRoaW5rIHdlCi0gICAgLy8gY2FuIGxpdmUgd2l0 aCB0aGF0LgorICAgIC8vIGNvbnN0cnVjdGVkIGFuZCB0aGlzIGtsdWRnZSBpcyBub3QgY2FsbGVk IGFueSBtb3JlLiBTbyBvbmx5IHRoZSBjYXJldCBzaXplCisgICAgLy8gb2YgYW4gZW1wdHkgOmZp cnN0LWxpbmUnZCBibG9jayBpcyB3cm9uZy4gSSB0aGluayB3ZSBjYW4gbGl2ZSB3aXRoIHRoYXQu CiAgICAgUmVuZGVyU3R5bGUgKmN1cnJlbnRTdHlsZSA9IGZpcnN0TGluZVN0eWxlKCk7Ci0gICAg aGVpZ2h0ID0gbGluZUhlaWdodCh0cnVlKTsKLSAgICB3aWR0aCA9IDE7CisgICAgaW50IGhlaWdo dCA9IGxpbmVIZWlnaHQodHJ1ZSk7CisgICAgY29uc3QgaW50IHdpZHRoID0gMTsKIAotICAgIC8v IEVESVQgRklYTUU6IFRoaXMgbmVlZHMgdG8gYWNjb3VudCBmb3IgdGV4dCBkaXJlY3Rpb24KKyAg ICAvLyBGSVhNRTogRG9lcyB0aGlzIG5lZWQgdG8gdGFrZSB0ZXh0IGRpcmVjdGlvbiBpbnRvIGFj Y291bnQ/CiAgICAgaW50IHcgPSB0aGlzLT53aWR0aCgpOworICAgIGludCB4OwogICAgIHN3aXRj aCAoY3VycmVudFN0eWxlLT50ZXh0QWxpZ24oKSkgewogICAgICAgICBjYXNlIExFRlQ6CiAgICAg ICAgIGNhc2UgS0hUTUxfTEVGVDoKICAgICAgICAgY2FzZSBUQUFVVE86CiAgICAgICAgIGNhc2Ug SlVTVElGWToKICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIF94ID0gMDsKKyAgICAgICAg ICAgIHggPSBib3JkZXJMZWZ0KCkgKyBwYWRkaW5nTGVmdCgpOwogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIGNhc2UgQ0VOVEVSOgogICAgICAgICBjYXNlIEtIVE1MX0NFTlRFUjoKLSAgICAg ICAgICAgIF94ID0gdyAvIDI7Ci0gICAgICAgIGJyZWFrOworICAgICAgICAgICAgeCA9IChib3Jk ZXJMZWZ0KCkgKyBwYWRkaW5nTGVmdCgpICsgdyAtIChib3JkZXJSaWdodCgpICsgcGFkZGluZ1Jp Z2h0KCkpIC0gd2lkdGgpIC8gMjsKKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFJJ R0hUOgogICAgICAgICBjYXNlIEtIVE1MX1JJR0hUOgotICAgICAgICAgICAgX3ggPSB3OwotICAg ICAgICBicmVhazsKKyAgICAgICAgICAgIHggPSB3IC0gKGJvcmRlclJpZ2h0KCkgKyBwYWRkaW5n UmlnaHQoKSkgLSB3aWR0aDsKKyAgICAgICAgICAgIGJyZWFrOwogICAgIH0KLSAgICAKLSAgICBf eSA9IDA7Ci0gICAgCiAKICAgICBpZiAoZXh0cmFXaWR0aFRvRW5kT2ZMaW5lKSB7CiAgICAgICAg IGlmIChpc1JlbmRlckJsb2NrKCkpIHsKLSAgICAgICAgICAgICpleHRyYVdpZHRoVG9FbmRPZkxp bmUgPSB0aGlzLT53aWR0aCgpIC0gKF94ICsgd2lkdGgpOworICAgICAgICAgICAgKmV4dHJhV2lk dGhUb0VuZE9mTGluZSA9IHcgLSAoeCArIHdpZHRoKTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAg ICAgICAgIGludCBteVJpZ2h0ID0gX3ggKyB3aWR0aDsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBU aGlzIGNvZGUgbG9va3Mgd3JvbmcuCisgICAgICAgICAgICAvLyBteVJpZ2h0IGFuZCBjb250YWlu ZXJSaWdodCBhcmUgc2V0IHVwLCBidXQgdGhlbiBjbG9iYmVyZWQuCisgICAgICAgICAgICAvLyBT byAqZXh0cmFXaWR0aFRvRW5kT2ZMaW5lIHdpbGwgYWx3YXlzIGJlIDAgaGVyZS4KKworICAgICAg ICAgICAgaW50IG15UmlnaHQgPSB4ICsgd2lkdGg7CiAgICAgICAgICAgICBpbnQgaWdub3JlOwog ICAgICAgICAgICAgYWJzb2x1dGVQb3NpdGlvbkZvckNvbnRlbnQobXlSaWdodCwgaWdub3JlKTsK ICAgICAgICAgICAgIApAQCAtNjM5LDEwICs2MzcsMTAgQEAKIAogICAgIGludCBhYnN4LCBhYnN5 OwogICAgIGFic29sdXRlUG9zaXRpb25Gb3JDb250ZW50KGFic3gsIGFic3kpOwotICAgIF94ICs9 IGFic3ggKyBwYWRkaW5nTGVmdCgpICsgYm9yZGVyTGVmdCgpOwotICAgIF95ICs9IGFic3kgKyBw YWRkaW5nVG9wKCkgKyBib3JkZXJUb3AoKTsKKyAgICB4ICs9IGFic3g7CisgICAgaW50IHkgPSBh YnN5ICsgcGFkZGluZ1RvcCgpICsgYm9yZGVyVG9wKCk7CiAKLSAgICByZXR1cm4gSW50UmVjdChf eCwgX3ksIHdpZHRoLCBoZWlnaHQpOworICAgIHJldHVybiBJbnRSZWN0KHgsIHksIHdpZHRoLCBo ZWlnaHQpOwogfQogCiB2b2lkIFJlbmRlckZsb3c6OmFkZEZvY3VzUmluZ1JlY3RzKEdyYXBoaWNz Q29udGV4dCogcCwgaW50IF90eCwgaW50IF90eSkKSW5kZXg6IHJlbmRlcmluZy9SZW5kZXJCb3gu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwCShyZXZpc2lvbiAxMzYy OCkKKysrIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzIxLDM1 ICsxNzIxLDMzIEBACiAgICAgeSA9IHQgKyBtdCArIGNiLT5ib3JkZXJUb3AoKTsKIH0KIAotSW50 UmVjdCBSZW5kZXJCb3g6OmNhcmV0UmVjdChpbnQgb2Zmc2V0LCBFQWZmaW5pdHkgYWZmaW5pdHks IGludCAqZXh0cmFXaWR0aFRvRW5kT2ZMaW5lKQorSW50UmVjdCBSZW5kZXJCb3g6OmNhcmV0UmVj dChpbnQgb2Zmc2V0LCBFQWZmaW5pdHkgYWZmaW5pdHksIGludCogZXh0cmFXaWR0aFRvRW5kT2ZM aW5lKQogewogICAgIC8vIEZJWE1FOiBJcyBpdCBPSyB0byBjaGVjayBvbmx5IGZpcnN0IGNoaWxk IGluc3RlYWQgb2YgcGlja2luZwogICAgIC8vIHJpZ2h0IGNoaWxkIGJhc2VkIG9uIG9mZnNldD8g SXMgaXQgT0sgdG8gcGFzcyB0aGUgc2FtZSBvZmZzZXQKICAgICAvLyBhbG9uZyB0byB0aGUgY2hp bGQgaW5zdGVhZCBvZiBvZmZzZXQgMCBvciB3aGF0ZXZlcj8KIAogICAgIC8vIHByb3BhZ2F0ZSBp dCBkb3dud2FyZHMgdG8gaXRzIGNoaWxkcmVuLCBzb21lb25lIHdpbGwgZmVlbCByZXNwb25zaWJs ZQotICAgIFJlbmRlck9iamVjdCAqY2hpbGQgPSBmaXJzdENoaWxkKCk7Ci0gICAgaWYgKGNoaWxk KSB7CisgICAgaWYgKFJlbmRlck9iamVjdCogY2hpbGQgPSBmaXJzdENoaWxkKCkpIHsKICAgICAg ICAgSW50UmVjdCByZXN1bHQgPSBjaGlsZC0+Y2FyZXRSZWN0KG9mZnNldCwgYWZmaW5pdHksIGV4 dHJhV2lkdGhUb0VuZE9mTGluZSk7Ci0gICAgICAgIC8vIEZJWE1FOiBpbi1iYW5kIHNpZ25hbGxp bmchCi0gICAgICAgIGlmIChyZXN1bHQuaXNFbXB0eSgpKQorICAgICAgICBpZiAoIXJlc3VsdC5p c0VtcHR5KCkpCiAgICAgICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0KLSAgICAKLSAgICBp bnQgX3gsIF95LCBoZWlnaHQ7CiAKICAgICAvLyBpZiBub3QsIHVzZSB0aGUgZXh0ZW50cyBvZiB0 aGlzIGJveCAKICAgICAvLyBvZmZzZXQgMCBtZWFucyBsZWZ0LCBvZmZzZXQgMSBtZWFucyByaWdo dAotICAgIF94ID0geFBvcygpICsgKG9mZnNldCA9PSAwID8gMCA6IG1fd2lkdGgpOwotICAgIElu bGluZUJveCAqYm94ID0gaW5saW5lQm94V3JhcHBlcigpOwotICAgIGlmIChib3gpIHsKLSAgICAg ICAgaGVpZ2h0ID0gYm94LT5yb290KCktPmJvdHRvbU92ZXJmbG93KCkgLSBib3gtPnJvb3QoKS0+ dG9wT3ZlcmZsb3coKTsKLSAgICAgICAgX3kgPSBib3gtPnJvb3QoKS0+dG9wT3ZlcmZsb3coKTsK KyAgICAvLyBGSVhNRTogV2hhdCBhYm91dCBib3JkZXIgYW5kIHBhZGRpbmc/CisgICAgY29uc3Qg aW50IGNhcmV0V2lkdGggPSAxOworICAgIEludFJlY3QgcmVjdCh4UG9zKCksIHlQb3MoKSwgY2Fy ZXRXaWR0aCwgbV9oZWlnaHQpOworICAgIGlmIChvZmZzZXQgIT0gMCkKKyAgICAgICAgcmVjdC5z ZXRXaWR0aChtX3dpZHRoIC0gY2FyZXRXaWR0aCk7CisgICAgaWYgKElubGluZUJveCogYm94ID0g aW5saW5lQm94V3JhcHBlcigpKSB7CisgICAgICAgIFJvb3RJbmxpbmVCb3gqIHJvb3RCb3ggPSBi b3gtPnJvb3QoKTsKKyAgICAgICAgaW50IHRvcCA9IHJvb3RCb3gtPnRvcE92ZXJmbG93KCk7Cisg ICAgICAgIHJlY3Quc2V0WSh0b3ApOworICAgICAgICByZWN0LnNldEhlaWdodChyb290Qm94LT5i b3R0b21PdmVyZmxvdygpIC0gdG9wKTsKICAgICB9Ci0gICAgZWxzZSB7Ci0gICAgICAgIF95ID0g eVBvcygpOwotICAgICAgICBoZWlnaHQgPSBtX2hlaWdodDsKLSAgICB9CisKICAgICAvLyBJZiBo ZWlnaHQgb2YgYm94IGlzIHNtYWxsZXIgdGhhbiBmb250IGhlaWdodCwgdXNlIHRoZSBsYXR0ZXIg b25lLAogICAgIC8vIG90aGVyd2lzZSB0aGUgY2FyZXQgbWlnaHQgYmVjb21lIGludmlzaWJsZS4K ICAgICAvLyAKQEAgLTE3NTksMjUgKzE3NTcsMjAgQEAKICAgICAvLwogICAgIC8vIEZJWE1FOiBp Z25vcmluZyA6Zmlyc3QtbGluZSwgbWlzc2luZyBnb29kIHJlYXNvbiB0byB0YWtlIGNhcmUgb2YK ICAgICBpbnQgZm9udEhlaWdodCA9IHN0eWxlKCktPmZvbnQoKS5oZWlnaHQoKTsKLSAgICBpZiAo Zm9udEhlaWdodCA+IGhlaWdodCB8fCAhaXNSZXBsYWNlZCgpKQotICAgICAgICBoZWlnaHQgPSBm b250SGVpZ2h0OwotICAgIAotICAgIGludCBhYnN4LCBhYnN5OwotICAgIFJlbmRlck9iamVjdCAq Y2IgPSBjb250YWluaW5nQmxvY2soKTsKLSAgICBpZiAoY2IgJiYgY2IgIT0gdGhpcyAmJiBjYi0+ YWJzb2x1dGVQb3NpdGlvbihhYnN4LCBhYnN5KSkgewotICAgICAgICBfeCArPSBhYnN4OwotICAg ICAgICBfeSArPSBhYnN5OwotICAgIH0gCi0gICAgZWxzZSB7Ci0gICAgICAgIC8vIHdlIGRvbid0 IGtub3cgb3VyIGFic29sdXRlIHBvc2l0aW9uLCBhbmQgdGhlcmUgaXMgbm8gcG9pbnQgcmV0dXJu aW5nCi0gICAgICAgIC8vIGp1c3QgYSByZWxhdGl2ZSBvbmUKKyAgICBpZiAoZm9udEhlaWdodCA+ IHJlY3QuaGVpZ2h0KCkgfHwgIWlzUmVwbGFjZWQoKSkKKyAgICAgICAgcmVjdC5zZXRIZWlnaHQo Zm9udEhlaWdodCk7CisKKyAgICBSZW5kZXJPYmplY3QqIGNiID0gY29udGFpbmluZ0Jsb2NrKCk7 CisgICAgaW50IGNieCwgY2J5OworICAgIGlmICghY2IgfHwgIWNiLT5hYnNvbHV0ZVBvc2l0aW9u KGNieCwgY2J5KSkKKyAgICAgICAgLy8gTm8gcG9pbnQgcmV0dXJuaW5nIGEgcmVsYXRpdmUgcG9z aXRpb24uCiAgICAgICAgIHJldHVybiBJbnRSZWN0KCk7Ci0gICAgfQorICAgIHJlY3QubW92ZShj YngsIGNieSk7CiAKICAgICBpZiAoZXh0cmFXaWR0aFRvRW5kT2ZMaW5lKQotICAgICAgICAqZXh0 cmFXaWR0aFRvRW5kT2ZMaW5lID0gbV93aWR0aCAtIF94OworICAgICAgICAqZXh0cmFXaWR0aFRv RW5kT2ZMaW5lID0gbV93aWR0aCAtIHJlY3QucmlnaHQoKTsKIAotICAgIHJldHVybiBJbnRSZWN0 KF94LCBfeSwgMSwgaGVpZ2h0KTsKKyAgICByZXR1cm4gcmVjdDsKIH0KIAogaW50IFJlbmRlckJv eDo6bG93ZXN0UG9zaXRpb24oYm9vbCBpbmNsdWRlT3ZlcmZsb3dJbnRlcmlvciwgYm9vbCBpbmNs dWRlU2VsZikgY29uc3QKSW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJ KHJldmlzaW9uIDEzNjI5KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTkgQEAKKzIwMDYtMDQtMDEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9i dWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4OQorICAgICAgICAgIFJF R1JFU1NJT046IENhcmV0IHBvc2l0aW9uIGlzIG9mZiBieSAycHggaW4gbmF0aXZlIHRleHQgZmll bGQgd2l0aCB0ZXh0LWFsaWduOnJpZ2h0CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRmxv dy5jcHA6IChXZWJDb3JlOjpSZW5kZXJGbG93OjpjYXJldFJlY3QpOgorICAgICAgICBDb25zaWRl ciBib3JkZXIsIHBhZGRpbmcsIGFuZCB0aGUgd2lkdGggb2YgdGhlIGNhcmV0IHByb3Blcmx5IGlu IHRoZQorICAgICAgICBjYWxjdWxhdGlvbiBvZiB0aGUgY2FyZXQncyBYIHBvc2l0aW9uLgorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6IChXZWJDb3JlOjpSZW5kZXJCb3g6OmNh cmV0UmVjdCk6CisgICAgICAgIEZpeGVkIHNvbWUgc2ltaWxhciBpc3N1ZXMgYW5kIHJld3JvdGUg dGhpcyBmdW5jdGlvbiBmb3IgY2xhcml0eS4KKyAgICAgICAgSG93ZXZlciwgSSBzdXNwZWN0IHRo aXMgZnVuY3Rpb24gd2FzIGFuZCByZW1haW5zIGJyb2tlbiBhbmQgaXMgYWxtb3N0CisgICAgICAg IG5ldmVyIGNhbGxlZC4KKwogMjAwNi0wMy0zMSAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkZWxlLgo=