80888 2012-03-12 14:20:19 -0700 Clear background for NSTextFieldCell is unreliable and not necessary 2012-03-24 12:03:23 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin mitz oldest_to_newest 576513 0 bdakin 2012-03-12 14:20:19 -0700 With http://trac.webkit.org/changeset/104240 I thought it was necessary to make NSTextFieldCells draw with a clear background in order to allow styled text fields. That is not actually necessary…we just had a different bug where isControlStyled() was only checking for styled borders on text fields. <rdar://problem/10663710> 576519 1 131409 bdakin 2012-03-12 14:25:34 -0700 Created attachment 131409 Patch 576540 2 bdakin 2012-03-12 14:34:27 -0700 Fixed with http://trac.webkit.org/changeset/110480 587155 3 mitz 2012-03-24 12:03:23 -0700 This caused bug 82131. 131409 2012-03-12 14:25:34 -0700 2012-03-12 14:30:30 -0700 Patch for-review.txt text/plain 2586 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDQ3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTEyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODA4ODgKKyAgICAgICAgQ2xlYXIgYmFja2dyb3VuZCBmb3IgTlNU ZXh0RmllbGRDZWxsIGlzIHVucmVsaWFibGUgYW5kIG5vdCBuZWNlc3NhcnkKKyAgICAgICAgLWFu ZCBjb3JyZXNwb25kaW5nLQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA2NjM3MTA+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2l0aCBodHRwOi8v dHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMDQyNDAgSSB0aG91Z2h0IGl0IHdhcyBuZWNlc3Nh cnkgdG8gCisgICAgICAgIG1ha2UgTlNUZXh0RmllbGRDZWxscyBkcmF3IHdpdGggYSBjbGVhciBi YWNrZ3JvdW5kIGluIG9yZGVyIHRvIGFsbG93IHN0eWxlZCAKKyAgICAgICAgdGV4dCBmaWVsZHMu IFRoYXQgaXMgbm90IGFjdHVhbGx5IG5lY2Vzc2FyeTsgd2UganVzdCBoYWQgYSBkaWZmZXJlbnQg YnVnIAorICAgICAgICB3aGVyZSBpc0NvbnRyb2xTdHlsZWQoKSB3YXMgb25seSBjaGVja2luZyBm b3Igc3R5bGVkIGJvcmRlcnMgb24gdGV4dCBmaWVsZHMuIAorICAgICAgICBUZXh0IGZpZWxkcyBj YW4gYWxzbyBiZSBzdHlsZWQgd2l0aCBiYWNrZ3JvdW5kcywgc28gdGhleSBuZWVkIHRoZSBmdWxs IGNoZWNrLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbToKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlclRoZW1lTWFjOjppc0NvbnRyb2xTdHlsZWQpOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyVGhlbWVNYWM6OnRleHRGaWVsZCk6CisKIDIwMTItMDMtMTIgIFNjb3R0IEJ5 ZXIgIDxzY290dGJ5ZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENsZWFudXAgb2Jzb2xldGUg ZmlsZXMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1t CShyZXZpc2lvbiAxMTAxNzUpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTQ4Nyw3ICs0ODcsNyBAQCBOU1ZpZXcqIFJlbmRl clRoZW1lTWFjOjpkb2N1bWVudFZpZXdGb3IoCiBib29sIFJlbmRlclRoZW1lTWFjOjppc0NvbnRy b2xTdHlsZWQoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlLCBjb25zdCBCb3JkZXJEYXRhJiBib3Jk ZXIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgRmlsbExheWVy JiBiYWNrZ3JvdW5kLCBjb25zdCBDb2xvciYgYmFja2dyb3VuZENvbG9yKSBjb25zdAogewotICAg IGlmIChzdHlsZS0+YXBwZWFyYW5jZSgpID09IFRleHRGaWVsZFBhcnQgfHwgc3R5bGUtPmFwcGVh cmFuY2UoKSA9PSBUZXh0QXJlYVBhcnQgfHwgc3R5bGUtPmFwcGVhcmFuY2UoKSA9PSBMaXN0Ym94 UGFydCkKKyAgICBpZiAoc3R5bGUtPmFwcGVhcmFuY2UoKSA9PSBUZXh0QXJlYVBhcnQgfHwgc3R5 bGUtPmFwcGVhcmFuY2UoKSA9PSBMaXN0Ym94UGFydCkKICAgICAgICAgcmV0dXJuIHN0eWxlLT5i b3JkZXIoKSAhPSBib3JkZXI7CiAgICAgICAgIAogICAgIC8vIEZJWE1FOiBUaGlzIGlzIGhvcnJp YmxlLCBidXQgdGhlcmUgaXMgbm90IG11Y2ggZWxzZSB0aGF0IGNhbiBiZSBkb25lLiAgTWVudSBs aXN0cyBjYW5ub3QgZHJhdyBwcm9wZXJseSB3aGVuCkBAIC0yMTM3LDExICsyMTM3LDYgQEAgTlNU ZXh0RmllbGRDZWxsKiBSZW5kZXJUaGVtZU1hYzo6dGV4dEZpZQogICAgICAgICBbbV90ZXh0Rmll bGQuZ2V0KCkgc2V0QmV6ZWxlZDpZRVNdOwogICAgICAgICBbbV90ZXh0RmllbGQuZ2V0KCkgc2V0 RWRpdGFibGU6WUVTXTsKICAgICAgICAgW21fdGV4dEZpZWxkLmdldCgpIHNldEZvY3VzUmluZ1R5 cGU6TlNGb2N1c1JpbmdUeXBlRXh0ZXJpb3JdOwotCi0gICAgICAgIC8vIFNldHRpbmcgYSBjbGVh ciBiYWNrZ3JvdW5kIG9uIHRoZSBjZWxsIGlzIG5lY2Vzc2FyeSBmb3IgQ1NTLXN0eWxlZCBiYWNr Z3JvdW5kcwotICAgICAgICAvLyB0byBzaG93IHRocm91Z2guIElkZWFsbHksIHRoZXJlIHdvdWxk IGJlIGEgYmV0dGVyIHdheSB0byBkbyB0aGlzLgotICAgICAgICBbbV90ZXh0RmllbGQuZ2V0KCkg c2V0RHJhd3NCYWNrZ3JvdW5kOllFU107Ci0gICAgICAgIFttX3RleHRGaWVsZC5nZXQoKSBzZXRC YWNrZ3JvdW5kQ29sb3I6W05TQ29sb3IgY2xlYXJDb2xvcl1dOwogICAgIH0KIAogICAgIHJldHVy biBtX3RleHRGaWVsZC5nZXQoKTsK