<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>80881</bug_id>
          
          <creation_ts>2012-03-12 13:49:47 -0700</creation_ts>
          <short_desc>Implement proper sub-pixel support in RenderFileUploadControl</short_desc>
          <delta_ts>2012-03-14 15:02:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>60318</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Levi Weintraub">leviw</reporter>
          <assigned_to name="Levi Weintraub">leviw</assigned_to>
          <cc>darin</cc>
    
    <cc>eae</cc>
    
    <cc>eric</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>tkent</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>576483</commentid>
    <comment_count>0</comment_count>
    <who name="Levi Weintraub">leviw</who>
    <bug_when>2012-03-12 13:49:47 -0700</bug_when>
    <thetext>We currently do some improper truncating and promoting of LayoutUnits to floats without pixel snapping in RenderFileUploadControl.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>576507</commentid>
    <comment_count>1</comment_count>
      <attachid>131406</attachid>
    <who name="Levi Weintraub">leviw</who>
    <bug_when>2012-03-12 14:16:07 -0700</bug_when>
    <thetext>Created attachment 131406
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>576515</commentid>
    <comment_count>2</comment_count>
      <attachid>131406</attachid>
    <who name="Emil A Eklund">eae</who>
    <bug_when>2012-03-12 14:21:31 -0700</bug_when>
    <thetext>Comment on attachment 131406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=131406&amp;action=review

&gt; Source/WebCore/rendering/RenderFileUploadControl.cpp:107
&gt; +        IntRect clipRect = pixelSnappedIntRect(LayoutRect(paintOffset.x() + borderLeft(), paintOffset.y() + borderTop(),

Isn&apos;t there a pixelSnappedIntRect implementation that takes x, y, w, h? Seems better than creating a LayoutRect and then immediately snapping it.

&gt; Source/WebCore/rendering/RenderFileUploadControl.cpp:157
&gt; +            input-&gt;icon()-&gt;paint(paintInfo.context, IntRect(roundedIntPoint(LayoutPoint(iconX, iconY)), IntSize(iconWidth, iconHeight)));

IntRect(iconX.round(), iconY.round(), iconWidth, iconHeight) seems easier.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>576528</commentid>
    <comment_count>3</comment_count>
      <attachid>131413</attachid>
    <who name="Levi Weintraub">leviw</who>
    <bug_when>2012-03-12 14:27:50 -0700</bug_when>
    <thetext>Created attachment 131413
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>576533</commentid>
    <comment_count>4</comment_count>
    <who name="Emil A Eklund">eae</who>
    <bug_when>2012-03-12 14:30:50 -0700</bug_when>
    <thetext>Looks good, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>578545</commentid>
    <comment_count>5</comment_count>
    <who name="Levi Weintraub">leviw</who>
    <bug_when>2012-03-14 10:38:28 -0700</bug_when>
    <thetext>Any takers on a review?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>578732</commentid>
    <comment_count>6</comment_count>
      <attachid>131413</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2012-03-14 13:54:31 -0700</bug_when>
    <thetext>Comment on attachment 131413
Patch

ok</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>578757</commentid>
    <comment_count>7</comment_count>
      <attachid>131413</attachid>
    <who name="Levi Weintraub">leviw</who>
    <bug_when>2012-03-14 14:14:18 -0700</bug_when>
    <thetext>Comment on attachment 131413
Patch

Thanks for the review, Mr. Glazkov :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>578816</commentid>
    <comment_count>8</comment_count>
      <attachid>131413</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-03-14 15:02:17 -0700</bug_when>
    <thetext>Comment on attachment 131413
Patch

Clearing flags on attachment: 131413

Committed r110761: &lt;http://trac.webkit.org/changeset/110761&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>578817</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-03-14 15:02:22 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>131406</attachid>
            <date>2012-03-12 14:16:07 -0700</date>
            <delta_ts>2012-03-12 14:27:21 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-80881-20120312141606.patch</filename>
            <type>text/plain</type>
            <size>3896</size>
            <attacher name="Levi Weintraub">leviw</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDQ3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAzLTEyICBMZXZpIFdl
aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1lbnQgcHJvcGVy
IHN1Yi1waXhlbCBzdXBwb3J0IGluIFJlbmRlckZpbGVVcGxvYWRDb250cm9sCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDg4MQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3RpbmcgaW1wcm9wZXIg
dXNhZ2Ugb2YgTGF5b3V0VW5pdHMgd2hlbiBpbnRlcmFjdGluZyB3aXRoIHRoZSBncmFwaGljcyBj
b250ZXh0CisgICAgICAgIGFuZCBwbGF0Zm9ybSBjb2RlLiBTcGVjaWZpY2FsbHk6CisgICAgICAg
IC0gcGl4ZWwgc25hcHBpbmcgdGhlIGNsaXAgcmVjdCBhbmQgcGFpbnQgb2Zmc2V0cyBiZWZvcmUg
c2VuZGluZyB2YWx1ZXMgdG8gdGhlCisgICAgICAgICAgZ3JhcGhpY3MgY29udGV4dCBpbiBwYWlu
dE9iamVjdC4KKyAgICAgICAgLSB1c2luZyBvbi1zY3JlZW4gKHBpeGVsIHNuYXBwZWQpIHZhbHVl
cyB0byBwYXNzIG9mZiB0byBwbGF0Zm9ybSBjb2RlIHRvIGRldGVybWluZQorICAgICAgICAgIHRo
ZSBtYXggbGVuZ3RoIG9mIHRoZSBmaWxlbmFtZSB0byBiZSBkcmF3bi4KKworICAgICAgICBObyBu
ZXcgdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHJlbmRlcmluZy9S
ZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpub2RlV2lkdGgp
OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6Om1heEZpbGVuYW1l
V2lkdGgpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OnBhaW50
T2JqZWN0KToKKwogMjAxMi0wMy0xMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl
LmNvbT4KIAogICAgICAgICBJbmZpbml0ZSByZXBhaW50IGxvb3Agd2l0aCBTVkdJbWFnZUNhY2hl
IGFuZCBkZWZlcnJlZCByZXBhaW50IHRpbWVycwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy
aW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwCShyZXZpc2lvbiAxMTA0
NDgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NiwxMyArODYsMTMgQEAgdm9pZCBSZW5kZXJGaWxlVXBs
b2FkQ29udHJvbDo6dXBkYXRlRnJvbQogCiBzdGF0aWMgaW50IG5vZGVXaWR0aChOb2RlKiBub2Rl
KQogewotICAgIHJldHVybiBub2RlID8gbm9kZS0+cmVuZGVyQm94KCktPndpZHRoKCkgOiB6ZXJv
TGF5b3V0VW5pdDsKKyAgICByZXR1cm4gbm9kZSA/IG5vZGUtPnJlbmRlckJveCgpLT5waXhlbFNu
YXBwZWRXaWR0aCgpIDogMDsKIH0KIAogaW50IFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjptYXhG
aWxlbmFtZVdpZHRoKCkgY29uc3QKIHsKICAgICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCA9IHN0
YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihub2RlKCkpOwotICAgIHJldHVybiBtYXgoMCwg
Y29udGVudFdpZHRoKCkgLSBub2RlV2lkdGgodXBsb2FkQnV0dG9uKCkpIC0gYWZ0ZXJCdXR0b25T
cGFjaW5nCisgICAgcmV0dXJuIG1heCgwLCBjb250ZW50Qm94UmVjdCgpLnBpeGVsU25hcHBlZFdp
ZHRoKCkgLSBub2RlV2lkdGgodXBsb2FkQnV0dG9uKCkpIC0gYWZ0ZXJCdXR0b25TcGFjaW5nCiAg
ICAgICAgIC0gKGlucHV0LT5pY29uKCkgPyBpY29uV2lkdGggKyBpY29uRmlsZW5hbWVTcGFjaW5n
IDogMCkpOwogfQogCkBAIC0xMDQsOCArMTA0LDggQEAgdm9pZCBSZW5kZXJGaWxlVXBsb2FkQ29u
dHJvbDo6cGFpbnRPYmplYwogICAgIC8vIFB1c2ggYSBjbGlwLgogICAgIEdyYXBoaWNzQ29udGV4
dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcigqcGFpbnRJbmZvLmNvbnRleHQsIGZhbHNlKTsKICAgICBp
ZiAocGFpbnRJbmZvLnBoYXNlID09IFBhaW50UGhhc2VGb3JlZ3JvdW5kIHx8IHBhaW50SW5mby5w
aGFzZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmRzKSB7Ci0gICAgICAgIExheW91
dFJlY3QgY2xpcFJlY3QocGFpbnRPZmZzZXQueCgpICsgYm9yZGVyTGVmdCgpLCBwYWludE9mZnNl
dC55KCkgKyBib3JkZXJUb3AoKSwKLSAgICAgICAgICAgICAgICAgICAgICAgICB3aWR0aCgpIC0g
Ym9yZGVyTGVmdCgpIC0gYm9yZGVyUmlnaHQoKSwgaGVpZ2h0KCkgLSBib3JkZXJCb3R0b20oKSAt
IGJvcmRlclRvcCgpICsgYnV0dG9uU2hhZG93SGVpZ2h0KTsKKyAgICAgICAgSW50UmVjdCBjbGlw
UmVjdCA9IHBpeGVsU25hcHBlZEludFJlY3QoTGF5b3V0UmVjdChwYWludE9mZnNldC54KCkgKyBi
b3JkZXJMZWZ0KCksIHBhaW50T2Zmc2V0LnkoKSArIGJvcmRlclRvcCgpLAorICAgICAgICAgICAg
ICAgICAgICAgICAgIHdpZHRoKCkgLSBib3JkZXJMZWZ0KCkgLSBib3JkZXJSaWdodCgpLCBoZWln
aHQoKSAtIGJvcmRlckJvdHRvbSgpIC0gYm9yZGVyVG9wKCkgKyBidXR0b25TaGFkb3dIZWlnaHQp
KTsKICAgICAgICAgaWYgKGNsaXBSZWN0LmlzRW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybjsK
ICAgICAgICAgc3RhdGVTYXZlci5zYXZlKCk7CkBAIC0xNDIsNyArMTQyLDcgQEAgdm9pZCBSZW5k
ZXJGaWxlVXBsb2FkQ29udHJvbDo6cGFpbnRPYmplYwogICAgICAgICBwYWludEluZm8uY29udGV4
dC0+c2V0RmlsbENvbG9yKHN0eWxlKCktPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0
eUNvbG9yKSwgc3R5bGUoKS0+Y29sb3JTcGFjZSgpKTsKICAgICAgICAgCiAgICAgICAgIC8vIERy
YXcgdGhlIGZpbGVuYW1lCi0gICAgICAgIHBhaW50SW5mby5jb250ZXh0LT5kcmF3QmlkaVRleHQo
Zm9udCwgdGV4dFJ1biwgTGF5b3V0UG9pbnQodGV4dFgsIHRleHRZKSk7CisgICAgICAgIHBhaW50
SW5mby5jb250ZXh0LT5kcmF3QmlkaVRleHQoZm9udCwgdGV4dFJ1biwgcm91bmRlZEludFBvaW50
KExheW91dFBvaW50KHRleHRYLCB0ZXh0WSkpKTsKICAgICAgICAgCiAgICAgICAgIGlmIChpbnB1
dC0+aWNvbigpKSB7CiAgICAgICAgICAgICAvLyBEZXRlcm1pbmUgd2hlcmUgdGhlIGljb24gc2hv
dWxkIGJlIHBsYWNlZApAQCAtMTU0LDcgKzE1NCw3IEBAIHZvaWQgUmVuZGVyRmlsZVVwbG9hZENv
bnRyb2w6OnBhaW50T2JqZWMKICAgICAgICAgICAgICAgICBpY29uWCA9IGNvbnRlbnRMZWZ0ICsg
Y29udGVudFdpZHRoKCkgLSBidXR0b25XaWR0aCAtIGFmdGVyQnV0dG9uU3BhY2luZyAtIGljb25X
aWR0aDsKIAogICAgICAgICAgICAgLy8gRHJhdyB0aGUgZmlsZSBpY29uCi0gICAgICAgICAgICBp
bnB1dC0+aWNvbigpLT5wYWludChwYWludEluZm8uY29udGV4dCwgTGF5b3V0UmVjdChpY29uWCwg
aWNvblksIGljb25XaWR0aCwgaWNvbkhlaWdodCkpOworICAgICAgICAgICAgaW5wdXQtPmljb24o
KS0+cGFpbnQocGFpbnRJbmZvLmNvbnRleHQsIEludFJlY3Qocm91bmRlZEludFBvaW50KExheW91
dFBvaW50KGljb25YLCBpY29uWSkpLCBJbnRTaXplKGljb25XaWR0aCwgaWNvbkhlaWdodCkpKTsK
ICAgICAgICAgfQogICAgIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>131413</attachid>
            <date>2012-03-12 14:27:50 -0700</date>
            <delta_ts>2012-03-14 15:02:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-80881-20120312142749.patch</filename>
            <type>text/plain</type>
            <size>3716</size>
            <attacher name="Levi Weintraub">leviw</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExMDQ3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTAzLTEyICBMZXZpIFdl
aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBJbXBsZW1lbnQgcHJvcGVy
IHN1Yi1waXhlbCBzdXBwb3J0IGluIFJlbmRlckZpbGVVcGxvYWRDb250cm9sCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDg4MQorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvcnJlY3RpbmcgaW1wcm9wZXIg
dXNhZ2Ugb2YgTGF5b3V0VW5pdHMgd2hlbiBpbnRlcmFjdGluZyB3aXRoIHRoZSBncmFwaGljcyBj
b250ZXh0CisgICAgICAgIGFuZCBwbGF0Zm9ybSBjb2RlLiBTcGVjaWZpY2FsbHk6CisgICAgICAg
IC0gcGl4ZWwgc25hcHBpbmcgdGhlIGNsaXAgcmVjdCBhbmQgcGFpbnQgb2Zmc2V0cyBiZWZvcmUg
c2VuZGluZyB2YWx1ZXMgdG8gdGhlCisgICAgICAgICAgZ3JhcGhpY3MgY29udGV4dCBpbiBwYWlu
dE9iamVjdC4KKyAgICAgICAgLSB1c2luZyBvbi1zY3JlZW4gKHBpeGVsIHNuYXBwZWQpIHZhbHVl
cyB0byBwYXNzIG9mZiB0byBwbGF0Zm9ybSBjb2RlIHRvIGRldGVybWluZQorICAgICAgICAgIHRo
ZSBtYXggbGVuZ3RoIG9mIHRoZSBmaWxlbmFtZSB0byBiZSBkcmF3bi4KKworICAgICAgICBObyBu
ZXcgdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIHJlbmRlcmluZy9S
ZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpub2RlV2lkdGgp
OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6Om1heEZpbGVuYW1l
V2lkdGgpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmlsZVVwbG9hZENvbnRyb2w6OnBhaW50
T2JqZWN0KToKKwogMjAxMi0wMy0xMiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl
LmNvbT4KIAogICAgICAgICBJbmZpbml0ZSByZXBhaW50IGxvb3Agd2l0aCBTVkdJbWFnZUNhY2hl
IGFuZCBkZWZlcnJlZCByZXBhaW50IHRpbWVycwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy
aW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwCShyZXZpc2lvbiAxMTA0
NDgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmlsZVVwbG9hZENvbnRyb2wu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NiwxMyArODYsMTMgQEAgdm9pZCBSZW5kZXJGaWxlVXBs
b2FkQ29udHJvbDo6dXBkYXRlRnJvbQogCiBzdGF0aWMgaW50IG5vZGVXaWR0aChOb2RlKiBub2Rl
KQogewotICAgIHJldHVybiBub2RlID8gbm9kZS0+cmVuZGVyQm94KCktPndpZHRoKCkgOiB6ZXJv
TGF5b3V0VW5pdDsKKyAgICByZXR1cm4gbm9kZSA/IG5vZGUtPnJlbmRlckJveCgpLT5waXhlbFNu
YXBwZWRXaWR0aCgpIDogMDsKIH0KIAogaW50IFJlbmRlckZpbGVVcGxvYWRDb250cm9sOjptYXhG
aWxlbmFtZVdpZHRoKCkgY29uc3QKIHsKICAgICBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dCA9IHN0
YXRpY19jYXN0PEhUTUxJbnB1dEVsZW1lbnQqPihub2RlKCkpOwotICAgIHJldHVybiBtYXgoMCwg
Y29udGVudFdpZHRoKCkgLSBub2RlV2lkdGgodXBsb2FkQnV0dG9uKCkpIC0gYWZ0ZXJCdXR0b25T
cGFjaW5nCisgICAgcmV0dXJuIG1heCgwLCBjb250ZW50Qm94UmVjdCgpLnBpeGVsU25hcHBlZFdp
ZHRoKCkgLSBub2RlV2lkdGgodXBsb2FkQnV0dG9uKCkpIC0gYWZ0ZXJCdXR0b25TcGFjaW5nCiAg
ICAgICAgIC0gKGlucHV0LT5pY29uKCkgPyBpY29uV2lkdGggKyBpY29uRmlsZW5hbWVTcGFjaW5n
IDogMCkpOwogfQogCkBAIC0xMDQsNyArMTA0LDcgQEAgdm9pZCBSZW5kZXJGaWxlVXBsb2FkQ29u
dHJvbDo6cGFpbnRPYmplYwogICAgIC8vIFB1c2ggYSBjbGlwLgogICAgIEdyYXBoaWNzQ29udGV4
dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcigqcGFpbnRJbmZvLmNvbnRleHQsIGZhbHNlKTsKICAgICBp
ZiAocGFpbnRJbmZvLnBoYXNlID09IFBhaW50UGhhc2VGb3JlZ3JvdW5kIHx8IHBhaW50SW5mby5w
aGFzZSA9PSBQYWludFBoYXNlQ2hpbGRCbG9ja0JhY2tncm91bmRzKSB7Ci0gICAgICAgIExheW91
dFJlY3QgY2xpcFJlY3QocGFpbnRPZmZzZXQueCgpICsgYm9yZGVyTGVmdCgpLCBwYWludE9mZnNl
dC55KCkgKyBib3JkZXJUb3AoKSwKKyAgICAgICAgSW50UmVjdCBjbGlwUmVjdCA9IHBpeGVsU25h
cHBlZEludFJlY3QocGFpbnRPZmZzZXQueCgpICsgYm9yZGVyTGVmdCgpLCBwYWludE9mZnNldC55
KCkgKyBib3JkZXJUb3AoKSwKICAgICAgICAgICAgICAgICAgICAgICAgICB3aWR0aCgpIC0gYm9y
ZGVyTGVmdCgpIC0gYm9yZGVyUmlnaHQoKSwgaGVpZ2h0KCkgLSBib3JkZXJCb3R0b20oKSAtIGJv
cmRlclRvcCgpICsgYnV0dG9uU2hhZG93SGVpZ2h0KTsKICAgICAgICAgaWYgKGNsaXBSZWN0Lmlz
RW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybjsKQEAgLTE0Miw3ICsxNDIsNyBAQCB2b2lkIFJl
bmRlckZpbGVVcGxvYWRDb250cm9sOjpwYWludE9iamVjCiAgICAgICAgIHBhaW50SW5mby5jb250
ZXh0LT5zZXRGaWxsQ29sb3Ioc3R5bGUoKS0+dmlzaXRlZERlcGVuZGVudENvbG9yKENTU1Byb3Bl
cnR5Q29sb3IpLCBzdHlsZSgpLT5jb2xvclNwYWNlKCkpOwogICAgICAgICAKICAgICAgICAgLy8g
RHJhdyB0aGUgZmlsZW5hbWUKLSAgICAgICAgcGFpbnRJbmZvLmNvbnRleHQtPmRyYXdCaWRpVGV4
dChmb250LCB0ZXh0UnVuLCBMYXlvdXRQb2ludCh0ZXh0WCwgdGV4dFkpKTsKKyAgICAgICAgcGFp
bnRJbmZvLmNvbnRleHQtPmRyYXdCaWRpVGV4dChmb250LCB0ZXh0UnVuLCBJbnRQb2ludChyb3Vu
ZFRvSW50KHRleHRYKSwgcm91bmRUb0ludCh0ZXh0WSkpKTsKICAgICAgICAgCiAgICAgICAgIGlm
IChpbnB1dC0+aWNvbigpKSB7CiAgICAgICAgICAgICAvLyBEZXRlcm1pbmUgd2hlcmUgdGhlIGlj
b24gc2hvdWxkIGJlIHBsYWNlZApAQCAtMTU0LDcgKzE1NCw3IEBAIHZvaWQgUmVuZGVyRmlsZVVw
bG9hZENvbnRyb2w6OnBhaW50T2JqZWMKICAgICAgICAgICAgICAgICBpY29uWCA9IGNvbnRlbnRM
ZWZ0ICsgY29udGVudFdpZHRoKCkgLSBidXR0b25XaWR0aCAtIGFmdGVyQnV0dG9uU3BhY2luZyAt
IGljb25XaWR0aDsKIAogICAgICAgICAgICAgLy8gRHJhdyB0aGUgZmlsZSBpY29uCi0gICAgICAg
ICAgICBpbnB1dC0+aWNvbigpLT5wYWludChwYWludEluZm8uY29udGV4dCwgTGF5b3V0UmVjdChp
Y29uWCwgaWNvblksIGljb25XaWR0aCwgaWNvbkhlaWdodCkpOworICAgICAgICAgICAgaW5wdXQt
Pmljb24oKS0+cGFpbnQocGFpbnRJbmZvLmNvbnRleHQsIEludFJlY3Qocm91bmRUb0ludChpY29u
WCksIHJvdW5kVG9JbnQoaWNvblkpLCBpY29uV2lkdGgsIGljb25IZWlnaHQpKTsKICAgICAgICAg
fQogICAgIH0KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>