80875 2012-03-12 13:10:35 -0700 GestureTapDown needs to pin in-progress flings 2012-03-16 17:52:38 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rjkroege rjkroege abarth rjkroege webkit.review.bot oldest_to_newest 576440 0 rjkroege 2012-03-12 13:10:35 -0700 GestureTapDown should pin (i.e. stop) any in-progress animation. 576449 1 131392 rjkroege 2012-03-12 13:18:58 -0700 Created attachment 131392 Patch 576588 2 rjkroege 2012-03-12 15:04:55 -0700 abarth@: please take a look? 579825 3 131392 abarth 2012-03-15 15:41:58 -0700 Comment on attachment 131392 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131392&action=review This looks fine. I'm always torn for these patch in how hard I should push you for tests. It seems like we don't have much test coverage for this code, which makes me worry that we'll break it in the future. > Source/WebCore/page/EventHandler.cpp:2371 > + FrameView* view = m_frame->view(); > + if (view) { Prefer early return. > Source/WebCore/page/EventHandler.cpp:2375 > + return false; Bad indent. 579859 4 rjkroege 2012-03-15 16:17:41 -0700 About tests: there should be a better way to test ScrollAnimatorNone-based behaviour. I plan on trying to write something as a prereq for https://bugs.webkit.org/show_bug.cgi?id=80596. 581057 5 132408 rjkroege 2012-03-16 15:50:42 -0700 Created attachment 132408 Patch 581159 6 132408 webkit.review.bot 2012-03-16 17:52:33 -0700 Comment on attachment 132408 Patch Clearing flags on attachment: 132408 Committed r111101: <http://trac.webkit.org/changeset/111101> 581160 7 webkit.review.bot 2012-03-16 17:52:38 -0700 All reviewed patches have been landed. Closing bug. 131392 2012-03-12 13:18:58 -0700 2012-03-16 15:50:37 -0700 Patch bug-80875-20120312161857.patch text/plain 2856 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI0ZDlmM2MxZjY1MGE2 MTgyMzczM2NiNDU0ZjAxNDkzZWYwMGE4NS4uYTJjMGZkMDM4ZjkxY2RjYzIwZmUyODU3NDJiOTdl M2Y0MDBjMGU1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTEyICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBHZXN0dXJlVGFw RG93biBuZWVkcyB0byBwaW4gaW4tcHJvZ3Jlc3MgZmxpbmdzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDg3NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZUdl c3R1cmVUYXBEb3duKToKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorICAgICAgICAo RXZlbnRIYW5kbGVyKToKKwogMjAxMi0wMy0xMiAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmUtYXBwbHkgdGhlIHBhdGNoIGFmdGVyIHY4IHJvbGwg dG8gcjExMDAwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDE3MzhkYjg5 NjNhODYzNjE0NTMxMWRiZDE2YjJmNmQ4YWJjNDI3YjkuLjI2OTZjMmIxNDU0NWY5MmE2MWFhZjFl NmRlNzUwNTAwNzg4NjhmNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRI YW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAg LTIzNjUsNiArMjM2NSwyNCBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6ZGVmYXVsdFdoZWVsRXZlbnRI YW5kbGVyKE5vZGUqIHN0YXJ0Tm9kZSwgV2hlZWxFdmVudCogd2hlZWxFdgogfQogCiAjaWYgRU5B QkxFKEdFU1RVUkVfRVZFTlRTKQorYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVUYXBE b3duKCkKK3sKKyAgICBGcmFtZVZpZXcqIHZpZXcgPSBtX2ZyYW1lLT52aWV3KCk7CisgICAgaWYg KHZpZXcpIHsKKyAgICAgICAgdmlldy0+c2Nyb2xsQW5pbWF0b3IoKS0+Y2FuY2VsQW5pbWF0aW9u cygpOworICAgICAgICBjb25zdCBGcmFtZVZpZXc6OlNjcm9sbGFibGVBcmVhU2V0KiBhcmVhcyA9 IHZpZXctPnNjcm9sbGFibGVBcmVhcygpOworICAgICAgICBpZiAoIWFyZWFzKQorICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgICAgIGZvciAoRnJhbWVWaWV3OjpTY3JvbGxhYmxlQXJlYVNl dDo6Y29uc3RfaXRlcmF0b3IgaXQgPSBhcmVhcy0+YmVnaW4oKTsgaXQgIT0gYXJlYXMtPmVuZCgp OyArK2l0KSB7CisgICAgICAgICAgICBTY3JvbGxhYmxlQXJlYSogc2EgPSAqaXQ7CisgICAgICAg ICAgICBTY3JvbGxBbmltYXRvciogYW5pbWF0b3IgPSBzYS0+c2Nyb2xsQW5pbWF0b3IoKTsKKyAg ICAgICAgICAgIGlmIChhbmltYXRvcikKKyAgICAgICAgICAgICAgICBhbmltYXRvci0+Y2FuY2Vs QW5pbWF0aW9ucygpOworICAgICAgICB9CisgICAgfQorICAgIHJldHVybiBmYWxzZTsKK30KKwog Ym9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1 cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQogewogICAgIC8vIEZJWE1FOiBBIG1vcmUgZ2VuZXJhbCBz Y3JvbGwgc3lzdGVtIChodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA1 OTYpIHdpbGwKQEAgLTIzNzMsOCArMjM5MSw3IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVH ZXN0dXJlRXZlbnQoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1cmVFdmVudCkKIAog ICAgIHN3aXRjaCAoZ2VzdHVyZUV2ZW50LnR5cGUoKSkgewogICAgIGNhc2UgUGxhdGZvcm1FdmVu dDo6R2VzdHVyZVRhcERvd246Ci0gICAgICAgIC8vIEZJWE1FOiBTdG9wIGFuaW1hdGlvbiBoZXJl LgotICAgICAgICBicmVhazsKKyAgICAgICAgcmV0dXJuIGhhbmRsZUdlc3R1cmVUYXBEb3duKCk7 CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlVGFwOgogICAgICAgICByZXR1cm4gaGFu ZGxlR2VzdHVyZVRhcChnZXN0dXJlRXZlbnQpOwogICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2Vz dHVyZVNjcm9sbFVwZGF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRI YW5kbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCmluZGV4IDJlZGJh OTBhYmZlNTIxMjg4NzI0MTNhMjBkY2NiZjgxMDVmYjcxYzEuLjFjYWMwNzVmYjk4OTk2MWI5ZjZi MWY0MjEwOTgwYjhjZWU4MjdlZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaApAQCAt MzUwLDYgKzM1MCw3IEBAIHByaXZhdGU6CiAKICNpZiBFTkFCTEUoR0VTVFVSRV9FVkVOVFMpCiAg ICAgYm9vbCBoYW5kbGVHZXN0dXJlU2Nyb2xsQ29yZShjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVu dCYsIFBsYXRmb3JtV2hlZWxFdmVudEdyYW51bGFyaXR5LCBib29sIGxhdGNoZWRXaGVlbCk7Cisg ICAgYm9vbCBoYW5kbGVHZXN0dXJlVGFwRG93bigpOwogI2VuZGlmCiAKICAgICBGcmFtZSogbV9m cmFtZTsK 132408 2012-03-16 15:50:42 -0700 2012-03-16 17:52:33 -0700 Patch bug-80875-20120316185041.patch text/plain 2852 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2EzZTY5ZjVhN2ZhZmI0 ZTQwNmJjYjE1MTUwZDJiZjczNmYxODJjMi4uNzU1YzgxMGZlNmFmMTNiNzJkMTkwMjBjNjQxMjRj NTVjYTIwN2VhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTAzLTEyICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBHZXN0dXJlVGFw RG93biBuZWVkcyB0byBwaW4gaW4tcHJvZ3Jlc3MgZmxpbmdzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDg3NQorCisgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0gQmFydGguCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAg IChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVy ZVRhcERvd24pOgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmg6CisgICAgICAgIChFdmVu dEhhbmRsZXIpOgorCiAyMDEyLTAzLTE2ICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIDEwMCUgaGVpZ2h0IGVsZW1lbnRzIHRvIG5vdCByZXNwb25k IHRvIHZlcnRpY2FsIGJyb3dzZXIgcmVzY2FsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAKaW5kZXggNGZhYzBlMjQ4NzExMmYyYTU3ZGI3NjI4NTVlMTYwMWM4ZjJhOTE0MS4uZGM1 NjAyYjczYjMzOTliMzUzMWNkOThiMmFkNzUyNDE0OTU0MmMxMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcApAQCAtMjM2NSw2ICsyMzY1LDI0IEBAIHZvaWQgRXZlbnRIYW5kbGVy OjpkZWZhdWx0V2hlZWxFdmVudEhhbmRsZXIoTm9kZSogc3RhcnROb2RlLCBXaGVlbEV2ZW50KiB3 aGVlbEV2CiB9CiAKICNpZiBFTkFCTEUoR0VTVFVSRV9FVkVOVFMpCitib29sIEV2ZW50SGFuZGxl cjo6aGFuZGxlR2VzdHVyZVRhcERvd24oKQoreworICAgIEZyYW1lVmlldyogdmlldyA9IG1fZnJh bWUtPnZpZXcoKTsKKyAgICBpZiAoIXZpZXcpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB2 aWV3LT5zY3JvbGxBbmltYXRvcigpLT5jYW5jZWxBbmltYXRpb25zKCk7CisgICAgY29uc3QgRnJh bWVWaWV3OjpTY3JvbGxhYmxlQXJlYVNldCogYXJlYXMgPSB2aWV3LT5zY3JvbGxhYmxlQXJlYXMo KTsKKyAgICBpZiAoIWFyZWFzKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgZm9yIChGcmFt ZVZpZXc6OlNjcm9sbGFibGVBcmVhU2V0Ojpjb25zdF9pdGVyYXRvciBpdCA9IGFyZWFzLT5iZWdp bigpOyBpdCAhPSBhcmVhcy0+ZW5kKCk7ICsraXQpIHsKKyAgICAgICAgU2Nyb2xsYWJsZUFyZWEq IHNhID0gKml0OworICAgICAgICBTY3JvbGxBbmltYXRvciogYW5pbWF0b3IgPSBzYS0+c2Nyb2xs QW5pbWF0b3IoKTsKKyAgICAgICAgaWYgKGFuaW1hdG9yKQorICAgICAgICAgICAgYW5pbWF0b3It PmNhbmNlbEFuaW1hdGlvbnMoKTsKKyAgICB9CisgICAgcmV0dXJuIGZhbHNlOworfQorCiBib29s IEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUV2ZW50KGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2 ZW50JiBnZXN0dXJlRXZlbnQpCiB7CiAgICAgLy8gRklYTUU6IEEgbW9yZSBnZW5lcmFsIHNjcm9s bCBzeXN0ZW0gKGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDU5Nikg d2lsbApAQCAtMjM3Myw4ICsyMzkxLDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1 cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQogCiAgICAg c3dpdGNoIChnZXN0dXJlRXZlbnQudHlwZSgpKSB7CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpH ZXN0dXJlVGFwRG93bjoKLSAgICAgICAgLy8gRklYTUU6IFN0b3AgYW5pbWF0aW9uIGhlcmUuCi0g ICAgICAgIGJyZWFrOworICAgICAgICByZXR1cm4gaGFuZGxlR2VzdHVyZVRhcERvd24oKTsKICAg ICBjYXNlIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVUYXA6CiAgICAgICAgIHJldHVybiBoYW5kbGVH ZXN0dXJlVGFwKGdlc3R1cmVFdmVudCk7CiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJl U2Nyb2xsVXBkYXRlOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgKaW5kZXggMmVkYmE5MGFi ZmU1MjEyODg3MjQxM2EyMGRjY2JmODEwNWZiNzFjMS4uMWNhYzA3NWZiOTg5OTYxYjlmNmIxZjQy MTA5ODBiOGNlZTgyN2VmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhh bmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCkBAIC0zNTAs NiArMzUwLDcgQEAgcHJpdmF0ZToKIAogI2lmIEVOQUJMRShHRVNUVVJFX0VWRU5UUykKICAgICBi b29sIGhhbmRsZUdlc3R1cmVTY3JvbGxDb3JlKGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50Jiwg UGxhdGZvcm1XaGVlbEV2ZW50R3JhbnVsYXJpdHksIGJvb2wgbGF0Y2hlZFdoZWVsKTsKKyAgICBi b29sIGhhbmRsZUdlc3R1cmVUYXBEb3duKCk7CiAjZW5kaWYKIAogICAgIEZyYW1lKiBtX2ZyYW1l Owo=