80868 2012-03-12 12:35:47 -0700 Make texImage2D error for wrong size ArrayBufferView more helpful 2012-03-12 14:15:48 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 gman gman kbr webkit.review.bot oldest_to_newest 576395 0 gman 2012-03-12 12:35:47 -0700 Make texImage2D error for wrong size ArrayBufferView more helpful 576398 1 131383 gman 2012-03-12 12:38:03 -0700 Created attachment 131383 Patch 576401 2 gman 2012-03-12 12:40:12 -0700 I could just change the original message instead of adding the special check. I could also change the new message to something more verbose like "ArrayBufferView not big enough for request but would be if UNPACK_ALIGNMENT was set to 1" thoughts? 576420 3 131383 kbr 2012-03-12 13:01:44 -0700 Comment on attachment 131383 Patch Looks good. r=me 576505 4 131383 webkit.review.bot 2012-03-12 14:15:38 -0700 Comment on attachment 131383 Patch Clearing flags on attachment: 131383 Committed r110477: <http://trac.webkit.org/changeset/110477> 576506 5 webkit.review.bot 2012-03-12 14:15:48 -0700 All reviewed patches have been landed. Closing bug. 131383 2012-03-12 12:38:03 -0700 2012-03-12 14:15:37 -0700 Patch bug-80868-20120312123802.patch text/plain 2153 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQ3ZGVhNDA5OGEwYzQ2 ODVhNGQwMDBlMmNhNTVhZWM5NTAwYTNmOC4uNzkwMDJjYzYxNGUxZjMxYTJiMmQ5MzQwOTA5MTI2 YTM4MzdmNDEwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTAzLTEyICBHcmVn ZyBUYXZhcmVzICA8Z21hbkBnb29nbGUuY29tPgorCisgICAgICAgIE1ha2UgdGV4SW1hZ2UyRCBl cnJvciBmb3Igd3Jvbmcgc2l6ZSBBcnJheUJ1ZmZlclZpZXcgbW9yZSBoZWxwZnVsCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDg2OAorICAgICAgICAK KyAgICAgICAgSXQgdG9vayBtZSBhYm91dCAzMCBtaW51dGVzIHRvIGZpZ3VyZSBvdXQgbXkgdGV4 SW1hZ2UyRCB3YXMgZmFpbGluZworICAgICAgICBub3QgYmVjYXVzZSBteSBBcnJheUJ1ZmZlclZp ZXcgd2FzIHRvbyBzbWFsbCBidXQgYmVjYXVzZSB0aGUgZGVmYXVsdAorICAgICAgICBhbGlnbm1l bnQgaXMgNC4gQSBiZXR0ZXIgZXJyb3IgbWVzc2FnZSBtaWdodCBoZWxwIGRldnMgZmluZCB0aGlz IGlzc3VlCisgICAgICAgIGZhc3Rlci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisK KyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAg ICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnZh bGlkYXRlVGV4RnVuY0RhdGEpOgorCiAyMDEyLTAzLTExICBWaWN0b3IgQ2FyYnVuZSAgPHZjYXJi dW5lQGFkb2JlLmNvbT4KIAogICAgICAgICBUaGUgbWFpbiBjb2RlIHN0cnVjdHVyZSBmb3IgcGxh Y2luZyBmdXR1cmUgdGV4dCB0cmFjayBjdWUgcmVuZGVyaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dl YkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAppbmRleCA0ZGVkOTc4 MWRlYTZhMmE5YzMwYTIyMmJlMTJlOGIxMGIzYTA4MjRlLi45OGEyYjdlNTI1YTNjN2UzMGFiNzk0 NTJmNDAxYzU1ZjNjNzcyMTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2Fu dmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKQEAgLTQ3NTUsNiArNDc1NSwxMyBAQCBib29s IFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6dmFsaWRhdGVUZXhGdW5jRGF0YShjb25zdCBjaGFyKiBm dW5jdGlvbk5hbWUsCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAgICAgaWYgKHBpeGVs cy0+Ynl0ZUxlbmd0aCgpIDwgdG90YWxCeXRlc1JlcXVpcmVkKSB7CisgICAgICAgIGlmIChtX3Vu cGFja0FsaWdubWVudCAhPSAxKSB7CisgICAgICAgICAgZXJyb3IgPSBtX2NvbnRleHQtPmNvbXB1 dGVJbWFnZVNpemVJbkJ5dGVzKGZvcm1hdCwgdHlwZSwgd2lkdGgsIGhlaWdodCwgMSwgJnRvdGFs Qnl0ZXNSZXF1aXJlZCwgMCk7CisgICAgICAgICAgaWYgKHBpeGVscy0+Ynl0ZUxlbmd0aCgpID09 IHRvdGFsQnl0ZXNSZXF1aXJlZCkgeworICAgICAgICAgICAgc3ludGhlc2l6ZUdMRXJyb3IoR3Jh cGhpY3NDb250ZXh0M0Q6OklOVkFMSURfT1BFUkFUSU9OLCBmdW5jdGlvbk5hbWUsICJBcnJheUJ1 ZmZlclZpZXcgbm90IGJpZyBlbm91Z2ggZm9yIHJlcXVlc3Qgd2l0aCBVTlBBQ0tfQUxJR05NRU5U ID4gMSIpOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgIH0KKyAgICAgICAg fQogICAgICAgICBzeW50aGVzaXplR0xFcnJvcihHcmFwaGljc0NvbnRleHQzRDo6SU5WQUxJRF9P UEVSQVRJT04sIGZ1bmN0aW9uTmFtZSwgIkFycmF5QnVmZmVyVmlldyBub3QgYmlnIGVub3VnaCBm b3IgcmVxdWVzdCIpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQo=