80864 2012-03-12 12:02:54 -0700 New PageCache histogram which counts failures ignoring Settings. 2012-03-13 08:29:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gavinp gavinp beidson webkit.review.bot oldest_to_newest 576366 0 gavinp 2012-03-12 12:02:54 -0700 New PageCache histogram which counts failures ignoring Settings. 576367 1 131375 gavinp 2012-03-12 12:04:38 -0700 Created attachment 131375 Patch 576368 2 gavinp 2012-03-12 12:07:22 -0700 Chrome has a command line switch to turn on the page cache. Currently it doesn't work, but it can cause the PageCache reasons for failure count to read lower than it should. Add a new histogram to report the corrected value. 576369 3 gavinp 2012-03-12 12:08:13 -0700 beidson, Two questions: 1. Do you want to review histogram changes? 2. WDYT? 576391 4 beidson 2012-03-12 12:31:02 -0700 (In reply to comment #3) > beidson, > > Two questions: > > 1. Do you want to review histogram changes? > Sure > 2. WDYT? Will look after lunch. 577340 5 131375 webkit.review.bot 2012-03-13 08:29:11 -0700 Comment on attachment 131375 Patch Clearing flags on attachment: 131375 Committed r110567: <http://trac.webkit.org/changeset/110567> 577341 6 webkit.review.bot 2012-03-13 08:29:15 -0700 All reviewed patches have been landed. Closing bug. 131375 2012-03-12 12:04:38 -0700 2012-03-13 08:29:11 -0700 Patch bug-80864-20120312150436.patch text/plain 1859 gavinp U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwMzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVmNGM1ZTZmYTM2ZGE1 ZGQ0NGQwZTEyNjAwNzk1N2Y4YWJiNzgzMC4uNTBjODExYjYxZmFlZGFlNzlmNThlNmRhNjJjZGE5 YWFjNDM3ZTdjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTAzLTEyICBHYXZp biBQZXRlcnMgIDxnYXZpbnBAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE5ldyBQYWdlQ2FjaGUg aGlzdG9ncmFtIHdoaWNoIGNvdW50cyBmYWlsdXJlcyBpZ25vcmluZyBTZXR0aW5ncy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgwODY0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21lIGhhcyBhIGNv bW1hbmQgbGluZSBzd2l0Y2ggdG8gdHVybiBvbiB0aGUgcGFnZSBjYWNoZS4KKyAgICAgICAgQ3Vy cmVudGx5IGl0IGRvZXNuJ3Qgd29yaywgYnV0IGl0IGNhbiBjYXVzZSB0aGUgUGFnZUNhY2hlIHJl YXNvbnMKKyAgICAgICAgZm9yIGZhaWx1cmUgY291bnQgdG8gcmVhZCBsb3dlciB0aGFuIGl0IHNo b3VsZC4gIEFkZCBhIG5ldworICAgICAgICBoaXN0b2dyYW0gdG8gcmVwb3J0IHRoZSBjb3JyZWN0 ZWQgdmFsdWUuCisKKyAgICAgICAgKiBoaXN0b3J5L1BhZ2VDYWNoZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpsb2dDYW5DYWNoZVBhZ2VEZWNpc2lvbik6CisKIDIwMTItMDMtMTAgIFN0ZXBoZW4g V2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjExMDM1OC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2hpc3Rvcnkv UGFnZUNhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcAppbmRl eCA5ZjE3NzNjZWZmNzg5ZDEwY2MzNDRhM2ExZDc0MjA2YmVkZWFhYTNiLi5iYmRmNGRiY2M2NmIy ZGI4OTRlOTZlZmFjYjkwNzA3OWY5ZjVmMzJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9o aXN0b3J5L1BhZ2VDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2Fj aGUuY3BwCkBAIC0yNjQsNiArMjY0LDggQEAgc3RhdGljIHZvaWQgbG9nQ2FuQ2FjaGVQYWdlRGVj aXNpb24oUGFnZSogcGFnZSkKICAgICAgICAgfQogICAgIH0KICAgICBIaXN0b2dyYW1TdXBwb3J0 OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiUGFnZUNhY2hlLlBhZ2VSZWplY3RSZWFzb25Db3VudCIs IHJlYXNvbkNvdW50LCAxICsgTnVtYmVyT2ZSZWFzb25zUGFnZXNDYW5ub3RCZUluUGFnZUNhY2hl KTsKKyAgICBjb25zdCBib29sIHNldHRpbmdzRGlzYWJsZWRQYWdlQ2FjaGUgPSByZWplY3RSZWFz b25zICYgKDEgPDwgRGlzYWJsZWRQYWdlQ2FjaGUpOworICAgIEhpc3RvZ3JhbVN1cHBvcnQ6Omhp c3RvZ3JhbUVudW1lcmF0aW9uKCJQYWdlQ2FjaGUuUGFnZVJlamVjdFJlYXNvbkNvdW50RXhjbHVk aW5nU2V0dGluZ3MiLCByZWFzb25Db3VudCAtIHNldHRpbmdzRGlzYWJsZWRQYWdlQ2FjaGUsIE51 bWJlck9mUmVhc29uc1BhZ2VzQ2Fubm90QmVJblBhZ2VDYWNoZSk7CiAKICAgICAvLyBSZXBvcnQg YWxzbyBvbiB0aGUgZnJhbWUgcmVhc29ucyBieSBwYWdlOyB0aGlzIGlzIGRpc3RpbmN0IGZyb20g dGhlIHBlciBmcmFtZSBzdGF0aXN0aWNzIHNpbmNlIGl0IGNvYWxlc2NlcyB0aGUKICAgICAvLyBj YXVzZXMgZnJvbSBhbGwgc3ViZnJhbWVzIHRvZ2V0aGVyLgo=