80862 2012-03-12 11:33:51 -0700 [Chromium] Temporary build-fix for the Android bot 2012-03-12 12:50:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80861 1 peter peter webkit.review.bot oldest_to_newest 576322 0 peter 2012-03-12 11:33:51 -0700 [Chromium] Temporary build-fix for the Android bot 576324 1 131364 peter 2012-03-12 11:35:07 -0700 Created attachment 131364 Patch 576334 2 peter 2012-03-12 11:40:34 -0700 Firstly: Yes, I'm aware that this is horrible. A change in the Android envsetup.sh script at Chromium[1] has broken the WebKit Android builder, among another configuration. A Chromium-side fix is being created by bulach@ downstream but isn't ready to be upstreamed yet, and getting that into WebKit would take another day. In the meantime there are two other compile errors which have gone unnoticed, unfortunately both on the Chromium side as well. To make sure things don't get significantly worse I'd like to have the bot compiling *something* asap, aiming to be completely green again by the end of this week. This code will be removed very shortly after the Chromium-side fix is available, which shouldn't be more than a few days. [1] http://src.chromium.org/viewvc/chrome?view=rev&revision=124565 576335 3 131364 abarth 2012-03-12 11:41:59 -0700 Comment on attachment 131364 Patch Ok. 576338 4 131364 peter 2012-03-12 11:43:12 -0700 Comment on attachment 131364 Patch Thanks! 576408 5 131364 webkit.review.bot 2012-03-12 12:50:51 -0700 Comment on attachment 131364 Patch Clearing flags on attachment: 131364 Committed r110460: <http://trac.webkit.org/changeset/110460> 576409 6 webkit.review.bot 2012-03-12 12:50:55 -0700 All reviewed patches have been landed. Closing bug. 131364 2012-03-12 11:35:07 -0700 2012-03-12 12:50:51 -0700 Patch bug-80862-20120312183505.patch text/plain 2025 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmZiODllMTAxYzI3YTE0MjVlNThlZDMwMDkzZTIxMDlh MmYxZDk5Ni4uZjcxYzM4MzRmNzIwMjA2N2E2MWU2YTQxOTRjNTFkYWQyNTZlOTcxNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTAzLTEyICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIFRlbXBvcmFyeSBidWlsZC1maXggZm9yIHRoZSBBbmRyb2lkIGJv dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4NjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYW51YWxs eSBzZXQgdGhlIGVudmlyb25tZW50YWwgdmFyaWFibGVzIHJlcXVpcmVkIHRvIGNvbXBpbGUgc291 cmNlCisgICAgICAgIGZpbGVzIHRocm91Z2ggdGhlIEFuZHJvaWQgTkRLIGluc3RlYWQgb2YgcmVs eWluZyBvbiB0aGUgZW52c2V0dXAuc2gKKyAgICAgICAgc2NyaXB0LiBBIHByb3BlciBmaXggd2ls bCBiZSBsYW5kZWQgdG8gQ2hyb21pdW0gQVNBUCwgYW5kIGZvbGxvd2luZworICAgICAgICBhIENo cm9taXVtIHJvbGwgaW50byBXZWJLaXQgdGhpcyBjb2RlIHdpbGwgYmUgcmVtb3ZlZC4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGJ1aWxkQ2hyb21pdW1NYWtl ZmlsZSk6CisKIDIwMTItMDMtMTIgIEMgQW50aG9ueSBSaXNpbmdlciAgPGFudGhvbnlAeHRmeC5t ZT4KIAogICAgICAgICBbR1RLXSByMTEwMjk2IGluY2x1ZGVkIGFuIGV4dHJhICQgaW4gQCQoQU1f Vl9HRU4pCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNTFhMWI5YzUzYzEwNTg1NDk4MjVmNDE2MTQzZWIz NDhhODE5OGY4YS4uN2ExNThlM2YyNzJkZDIxM2U3NTllY2I0OGNmMjk5YzRhMjVlNDY4YyAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQpAQCAtMjMwMiw2ICsyMzAyLDEzIEBAIHN1YiBidWlsZENocm9taXVtTWFr ZWZpbGUoJCRAKQogICAgICAgICAkY29tbWFuZCAuPSAiYmFzaCAtYyBcInNvdXJjZSAiIC4gc291 cmNlRGlyKCkgLiAiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vYnVpbGQvYW5kcm9pZC9lbnZzZXR1 cC5zaCAmJiAiOwogICAgICAgICAkRU5We0FORFJPSURfTkRLX1JPT1R9ID0gc291cmNlRGlyKCkg LiAiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vYW5kcm9pZC1uZGstcjciOwogICAgICAgICAkRU5W e1dFQktJVF9BTkRST0lEX0JVSUxEfSA9IDE7CisKKyAgICAgICAgIyBGSVhNRTogUmVtb3ZlIHRo ZSBidWlsZC1maXggb25jZSB0aGUgQ2hyb21pdW0tc2lkZSBmaXggcm9sbGVkIGluLgorICAgICAg ICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MDg2MQorICAgICAg ICBteSAkYmluYXJ5UHJlZml4ID0gJEVOVntBTkRST0lEX05ES19ST09UfSAuICIvdG9vbGNoYWlu cy9hcm0tbGludXgtYW5kcm9pZGVhYmktNC40LjMvcHJlYnVpbHQvbGludXgteDg2L2Jpbi9hcm0t bGludXgtYW5kcm9pZGVhYmkiOworICAgICAgICAkY29tbWFuZCAuPSBxcShDQz0iJGJpbmFyeVBy ZWZpeC1nY2MiIENYWD0iJGJpbmFyeVByZWZpeC1nKysiICk7CisgICAgICAgICRjb21tYW5kIC49 IHFxKExJTks9IiRiaW5hcnlQcmVmaXgtZ2NjIiBBUj0iJGJpbmFyeVByZWZpeC1hciIgKTsKKyAg ICAgICAgJGNvbW1hbmQgLj0gcXEoUkFOTElCPSIkYmluYXJ5UHJlZml4LXJhbmxpYiIgKTsKICAg ICB9CiAKICAgICAkY29tbWFuZCAuPSAibWFrZSAtZk1ha2VmaWxlLmNocm9taXVtICRtYWtlQXJn cyBCVUlMRFRZUEU9JGNvbmZpZyAkdGFyZ2V0IjsK