80858 2012-03-12 10:47:43 -0700 Connect up fling event delivery to gesture curve animation framework 2012-03-16 03:20:23 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 80607 1 rjkroege rjkroege dglazkov gustavo webkit.review.bot wjmaclean xan.lopez oldest_to_newest 576265 0 rjkroege 2012-03-12 10:47:43 -0700 To let https://bugs.webkit.org/show_bug.cgi?id=79827 and https://bugs.webkit.org/show_bug.cgi?id=80311 land separately, it was necessary to remove the final wiring connecting them. Add the necessary plumbing. 576285 1 131353 rjkroege 2012-03-12 11:05:18 -0700 Created attachment 131353 Patch 576294 2 131353 gustavo 2012-03-12 11:15:29 -0700 Comment on attachment 131353 Patch Attachment 131353 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11938985 576309 3 131353 webkit.review.bot 2012-03-12 11:25:34 -0700 Comment on attachment 131353 Patch Attachment 131353 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11939950 576376 4 rjkroege 2012-03-12 12:17:04 -0700 note: needs 80607 to build. 576593 5 131353 abarth 2012-03-12 15:10:32 -0700 Comment on attachment 131353 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131353&action=review > Source/WebCore/platform/ScrollAnimatorNone.cpp:397 > + if (!!m_gestureAnimation) Do you need the !! here? 577351 6 131353 rjkroege 2012-03-13 08:38:49 -0700 Comment on attachment 131353 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=131353&action=review >> Source/WebCore/platform/ScrollAnimatorNone.cpp:397 >> + if (!!m_gestureAnimation) > > Do you need the !! here? probably not. I'll update if so prior to committing. 579983 7 132167 rjkroege 2012-03-15 18:07:44 -0700 Created attachment 132167 Patch 580327 8 132167 webkit.review.bot 2012-03-16 03:20:18 -0700 Comment on attachment 132167 Patch Clearing flags on attachment: 132167 Committed r110978: <http://trac.webkit.org/changeset/110978> 580328 9 webkit.review.bot 2012-03-16 03:20:23 -0700 All reviewed patches have been landed. Closing bug. 131353 2012-03-12 11:05:18 -0700 2012-03-15 18:07:38 -0700 Patch bug-80858-20120312140517.patch text/plain 1511 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwNDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI0ZDlmM2MxZjY1MGE2 MTgyMzczM2NiNDU0ZjAxNDkzZWYwMGE4NS4uOThiNGVjODJkYmVlZWM3ZTY3NWNkMjg1NDRkMmY4 NDRkOGYyMThmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTEyICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDb25uZWN0IHVw IGZsaW5nIGV2ZW50IGRlbGl2ZXJ5IHRvIGdlc3R1cmUgY3VydmUgYW5pbWF0aW9uIGZyYW1ld29y aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4NTgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRm b3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxBbmlt YXRvck5vbmU6OmZpcmVVcEFuQW5pbWF0aW9uKToKKwogMjAxMi0wMy0xMiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmUtYXBwbHkgdGhlIHBhdGNo IGFmdGVyIHY4IHJvbGwgdG8gcjExMDAwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Nj cm9sbEFuaW1hdG9yTm9uZS5jcHAKaW5kZXggZTEyNTg3YzNlNjNlNjZiZjJmM2Q1YTNhNjM2ZmMy MTE3ZWJiMzcwMC4uNTg5YmQ4MjE5N2NjN2ZhNzY3ZGYxMjRjNjJmMWFlODkyZDM4OGExMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxBbmltYXRvck5vbmUuY3BwCkBAIC0z OTQsNyArMzk0LDEwIEBAIFNjcm9sbEFuaW1hdG9yTm9uZTo6flNjcm9sbEFuaW1hdG9yTm9uZSgp CiAKIHZvaWQgU2Nyb2xsQW5pbWF0b3JOb25lOjpmaXJlVXBBbkFuaW1hdGlvbihGbG9hdFBvaW50 IGZwKQogewotICAgIFVOVVNFRF9QQVJBTShmcCk7CisgICAgaWYgKCEhbV9nZXN0dXJlQW5pbWF0 aW9uKQorICAgICAgICBtX2dlc3R1cmVBbmltYXRpb24uY2xlYXIoKTsKKyAgICBtX2dlc3R1cmVB bmltYXRpb24gPSBBY3RpdmVQbGF0Zm9ybUdlc3R1cmVBbmltYXRpb246OmNyZWF0ZShUb3VjaEZs aW5nUGxhdGZvcm1HZXN0dXJlQ3VydmU6OmNyZWF0ZShmcCksIHRoaXMpOworICAgIHN0YXJ0TmV4 dFRpbWVyKCk7CiB9CiAKIGJvb2wgU2Nyb2xsQW5pbWF0b3JOb25lOjpzY3JvbGwoU2Nyb2xsYmFy T3JpZW50YXRpb24gb3JpZW50YXRpb24sIFNjcm9sbEdyYW51bGFyaXR5IGdyYW51bGFyaXR5LCBm bG9hdCBzdGVwLCBmbG9hdCBtdWx0aXBsaWVyKQo= 132167 2012-03-15 18:07:44 -0700 2012-03-16 03:20:18 -0700 Patch bug-80858-20120315210743.patch text/plain 1533 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTEwODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZjNjNkNzNkZDM1OGJm OTgxZWViZWY5YWViMjI1NTc1ZGI4MjgxYy4uNTU0NDJlY2Q2YzFmOTJmODA4MDM5ODVmMWYxNDA4 NDMxOTViYjQ1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTAzLTE0ICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBDb25uZWN0IHVw IGZsaW5nIGV2ZW50IGRlbGl2ZXJ5IHRvIGdlc3R1cmUgY3VydmUgYW5pbWF0aW9uIGZyYW1ld29y aworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODA4NTgK KworICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgICogcGxhdGZvcm0v U2Nyb2xsQW5pbWF0b3JOb25lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbEFuaW1hdG9y Tm9uZTo6ZmlyZVVwQW5BbmltYXRpb24pOgorCiAyMDEyLTAzLTE0ICBXLiBKYW1lcyBNYWNMZWFu ICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFdpcmUgdXAg UGxhdGZvcm1HZXN0dXJlQ3VydmVzIGZvciBDQywgU2Nyb2xsQW5pbWF0b3JOb25lLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsQW5pbWF0b3JOb25lLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbEFuaW1hdG9yTm9uZS5jcHAKaW5kZXggZTEyNTg3 YzNlNjNlNjZiZjJmM2Q1YTNhNjM2ZmMyMTE3ZWJiMzcwMC4uMGNkMTAwNGU1YzBhYzI5Yzk5NTk2 Nzg0MGRmYTVkMGRlNzRiMTgwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v U2Nyb2xsQW5pbWF0b3JOb25lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3Jv bGxBbmltYXRvck5vbmUuY3BwCkBAIC0zOTQsNyArMzk0LDEwIEBAIFNjcm9sbEFuaW1hdG9yTm9u ZTo6flNjcm9sbEFuaW1hdG9yTm9uZSgpCiAKIHZvaWQgU2Nyb2xsQW5pbWF0b3JOb25lOjpmaXJl VXBBbkFuaW1hdGlvbihGbG9hdFBvaW50IGZwKQogewotICAgIFVOVVNFRF9QQVJBTShmcCk7Cisg ICAgaWYgKG1fZ2VzdHVyZUFuaW1hdGlvbikKKyAgICAgICAgbV9nZXN0dXJlQW5pbWF0aW9uLmNs ZWFyKCk7CisgICAgbV9nZXN0dXJlQW5pbWF0aW9uID0gQWN0aXZlUGxhdGZvcm1HZXN0dXJlQW5p bWF0aW9uOjpjcmVhdGUoVG91Y2hGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjpjcmVhdGUoZnAp LCB0aGlzKTsKKyAgICBzdGFydE5leHRUaW1lcigpOwogfQogCiBib29sIFNjcm9sbEFuaW1hdG9y Tm9uZTo6c2Nyb2xsKFNjcm9sbGJhck9yaWVudGF0aW9uIG9yaWVudGF0aW9uLCBTY3JvbGxHcmFu dWxhcml0eSBncmFudWxhcml0eSwgZmxvYXQgc3RlcCwgZmxvYXQgbXVsdGlwbGllcikK